[PATCH 1/1] gnu: ffmpeg: Add support for libgme.

  • Open
  • quality assurance status badge
Details
2 participants
  • Jesse Gibbons
  • Marius Bakke
Owner
unassigned
Submitted by
Jesse Gibbons
Severity
normal
J
J
Jesse Gibbons wrote on 21 Jul 2020 08:08
(name . Guix Patches)(address . guix-patches@gnu.org)
bd58d012-fd93-a8f5-2fa9-5358d5f607cc@gmail.com
* gnu/packages/video.scm (ffmpeg):
[inputs]: Add libgme.
[arguments]: Pass "--enable-libgme" to configure.
---
gnu/packages/video.scm | 2 ++
1 file changed, 2 insertions(+)

Toggle diff (20 lines)
diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 6b57d384e1..cbb8e76949 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -963,6 +963,7 @@ operate properly.")
("libcaca" ,libcaca)
("libcdio-paranoia" ,libcdio-paranoia)
("libdrm" ,libdrm)
+ ("libgme" ,libgme)
("libtheora" ,libtheora)
("libva" ,libva)
("libvdpau" ,libvdpau)
@@ -1057,6 +1058,7 @@ operate properly.")
"--enable-libcdio"
"--enable-libdav1d"
"--enable-libfreetype"
+ "--enable-libgme"
"--enable-libmp3lame"
"--enable-libopus"
"--enable-libpulse"
M
M
Marius Bakke wrote on 25 Jul 2020 17:28
875zabvckc.fsf@gnu.org
Jesse Gibbons <jgibbons2357@gmail.com> writes:

Toggle quote (4 lines)
> * gnu/packages/video.scm (ffmpeg):
> [inputs]: Add libgme.
> [arguments]: Pass "--enable-libgme" to configure.

'libgme' appears to keep a reference to 'gcc':

$ guix size libgme
store item total self
/gnu/store/rn75fm7adgx3pw5j8pg3bczfqq1y17lk-gcc-7.5.0 178.5 107.3 59.1% <--- this should not be here
/gnu/store/fa6wj5bxkj5ll1d7292a70knmyl7a0cr-glibc-2.31 38.4 36.7 20.2%
/gnu/store/01b4w3m6mp55y531kyi1g8shh722kwqm-gcc-7.5.0-lib 71.0 32.6 18.0%
/gnu/store/483hgxdmnhh2jh471d0x3aywqrpfp36k-libgme-0.6.3 181.6 3.1 1.7%
/gnu/store/mmhimfwmmidf09jw1plw3aw1g1zn2nkh-bash-static-5.0.16 1.6 1.6 0.9%
/gnu/store/g2s5jfkfd4k973wb58476b1bbv9zpm6m-zlib-1.2.11 38.6 0.2 0.1%
total: 181.6 MiB

Thus adding it to ffmpeg would increase the closure size of ffmpeg by
more than 100MiB (compare 'guix size ffmpeg' and
'guix size libgme ffmpeg').

We should sort out that GCC reference first.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl8cT6MACgkQoqBt8qM6
VPp59wf/fe6e9Hj70/b9lSjhP8Ns/6DYzoqBMWc0EI2DO7ICHNPpdjfP3KpklAcp
fPD3Uaj5wCqSpFjNG6P9N0H2m2OM6Yp2qB+qFrz5I8oXg2ADZt9/OPzuWMV7IjNf
Zyh/Zd6kIXFJFul7GOou3YpUTiOBIlqsUWrm4NP9ySHjHhwevaxI2PcsfH9EqjhO
TkmuP69E/aWQj5FBRbTilgztNuLjvvIlcipe7qNu2oJRoPAVn15GAOYzSwtHWVBx
KAlHuREN21FHhNYoESqCFNSqymxIVhfn3qnlvIQZjRLrZbKHwZ7G4KrVcrM7DsAu
YMMo9zLw1HDmy2IvpNQTTAa1KP6oBw==
=1QaY
-----END PGP SIGNATURE-----

?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 42455@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 42455
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch