[PATCH] gnu: Add nfs4-acl-tools

  • Done
  • quality assurance status badge
Details
3 participants
  • Lars-Dominik Braun
  • Marius Bakke
  • Michael Rohleder
Owner
unassigned
Submitted by
Lars-Dominik Braun
Severity
normal
L
L
Lars-Dominik Braun wrote on 10 Jul 2020 11:21
(address . guix-patches@gnu.org)
20200710092101.GA22947@zpidnp36
Attachment: file
-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEEyk+M9DfXR4/aBV/UQhN3ARo3hEYFAl8IMvoACgkQQhN3ARo3
hEYN/Av+PopZHUdtHs9vAgbUpsUaokmZ+qd44kjS1jXGF9zUr6RzmBMXzN+qzFYY
Kxf2PP0+evXznV/RuGCTSI7LdYoXYexoZMZcrqlVoPCkfNb8pk3Xx+hRpN33VpLy
/OoaqPALDDaP7paijJfsQGhqN2F9TM3KJzOWdFl0XNOwNnMJj9PFpuZsRcOhvAQy
vHhmePivW1XLXgZ8QeujfrX+X/b0teZM2aVcyI6vtcBe2FldkcHn5Vba/vsnDYws
3bU4B2ch/6DorDHkWL14M4iYo0bnHJ3D9LEYqPzZco37dKxUSJ/9SgJaM5WnYSwD
x1bLwjWkYqIWnenp/8JzD27DAzXRVlCruL5zC1BPNw5XCdhVaDs7GKCS7USkfeGH
7HClfEpdsXC0GaHHj3Lt0xSWFx26LQy/hnhbt5IXq5lUni7rqBvJZNA1WkegtTHS
y758BThk9O9Mop2q/fUfoX/BZxfvqeHzB82Di4SPazNUsT+uF7QW4u+o3Xz2PjCQ
bqMr3U6D
=q4xV
-----END PGP SIGNATURE-----


M
M
Marius Bakke wrote on 25 Jul 2020 17:20
87blk3vcyn.fsf@gnu.org
Hello!

Sorry for the late reply...

The patch mostly LGTM, but no longer applies. Can you rebase it on
current master? Meanwhile, a few comments:

Lars-Dominik Braun <ldb@leibniz-psychology.org> writes:

Toggle quote (4 lines)
> * gnu/packages/acl.scm (nfs4-acl-tools): New variable.
> * gnu/packages/patches/nfs4-acl-tools-0.3.7-fixpaths.patch: New file.
> * gnu/local.mk: Add it.

[...]

Toggle quote (3 lines)
> + (synopsis "This package contains commandline ACL utilities for the Linux
> +NFSv4 client")

Just "Command line ACL utilities for NFS"

Toggle quote (3 lines)
> + (description "Provides the commandline utilities nfs4_setfacl and
> +nfs4_getfacl, which are similar to their POSIX equivalents.")

Descriptions OTOH should be complete sentences, something like:

"This package provides the command line utilities
@command{nfs4_setfacl} and @command{nfs4_getfacl} [...]".
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl8cTaAACgkQoqBt8qM6
VPofawf/fjD9NyvMgoSYOqw0QIE9iMERiNKK4SzuhvTWDRmacnXB9I5GZU8pJRGT
rMdqTA7MnX0Vmk2UaLuwoTk/didj93vri0Xfzen7PlHVAoOiCM022kj07HFnrCyR
cZaDip+NcBViRodP8Eetojvka5YXKWrUTQLyAGssDe22rk+rzKKNA6a9KKqXLhdm
PZsZmailxzeVq+9iP75V1qWTC9xFLrY4iLtz2gw1RM44jpPGZC7nwyAS0GdXGhMr
eWjhXZ4MlQWA6eCY5ufb+B6MWx1Ye888YHUxdwcjuytC4mJcU5fQ+hmuZfytXhqH
8MmmjtQgX3rRNpNx15Iq/ZeYfmpzlg==
=kSzK
-----END PGP SIGNATURE-----

L
L
Lars-Dominik Braun wrote on 27 Jul 2020 09:11
(name . Marius Bakke)(address . marius@gnu.org)(address . 42306@debbugs.gnu.org)
20200727071139.GB3225@zpidnp36
Hey Marius,

Toggle quote (1 lines)
> Sorry for the late reply...
no problem.

Toggle quote (2 lines)
> The patch mostly LGTM, but no longer applies. Can you rebase it on
> current master? Meanwhile, a few comments:
Sure, see attached patch, which (hopefully) also improves the description.

I noticed linting fails with a pattern matching error, because git:// protocol
URI’s are not supported. The second patch fixes it, but I’m not sure that’s a
“proper” solution.

Cheers,
Lars
Attachment: 0001-gnu-Add-nfs4-acl-tools.patch
From 5c9dddd0d4b54ca73f4fe4ebac37789bde0e54ce Mon Sep 17 00:00:00 2001
From: Lars-Dominik Braun <ldb@leibniz-psychology.org>
Date: Mon, 27 Jul 2020 09:09:24 +0200
Subject: [PATCH 2/2] =?UTF-8?q?guix:=20lint:=20Ignore=20unsupported=20sour?=
=?UTF-8?q?ce=20URL=E2=80=99s.?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* guix/lint.scm (check-source): Add match case for #f.
---
guix/lint.scm | 3 +++
1 file changed, 3 insertions(+)

Toggle diff (16 lines)
diff --git a/guix/lint.scm b/guix/lint.scm
index 8a55f3e744..395630aa1c 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -794,6 +794,9 @@ descriptions maintained upstream."
(#t
;; We found a working URL, so stop right away.
'())
+ (#f
+ ;; Unsupported URL or other error, skip.
+ (loop rest '()))
((? lint-warning? warning)
(loop rest (cons warning warnings))))))))
--
2.20.1
-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEEyk+M9DfXR4/aBV/UQhN3ARo3hEYFAl8eficACgkQQhN3ARo3
hEYQvgv/Z54B3HgqnwiFYhQmH/0JxRJ9Qf3RnjsJ7fJVxPmZzHpAOBmhSd2xXgCW
YvJn1xbzWcanX1gmi4nANQsVd4Bq5ILKe1dW5MQMsBhxxqMyznaxHlXHdVXxa/yf
ziEbsX8BWJeSFIiVTmm1VxDC+DNHp6al8fJAN9LAHesoJa30BI5JNZMsv5/Mr/vo
JmIL7u9anpG5MB+5AomTkfHvDAjVVk6DrSKVK+OG/16pcItAUDPMsLxixLU9LqkC
MBlIkpqPb5XYQBI4myf/goY+RLS0OsqXX0mpKsRTgGoKT8BtN982FxwEJteKgyZn
kGqFMRkC2T0SOEh6OFr3PpGnXBf6aBKrb8Xkod/ZuVEGgiFA9DZfGFGytJwaaC7C
z5mUiw3A/uCr5wQmMS12NMUnk97//4i89R4yyI0Q24oxqvRWUrKLEoh17lqjIsFF
jifOUD5vM+KqmGkywg7wBZJFmZOi+RpRHlDUh3kf0Bdz0/2NiNInYBxSew2gPSc6
iUSGmRNv
=xPhs
-----END PGP SIGNATURE-----


M
M
Marius Bakke wrote on 30 Jul 2020 00:01
(name . Lars-Dominik Braun)(address . ldb@leibniz-psychology.org)(address . 42306@debbugs.gnu.org)
87k0ymq8uf.fsf@gnu.org
Lars-Dominik Braun <ldb@leibniz-psychology.org> writes:

Toggle quote (9 lines)
> Hey Marius,
>
>> Sorry for the late reply...
> no problem.
>
>> The patch mostly LGTM, but no longer applies. Can you rebase it on
>> current master? Meanwhile, a few comments:
> Sure, see attached patch, which (hopefully) also improves the description.

Thanks! FYI I had to convert the patch from ISO-8859-1 encoding to
UTF-8 in order to make it apply.

Applied with the following changes:
Toggle diff (34 lines)
diff --git a/gnu/packages/acl.scm b/gnu/packages/acl.scm
index 128afc52c2..a6409765ff 100644
--- a/gnu/packages/acl.scm
+++ b/gnu/packages/acl.scm
@@ -27,7 +27,6 @@
#:use-module (gnu packages attr)
#:use-module (gnu packages autotools)
#:use-module (gnu packages base)
- #:use-module (gnu packages bash)
#:use-module (gnu packages gettext)
#:use-module (gnu packages perl)
#:use-module (guix packages)
@@ -116,14 +115,13 @@
#:phases
(modify-phases %standard-phases
(add-after 'unpack 'fix-bin-sh
- (lambda* (#:key inputs native-inputs #:allow-other-keys)
+ (lambda _
(substitute* "include/buildmacros"
- (("/bin/sh") (string-append (assoc-ref inputs "bash-minimal") "/bin/sh")))
+ (("/bin/sh") (which "sh")))
#t)))))
(native-inputs
`(("automake" ,automake)
("autoconf" ,autoconf)
- ("bash-minimal" ,bash-minimal)
("libtool" ,libtool)))
(inputs
`(("attr" ,attr)))
@@ -134,4 +132,3 @@
POSIX equivalents @command{getfacl} and @command{setfacl}. They fetch and
manipulate access control lists for files and directories on NFSv4 mounts.")
(license bsd-3)))
-
...however I also decided to move it to (gnu packages nfs).

Toggle quote (4 lines)
> I noticed linting fails with a pattern matching error, because git:// protocol
> URI’s are not supported. The second patch fixes it, but I’m not sure that’s a
> “proper” solution.

Me neither and I don't feel like jumping on that one right away. :-)

It seems we already have a number of git:// URLs around so it would be
good to fix it, can you submit the second patch to a separate issue?

Thanks!
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl8h8bgACgkQoqBt8qM6
VPouAgf9F38mmXe+AMpLcKeitAgwBdIqlYk/0sOa+qKDJZhfwmPwjK2VAw4Hl+Gp
odoJgz6SzVStp78pKfWSmcSMCb3GETIV/0rG2xm4upG3c4L+l4t33opFERWvy+nY
lqdbhFyCVSZ4JAaElx1R1VbXLUXEamKoYpQgkIFR4H77oiDrrb16b23zzcbFmyLI
6ONprl2q8KVhwDIv76a2mDmPzu5ZfXASOMr9wQ8SdgkV+kHczBMMiCDKtQZyO7/k
tNAc2GmCqjCQmd0a5nCYOBnuQWr4an7ktEt2ienH7FcTGuR36nHUZJ6uiBFhso2w
8ItbQB2yezTtEbcc25OqiqpPTPdwqQ==
=ywmL
-----END PGP SIGNATURE-----

L
L
Lars-Dominik Braun wrote on 30 Jul 2020 09:17
(name . Marius Bakke)(address . marius@gnu.org)(address . 42306@debbugs.gnu.org)
20200730071738.GB3210@zpidnp36
Hey,

Toggle quote (2 lines)
> Thanks! FYI I had to convert the patch from ISO-8859-1 encoding to
> UTF-8 in order to make it apply.
hm, that’s weird, it worked for me.

Toggle quote (2 lines)
> It seems we already have a number of git:// URLs around so it would be
> good to fix it, can you submit the second patch to a separate issue?
Done, see bug#42615

Thank you,
Lars
-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEEyk+M9DfXR4/aBV/UQhN3ARo3hEYFAl8idA8ACgkQQhN3ARo3
hEYzBwwAgYxqHrWtRafO3oIC6BLKJGZf09Ms4k+tsz+07zErf58kJbekNtpTbvVT
UGpcp3uSmOUIPKX7hE960k10gW5NE+vspqnIzyEBlIjRirHkRCTEMnYqltfXV84m
VFmmri4ulNxEL7IKdNVJC0s3jBwvoSHeuqmkjPngMl1UXz20OoFzNPVkKhsKgg9c
AjSyYCyaWcEr4p+OoitYP1ni5ERXkj5ruWm7oBw+hzaGeQL1ZbkXr//8ar9JsCyg
p6obyP7G8ooLwB4rYcXPKyRBiPjellTiplD6g5ewCY70xiA2co6MsE5OCcO1Xso+
GC3q+vgtsuxdFyKdtT4wWfPRVIOIlTj51MaqtqERKhoWdoXtHlIIIqov327SQJqY
d4dVtAvjvd8KFl6DxCZjajRxGxIY2SkNHkMPBn7XeJVrCMIcOi3Wus3sEo4zWiTw
czWSqFoRdf2Fh7Uv+dhrpHJH76X/FvAmy8/7UNftIrCUiluPKJBuymgKogvUU7XD
34ivKCRJ
=Hk9p
-----END PGP SIGNATURE-----


M
M
Michael Rohleder wrote on 9 Sep 2020 16:11
control message for bug #42306
(address . control@debbugs.gnu.org)
87tuw7jb0g.fsf@rohleder.de
tags 42306 fixed
close 42306
quit
?