[PATCH 0/3] gnu: lxqt-build-tools: Update to 0.7.0.

Done

Details

3 participants

Jonathan Brielmaier
Ludovic Courtès
Andre Batista

Owner: unassigned

Submitted by: Andre Batista

Severity: normal

Debbugs page

Andre Batista wrote 5 years ago

Recipients:(address . guix-patches@gnu.org)

Message-ID:20200624195250.GA20387@andel

Hello Guix,

This patch series fixes recent build problems when building

lxqt-config by updating this package and its dependencies.

Built with --rounds=2 on x86_64.

---

From aa6bd87fe62db12120146b93a19b036445a10bc2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Batista?= <nandre@riseup.net>
Date: Wed, 24 Jun 2020 16:23:04 -0300
Subject: [PATCH] gnu: lxqt-build-tools: Update to 0.7.0.
To: guix-devel@gnu.org

* gnu/packages/lxqt.scm (lxqt-build-tools): Update to 0.7.0.
---
 gnu/packages/lxqt.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (24 lines)diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index f9c757a804..9db911f417 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -126,7 +126,7 @@ to statistics about the system on which it's run.")
 (define-public lxqt-build-tools
   (package
     (name "lxqt-build-tools")
-    (version "0.6.0")
+    (version "0.7.0")
     (source
      (origin
        (method url-fetch)
@@ -134,7 +134,7 @@ to statistics about the system on which it's run.")
                            "/download/" version
                            "/lxqt-build-tools-" version ".tar.xz"))
        (sha256
-        (base32 "0n0p0mf12n9f7zm2592779rpqrbcamfdz87nnjb8j058bc8g3214"))))
+        (base32 "147vdkc25mrlr0fy785yzwhm4gwjxa5xl3n3hljz4c97m531kzl5"))))
     (build-system cmake-build-system)
     (arguments
      `(#:tests? #f                      ; no tests
-- 
2.26.2

Andre Batista wrote 5 years ago

[PATCH 1/3] gnu: libqtxdg: Update to 3.5.0

Recipients:(address . 42037@debbugs.gnu.org)

Message-ID:20200624214549.GA22696@andel

From 4d438fddce17e0e460f1f61d97e2f09b046953b5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Batista?= <nandre@riseup.net>
Date: Wed, 24 Jun 2020 16:27:31 -0300
Subject: [PATCH] gnu: libqtxdg: Update to 3.5.0.
To: guix-devel@gnu.org

* gnu/packages/lxqt.scm (libqtxdg): Update to 3.5.0.
---
 gnu/packages/lxqt.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (24 lines)diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index 9db911f417..ef0bb1e43e 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -159,7 +159,7 @@ itself as well as other components maintained by the LXQt project.")
 (define-public libqtxdg
   (package
     (name "libqtxdg")
-    (version "3.4.0")
+    (version "3.5.0")
     (source
      (origin
        (method url-fetch)
@@ -167,7 +167,7 @@ itself as well as other components maintained by the LXQt project.")
              "https://github.com/lxqt/libqtxdg/releases/download/"
              version "/libqtxdg-" version ".tar.xz"))
        (sha256
-        (base32 "0vmn59653dmy79mnbnibhdq9jmh11091zkfx0y0qh58rj2xvpdbv"))))
+        (base32 "0g2mwipgl8737jhgqymjixvk745svh2rlini3qr92lrg60v9paa1"))))
     (build-system cmake-build-system)
     (arguments
      '(#:configure-flags
-- 
2.26.2

Andre Batista wrote 5 years ago

[PATCH 2/3] gnu: liblxqt: Update to 0.15.1

Recipients:(address . 42037@debbugs.gnu.org)

Message-ID:20200624215001.GB22696@andel

From 4ce2cf42f936fb4aaf8d64400387ec36527ca673 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Batista?= <nandre@riseup.net>
Date: Wed, 24 Jun 2020 16:30:44 -0300
Subject: [PATCH] gnu: liblxqt: Update to 0.15.1.
To: guix-devel@gnu.org

* gnu/packages/lxqt.scm (liblxqt): Update to 0.15.1.
---
 gnu/packages/lxqt.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (24 lines)diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index ef0bb1e43e..446a69418c 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -197,7 +197,7 @@ in Qt.")
 (define-public liblxqt
   (package
     (name "liblxqt")
-    (version "0.14.1")
+    (version "0.15.1")
     (source
      (origin
        (method url-fetch)
@@ -205,7 +205,7 @@ in Qt.")
              "https://github.com/lxqt/" name "/releases/download/"
              version "/" name "-" version ".tar.xz"))
        (sha256
-        (base32 "1gb922npf6nw4w3nkvh4czk8xmdzzqkzq3zgl1h303fjaib359qs"))))
+        (base32 "0mg62gypjpmpjd3lr7rrvzmkkhli1vf5pri47hg76byz84vng4a9"))))
     (build-system cmake-build-system)
     (arguments
      `(#:tests? #f                      ; no tests
-- 
2.26.2

Andre Batista wrote 5 years ago

[PATCH 3/3] gnu: lxqt-config: Update to 0.15.0

Recipients:(address . 42037@debbugs.gnu.org)

Message-ID:20200624215607.GC22696@andel

This patch series solves a build error where QFile remains

undeclared.

The failed build logs follow attached.

TODO: Update all remaining lxqt packages to current versions.

I'm downloading all packages, checking signatures and will

send another patch series if lxqt builds with --rounds=2.

Cheers,

From 08c4a5e77db50dd8cde3b69fc8ae458ab08f3719 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Batista?= <nandre@riseup.net>
Date: Wed, 24 Jun 2020 16:33:32 -0300
Subject: [PATCH] gnu: lxqt-config: Update to 0.15.0.
To: guix-devel@gnu.org

* gnu/packages/lxqt.scm (lxqt-config): Update to 0.15.1.
---
 gnu/packages/lxqt.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (23 lines)diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index 446a69418c..7aab30f170 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -358,14 +358,14 @@ the operating system LXQt is running on.")
 (define-public lxqt-config
   (package
     (name "lxqt-config")
-    (version "0.14.1")
+    (version "0.15.0")
     (source
      (origin
        (method url-fetch)
        (uri (string-append "https://github.com/lxqt/" name "/releases/download/"
                            version "/" name "-" version ".tar.xz"))
        (sha256
-        (base32 "16k36knv6d72gg8hp7423l3ic43y3l3zbaf3spqn2a354y30myrg"))))
+        (base32 "18fagd6ynmx74qw0pjkkg2n3v6s18n6lcsbj7lvfd4lkbcfnzqpb"))))
     (build-system cmake-build-system)
     (inputs
      `(("eudev" ,eudev)
-- 
2.26.2

Attachment: v7slv4cdk51hwci8vg689f5hkc4z6b-liblxqt-0.14.1.drv.bz2

Ludovic Courtès wrote 5 years ago

Re: [bug#42037] [PATCH 0/3] gnu: lxqt-build-tools: Update to 0.7.0.

Recipients:(name . Andre Batista)(address . nandre@riseup.net)(address . 42037@debbugs.gnu.org)

Message-ID:87lfkbsala.fsf@gnu.org

Hi,

Andre Batista <nandre@riseup.net> skribis:

Toggle quote (3 lines)

> This patch series fixes recent build problems when building

> lxqt-config by updating this package and its dependencies.

After applying the patches, “guix build lxqt” fails:

Toggle snippet (39 lines)/gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qstringbuilder.h:428:35: error: no matching function for call to ‘QConcatenable<char [14]>::appendTo(const char [14], Q
Char*&)’
         QConcatenable<A>::appendTo(p.a, out);
         ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
/gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qstringbuilder.h:318:24: note: candidate: static void QConcatenable<const char [N]>::appendTo(const char*, char*&) [wit
h int N = 14]
     static inline void appendTo(const char a[N], char *&out)
                        ^~~~~~~~
/gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qstringbuilder.h:318:24: note:   no known conversion for argument 2 from ‘QChar*’ to ‘char*&’
exporting path `/gnu/store/x5jzmg1q7ivk5jaqqvr16q2iq5w4yr3l-libexif-0.6.22'
make[2]: *** [CMakeFiles/compton-conf.dir/build.make:213: CMakeFiles/compton-conf.dir/compton-conf.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from /gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qstring.h:2079:0,
                 from /gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qobject.h:47,
                 from /gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtWidgets/qwidget.h:45,
                 from /gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtWidgets/qdialog.h:44,
                 from /gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtWidgets/QDialog:1,
                 from /tmp/guix-build-compton-conf-0.14.1.drv-0/compton-conf-0.14.1/maindialog.h:24,
                 from /tmp/guix-build-compton-conf-0.14.1.drv-0/compton-conf-0.14.1/maindialog.cpp:21:
/gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qstringbuilder.h: In instantiation of ‘static void QConcatenable<QStringBuilder<A, B> >::appendTo(const type&, T*&) [with T = QChar; A = char [25]; B = QString; QConcatenable<QStringBuilder<A, B> >::type = QStringBuilder<char [25], QString>]’:
/gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qstringbuilder.h:118:56:   required from ‘T QStringBuilder<A, B>::convertTo() const [with T = QString; A = char [25]; B = QString]’
/gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qstringbuilder.h:131:61:   required from ‘QStringBuilder<A, B>::operator QStringBuilder<A, B>::ConvertTo() const [with A = char [25]; B = QString; QStringBuilder<A, B>::ConvertTo = QString]’
/tmp/guix-build-compton-conf-0.14.1.drv-0/compton-conf-0.14.1/maindialog.cpp:174:57:   required from here
/gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qstringbuilder.h:428:35: error: no matching function for call to ‘QConcatenable<char [25]>::appendTo(const char [25], QChar*&)’
         QConcatenable<A>::appendTo(p.a, out);
         ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
/gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qstringbuilder.h:318:24: note: candidate: static void QConcatenable<const char [N]>::appendTo(const char*, char*&) [with int N = 25]
     static inline void appendTo(const char a[N], char *&out)
                        ^~~~~~~~
/gnu/store/59dq1n4wj3maa3kcar6hspj2zd82as7q-qtbase-5.14.2/include/qt5/QtCore/qstringbuilder.h:318:24: note:   no known conversion for argument 2 from ‘QChar*’ to ‘char*&’
make[2]: *** [CMakeFiles/compton-conf.dir/build.make:200: CMakeFiles/compton-conf.dir/maindialog.cpp.o] Error 1
make[2]: Leaving directory '/tmp/guix-build-compton-conf-0.14.1.drv-0/build'
make[1]: *** [CMakeFiles/Makefile2:100: CMakeFiles/compton-conf.dir/all] Error 2
make[1]: Leaving directory '/tmp/guix-build-compton-conf-0.14.1.drv-0/build'
make: *** [Makefile:133: all] Error 2
command "make" "-j" "8" failed with status 2
builder for `/gnu/store/2wn9m74y4qjsmywlgy90rd09i39vb2nn-compton-conf-0.14.1.drv' failed with exit code 1

Maybe all the lxqt packages should be upgraded in lockstep?

If that is the case, it’s better to upgrade them in a single commit,

such that there are no intermediate commits where things fail to build.

Thanks,

Ludo’.

Andre Batista wrote 5 years ago

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 42037@debbugs.gnu.org)

Message-ID:20200625202726.GA7049@andel

Hello,

qui 25 jun 2020 às 12:28:49 (1593098929), ludo@gnu.org enviou:

Toggle quote (4 lines)

> Hi,

> After applying the patches, “guix build lxqt” fails:

Current guix version of lxqt is failing as well since liblxqt cannot

be built.

Toggle quote (2 lines)

> Maybe all the lxqt packages should be upgraded in lockstep?

Certainly. It was only after sending the first patch that it occured

to me that it would be necessary to upgrade the whole DE in a single

step. I'm sorry.

I've tried to do it, but 'qps' is failing, so no lxqt for now.

lxqt-connman-applet is also failing - both before and after this

patch - but it does not seem to be needed to build lxqt.

Toggle quote (3 lines)

> If that is the case, it’s better to upgrade them in a single commit,

> such that there are no intermediate commits where things fail to build.

Ok, I'll try a bit more and will get back to you.

Thanks,

Jonathan Brielmaier wrote 5 years ago

Recipients:(address . guix-patches@gnu.org)

Message-ID:9c9d6402-4dac-7eb8-6890-0bac0a0f5c07@web.de

I have a branch with lxqt 0.15 with all packages working including

lxqt-build-tools.

I'll post it as a patch series.

Sorry for the duplicated effort, I've should sent it earlier...

On 25.06.20 22:27, Andre Batista wrote:

Toggle quote (30 lines)> Hello,
>
> qui 25 jun 2020 às 12:28:49 (1593098929), ludo@gnu.org enviou:
>> Hi,
>>
>> After applying the patches, “guix build lxqt” fails:
>
> Current guix version of lxqt is failing as well since liblxqt cannot
> be built.
>
>> Maybe all the lxqt packages should be upgraded in lockstep?
>
> Certainly. It was only after sending the first patch that it occured
> to me that it would be necessary to upgrade the whole DE in a single
> step. I'm sorry.
>
> I've tried to do it, but 'qps' is failing, so no lxqt for now.
>
> lxqt-connman-applet is also failing - both before and after this
> patch - but it does not seem to be needed to build lxqt.
>
>> If that is the case, it’s better to upgrade them in a single commit,
>> such that there are no intermediate commits where things fail to build.
>
> Ok, I'll try a bit more and will get back to you.
>
> Thanks,
>
>
>

Andre Batista wrote 5 years ago

Re: [bug#42037] [PATCH] gnu: lxqt: Update to 0.15.0.

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 42037@debbugs.gnu.org)

Message-ID:20200626120525.GA2652@andel

qui 25 jun 2020 às 17:27:26 (1593116846), nandre@riseup.net enviou:

Toggle quote (14 lines)> > Maybe all the lxqt packages should be upgraded in lockstep?
> 
> Certainly. It was only after sending the first patch that it occured
> to me that it would be necessary to upgrade the whole DE in a single
> step. I'm sorry.
> 
> I've tried to do it, but 'qps' is failing, so no lxqt for now.
> 
> lxqt-connman-applet is also failing - both before and after this
> patch - but it does not seem to be needed to build lxqt.
> 
> > If that is the case, it’s better to upgrade them in a single commit,
> > such that there are no intermediate commits where things fail to build.

It seems that 'qps' had some code refactoring and it now needs new

inputs: kwindowsystem, liblxqt and libqtxdg.

Besides that, lxqt-archiver now has a stable release, so I've changed

its origin to point at the tarball instead of a commit on git.

lxqt now builds again and it's updated.

On the down side, I could not build lxqt-connman-applet, so I did not

touch its definition on this patch. Again, it's not needed to build

lxqt and it was already broken.

---

Attachment: 0001-gnu-lxqt-Update-to-0.15.0.patch

Andre Batista wrote 5 years ago

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 42037@debbugs.gnu.org)

Message-ID:20200626194358.GA6394@andel

Hello,

sex 26 jun 2020 às 09:05:25 (1593173125), nandre@riseup.net enviou:

Toggle quote (12 lines)> It seems that 'qps' had some code refactoring and it now needs new
> inputs: kwindowsystem, liblxqt and libqtxdg.
> 
> Besides that, lxqt-archiver now has a stable release, so I've changed
> its origin to point at the tarball instead of a commit on git.
> 
> lxqt now builds again and it's updated.
> 
> On the down side, I could not build lxqt-connman-applet, so I did not
> touch its definition on this patch. Again, it's not needed to build
> lxqt and it was already broken.

Now everything should be ok. Since the previous patch was not merged,

discard it and use this one instead. I had to patch CMakeLists.txt on

lxqt-connman-applet in order to build it.

Cheers,

---

Attachment: 0001-gnu-lxqt-Update-to-0.15.0.patch

Ludovic Courtès wrote 5 years ago

Recipients:(name . Andre Batista)(address . nandre@riseup.net)(address . 42037-done@debbugs.gnu.org)

Message-ID:87o8p4jirz.fsf@gnu.org

Hi Andre,

Andre Batista <nandre@riseup.net> skribis:

Toggle quote (42 lines)> From dc90e498c9d4331031f605c0783d400338e3715d Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Andr=C3=A9=20Batista?= <nandre@riseup.net>
> Date: Fri, 26 Jun 2020 16:30:50 -0300
> Subject: [PATCH] gnu: lxqt: Update to 0.15.0.
> To: guix-devel@gnu.org
>
> * gnu/packages/lxqt.scm
> (libstatgrab): Update to 0.92.
> (lxqt-build-tools): Update to 0.7.0.
> (libqtxdg): Update to 3.5.0.
> (liblxqt): Update to 0.15.1.
> (libsysstat): Update to 0.4.3.
> (lxqt-about): Update to 0.15.0.
> (lxqt-admin): Update to 0.15.0.
> (lxqt-config): Update to 0.15.0.
> (lxqt-globalkeys): Update to 0.15.0.
> (lxqt-notificationd): Update to 0.15.0.
> (lxqt-openssh-askpass): Update to 0.15.0.
> (lxqt-panel): Update to 0.15.1.
> (lxqt-policykit): Update to 0.15.0.
> (lxqt-powermanagement): Update to 0.15.0.
> (lxqt-qtplugin): Update to 0.15.1.
> (lxqt-runner): Update to 0.15.0.
> (lxqt-session): Update to 0.15.0.
> (lxqt-sudo): Update to 0.15.0.
> (lxqt-themes): Update to 0.15.0.
> (libfm-qt): Update to 0.15.1.
> (pcmanfm-qt): Update to 0.15.1.
> (compton-conf): Update to 0.15.0.
> (lximage-qt): Update to 0.15.0.
> (obconf-qt): Update to 0.15.0.
> (pavucontrol-qt): Update to 0.15.0.
> (qps): Update to 2.1.0.
> (qps)[inputs]: Add kwindowsystem, liblxqt and libqtxdg.
> (qtermwidget): Update to 0.15.0.
> (qterminal): Update to 0.15.0.
> (screengrab): Update to 2.0.1.
> (lxqt-archiver): Update to 0.2.0.
> (lxqt-archiver)[origin]: Use tarball release.
> (lxqt-connman-applet): Update to 0.15.0.
> (lxqt-connman-applet)[arguments]: Add new patch phase.

Applied, thanks!

Ludo’.

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 42037@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 42037

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags

mumi command -t +confirmed -t +easy

Or, remove the moreinfo tag and set the help tag

mumi command -t -moreinfo -t +help

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date