[PATCH] nix: Tweak .gitignore files.

  • Done
  • quality assurance status badge
Details
2 participants
  • Ludovic Courtès
  • Christopher Baines
Owner
unassigned
Submitted by
Christopher Baines
Severity
normal

Debbugs page

Christopher Baines wrote 5 years ago
(address . guix-patches@gnu.org)
20200623172717.10275-1-mail@cbaines.net
Remove .gitignore entries where they match source files that are tracked in
Git. This is relevant to me at least, as some code searching tools use
.gitignore files and will ignore matched files.

* nix/boost/.gitignore: Delete this file.
* nix/libutils/.gitignore: Delete this file.
* nix/libstore/.gitignore (*.cc, *.hh): Remove entries.
(/schema.sql.hh): New entry.
---
nix/boost/.gitignore | 3 ---
nix/libstore/.gitignore | 3 +--
nix/libutil/.gitignore | 2 --
3 files changed, 1 insertion(+), 7 deletions(-)
delete mode 100644 nix/boost/.gitignore
delete mode 100644 nix/libutil/.gitignore

Toggle diff (28 lines)
diff --git a/nix/boost/.gitignore b/nix/boost/.gitignore
deleted file mode 100644
index 1f188e3b65..0000000000
--- a/nix/boost/.gitignore
+++ /dev/null
@@ -1,3 +0,0 @@
-*.hpp
-*.cpp
-*.cc
diff --git a/nix/libstore/.gitignore b/nix/libstore/.gitignore
index 512a0d022f..805301d6d7 100644
--- a/nix/libstore/.gitignore
+++ b/nix/libstore/.gitignore
@@ -1,3 +1,2 @@
-*.cc
-*.hh
/schema.sql
+/schema.sql.hh
diff --git a/nix/libutil/.gitignore b/nix/libutil/.gitignore
deleted file mode 100644
index e539428b1b..0000000000
--- a/nix/libutil/.gitignore
+++ /dev/null
@@ -1,2 +0,0 @@
-*.cc
-*.hh
--
2.26.2
Ludovic Courtès wrote 5 years ago
(name . Christopher Baines)(address . mail@cbaines.net)(address . 42024@debbugs.gnu.org)
87h7v1zdqh.fsf@gnu.org
Christopher Baines <mail@cbaines.net> skribis:

Toggle quote (9 lines)
> Remove .gitignore entries where they match source files that are tracked in
> Git. This is relevant to me at least, as some code searching tools use
> .gitignore files and will ignore matched files.
>
> * nix/boost/.gitignore: Delete this file.
> * nix/libutils/.gitignore: Delete this file.
> * nix/libstore/.gitignore (*.cc, *.hh): Remove entries.
> (/schema.sql.hh): New entry.

LGTM! I don’t know what the rationale was.

BTW, no need to bother with ChangeLog entries for this.

Ludo’.
Christopher Baines wrote 5 years ago
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 42024-done@debbugs.gnu.org)
87h7v070hp.fsf@cbaines.net
Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (15 lines)
> Christopher Baines <mail@cbaines.net> skribis:
>
>> Remove .gitignore entries where they match source files that are tracked in
>> Git. This is relevant to me at least, as some code searching tools use
>> .gitignore files and will ignore matched files.
>>
>> * nix/boost/.gitignore: Delete this file.
>> * nix/libutils/.gitignore: Delete this file.
>> * nix/libstore/.gitignore (*.cc, *.hh): Remove entries.
>> (/schema.sql.hh): New entry.
>
> LGTM! I don’t know what the rationale was.
>
> BTW, no need to bother with ChangeLog entries for this.

Great, I've removed the ChangeLog entries and pushed this as
cd43b55da7ab51c996a7a3449c78f2a493616106.

Thanks,

Chris
-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl7zosJfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE
9XfoCA/7B126voHnAf2KT/eAa0H4/bUWVIHJDxRCD+ghfDiOgwDUMllKqXQk9r2X
qFdJb4oL9dFvbgXSLhkYlVThD9yrmzsNrszjpmAN4sFoJ3HY2yiUhkIm48W/ADmw
wTwDPkAMgQy5D5NG1J3icolwOLMT8Ku55mmQ6qpS6De9yEQVZwphp9ANFad9BzNv
Eseq8niyXME66VRvJ7wjCAxm2uIj/h5ljphx9ZE1R+IoR1BtQbXJJvkYUKHzwUzu
TdZ1eh3O0OXzhvhFtWklbDri/zYbe+5B0fTEdDazu6GYmj/aLTpTicWsoy6+fznj
L8TplYOXJ7xOrBkQDyH3RyLILABBqu9jCB+eONbi/+nc0DyeI6al0YQ1mx1YvluZ
ZJxDjc4dKN8dBkNfu9vnhRTWJ+XjON04QClK3wOOqBNkTPU7D6PkIeMT/T+iOKxB
g9AxZW62h+KkvR9EsI0+R4yJ8IKGMQRwb4HRmNO6dLrC4zzDbg7dZU71o38kSpd1
6hon7jT/5sGa2KNQqijHzKiWfRhLbRoogOwKb79bGQX8sr58+cQRD7DvxNrU0uzX
8oKAaYes4bs3448/SAsG6peGayzdkN1BPKqvkS4EkoRT/hmumTaY35Xio0taVu2C
Wa6qFUpbUI0zYGLCbA9464GIS0T5XbuqxQLxgMhel/aOx9t680k=
=7oP0
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 42024@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 42024
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help