[PATCH] gnu: glade3: Enable tests.

DoneSubmitted by Arun Isaac.
Details
2 participants
  • Arun Isaac
  • Mathieu Othacehe
Owner
unassigned
Severity
normal
A
A
Arun Isaac wrote on 29 May 2020 23:31
(address . guix-patches@gnu.org)(name . Arun Isaac)(address . arunisaac@systemreboot.net)
20200529213110.2354-1-arunisaac@systemreboot.net
* gnu/packages/gnome.scm (glade3)[arguments]: Enable tests. Add custom
pre-check phase.
[native-inputs]: Add hicolor-icon-theme and xorg-server-for-tests.
---
gnu/packages/gnome.scm | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)

Toggle diff (46 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 1745bf7906..02e14233d1 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -2102,8 +2102,7 @@ API add-ons to make GTK+ widgets OpenGL-capable.")
                 "023gx8rj51njn8fsb6ma5kz1irjpxi4js0n8rwy22inc4ysldd8r"))))
     (build-system glib-or-gtk-build-system)
     (arguments
-     `(#:tests? #f ; needs X, GL, and software rendering
-       #:phases
+     `(#:phases
        (modify-phases %standard-phases
          (add-before 'configure 'fix-docbook
            (lambda* (#:key inputs #:allow-other-keys)
@@ -2113,18 +2112,27 @@ API add-ons to make GTK+ widgets OpenGL-capable.")
                                "/xml/xsl/docbook-xsl-"
                                ,(package-version docbook-xsl)
                                "/manpages/docbook.xsl")))
+             #t))
+         (add-before 'check 'pre-check
+           (lambda _
+             (setenv "HOME" "/tmp")
+             ;; Tests require a running X server.
+             (system "Xvfb :1 &")
+             (setenv "DISPLAY" ":1")
              #t)))))
     (inputs
      `(("gtk+" ,gtk+)
        ("libxml2" ,libxml2)))
     (native-inputs
-     `(("intltool" ,intltool)
+     `(("hicolor-icon-theme" ,hicolor-icon-theme)
+       ("intltool" ,intltool)
        ("itstool" ,itstool)
        ("libxslt" ,libxslt) ;for xsltproc
        ("docbook-xml" ,docbook-xml-4.2)
        ("docbook-xsl" ,docbook-xsl)
        ("python" ,python-2)
-       ("pkg-config" ,pkg-config)))
+       ("pkg-config" ,pkg-config)
+       ("xorg-server" ,xorg-server-for-tests)))
     (home-page "https://glade.gnome.org")
     (synopsis "GTK+ rapid application development tool")
     (description "Glade is a rapid application development (RAD) tool to
-- 
2.26.2
M
M
Mathieu Othacehe wrote on 14 Jun 2020 12:25
(name . Arun Isaac)(address . arunisaac@systemreboot.net)(address . 41610@debbugs.gnu.org)
87366ykkpa.fsf@gnu.org
Hello Arun,

Toggle quote (7 lines)
> - ("pkg-config" ,pkg-config)))
> + ("pkg-config" ,pkg-config)
> + ("xorg-server" ,xorg-server-for-tests)))
> (home-page "https://glade.gnome.org")
> (synopsis "GTK+ rapid application development tool")
> (description "Glade is a rapid application development (RAD) tool to

This looks fine, please go ahead!

Thanks,

Mathieu
A
A
Arun Isaac wrote on 15 Jun 2020 20:40
(name . Mathieu Othacehe)(address . othacehe@gnu.org)(address . 41610-done@debbugs.gnu.org)
87eeqgnpey.fsf@systemreboot.net
Pushed, thanks for the review!
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAl7nwJYACgkQLiXui2GA
K7M/kQf/XwHYE1zvXZ+Wt0ApUWsQM1Erm9fRBcX1aiZascDyUG5+aWysPIpfMPON
rQYPv7C8WDbe38ZMrlVG2Vw3Wu483+zp8pVHIytoEDa3MLTwbpAQTcZ0lcjRj197
Ojj8t15dLupZY9k0JSytuy86yJ4JPHWWbkg5lUOt/ddPssiElTx+0YvqCb4y+Aqo
QsW21gvFg3GPi9a89M0yvwbhrJlj0waF8b8IpjSW9lJjOovWXFYAEYOwK94/QM8h
oQBwix9KPVXMJzBQfc9sgqkWprb6SifcLorhsG9epSM3Qs6D77VaXNrD1UitCHio
BBrWjJDj7qV0SHmUqbTucgmU5EHx9g==
=P73k
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 41610@debbugs.gnu.org