[PATCH] gnu: aegis: Update homepage link and fix build failure

  • Done
  • quality assurance status badge
Details
2 participants
  • Josh Marshall
  • Tobias Geerinckx-Rice
Owner
unassigned
Submitted by
Josh Marshall
Severity
normal

Debbugs page

Josh Marshall wrote 5 years ago
(address . guix-patches@gnu.org)(name . Josh Marshall)(address . joshua.r.marshall.1991@gmail.com)
20200527031226.64428-1-joshua.r.marshall.1991@gmail.com
* gnu/packages/version-control.scm (aegis): Update homepage link and fix build failure
---
gnu/packages/version-control.scm | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

Toggle diff (27 lines)
diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 09ffd8f271..deb746db26 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -1885,7 +1885,10 @@ accessed and migrated on modern systems.")
("ed" ,ed)))
(arguments
`(#:configure-flags (list "--with-no-aegis-configured"
- "--sharedstatedir=/var/com/aegis")
+ "--sharedstatedir=/var/com/aegis"
+ ;; Uses the old 'throw()' specifier with 'new'
+ ;; which changed in C++11.
+ "CXXFLAGS=-std=c++03")
#:parallel-build? #f ; There are some nasty racy rules in the Makefile.
#:phases
(modify-phases %standard-phases
@@ -1928,7 +1931,7 @@ accessed and migrated on modern systems.")
;; The author decided to call the check rule "sure".
(invoke "make" "sure")))))))
- (home-page "http://aegis.sourceforge.net")
+ (home-page "https://sourceforge.net/projects/aegis/")
(synopsis "Project change supervisor")
(description "Aegis is a project change supervisor, and performs some of
the Software Configuration Management needed in a CASE environment. Aegis
--
2.26.2
Tobias Geerinckx-Rice wrote 5 years ago
Re: [bug#41556] [PATCH] gnu: aegis: Update homepage link and fix build failure
(name . Josh Marshall)(address . joshua.r.marshall.1991@gmail.com)(address . 41556-done@debbugs.gnu.org)
874ks1627v.fsf@nckx
Josh,

Josh Marshall 写道：
Toggle quote (1 lines)
> * gnu/packages/version-control.scm (aegis):
^^^^

‘git log’ adds 4 leading spaces to commit message bodies but you
don't need to add (or, I presume, copy/paste :-) them yourself.

Toggle quote (2 lines)
> Update homepage link and fix build failure

Thanks! I've split these two unrelated changes into two commits.

SF project pages aren't goot home pages but this project looks
very dead indeed. Are you fixing this because you use it?

Toggle quote (13 lines)
> @@ -1885,7 +1885,10 @@ accessed and migrated on modern
> systems.")
> ("ed" ,ed)))
> (arguments
> `(#:configure-flags (list "--with-no-aegis-configured"
> -
> "--sharedstatedir=/var/com/aegis")
> +
> "--sharedstatedir=/var/com/aegis"
> + ;; Uses the old 'throw()' specifier
> with 'new'
> + ;; which changed in C++11.
> + "CXXFLAGS=-std=c++03")
^^^^…

It's worth running ‘guix lint’ even after trivial changes: these
are tabs & we're a spaces family. Changed and pushed as
812dad08764af5ae4d80394732dcc1481742db3a et al.

Kind regards,

T G-R
-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXs5QRAAKCRANsP+IT1Vt
eQ6DAQCyQm4XVnzw+qkTqBKy0sMloglswGFyhklVe1ykdny/qgEAtAQflD3RHCDO
9WwJEtgN3FtQTzbgMV8e+AVjVl+5kQg=
=XGJR
-----END PGP SIGNATURE-----

Closed
Josh Marshall wrote 5 years ago
(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)(address . 41556-done@debbugs.gnu.org)
CAFkJGRf=-Te60SyF0n+9xQNEWJzpD6Tkw_10dg3-Pt5mxMGXbQ@mail.gmail.com
Gah! No matter how many times I tell my editor to use spaces it inserts
tabs. I'm dumping neovim.

I don't use it, just fixing up something I saw.

On Wed, May 27, 2020, 07:34 Tobias Geerinckx-Rice <me@tobias.gr> wrote:

Toggle quote (39 lines)
> Josh,
>
> Josh Marshall 写道：
> > * gnu/packages/version-control.scm (aegis):
> ^^^^
>
> ‘git log’ adds 4 leading spaces to commit message bodies but you
> don't need to add (or, I presume, copy/paste :-) them yourself.
>
> > Update homepage link and fix build failure
>
> Thanks! I've split these two unrelated changes into two commits.
>
> SF project pages aren't goot home pages but this project looks
> very dead indeed. Are you fixing this because you use it?
>
> > @@ -1885,7 +1885,10 @@ accessed and migrated on modern
> > systems.")
> > ("ed" ,ed)))
> > (arguments
> > `(#:configure-flags (list "--with-no-aegis-configured"
> > -
> > "--sharedstatedir=/var/com/aegis")
> > +
> > "--sharedstatedir=/var/com/aegis"
> > + ;; Uses the old 'throw()' specifier
> > with 'new'
> > + ;; which changed in C++11.
> > + "CXXFLAGS=-std=c++03")
> ^^^^…
>
> It's worth running ‘guix lint’ even after trivial changes: these
> are tabs & we're a spaces family. Changed and pushed as
> 812dad08764af5ae4d80394732dcc1481742db3a et al.
>
> Kind regards,
>
> T G-R
>
Attachment: file
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 41556@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 41556
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help