[PATCH] gnu: Add emacs-bm.

DoneSubmitted by Michael Rohleder.
Details
2 participants
  • Marius Bakke
  • Michael Rohleder
Owner
unassigned
Severity
normal
M
M
Michael Rohleder wrote on 27 May 2020 01:41
(address . guix-patches@gnu.org)
87imgixo1a.fsf@rohleder.de
From edd01faf84a59499a9a83b336d55828aadd6bfa3 Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike@rohleder.de>
Date: Wed, 27 May 2020 01:37:42 +0200
Subject: [PATCH] gnu: Add emacs-bm.

* gnu/packages/emacs-xyz.scm (emacs-bm): New variable.
---
gnu/packages/emacs-xyz.scm | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)

Toggle diff (33 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b99acb7815..34afc73d8e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1860,6 +1860,26 @@ code@{emacs-wiki.el}, it facilitates using hyperlinks and doing full-text
 searches.  Unlike code@{emacs-wiki.el}, it can be combined with any format.")
     (license license:gpl1+)))
 
+(define-public emacs-bm
+  (package
+    (name "emacs-bm")
+    (version "201905")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/joodland/bm.git")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "180b3rc13asrmsdh7v405d54jkrininvaj52xhp71vw91ng51dkn"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/joodland/bm")
+    (synopsis "Visual Bookmarks for Emacs")
+    (description "This package provides visible, buffer local, bookmarks and
+the ability to jump forward and backward to the next bookmark.")
+    (license license:gpl2+)))
+
 (define-public emacs-calfw
   (package
     (name "emacs-calfw")
-- 
2.26.2
--
There are three kinds of people: men, women, and unix.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEdV4t5dDVhcUueCgwfHr/vv7yyyUFAl7NqREACgkQfHr/vv7y
yyVftggAkiGb2rbUWsI0+ktthifwDSK6bAOdvAhE5SzUS4beFW4WtXySF9EOvUWD
HgI/ONVOpXAnIxyRu6DMeRvDAf96RIMIC0B+U1fPMn4atu6QJG61NepOpSATj52t
NsafV2nUG+V54lhPI1E596PGEQ+qg7pqtQbymPdvgGRFZZ1QHSLqDZwGlXNYOkwa
6k8RvUnCk1VuZ+BUrIGZqaUqVqQ7hNxbp+BCYinTyTnVlSzaV6k5OZlIXE0c6u/Q
vjgjYbE6Ovys5NQcjXo+Ih83fcrezS5ShzFqy2/g8N9dFt2mFzAA2lS4lAgkOZWo
yoxdGpnQ5MBLcwaXBJhvcZynm1n+Mg==
=h/+x
-----END PGP SIGNATURE-----

M
M
Marius Bakke wrote on 30 May 2020 13:50
87ftbh3alu.fsf@gnu.org
Michael Rohleder <mike@rohleder.de> writes:

Toggle quote (7 lines)
> From edd01faf84a59499a9a83b336d55828aadd6bfa3 Mon Sep 17 00:00:00 2001
> From: Michael Rohleder <mike@rohleder.de>
> Date: Wed, 27 May 2020 01:37:42 +0200
> Subject: [PATCH] gnu: Add emacs-bm.
>
> * gnu/packages/emacs-xyz.scm (emacs-bm): New variable.

Thanks! It LGTM but no longer applies, can you rebase it on the current
master branch?
Toggle quote (16 lines)
> +(define-public emacs-bm
> + (package
> + (name "emacs-bm")
> + (version "201905")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/joodland/bm.git")
> + (commit version)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "180b3rc13asrmsdh7v405d54jkrininvaj52xhp71vw91ng51dkn"))))
> + (build-system emacs-build-system)
> + (home-page "https://github.com/joodland/bm")
> + (synopsis "Visual Bookmarks for Emacs")
^^^
Lowercase 'b'.

Toggle quote (3 lines)
> + (description "This package provides visible, buffer local, bookmarks and
> +the ability to jump forward and backward to the next bookmark.")

The description reads a bit weird, I wonder if...

"visible, buffer local bookmarks" (without the second comma)

...is more correct?

Can you send an updated patch?
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7SSI0ACgkQoqBt8qM6
VPracgf+MtekpNxWd6LcVs9j/OdgOvAQSxEjyOvg81gt0uAC93uY7Pdq+s2gAATe
+MOEzjuHUT8tmKShJXKZnjJ40FMUG5yZj/j6AJcpCMNKrPx+hJo/WvecA7u2UtRv
b0c04DyN1LSaBsLeuTc/EU9nSy8EXaFtQXYovqlJ/yO0xpWD7eMxln1JPz6y7j6M
N5p6FjMCr4on8jhgt85XoInZH+sJ0tXso5K6jtezRv42gv/8UAfegJAGJVtREcIb
zP8SVlwUx1dIyjx/rQkButti9BEys7Od6EqEB1rjN6qB8eo729YzHMwD4bL8vGOY
r0xrgggEUQvrQwMV84HhX7ViY8iNDw==
=8z69
-----END PGP SIGNATURE-----

M
M
Michael Rohleder wrote on 30 May 2020 19:55
(name . Marius Bakke)(address . marius@gnu.org)(address . 41551@debbugs.gnu.org)
87o8q5z4rw.fsf@rohleder.de
Hi Marius,

you have an impressive pensum!
Thanks for the review!

Marius Bakke <marius@gnu.org> writes:
Toggle quote (5 lines)
>> * gnu/packages/emacs-xyz.scm (emacs-bm): New variable.
>
> Thanks! It LGTM but no longer applies, can you rebase it on the current
> master branch?

done.

Toggle quote (4 lines)
>> + (synopsis "Visual Bookmarks for Emacs")
> ^^^
> Lowercase 'b'.

done.

Toggle quote (9 lines)
>> + (description "This package provides visible, buffer local, bookmarks and
>> +the ability to jump forward and backward to the next bookmark.")
>
> The description reads a bit weird, I wonder if...
>
> "visible, buffer local bookmarks" (without the second comma)
>
> ...is more correct?

seems more correct, yes => done.
From b2a6beadb1b82a524f5ef665d747b5f5252534cb Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike@rohleder.de>
Date: Sat, 30 May 2020 19:50:02 +0200
Subject: [PATCH] gnu: Add emacs-bm.

* gnu/packages/emacs-xyz.scm (emacs-bm): New variable.
---
gnu/packages/emacs-xyz.scm | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)

Toggle diff (33 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6d82e1921c..9cf4cdd6a1 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1918,6 +1918,26 @@ code@{emacs-wiki.el}, it facilitates using hyperlinks and doing full-text
 searches.  Unlike code@{emacs-wiki.el}, it can be combined with any format.")
     (license license:gpl1+)))
 
+(define-public emacs-bm
+  (package
+    (name "emacs-bm")
+    (version "201905")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/joodland/bm.git")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "180b3rc13asrmsdh7v405d54jkrininvaj52xhp71vw91ng51dkn"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/joodland/bm")
+    (synopsis "Visual bookmarks for Emacs")
+    (description "This package provides visible, buffer local bookmarks and
+the ability to jump forward and backward to the next bookmark.")
+    (license license:gpl2+)))
+
 (define-public emacs-calfw
   (package
     (name "emacs-calfw")
-- 
2.26.2
--
In short, I think gcc should be fixed, or at the very least it should be a
_documented_ bug at which point I have no gripe with fixing it in the
kernel. But I refuse to work around undocumented bugs - that starts to
smell too much like microsoft, and then I might as well start using
Windows myself.
Linus
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEdV4t5dDVhcUueCgwfHr/vv7yyyUFAl7SnhMACgkQfHr/vv7y
yyWXwgf9E6UTdgVjlbf/PRGlHC33Und17h7/7wrNaW2c12zXSedHTb4cZ7vHZS1D
C+WHrpfd3b3S71ITy71YXsjdAM02yupNZ2BalzJr34+e78ROKvJfNy7i1OMbbb7z
644FXLciXoZqJPcRLhp6xtPmOTjrZqJq+NFgvJNcac1DlB9BZbIbadyvEIriHiHl
CKhCgaYDkBa+0AQyCuF13eiPMvrY8NRqZHyXeVX9t0xODU/cOMEeVuS16ABo/KDc
4w6PVeF9y+O45t5hhzDu7iPa5EeLuYI2rH6UTuNy9gzQj9KjeEQDjsxTjuP90uxw
0VdNs6QkvenSZupeZYFTiBZQcOUXcQ==
=0ttF
-----END PGP SIGNATURE-----

M
M
Marius Bakke wrote on 30 May 2020 23:16
(name . Michael Rohleder)(address . mike@rohleder.de)(address . 41551-done@debbugs.gnu.org)
87blm5xgvr.fsf@gnu.org
Michael Rohleder <mike@rohleder.de> writes:

Toggle quote (4 lines)
> Hi Marius,
>
> you have an impressive pensum!

Heh, not sure if that's meant as a compliment, but I'll take it. ;-)

Toggle quote (2 lines)
> Thanks for the review!

You are welcome!

[...]

Toggle quote (7 lines)
> From b2a6beadb1b82a524f5ef665d747b5f5252534cb Mon Sep 17 00:00:00 2001
> From: Michael Rohleder <mike@rohleder.de>
> Date: Sat, 30 May 2020 19:50:02 +0200
> Subject: [PATCH] gnu: Add emacs-bm.
>
> * gnu/packages/emacs-xyz.scm (emacs-bm): New variable.

Applied, thanks!
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7SzUgACgkQoqBt8qM6
VPqziwgAgCAvRiHtKgUDX4WRQ5VY3eODpRn4/iq/mg0BLu+34CGSBDcDUxTBfMCo
AcnQyIKusbCkDHfTj9WQzUYu99HoYcIDRFo3qJ1wntfnKJK6+yHvaOvRUksiJchb
nrLrXhLx0e+kqxdJ0iuIV6IxV4QboH0C1I4+LSSVFVCvPfKjuD1ErqdtQH1nGrF2
6wWmf2UEOyM275d0waFRwZXCEY6IgzWGTkjZOq7C+wVhupsS8a3BTYQhIctTqUfg
bK81PLB6zdjUmYLWcDC7n58llzrsPPuTm6S2hf0SSb7+/SXS2wFH9ot6Y6i1qQ9p
eBrYqJySgKN6MlvP6yhADJg42bIWyg==
=6BOD
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 41551@debbugs.gnu.org