[PATCH] gnu: mediainfo: Update to 20.03.

DoneSubmitted by Michael Rohleder.
Details
3 participants
  • Ludovic Courtès
  • Tobias Geerinckx-Rice
  • Michael Rohleder
Owner
unassigned
Severity
normal
M
M
Michael Rohleder wrote on 21 May 2020 20:30
(address . guix-patches@gnu.org)
871rndp2cz.fsf@rohleder.de
From c2a6e1cdd59defc8fa30bce401281ed0e8a505ee Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike@rohleder.de>
Date: Thu, 21 May 2020 20:27:20 +0200
Subject: [PATCH] gnu: mediainfo: Update to 20.03.

* gnu/packages/video.scm (mediainfo): Update to 20.03.
---
gnu/packages/video.scm | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)

Toggle diff (56 lines)
diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index bb465c64c9..2adf2c3024 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -41,6 +41,7 @@
 ;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com>
 ;;; Copyright © 2020 Guillaume Le Vaillant <glv@posteo.net>
 ;;; Copyright © 2020 Alex McGrath <amk@amk.ie>
+;;; Copyright © 2020 Michael Rohleder <mike@rohleder.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3019,15 +3020,15 @@ practically any type of media.")
 (define-public libmediainfo
   (package
     (name "libmediainfo")
-    (version "0.7.95")
+    (version "20.03")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://mediaarea.net/download/source/"
-                                  name "/" version"/"
-                                  name "_" version ".tar.bz2"))
+                                  name "/" version "/"
+                                  name "_" version ".tar.xz"))
               (sha256
                (base32
-                "1kchh6285b07z5nixv619hc9gml2ysdayicdiv30frrlqiyxqw4b"))))
+                "0wkzj5s34m8dvy7hif4h8f90q8ncrzd930gij1zzw3h5nw732j38"))))
     ;; TODO add a Big Buck Bunny webm for tests.
     (native-inputs
      `(("autoconf" ,autoconf)
@@ -3077,7 +3078,7 @@ MPEG-2, MPEG-4, DVD (VOB)...
 (define-public mediainfo
   (package
     (name "mediainfo")
-    (version "18.12")
+    (version "20.03")
     (source (origin
               (method url-fetch)
               ;; Warning: This source has proved unreliable 1 time at least.
@@ -3085,10 +3086,10 @@ MPEG-2, MPEG-4, DVD (VOB)...
               ;; happens again.
               (uri (string-append "https://mediaarea.net/download/source/"
                                   name "/" version "/"
-                                  name "_" version ".tar.bz2"))
+                                  name "_" version ".tar.xz"))
               (sha256
                (base32
-                "1ix95ilcjlawcq6phh25cgplm3riqa2ii7ql82g8yagqs4ldqp6a"))))
+                "1f1shnycf0f1fwka9k9s250l228xjkg0k4k73h8bpld8msighgnw"))))
     (native-inputs
      `(("autoconf" ,autoconf)
        ("automake" ,automake)
-- 
2.26.2
--
Why doesn't DOS ever say "EXCELLENT command or filename!"
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEdV4t5dDVhcUueCgwfHr/vv7yyyUFAl7GyMwACgkQfHr/vv7y
yyWYDwf+IjrKncCbfjH7byDUIbbZLXYqhZROsG5olYORI7cytMcAImvs1CpMzV+6
j8n34mG3dnum8CquLMKRzLJ/rYyNYl2f9c0EaDcFJQHHCdfCx4OXVOrWJMMInFwk
wWjFuG1C2OS3iqqQlFjPl22YCSHc+HRI2qcNhmlXMtboD/XKGYi6duaLYN/6M9TY
rJf7o5KDihsN8CbnGbn/csQVyWcO166FsWDLH6Z0KrbY0X0NmDGMBxf3ZOSV0Lt1
QN9oqpcMXls9IfTJuFrA2xASuTIVjg8VpN2Mu7eejd4f348j83FxLBFQMoCgAP3C
xp23q0kB+WqjcA47bTfbwzwDB6GqWg==
=E6hm
-----END PGP SIGNATURE-----

T
T
Tobias Geerinckx-Rice wrote on 21 May 2020 22:31
(name . Michael Rohleder)(address . mike@rohleder.de)(address . 41439@debbugs.gnu.org)
87imgpowrz.fsf@nckx
Michael,

Michael Rohleder 写道:
Toggle quote (2 lines)
> Subject: [PATCH] gnu: mediainfo: Update to 20.03.

Thanks!

Toggle quote (2 lines)
> * gnu/packages/video.scm (mediainfo): Update to 20.03.

When operating on multiple packages, you need to (list, both).

Are they required to be updated in lockstep? Is there really no
order in which we could update these as two separate commits?

If not, please add a comment noting that they need to be updated
in tandem. Or better yet: if you're reasonably sure that upstream
is committed to their new versioning scheme, you can use

(version (package-version libmediainfo))

in mediainfo to make that crystal clear.

Kind regards,

T G-R
-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXsblEAAKCRANsP+IT1Vt
eUA+AQCCailrxSAH9SVaNEu9ZfRLhHSojISArIncBQGtN5ilNwD7BA8BG+kCkyio
l0qnxXpucyrg8gGMNLiao565J3XU7gw=
=wbAt
-----END PGP SIGNATURE-----

M
M
Michael Rohleder wrote on 21 May 2020 23:51
(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)(address . 41439@debbugs.gnu.org)
87ftbtnegz.fsf@rohleder.de
Tobias,

thank you for the review!

Tobias Geerinckx-Rice <me@tobias.gr> writes:
Toggle quote (7 lines)
>> * gnu/packages/video.scm (mediainfo): Update to 20.03.
>
> When operating on multiple packages, you need to (list, both).
>
> Are they required to be updated in lockstep? Is there really no order
> in which we could update these as two separate commits?

mediainfo@18.12 does indeed run with libmediainfo@20.03, so here are 2
patches
From 600052b628ccb82e5722e439659c7266c46168b8 Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike@rohleder.de>
Date: Thu, 21 May 2020 23:32:19 +0200
Subject: [PATCH] gnu: libmediainfo: Update to 20.03.

* gnu/packages/video.scm (libmediainfo): Update to 20.03.
---
gnu/packages/video.scm | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

Toggle diff (26 lines)
diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index bb465c64c9..30b4d3cd9e 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -3019,15 +3019,15 @@ practically any type of media.")
 (define-public libmediainfo
   (package
     (name "libmediainfo")
-    (version "0.7.95")
+    (version "20.03")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://mediaarea.net/download/source/"
-                                  name "/" version"/"
-                                  name "_" version ".tar.bz2"))
+                                  name "/" version "/"
+                                  name "_" version ".tar.xz"))
               (sha256
                (base32
-                "1kchh6285b07z5nixv619hc9gml2ysdayicdiv30frrlqiyxqw4b"))))
+                "0wkzj5s34m8dvy7hif4h8f90q8ncrzd930gij1zzw3h5nw732j38"))))
     ;; TODO add a Big Buck Bunny webm for tests.
     (native-inputs
      `(("autoconf" ,autoconf)
-- 
2.26.2
From fb12c84e2b19b5cad6044a7a336253ffbdb1cc56 Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike@rohleder.de>
Date: Thu, 21 May 2020 23:37:13 +0200
Subject: [PATCH] gnu: mediainfo: Update to 20.03.

* gnu/packages/video.scm (mediainfo): Update to 20.03.
---
gnu/packages/video.scm | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

Toggle diff (36 lines)
diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 30b4d3cd9e..2adf2c3024 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -41,6 +41,7 @@
 ;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com>
 ;;; Copyright © 2020 Guillaume Le Vaillant <glv@posteo.net>
 ;;; Copyright © 2020 Alex McGrath <amk@amk.ie>
+;;; Copyright © 2020 Michael Rohleder <mike@rohleder.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3077,7 +3078,7 @@ MPEG-2, MPEG-4, DVD (VOB)...
 (define-public mediainfo
   (package
     (name "mediainfo")
-    (version "18.12")
+    (version "20.03")
     (source (origin
               (method url-fetch)
               ;; Warning: This source has proved unreliable 1 time at least.
@@ -3085,10 +3086,10 @@ MPEG-2, MPEG-4, DVD (VOB)...
               ;; happens again.
               (uri (string-append "https://mediaarea.net/download/source/"
                                   name "/" version "/"
-                                  name "_" version ".tar.bz2"))
+                                  name "_" version ".tar.xz"))
               (sha256
                (base32
-                "1ix95ilcjlawcq6phh25cgplm3riqa2ii7ql82g8yagqs4ldqp6a"))))
+                "1f1shnycf0f1fwka9k9s250l228xjkg0k4k73h8bpld8msighgnw"))))
     (native-inputs
      `(("autoconf" ,autoconf)
        ("automake" ,automake)
-- 
2.26.2
Kind Regards
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEdV4t5dDVhcUueCgwfHr/vv7yyyUFAl7G9/wACgkQfHr/vv7y
yyUM3AgAmre0F7LVAgOhy7H/J8iLbRbIdfZAFYhTmHOt0U6i6cNQMY85WS9SMHTz
+rf/8PGLVvfrN+gVUvAC1PNiDnEIUSBT3dDnuOFASMkGkIb+sIaUcB6Hx3uacAv8
9a+3EJ6j4/UrEJuKRaqg+uhlgz0rC6OHgqT/YyFHtQYTvKshmWnobKo1CU3c9SCZ
eSbYvs0hcIQMtBGARkEXpucpORsey4nBcmY18yOdaZipNWfZES8A921MCvP46r/r
Hdc5nAOmrorrG/ENULCd+xY26Zu4h0ia1f5InCZ5bFiBwy0e0Gwe7JQ7FJam3fZ1
6lfKB8wOpyZxRrX84QMpSW5wSYF6SQ==
=U4x1
-----END PGP SIGNATURE-----

L
L
Ludovic Courtès wrote on 23 May 2020 16:23
(name . Michael Rohleder)(address . mike@rohleder.de)
87k112688d.fsf@gnu.org
Hi,

Michael Rohleder <mike@rohleder.de> skribis:

Toggle quote (7 lines)
> From 600052b628ccb82e5722e439659c7266c46168b8 Mon Sep 17 00:00:00 2001
> From: Michael Rohleder <mike@rohleder.de>
> Date: Thu, 21 May 2020 23:32:19 +0200
> Subject: [PATCH] gnu: libmediainfo: Update to 20.03.
>
> * gnu/packages/video.scm (libmediainfo): Update to 20.03.

[...]

Toggle quote (7 lines)
> From fb12c84e2b19b5cad6044a7a336253ffbdb1cc56 Mon Sep 17 00:00:00 2001
> From: Michael Rohleder <mike@rohleder.de>
> Date: Thu, 21 May 2020 23:37:13 +0200
> Subject: [PATCH] gnu: mediainfo: Update to 20.03.
>
> * gnu/packages/video.scm (mediainfo): Update to 20.03.

Applied, thanks!

Ludo’.
Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 41439@debbugs.gnu.org