000-update-python-argon2-cffi.patch

  • Done
  • quality assurance status badge
Details
3 participants
  • Josh Marshall
  • Marius Bakke
  • Marius Bakke
Owner
unassigned
Submitted by
Josh Marshall
Severity
normal

Debbugs page

Josh Marshall wrote 5 years ago
(address . guix-patches@gnu.org)
CAFkJGRevx7HfdA5=gCSgtumgPt1zjLqVvK+-Gfy1J4_GDOm81g@mail.gmail.com
Toggle diff (22 lines)
diff --git a/gnu/packages/python-crypto.scm b/gnu/packages/python-crypto.scm
index e6208ab3d9..fc451e83ef 100644
--- a/gnu/packages/python-crypto.scm
+++ b/gnu/packages/python-crypto.scm
@@ -1365,14 +1365,14 @@ I/O-free core, and integration modules for
different event loops.")
(define-public python-argon2-cffi
(package
(name "python-argon2-cffi")
- (version "19.2.0")
+ (version "20.1.0")
(source
(origin
(method url-fetch)
(uri (pypi-uri "argon2-cffi" version))
(sha256
(base32
- "18xxfw30gi3lwaz4vwb05iavzlrk3fa1x9fippzrgd3px8z65apz"))
+ "0zgr4mnnm0p4i99023safb0qb8cgvl202nly1rvylk2b7qnrn0nq"))
(modules '((guix build utils)))
(snippet '(begin (delete-file-recursively "extras") #t))))
(build-system python-build-system)
Marius Bakke wrote 5 years ago
(name . Josh Marshall)(address . joshua.r.marshall.1991@gmail.com)(address . 41345@debbugs.gnu.org)
87o8qi9v8i.fsf@devup.no
Hi Josh,

Can you resubmit this patch with a proper commit message?

Thanks!
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7Fmp0ACgkQoqBt8qM6
VPofGQf+NGjGe0DU55NIqciRllCzRQ6YqkUvk1pt6tbvlc3KE4V/03EZdiPKW1L2
fgozisTq2a1Jxb0AaywzBguVqNda01s5yubcOnBqxOHvOfVVnqq7G+d668TbFO4t
NPzWLaZ0lWYjUmpXX9EBNhSolQRinifKce6wUdfFxpooaf/WYmmYJ836NxTXOGYz
ZfkgG1z+KW0y4hdqJyeJWFmTal4CovKIRGExu8FM9i28efosNX3017RRGkTPTQXW
nzDkyYqPxj28yLsfhPod8511Las/WrKLfvI9OsVRqul4MnkBH+O+gKKq21jOCJHO
lze56CoA8OUk0w17A+vPW5K21Mla1A==
=6Mmo
-----END PGP SIGNATURE-----

Josh Marshall wrote 5 years ago
(name . Marius Bakke)(address . mbakke@fastmail.com)(address . 41345@debbugs.gnu.org)
CAFkJGRfZkL61R3nUqF8Pp=U9me=naKjbvU+jtrbJ5Em41o3N4w@mail.gmail.com
Sure. This was before I figured out `git send-email`.

On Wed, May 20, 2020, 17:01 Marius Bakke <mbakke@fastmail.com> wrote:

Toggle quote (6 lines)
> Hi Josh,
>
> Can you resubmit this patch with a proper commit message?
>
> Thanks!
>
Attachment: file
Josh Marshall wrote 5 years ago
(name . Marius Bakke)(address . mbakke@fastmail.com)(address . 41345@debbugs.gnu.org)
CAFkJGRfCGi_=jYNRefPT0Go1Nmpq+j9NWmEtw204M2kXpYkngw@mail.gmail.com
Resubmitted the patch more properly made. Looks like it didn't continue
this thread. How do I close this?

On Wed, May 20, 2020, 17:07 Josh Marshall <joshua.r.marshall.1991@gmail.com>
wrote:

Toggle quote (11 lines)
> Sure. This was before I figured out `git send-email`.
>
> On Wed, May 20, 2020, 17:01 Marius Bakke <mbakke@fastmail.com> wrote:
>
>> Hi Josh,
>>
>> Can you resubmit this patch with a proper commit message?
>>
>> Thanks!
>>
>
Attachment: file
Marius Bakke wrote 5 years ago
(name . Josh Marshall)(address . joshua.r.marshall.1991@gmail.com)(address . 41345-done@debbugs.gnu.org)
87lflg6owx.fsf@gnu.org
Josh Marshall <joshua.r.marshall.1991@gmail.com> writes:

Toggle quote (3 lines)
> Resubmitted the patch more properly made. Looks like it didn't continue
> this thread. How do I close this?

It still did not have a commit message though:


Note how it differs from other package updates, in particular lacking
the '* gnu/packages/file.scm (variable):' line, as well as the "gnu: "
prefix. No big deal, but try to follow the convention next time.

In any case you can close bugs by appending -done to the issue ID, like
I've done in this message. Thanks!
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7L3V4ACgkQoqBt8qM6
VPoXdAf+PA7MMwaMaVwkcd55IFQUuroWY2FVOMjYjIMtIiIA4UjWpU6rqunuOc8a
YjQCUkgDl7Tmh9fsDi/BxsdMhLke2OUejijvEP0GrYLlYa6XL0yjj9aBBy10Smvw
/WRzfraYLFBnoSI0N9kplm4F+P1lnRkGczfQ2ud3nM6uoB92SMC4FrAtLO9YK2SO
bv2iS+oui/JAML5UzrY1U1xsFAHrxHn3j1WcpMYBQfGrZLj3UQ9hf82eKvGCrbGE
5Fzu0c7438Yf92bRxkPJO1Z37HmhiO9WVGcPulKzakSNFi9buwwAyCFSDWat3miQ
YCHsKxH1a890oc18Du6sZVn/bh9OUA==
=WVtN
-----END PGP SIGNATURE-----

Closed
Josh Marshall wrote 5 years ago
(name . Marius Bakke)(address . marius@gnu.org)(address . 41345-done@debbugs.gnu.org)
CAFkJGRciGh8irJ+H_qAEshZDxH8i9of_R_KK1WqkjaepRKJ7OQ@mail.gmail.com
Here is what I'm doing:
```
git commit -am "Updating python-argon2-cffi to 20.1.0"
git format-patch master
git send-email --to=guix-patches@gnu.org
--subject="000-update-python-argon2-cffi.patch"
0001-Updating-python-argon2-cffi-to-20.1.0.patch
```

I do not see guidance on this particular aspect of sending patches.
What do I need to alter, and should those details be added to the
manual?

On Mon, May 25, 2020 at 10:59 AM Marius Bakke <marius@gnu.org> wrote:
Toggle quote (16 lines)
>
> Josh Marshall <joshua.r.marshall.1991@gmail.com> writes:
>
> > Resubmitted the patch more properly made. Looks like it didn't continue
> > this thread. How do I close this?
>
> It still did not have a commit message though:
>
> https://git.savannah.gnu.org/cgit/guix.git/log/gnu/packages?id=9813805b30dad444984111d5413b8ab7356f7908
>
> Note how it differs from other package updates, in particular lacking
> the '* gnu/packages/file.scm (variable):' line, as well as the "gnu: "
> prefix. No big deal, but try to follow the convention next time.
>
> In any case you can close bugs by appending -done to the issue ID, like
> I've done in this message. Thanks!
Closed
Marius Bakke wrote 5 years ago
(name . Josh Marshall)(address . joshua.r.marshall.1991@gmail.com)(address . 41345-done@debbugs.gnu.org)
87a71v7l5d.fsf@gnu.org
Josh Marshall <joshua.r.marshall.1991@gmail.com> writes:

Toggle quote (5 lines)
> I do not see guidance on this particular aspect of sending patches.
> What do I need to alter, and should those details be added to the
> manual?

It's not very prominent, but it's there:

Please write commit logs in the ChangeLog format (see Change Logs in
GNU Coding Standards); you can check the commit history for examples.

With a link to the GNU Coding Standards document:


Perhaps we could include a condensed version as it borders on TL;DR.

Toggle quote (2 lines)
> git commit -am "Updating python-argon2-cffi to 20.1.0"

If you omit the -m, git will open your $EDITOR where you can contemplate
on how best to communicate what the patch does, and write over multiple
lines. There are helper functions in Emacs to fill out the boring
"* gnu/packages/file-name.scm (variable):" part of the commit message.

When unsure, I recommend running "git log the-file.scm" and look at
previous commit messages for inspiration.

Thanks for persevering! :-)
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7MOi4ACgkQoqBt8qM6
VPrbfQf9HwteyLx3AXTPPQglkNRkP7jBr7aADJRRBxYutnwlE0FkSKKZwScnq/Bl
y2D4cLao3FuMViuWofAIY43qLbKGT+xrxemC5uF+35lGYsTB40519o05jpAeC+3Z
YCxS4ZSC5ESY+BanEw52MxwzBepcEmv/Y9GdWaz8/0JXKYcxXtwYCN3vJtN1MwvP
d6VXc3yilT70ygQdHRjnyAl2TUkgp5cH6ePg0OB7Y+CFzjFTnZWBvTN2mtwzkIKQ
BObhyObLlEt65nwRnA8nexE8LiBP8D9BAfg62OoUt8Fz5eVTTf3u24ymrTkPqVXM
L3CXnln2y6GgBsfkPttQgPn8oKn5Lw==
=Yh17
-----END PGP SIGNATURE-----

Closed
Josh Marshall wrote 5 years ago
(name . Marius Bakke)(address . marius@gnu.org)(address . 41345-done@debbugs.gnu.org)
CAFkJGReBCBeD8ptwH4gu79L96w+QWd1yz2udtYROdLEfTAhaWg@mail.gmail.com
If those are the particular expectations and standards, should they change
from only policy in the manual to something enforced by a git pre-commit
hook?

On Mon, May 25, 2020, 17:35 Marius Bakke <marius@gnu.org> wrote:

Toggle quote (30 lines)
> Josh Marshall <joshua.r.marshall.1991@gmail.com> writes:
>
> > When reading https://guix.gnu.org/manual/en/guix.html#Submitting-Patches
> > I do not see guidance on this particular aspect of sending patches.
> > What do I need to alter, and should those details be added to the
> > manual?
>
> It's not very prominent, but it's there:
>
> Please write commit logs in the ChangeLog format (see Change Logs in
> GNU Coding Standards); you can check the commit history for examples.
>
> With a link to the GNU Coding Standards document:
>
> https://www.gnu.org/prep/standards/standards.html#Change-Logs
>
> Perhaps we could include a condensed version as it borders on TL;DR.
>
> > git commit -am "Updating python-argon2-cffi to 20.1.0"
>
> If you omit the -m, git will open your $EDITOR where you can contemplate
> on how best to communicate what the patch does, and write over multiple
> lines. There are helper functions in Emacs to fill out the boring
> "* gnu/packages/file-name.scm (variable):" part of the commit message.
>
> When unsure, I recommend running "git log the-file.scm" and look at
> previous commit messages for inspiration.
>
> Thanks for persevering! :-)
>
Attachment: file
Closed
Marius Bakke wrote 5 years ago
(name . Josh Marshall)(address . joshua.r.marshall.1991@gmail.com)(address . 41345-done@debbugs.gnu.org)
87k10t1s87.fsf@gnu.org
Josh Marshall <joshua.r.marshall.1991@gmail.com> writes:

Toggle quote (4 lines)
> If those are the particular expectations and standards, should they change
> from only policy in the manual to something enforced by a git pre-commit
> hook?

That's a good idea. I'm not sure about enforcing, but we could have a
post-commit hook that complains if all the files are not mentioned in
the commit message.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7SW9gACgkQoqBt8qM6
VPpeLQf/Rdn/tlOKNqsyIqTByjXJfJGFoFrsPvREx6cEy5HjLPSf9+ClrNjcmbLC
a6S4gGgDxrhCqMVxfAbXIjGD4OfCT5HG+g6jmXNENSqiQPlZl9ou0YhYfhyThO6D
cJuXm9+qabnUyimPPf5ELvJHNoDiw6Xrqj4jSmyG2P285XWg7/pBl97X0dxaSlv+
CTjkH6zUAnaBwvoe+dMKjbTgxPMenv246x1L8wqLUCms1wqZ12YgnHStq1vVuFj+
ReKJ/iSRqdInxoKGgBdEoHaYFNy9QWr8qOI4KbtMGVAF/i95kJw1UZKkA4tijUgk
cJ6l4OlFbTxtYncZABnmf/1Jxbe8Zw==
=23gG
-----END PGP SIGNATURE-----

Closed
Josh Marshall wrote 5 years ago
(name . Marius Bakke)(address . marius@gnu.org)(address . 41345-done@debbugs.gnu.org)
CAFkJGReRY6Fnq3YvBMa6qpcBHDqXxQV3=Nvt=9WWHb+zN54T9Q@mail.gmail.com
It could also enforce a number of linting details. That'd save reviewers
time.

On Sat, May 30, 2020, 09:12 Marius Bakke <marius@gnu.org> wrote:

Toggle quote (11 lines)
> Josh Marshall <joshua.r.marshall.1991@gmail.com> writes:
>
> > If those are the particular expectations and standards, should they
> change
> > from only policy in the manual to something enforced by a git pre-commit
> > hook?
>
> That's a good idea. I'm not sure about enforcing, but we could have a
> post-commit hook that complains if all the files are not mentioned in
> the commit message.
>
Attachment: file
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 41345@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 41345
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help