[PATCH] doc: Mention guix-daemon's 'https_proxy' environment variable.

DoneSubmitted by Brice Waegeneire.
Details
2 participants
  • Brice Waegeneire
  • Mathieu Othacehe
Owner
unassigned
Severity
normal
B
B
Brice Waegeneire wrote on 12 May 2020 22:04
(address . guix-patches@gnu.org)
20200512200439.16367-1-brice@waegenei.re
* doc/guix.texi (Proxy Settings, Derivations): Mention 'https_proxy'.
---
doc/guix.texi | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)

Toggle diff (42 lines)
diff --git a/doc/guix.texi b/doc/guix.texi
index 420c2c9eae..09d5a1dc52 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -1012,9 +1012,11 @@ environments, which avoids discrepancies in cases where build processes
 capture the name of their build tree.
 
 @vindex http_proxy
-The daemon also honors the @env{http_proxy} environment variable for
-HTTP downloads it performs, be it for fixed-output derivations
-(@pxref{Derivations}) or for substitutes (@pxref{Substitutes}).
+@vindex https_proxy
+The daemon also honors the @env{http_proxy} and @env{https_proxy}
+environment variables for HTTP and HTTPS downloads it performs, be it
+for fixed-output derivations (@pxref{Derivations}) or for substitutes
+(@pxref{Substitutes}).
 
 If you are installing Guix as an unprivileged user, it is still possible
 to run @command{guix-daemon} provided you pass @option{--disable-chroot}.
@@ -3376,13 +3378,13 @@ authenticating bindings between domain names and public keys.)
 @subsection Proxy Settings
 
 @vindex http_proxy
-Substitutes are downloaded over HTTP or HTTPS.
-The @env{http_proxy} environment
-variable can be set in the environment of @command{guix-daemon} and is
-honored for downloads of substitutes.  Note that the value of
-@env{http_proxy} in the environment where @command{guix build},
-@command{guix package}, and other client commands are run has
-@emph{absolutely no effect}.
+@vindex https_proxy
+Substitutes are downloaded over HTTP or HTTPS.  The @env{http_proxy} and
+@env{https_proxy} environment variables can be set in the environment of
+@command{guix-daemon} and is honored for downloads of substitutes.  Note
+that the value of those environment variables in the environment where
+@command{guix build}, @command{guix package}, and other client commands
+are run has @emph{absolutely no effect}.
 
 @node Substitution Failure
 @subsection Substitution Failure
-- 
2.26.2
M
M
Mathieu Othacehe wrote on 13 May 2020 08:49
(name . Brice Waegeneire)(address . brice@waegenei.re)(address . 41216@debbugs.gnu.org)
87y2pw49ec.fsf@gnu.org
Hello Brice,

Toggle quote (4 lines)
> +Substitutes are downloaded over HTTP or HTTPS. The @env{http_proxy} and
> +@env{https_proxy} environment variables can be set in the environment of
> +@command{guix-daemon} and is honored for downloads of substitutes. Note

are honored?

This looks fine, thanks!

Mathieu
B
B
Brice Waegeneire wrote on 13 May 2020 10:58
(name . Mathieu Othacehe)(address . othacehe@gnu.org)(address . 41216-done@debbugs.gnu.org)
7faf78b32f78157a09c4602e02510d4a@waegenei.re
Hello Mathieu,

Thank you for the review.

On 2020-05-13 06:49, Mathieu Othacehe wrote:
Toggle quote (11 lines)
> Hello Brice,
>
>> +Substitutes are downloaded over HTTP or HTTPS. The @env{http_proxy}
>> and
>> +@env{https_proxy} environment variables can be set in the environment
>> of
>> +@command{guix-daemon} and is honored for downloads of substitutes.
>> Note
>
> are honored?

Fixed.

Toggle quote (4 lines)
> This looks fine, thanks!
>
> Mathieu

Pushed as 15014dc61858e14e3356c7489cd366555085048b.

- Brice
Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 41216@debbugs.gnu.org