[PATCH] Do not propagate "emacs-org" in Emacs packages

  • Done
  • quality assurance status badge
Details
3 participants
  • Jelle Licht
  • Nicolas Goaziou
  • Ricardo Wurmus
Owner
unassigned
Submitted by
Nicolas Goaziou
Severity
normal
N
J
J
Jelle Licht wrote on 11 May 2020 18:02
878shy5ukk.fsf@jlicht.xyz
Hi Nicolas,


Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

Toggle quote (7 lines)
> Hello,
>
> The following patch removes dependency on upstream Org packages for
> Emacs packages.
>
> Feedback welcome.

You asked for it ;-).

On a more serious note, I have had _many_ issues with byte-compilation
of org-related anything over the years. Wouldn't this mean that the list
of packages that is touched by this patch will be byte-compiled using
the outdated org-mode that comes with Emacs?

Put another way, will all of these packages still work if I _do_ have
emacs-org installed in my profile?

Thanks!

- Jelle
N
N
Nicolas Goaziou wrote on 11 May 2020 18:59
(name . Jelle Licht)(address . jlicht@fsfe.org)(address . 41188@debbugs.gnu.org)
87h7wmwgor.fsf@nicolasgoaziou.fr
Hello,

Jelle Licht <jlicht@fsfe.org> writes:

Toggle quote (2 lines)
> You asked for it ;-).

Heh.

Toggle quote (3 lines)
> On a more serious note, I have had _many_ issues with byte-compilation
> of org-related anything over the years.

I have not encountered such problems. I don't use much Org-related
anything, either. Would you have any example in mind?

Toggle quote (4 lines)
> Wouldn't this mean that the list of packages that is touched by this
> patch will be byte-compiled using the outdated org-mode that comes
> with Emacs?

It means exactly that.

Toggle quote (3 lines)
> Put another way, will all of these packages still work if I _do_ have
> emacs-org installed in my profile?

Good question. This is why I'm sending this patch for review in the
first place.

I don't expect byte-compilation to do anything fancy here. As long as
the functions do not change their name, byte-compilation should be fine.
Take it with a grain of salt, tho. Maybe we should just test it and fix
encountered issues piece wise.

OTOH, we currently force users to always update Org, possibly
introducing, each time, breakage in their workflow, to get features that
would work perfectly with bundled Org.

Regards,

--
Nicolas Goaziou
R
R
Ricardo Wurmus wrote on 17 May 2020 17:45
(name . Nicolas Goaziou)(address . mail@nicolasgoaziou.fr)
87ftbyh8fb.fsf@elephly.net
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

Toggle quote (18 lines)
>> On a more serious note, I have had _many_ issues with byte-compilation
>> of org-related anything over the years.
>
> I have not encountered such problems. I don't use much Org-related
> anything, either. Would you have any example in mind?
>
>> Wouldn't this mean that the list of packages that is touched by this
>> patch will be byte-compiled using the outdated org-mode that comes
>> with Emacs?
>
> It means exactly that.
>
>> Put another way, will all of these packages still work if I _do_ have
>> emacs-org installed in my profile?
>
> Good question. This is why I'm sending this patch for review in the
> first place.

I think it’s a good idea to ignore the version of org-mode that comes
with Emacs and assume that the latest version is installed, because they
are unfortunately far apart that I’m sure will cause problems.

I’m assuming that Org users generally will have a more recent org-mode
installed.

Toggle quote (4 lines)
> OTOH, we currently force users to always update Org, possibly
> introducing, each time, breakage in their workflow, to get features that
> would work perfectly with bundled Org.

This is a general problem with Guix, though. Org-mode is no exception.

--
Ricardo
N
N
Nicolas Goaziou wrote on 18 May 2020 01:12
(name . Ricardo Wurmus)(address . rekado@elephly.net)
87y2pqrwak.fsf@nicolasgoaziou.fr
Hello,

Ricardo Wurmus <rekado@elephly.net> writes:

Toggle quote (7 lines)
> I think it’s a good idea to ignore the version of org-mode that comes
> with Emacs and assume that the latest version is installed, because they
> are unfortunately far apart that I’m sure will cause problems.
>
> I’m assuming that Org users generally will have a more recent org-mode
> installed.

Fair enough. I'm dropping the patch, then.

Thanks to both of you for the feedback.

Regards,

--
Nicolas Goaziou
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 41188@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 41188
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch