[PATCH] gnu: vis: Fix #39394

Recipients:(address . guix-patches@gnu.org)

Message-ID:CAMaATaNQBPNbx6GGcnSgR5h1C6s2CpOsSEYscTWTMRKn-cPQwA@mail.gmail.com

There is no need to set $VIS_PATH to $prefix/share/vis as VIS_PATH

(#define), which is also in search path

is already set by Makefile to $prefix/share/vis

---

gnu/packages/text-editors.scm | 4 ----

1 file changed, 4 deletions(-)

Toggle diff (17 lines)diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
index 886babf3fa..5b17a5082f 100644
--- a/gnu/packages/text-editors.scm
+++ b/gnu/packages/text-editors.scm
@@ -101,10 +101,6 @@
                  `("LUA_PATH" ":" prefix (,LUA_PATH))
                  `("LUA_CPATH" ":" prefix (,LUA_CPATH)))
                #t))))))
-    (native-search-paths
-     (list (search-path-specification
-            (variable "VIS_PATH")
-            (files '("share/vis")))))
     (inputs `(("lua" ,lua)
               ("ncurses" ,ncurses)
               ("libtermkey" ,libtermkey)
-- 
2.26.2

Jakub Kądziołka wrote on 1 Jun 2020 15:44

Recipients:(name . tsmish)(address . tsymsh@gmail.com)(address . 41151-done@debbugs.gnu.org)

Message-ID:20200601134413.m65s76owjlhlqg5e@gravity

On Sat, May 09, 2020 at 03:51:53PM +0000, tsmish wrote:

Toggle quote (6 lines)

> There is no need to set $VIS_PATH to $prefix/share/vis as VIS_PATH

> (#define), which is also in search path

> (https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/vis-lua.c#L2662),

> is already set by Makefile to $prefix/share/vis

> (https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/Makefile#L37).

Thanks for the patch! We usually avoid putting a bug number as the only

information in the commit title, so I took the liberty to rewrite the

commit message a bit:

commit 5b588f2c9ba9c40dc32aed7c3cdaa45e8f920509 (HEAD -> master, upstream/master)

Author: tsmish <tsymsh@gmail.com>

gnu: vis: Fix configuration load order.

* gnu/packages/text-editors.scm (vis)[native-search-paths]: Remove.

There is no need to set $VIS_PATH to $prefix/share/vis as VIS_PATH

(#define), which is also in search path

is already set by Makefile to $prefix/share/vis

Signed-off-by: Jakub Kądziołka <kuba@kadziolka.net>

Cheers!

Closed

Your comment

This issue is archived.