[PATCH] doc: Lower 'Kernel Module Loader Service' one level.

DoneSubmitted by Brice Waegeneire.
Details
2 participants
  • Brice Waegeneire
  • Mathieu Othacehe
Owner
unassigned
Severity
normal
B
B
Brice Waegeneire wrote on 28 Apr 2020 16:21
Download
(address . guix-patches@gnu.org)
20200428142141.13636-1-brice@waegenei.re
Download
* doc/guix.texi (Kernel Module Loader Service): Move it from under
'Early OOM Service' to 'Services'.
---

I made a typo when first submiting the module.

doc/guix.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/doc/guix.texi b/doc/guix.texi
index cea4eeb984..89699e6ca5 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -25679,7 +25679,7 @@ notifications.
 
 @cindex modprobe
 @cindex kernel module loader
-@subsubsection Kernel Module Loader Service
+@subsection Kernel Module Loader Service
 
 The kernel module loader service allows one to load loadable kernel
 modules at boot.  This is especially useful for modules that don't
-- 
2.26.0
M
M
Mathieu Othacehe wrote on 1 May 2020 13:41
Download
(name . Brice Waegeneire)(address . brice@waegenei.re)(address . 40938@debbugs.gnu.org)
878sib51bs.fsf@gmail.com
Download
Hello Brice,

Toggle quote (5 lines)
> @cindex modprobe
> @cindex kernel module loader
> -@subsubsection Kernel Module Loader Service
> +@subsection Kernel Module Loader Service

I have the following warning when applying this patch:

Toggle snippet (5 lines)
MAKEINFO doc/guix.info
./doc/guix.texi:25493: warning: node `Miscellaneous Services' is next for `Linux Services' in menu but not in sectioning
./doc/guix.texi:25595: warning: node `Linux Services' is prev for `Miscellaneous Services' in menu but not in sectioning

Do you know why?

Thanks,

Mathieu
B
B
Brice Waegeneire wrote on 1 May 2020 16:22
Download
[PATCH v2 1/2] doc: Replace section 'Early OOM service' by 'Linux Services'.
(address . 40938@debbugs.gnu.org)
20200501142255.5860-1-brice@waegenei.re
Download
* doc/guix.texi (Linux Services): Changed from 'subsubheading' to
'subsection'.
(Early OOM Service, Kernel Module Loader Service): Moved under 'Linux
Services'.
---
doc/guix.texi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Toggle diff (31 lines)
diff --git a/doc/guix.texi b/doc/guix.texi
index e01ecc1e63..a8550541fe 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -25622,13 +25622,13 @@ Extra command line options for @code{guix-data-service-process-jobs}.
 @end deftp
 
 @node Linux Services
-@subsubheading Linux Services
+@subsection Linux Services
 
 @cindex oom
 @cindex out of memory killer
 @cindex earlyoom
 @cindex early out of memory daemon
-@subsection Early OOM Service
+@subsubheading Early OOM Service
 
 @uref{https://github.com/rfjakob/earlyoom,Early OOM}, also known as
 Earlyoom, is a minimalist out of memory (OOM) daemon that runs in user
@@ -25688,7 +25688,7 @@ notifications.
 
 @cindex modprobe
 @cindex kernel module loader
-@subsubsection Kernel Module Loader Service
+@subsubheading Kernel Module Loader Service
 
 The kernel module loader service allows one to load loadable kernel
 modules at boot.  This is especially useful for modules that don't
-- 
2.26.0
B
B
Brice Waegeneire wrote on 1 May 2020 16:22
Download
[PATCH v2 2/2] doc: Move 'Dictionary Service' under 'Miscellaneous Services'.
(address . 40938@debbugs.gnu.org)
20200501142255.5860-2-brice@waegenei.re
Download
* doc/guix.texi (Dictionary Service): Renamed to singular and changed
from 'subsubsection' to 'subheading'.
---
doc/guix.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/doc/guix.texi b/doc/guix.texi
index a8550541fe..2f4688be91 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -25864,7 +25864,7 @@ If true, this must be the name of a file to log messages to.
 @end table
 @end deftp
 
-@subsection Dictionary Services
+@subsubheading Dictionary Service
 @cindex dictionary
 The @code{(gnu services dict)} module provides the following service:
 
-- 
2.26.0
B
B
Brice Waegeneire wrote on 1 May 2020 16:27
Download
Re: [bug#40938] [PATCH] doc: Lower 'Kernel Module Loader Service' one level.
(name . Mathieu Othacehe)(address . m.othacehe@gmail.com)(address . 40938@debbugs.gnu.org)
3a974964a46a22cba873d43fe1b2b8b1@waegenei.re
Download
Hello Mathieu,

On 2020-05-01 11:41, Mathieu Othacehe wrote:
Toggle quote (12 lines)
> I have the following warning when applying this patch:
>
> --8<---------------cut here---------------start------------->8---
> MAKEINFO doc/guix.info
> ./doc/guix.texi:25493: warning: node `Miscellaneous Services' is next
> for `Linux Services' in menu but not in sectioning
> ./doc/guix.texi:25595: warning: node `Linux Services' is prev for
> `Miscellaneous Services' in menu but not in sectioning
> --8<---------------cut here---------------end--------------->8---
>
> Do you know why?

It wasn't correctly patched, it turns out the whole 'Linux Services'
section wasn't properly organized compared to the other services
sections. I've found a similar issue with 'Dictionary Service',
so I added a patch for it in this series.

- Brice
M
M
Mathieu Othacehe wrote on 1 May 2020 16:42
Download
(name . Brice Waegeneire)(address . brice@waegenei.re)(address . 40938-done@debbugs.gnu.org)
87zhar3ee6.fsf@gmail.com
Download
Toggle quote (5 lines)
> It wasn't correctly patched, it turns out the whole 'Linux Services'
> section wasn't properly organized compared to the other services
> sections. I've found a similar issue with 'Dictionary Service',
> so I added a patch for it in this series.

Ok, this look fine! I pushed your v2.

Thanks,

Mathieu
Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 40938@debbugs.gnu.org