[PATCH] gnu: linux-boot: Allow to mount the root file system via nfs

Stefan wrote on 26 Apr 2020 21:21

Recipients:(address . guix-patches@gnu.org)

Message-ID:29B6FCE4-CD82-4BEA-A00B-9D1C6EAFE4A9@vodafonemail.de

* gnu/build/linux-boot.scm (boot-system) Treat a root option with ":/" as an nfs sourceand avoid to call 'canonicalize-device-spec' for it.--- gnu/build/linux-boot.scm | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)

Toggle diff (24 lines)diff --git a/gnu/build/linux-boot.scm b/gnu/build/linux-boot.scmindex 4fb711b8f2..05e833c0c6 100644--- a/gnu/build/linux-boot.scm+++ b/gnu/build/linux-boot.scm@@ -534,10 +534,13 @@ upon error."             ;; The "--root=SPEC" kernel command-line option always provides a             ;; string, but the string can represent a device, a UUID, or a             ;; label.  So check for all three.-            (let ((root (cond ((string-prefix? "/" root) root)-                              ((uuid root) => identity)-                              (else (file-system-label root)))))-              (mount-root-file-system (canonicalize-device-spec root)+            (let ((device-spec (cond ((string-prefix? "/" root) root)+                                     ((uuid root) => identity)+                                     ((string-contains root ":/") #f) ; nfs+                                     (else (file-system-label root)))))+              (mount-root-file-system (if device-spec+                                          (canonicalize-device-spec device-spec)+                                          root)                                       root-fs-type                                       #:volatile-root? volatile-root?                                       #:flags root-fs-flags-- 2.26.0

Ludovic Courtès wrote on 2 May 2020 16:22

Recipients:(name . Stefan)(address . stefan-guix@vodafonemail.de)(address . 40879-done@debbugs.gnu.org)

Message-ID:87wo5u5sdg.fsf@gnu.org

Hi Stefan,
Stefan <stefan-guix@vodafonemail.de> skribis:

Toggle quote (3 lines)

> * gnu/build/linux-boot.scm (boot-system) Treat a root option with ":/" as an nfs source> and avoid to call 'canonicalize-device-spec' for it.

I slightly tweaked the subject line and applied, thank you!
Ludo’.

Closed

Danny Milosavljevic wrote on 3 May 2020 00:19

Re: bug#40879: [PATCH] gnu: linux-boot: Allow to mount the root file system via nfs

Recipients:(address . 40879-done@debbugs.gnu.org)

Message-ID:20200503001916.3bab3207@scratchpost.org

--- a/gnu/build/linux-boot.scm+++ b/gnu/build/linux-boot.scm@@ -534,10 +534,13 @@ upon error."             ;; The "--root=SPEC" kernel command-line option always provides a             ;; string, but the string can represent a device, a UUID, or a             ;; label.  So check for all three.
Nitpick: Comment above it is now outdated ;)

Closed

Marius Bakke wrote on 4 May 2020 16:11

Re: [bug#40879] [PATCH] gnu: linux-boot: Allow to mount the root file system via nfs

Recipients:(address . 40879-done@debbugs.gnu.org)

Message-ID:87sggf23k0.fsf@devup.no

Danny Milosavljevic <dannym@scratchpost.org> writes:

Toggle quote (9 lines)

> --- a/gnu/build/linux-boot.scm> +++ b/gnu/build/linux-boot.scm> @@ -534,10 +534,13 @@ upon error."> ;; The "--root=SPEC" kernel command-line option always provides a> ;; string, but the string can represent a device, a UUID, or a> ;; label. So check for all three.>> Nitpick: Comment above it is now outdated ;)

Can you update it? :-)

Closed

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date