[PATCH core-updates] gnu: libgc/static-libs: Mark it as hidden.

DoneSubmitted by Christopher Baines.
Details
2 participants
  • Christopher Baines
  • Marius Bakke
Owner
unassigned
Severity
normal
C
C
Christopher Baines wrote on 26 Apr 2020 20:58
(address . guix-patches@gnu.org)
20200426185823.5652-1-mail@cbaines.net
* gnu/packages/bdw-gc.scm (libgc/static-libs)[properties] Set hidden? to #t.
---
gnu/packages/bdw-gc.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (16 lines)
diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm
index 112a161f94..50e4951dc1 100644
--- a/gnu/packages/bdw-gc.scm
+++ b/gnu/packages/bdw-gc.scm
@@ -91,7 +91,8 @@ C or C++ programs, though that is not its primary goal.")
    libgc
    (arguments (substitute-keyword-arguments (package-arguments libgc)
                 ((#:configure-flags flags ''())
-                 `(cons "--enable-static" ,flags))))))
+                 `(cons "--enable-static" ,flags))))
+   (properties '((hidden? . #t)))))
 
 (define-public libgc-7
   (package
-- 
2.26.0
C
C
Christopher Baines wrote on 26 Apr 2020 21:14
87zhaym53g.fsf@cbaines.net
Christopher Baines <mail@cbaines.net> writes:

Toggle quote (20 lines)
> * gnu/packages/bdw-gc.scm (libgc/static-libs)[properties] Set hidden? to #t.
> ---
> gnu/packages/bdw-gc.scm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm
> index 112a161f94..50e4951dc1 100644
> --- a/gnu/packages/bdw-gc.scm
> +++ b/gnu/packages/bdw-gc.scm
> @@ -91,7 +91,8 @@ C or C++ programs, though that is not its primary goal.")
> libgc
> (arguments (substitute-keyword-arguments (package-arguments libgc)
> ((#:configure-flags flags ''())
> - `(cons "--enable-static" ,flags))))))
> + `(cons "--enable-static" ,flags))))
> + (properties '((hidden? . #t)))))
>
> (define-public libgc-7
> (package

Forgot to include you Marius when I sent this patch. Does this seem
sensible?

Otherwise you get this libgc variant when you use Guix on the command
line, and commands like guix lint complain.

./pre-inst-env guix lint libgc
guix lint: warning: ambiguous package specification `libgc'
guix lint: warning: choosing libgc@8.0.4 from gnu/packages/bdw-gc.scm:90:2


I hope that setting the properties doesn't involve rebuilding anything.

Thanks,

Chris
-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl6l3bNfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE
9XcriA//XnkaT4pIQ5tswXcFau0ja+N5k6oWtHVjw2ki9C9eCorx2Yxa3FUZSRIz
YC4eutL7v8sZSuAQhDy0LDQdDqL8AcDhO/rzoaCZGQr3SqXw8G+rFyU8If5GrwnE
qGMw0KDE+ho23CNu1Cmmp+KqdANR/btdXLH2+3BurpQh3oItL53SsIZaVwNCx+oV
cJhLcQ4AamOI6zOxwA3mFQe+gkvBduYLb65fB07mcl030H1XHI3svLnt8yedGAw/
pOPo4H7MZXBr9pXeH5WUKa9LzZn550E0gxkF8GPgv7Z5Q1Rau29jxUZDDP/LEpgb
ubL5TxU3AP+poe7oI+s328AcBVFDS12PpM2a/gRdKkTjhWxNMTBPZ2KLidoPrAU3
7c9XRJs55KAjLF2aYSlZkBwzAOFlpT8ZYVO9C/R4G2vsxKoce16TL0GxIueMVZbJ
GHV3xNr87BF/3FSMKeuhPXFf6PRB2q7h9tdYKjK0DnJVNAYTKiTzmQakkkF8Lwvg
HHWizHNUd2pAKVjU0p6HnP+0WhkPxFQbL5YHsKNNF7XlKhTVJh3tWwr5+eQqY17R
3hZ3dZiAObdMmAM0Vphs/8/CqYMoA66RkUTDluBsCtGlijwzXeGDNmSMfOyfUllQ
Wv8DZIerl8jNSUT01GUTIECGZ9746Qbu5uxRrUDhla2j1Pa2hMM=
=+BYZ
-----END PGP SIGNATURE-----

M
M
Marius Bakke wrote on 28 Apr 2020 16:39
87d07r7jyy.fsf@devup.no
Christopher Baines <mail@cbaines.net> writes:

Toggle quote (17 lines)
> * gnu/packages/bdw-gc.scm (libgc/static-libs)[properties] Set hidden? to #t.
> ---
> gnu/packages/bdw-gc.scm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm
> index 112a161f94..50e4951dc1 100644
> --- a/gnu/packages/bdw-gc.scm
> +++ b/gnu/packages/bdw-gc.scm
> @@ -91,7 +91,8 @@ C or C++ programs, though that is not its primary goal.")
> libgc
> (arguments (substitute-keyword-arguments (package-arguments libgc)
> ((#:configure-flags flags ''())
> - `(cons "--enable-static" ,flags))))))
> + `(cons "--enable-static" ,flags))))
> + (properties '((hidden? . #t)))))

LGTM, thanks! Properties are only used by the Guix 'front-end' and not
part of the derivation.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6oQCUACgkQoqBt8qM6
VPp13wf8D9+5MUxNe2zNvSixq4BrmKCDTDJA0NSxw7XZLv9j5nXCnwd4I1M3Qzbk
5WnLmpBWfR6prHvhioyo/patyJeFbDjwF1VgeCaGiTLKSDBDfC6I4RC/1imjj5P9
6dPQxYID13UeWhGzNRq5WxJ2Kz2ScOb9V7j2JDKX0vAmJCtPKsuV0v1mQtWS++8f
3Mo89DMqchW0BtRHfCKgf+QVcDuhaI0XImmO754+dHvLu0kgPGSJSbTatRlJF1ma
UWr0JkRNmn0k/j4swS6QbH13CDnaIyCJatvmWSO0dbLD/Oo3O9H+s095sDPFdLvW
1OpHzIzCUG/yzyOvfgx/I61Naqd1ww==
=SD6V
-----END PGP SIGNATURE-----

C
C
Christopher Baines wrote on 28 Apr 2020 23:56
(name . Marius Bakke)(address . mbakke@fastmail.com)(address . 40876-done@debbugs.gnu.org)
87sggnmfyy.fsf@cbaines.net
Marius Bakke <mbakke@fastmail.com> writes:

Toggle quote (22 lines)
> Christopher Baines <mail@cbaines.net> writes:
>
>> * gnu/packages/bdw-gc.scm (libgc/static-libs)[properties] Set hidden? to #t.
>> ---
>> gnu/packages/bdw-gc.scm | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm
>> index 112a161f94..50e4951dc1 100644
>> --- a/gnu/packages/bdw-gc.scm
>> +++ b/gnu/packages/bdw-gc.scm
>> @@ -91,7 +91,8 @@ C or C++ programs, though that is not its primary goal.")
>> libgc
>> (arguments (substitute-keyword-arguments (package-arguments libgc)
>> ((#:configure-flags flags ''())
>> - `(cons "--enable-static" ,flags))))))
>> + `(cons "--enable-static" ,flags))))
>> + (properties '((hidden? . #t)))))
>
> LGTM, thanks! Properties are only used by the Guix 'front-end' and not
> part of the derivation.

Great, I've pushed this as 709ca6c9824e4bbb0d81959b885248294fb062ae now.
-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl6opqVfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE
9XcKJxAAmdpT0tjchbHFD5pjC9G/WIGB1QmjF/iQqUhhtzC5aIp3Hh8r7byh0aDl
SOIFXu4WAhyx39CODC/C2nY5IP73B9Kc1rj7sr/13OEGzVjZLiMtxBnSc+jbhCr5
POQVupTIyORALXTUpu3MOfLcH5vSfNXrNlDU9kWfoJnXvWlaz0lcKsbLIL35dEjd
ONyeWcaacW2QFZqPWJmkkokPE3HIcVepRHfDSQj2zot1g7jsVb8T1HVCEMmUdl5D
+F53XDWYQDdxRcuI1iK81NjIn3ZrwJyhoaaJYim/s+M69vyhPHganm1E7XsINi4P
VBAoucvHWF/DPB2HnV/LLXIdbWrH2MQKS9Mh83sakKgjRzCh9j0ZR0nhOU+dbPTU
65GO8G2VA3ed/d9H2ctIPyg1MoK26w/OMnmT59RjVk5Nq9XIJeavtD3l+IdREIGM
Wc1UEFg0k9NXkol3bmimFM5/2oAID69ON41yFS2eBhTrfMIALrMHsZC1eQJwbLu9
KjDtCLT/WJhbelnq5e/ckJFz+VTTiMNNyaHakS2lnCgHzuCirdfFM1E1nP2ULLzH
yuPaPgSmhmD8pUSZPPejtNBFfIml+DAZyKOgYlwczZWI9xCE1kPNYSOpgXydTw3J
9fHF7TQO39kVLwSsqhWSE6rnLP7OCnuM9AIUOyRW5NkDhXiR8UM=
=3ov+
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 40876@debbugs.gnu.org