[PATCH] service: sddm: Have sddm-service-type conflict with other display managers.

Done

Details

2 participants

Efraim Flashner
Ludovic Courtès

Owner: unassigned

Submitted by: Efraim Flashner

Severity: normal

Efraim Flashner wrote on 17 Apr 2020 16:41

Recipients:(address . guix-patches@gnu.org)(name . Efraim Flashner)(address . efraim@flashner.co.il)

Message-ID:20200417144115.2475-1-efraim@flashner.co.il

* gnu/services/sddm.scm (sddm-shepherd-service)[shepherd-service]:

Conflict with 'xorg-server.

---

I was looking over the services list with raingloom on IRC and I noticed

that GDM and Slim both provision xorg-server, while SDDM provisions

display-manager. To ensure that they conflict with each other we can

either:

A: Have SDDM conflict with 'xorg-server

B: Have SDDM also provision 'xorg-server

I'm currently using SDDM (in Wayland mode) to launch an X session of

Enlightenment, so I think it's safe enough to say that SDDM can

provision 'xorg-server.

---

gnu/services/sddm.scm | 1 +

1 file changed, 1 insertion(+)

Toggle diff (14 lines)diff --git a/gnu/services/sddm.scm b/gnu/services/sddm.scm
index 1921afce95..aa08859513 100644
--- a/gnu/services/sddm.scm
+++ b/gnu/services/sddm.scm
@@ -171,6 +171,7 @@ Relogin="              (if (sddm-configuration-relogin? config)
          (documentation "SDDM display manager.")
          (requirement '(user-processes))
          (provision '(display-manager))
+         (conflicts-with '(xorg-server))
          (start #~(make-forkexec-constructor #$sddm-command))
          (stop #~(make-kill-destructor)))))
 
-- 
2.26.1

Ludovic Courtès wrote on 17 Apr 2020 23:00

Recipients:(name . Efraim Flashner)(address . efraim@flashner.co.il)(address . 40680@debbugs.gnu.org)

Message-ID:87r1wlaku6.fsf@gnu.org

Hi Efraim,

Efraim Flashner <efraim@flashner.co.il> skribis:

Toggle quote (32 lines)> * gnu/services/sddm.scm (sddm-shepherd-service)[shepherd-service]:
> Conflict with 'xorg-server.
> ---
>
> I was looking over the services list with raingloom on IRC and I noticed
> that GDM and Slim both provision xorg-server, while SDDM provisions
> display-manager. To ensure that they conflict with each other we can
> either:
>
> A: Have SDDM conflict with 'xorg-server
>
> B: Have SDDM also provision 'xorg-server
>
> I'm currently using SDDM (in Wayland mode) to launch an X session of
> Enlightenment, so I think it's safe enough to say that SDDM can
> provision 'xorg-server.
>
> ---
>
>  gnu/services/sddm.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/services/sddm.scm b/gnu/services/sddm.scm
> index 1921afce95..aa08859513 100644
> --- a/gnu/services/sddm.scm
> +++ b/gnu/services/sddm.scm
> @@ -171,6 +171,7 @@ Relogin="              (if (sddm-configuration-relogin? config)
>           (documentation "SDDM display manager.")
>           (requirement '(user-processes))
>           (provision '(display-manager))
> +         (conflicts-with '(xorg-server))

‘conflicts-with’ doesn’t exist, right? :-)

But yes, I think (provision '(xorg-server display-manager)) would be

fine.

Or we can even drop ‘display-manager’ since it’s not used anywhere else.

Thanks,

Ludo’.

Efraim Flashner wrote on 18 Apr 2020 20:01

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 40680@debbugs.gnu.org)

Message-ID:20200418180121.GA4725@E5400

On Fri, Apr 17, 2020 at 11:00:49PM +0200, Ludovic Courtès wrote:

Toggle quote (39 lines)> Hi Efraim,
> 
> Efraim Flashner <efraim@flashner.co.il> skribis:
> 
> > * gnu/services/sddm.scm (sddm-shepherd-service)[shepherd-service]:
> > Conflict with 'xorg-server.
> > ---
> >
> > I was looking over the services list with raingloom on IRC and I noticed
> > that GDM and Slim both provision xorg-server, while SDDM provisions
> > display-manager. To ensure that they conflict with each other we can
> > either:
> >
> > A: Have SDDM conflict with 'xorg-server
> >
> > B: Have SDDM also provision 'xorg-server
> >
> > I'm currently using SDDM (in Wayland mode) to launch an X session of
> > Enlightenment, so I think it's safe enough to say that SDDM can
> > provision 'xorg-server.
> >
> > ---
> >
> >  gnu/services/sddm.scm | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/gnu/services/sddm.scm b/gnu/services/sddm.scm
> > index 1921afce95..aa08859513 100644
> > --- a/gnu/services/sddm.scm
> > +++ b/gnu/services/sddm.scm
> > @@ -171,6 +171,7 @@ Relogin="              (if (sddm-configuration-relogin? config)
> >           (documentation "SDDM display manager.")
> >           (requirement '(user-processes))
> >           (provision '(display-manager))
> > +         (conflicts-with '(xorg-server))
> 
> ‘conflicts-with’ doesn’t exist, right?  :-)
> 

I haven't tried it out for Guix services, but it exists for shepherd

services, according to the manual¹

Toggle quote (5 lines)

> But yes, I think (provision '(xorg-server display-manager)) would be

> fine.

> Or we can even drop ‘display-manager’ since it’s not used anywhere else.

Normally I'd be skeptical about dropping it since people might expect it

if they're using sddm, but it'd probably be fine.

¹ https://www.gnu.org/software/shepherd/manual/html_node/Methods-of-services.html#Methods-of-services

Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר

GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351

Confidentiality cannot be guaranteed on emails sent or received unencrypted

Ludovic Courtès wrote on 19 Apr 2020 01:33

Recipients:(name . Efraim Flashner)(address . efraim@flashner.co.il)(address . 40680@debbugs.gnu.org)

Message-ID:87h7xg4bf0.fsf@gnu.org

Hi,

Efraim Flashner <efraim@flashner.co.il> skribis:

Toggle quote (2 lines)

> On Fri, Apr 17, 2020 at 11:00:49PM +0200, Ludovic Courtès wrote:

[...]

Toggle quote (14 lines)>> > --- a/gnu/services/sddm.scm
>> > +++ b/gnu/services/sddm.scm
>> > @@ -171,6 +171,7 @@ Relogin="              (if (sddm-configuration-relogin? config)
>> >           (documentation "SDDM display manager.")
>> >           (requirement '(user-processes))
>> >           (provision '(display-manager))
>> > +         (conflicts-with '(xorg-server))
>> 
>> ‘conflicts-with’ doesn’t exist, right?  :-)
>> 
>
> I haven't tried it out for Guix services, but it exists for shepherd
> services, according to the manual¹

Right, it’s not available in Guix <shepherd-service>.

However, simplify adding ‘xorg-server’ to ‘provision’ should have the

desired effect: ‘guix system’ errors out if more than one service

provides the same symbol.

Toggle quote (8 lines)

>> But yes, I think (provision '(xorg-server display-manager)) would be

>> fine.

>> Or we can even drop ‘display-manager’ since it’s not used anywhere else.

> Normally I'd be skeptical about dropping it since people might expect it

> if they're using sddm, but it'd probably be fine.

Yeah, maybe it’s safer to keep it.

Thanks,

Ludo’.

Efraim Flashner wrote on 19 Apr 2020 08:07

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 40680-done@debbugs.gnu.org)

Message-ID:20200419060729.GB939@E5400

On Sun, Apr 19, 2020 at 01:33:07AM +0200, Ludovic Courtès wrote:

Toggle quote (41 lines)> Hi,
> 
> Efraim Flashner <efraim@flashner.co.il> skribis:
> 
> > On Fri, Apr 17, 2020 at 11:00:49PM +0200, Ludovic Courtès wrote:
> 
> [...]
> 
> >> > --- a/gnu/services/sddm.scm
> >> > +++ b/gnu/services/sddm.scm
> >> > @@ -171,6 +171,7 @@ Relogin="              (if (sddm-configuration-relogin? config)
> >> >           (documentation "SDDM display manager.")
> >> >           (requirement '(user-processes))
> >> >           (provision '(display-manager))
> >> > +         (conflicts-with '(xorg-server))
> >> 
> >> ‘conflicts-with’ doesn’t exist, right?  :-)
> >> 
> >
> > I haven't tried it out for Guix services, but it exists for shepherd
> > services, according to the manual¹
> 
> Right, it’s not available in Guix <shepherd-service>.
> 
> However, simplify adding ‘xorg-server’ to ‘provision’ should have the
> desired effect: ‘guix system’ errors out if more than one service
> provides the same symbol.
> 
> >> But yes, I think (provision '(xorg-server display-manager)) would be
> >> fine.
> >> 
> >> Or we can even drop ‘display-manager’ since it’s not used anywhere else.
> >
> > Normally I'd be skeptical about dropping it since people might expect it
> > if they're using sddm, but it'd probably be fine.
> 
> Yeah, maybe it’s safer to keep it.
> 
> Thanks,
> Ludo’.

Sounds good. I put xorg-server first so it more closely matches with the
other ones.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 40680@debbugs.gnu.org

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date