[PATCH] gnu: Add fdroidcl.

Done

Details

4 participants

Efraim Flashner
Ludovic Courtès
Glenn Morris
Sergey Trofimov

Owner: unassigned

Submitted by: Sergey Trofimov

Severity: normal

Debbugs page

Sergey Trofimov wrote 5 years ago

Recipients:

Message-ID:5e8c1249.1c69fb81.5b84a.0583@mx.google.com

* gnu/packages/android (fdroidcl): New variable.

---

gnu/packages/android.scm | 36 ++++++++++++++++++++++++++++++++++++

1 file changed, 36 insertions(+)

Toggle diff (70 lines)diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm
index 17f5f41fcb..4d1a591686 100644
--- a/gnu/packages/android.scm
+++ b/gnu/packages/android.scm
@@ -10,6 +10,7 @@
 ;;; Copyright © 2019 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2019 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer@gmail.com>
+;;; Copyright © 2020 Sergey Trofimov <sarg@sarg.org.ru>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -32,6 +33,7 @@
   #:use-module (guix git-download)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system android-ndk)
+  #:use-module (guix build-system go)
   #:use-module (guix build-system python)
   #:use-module (guix build-system trivial)
   #:use-module ((guix licenses) #:prefix license:)
@@ -41,6 +43,7 @@
   #:use-module (gnu packages docker)
   #:use-module (gnu packages gcc)
   #:use-module (gnu packages gnupg)
+  #:use-module (gnu packages golang)
   #:use-module (gnu packages java)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages pcre)
@@ -946,6 +949,39 @@ publishing, or to assist in creating, testing and submitting metadata to the
 main repository.")
     (license license:agpl3+)))
 
+(define-public fdroidcl
+  (package
+    (name "fdroidcl")
+    (version "0.5.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/mvdan/fdroidcl/archive/"
+                    "v" version ".tar.gz"))
+              (sha256
+               (base32 "0ybqxklhrp23xm89l4g6ms5qxm08db00kx4g6w9vyv11jd68qajk"))))
+    (build-system go-build-system)
+
+    (inputs
+     `(("go-github-com-kr-pretty"
+        ,go-github-com-kr-pretty)
+       ;; used in tests
+       ;; ("go-github-com-rogpeppe-go-internal-testscript"
+       ;;  ,go-github-com-rogpeppe-go-internal-testscript)
+       ("go-gopkg.in-check.v1"
+        ,go-gopkg.in-check.v1)))
+    (arguments
+     `(#:import-path "mvdan.cc/fdroidcl"
+       #:tests? #f ; TODO.
+       #:install-source? #f))
+    (synopsis "F-Droid desktop client")
+    (description
+     "While the Android client integrates with the system with regular update
+checks and notifications, this is a simple command line client that talks to
+connected devicesvia ADB.")
+    (home-page "https://github.com/mvdan/fdroidcl")
+    (license license:bsd-3)))
+
 (define-public enjarify
   (package
     (name "enjarify")
-- 
2.25.1

Glenn Morris wrote 5 years ago

control message for bug 40479

Recipients:(address . control@debbugs.gnu.org)

Message-ID:E1jLr6P-00072K-Em@fencepost.gnu.org

reassign 40479 guix-patches

Efraim Flashner wrote 5 years ago

[PATCH]: Add fdroidcl.

Recipients:(address . 40479@debbugs.gnu.org)(name . Sergey Trofimov)(address . sarg@sarg.org.ru)

Message-ID:20200420091653.GE7353@E5400

I made a couple of changes to the patch. It now downloads the source

using git-fetch and I updated the inputs a bit.

For the tests, I'm afraid you're going to need to package the

missing package.

Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר

GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351

Confidentiality cannot be guaranteed on emails sent or received unencrypted

From efd8708885f451b34cbb712ef6a7d97e8ea598c4 Mon Sep 17 00:00:00 2001

* gnu/packages/android (fdroidcl): New variable.

---

gnu/packages/android.scm | 36 ++++++++++++++++++++++++++++++++++++

1 file changed, 36 insertions(+)

Toggle diff (70 lines)diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm
index 17f5f41fcb..a32d6c570c 100644
--- a/gnu/packages/android.scm
+++ b/gnu/packages/android.scm
@@ -10,6 +10,7 @@
 ;;; Copyright © 2019 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2019 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer@gmail.com>
+;;; Copyright © 2020 Sergey Trofimov <sarg@sarg.org.ru>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -32,6 +33,7 @@
   #:use-module (guix git-download)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system android-ndk)
+  #:use-module (guix build-system go)
   #:use-module (guix build-system python)
   #:use-module (guix build-system trivial)
   #:use-module ((guix licenses) #:prefix license:)
@@ -41,6 +43,7 @@
   #:use-module (gnu packages docker)
   #:use-module (gnu packages gcc)
   #:use-module (gnu packages gnupg)
+  #:use-module (gnu packages golang)
   #:use-module (gnu packages java)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages pcre)
@@ -946,6 +949,39 @@ publishing, or to assist in creating, testing and submitting metadata to the
 main repository.")
     (license license:agpl3+)))
 
+(define-public fdroidcl
+  (package
+    (name "fdroidcl")
+    (version "0.5.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                     (url "https://github.com/mvdan/fdroidcl")
+                     (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32 "1rxcdyy2j34z0ql9d62w7ivsch9xihjnpb1z9kgy9q46vl8zhhy0"))))
+    (build-system go-build-system)
+    (arguments
+     `(#:import-path "mvdan.cc/fdroidcl"
+       #:tests? #f  ; TODO.
+       #:install-source? #f))
+    (inputs
+     `(("go-github-com-kr-pretty"
+        ,go-github-com-kr-pretty)))
+    (native-inputs
+     `(;; used in tests
+       ;; ("go-github-com-rogpeppe-go-internal-testscript"
+       ;;  ,go-github-com-rogpeppe-go-internal-testscript)
+       ))
+    (synopsis "F-Droid desktop client")
+    (description
+     "While the Android client integrates with the system with regular update
+checks and notifications, this is a simple command line client that talks to
+connected devices via ADB.")
+    (home-page "https://github.com/mvdan/fdroidcl")
+    (license license:bsd-3)))
+
 (define-public enjarify
   (package
     (name "enjarify")
-- 
2.26.1

Ludovic Courtès wrote 5 years ago

Recipients:(name . Efraim Flashner)(address . efraim@flashner.co.il)

Message-ID:878sdilk88.fsf@gnu.org

Hi,

Efraim Flashner <efraim@flashner.co.il> skribis:

Toggle quote (6 lines)

> I made a couple of changes to the patch. It now downloads the source

> using git-fetch and I updated the inputs a bit.

> For the tests, I'm afraid you're going to need to package the

> missing package.

[...]

Toggle quote (7 lines)

> From efd8708885f451b34cbb712ef6a7d97e8ea598c4 Mon Sep 17 00:00:00 2001

> From: Sergey Trofimov <sarg@sarg.org.ru>

> Date: Tue, 7 Apr 2020 06:57:13 +0200

> Subject: [PATCH] gnu: Add fdroidcl.

> * gnu/packages/android (fdroidcl): New variable.

[...]

Toggle quote (5 lines)

> + (native-inputs

> + `(;; used in tests

> + ;; ("go-github-com-rogpeppe-go-internal-testscript"

> + ;; ,go-github-com-rogpeppe-go-internal-testscript)

Perhaps make the comment a TODO and push?

Thanks,

Ludo’.

Efraim Flashner wrote 5 years ago

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)

Message-ID:20200910075931.GS1643@E5400

On Wed, Sep 09, 2020 at 11:21:27PM +0200, Ludovic Courtès wrote:

Toggle quote (31 lines)> Hi,
> 
> Efraim Flashner <efraim@flashner.co.il> skribis:
> 
> > I made a couple of changes to the patch. It now downloads the source
> > using git-fetch and I updated the inputs a bit.
> >
> > For the tests, I'm afraid you're going to need to package the
> > missing package.
> 
> [...]
> 
> > From efd8708885f451b34cbb712ef6a7d97e8ea598c4 Mon Sep 17 00:00:00 2001
> > From: Sergey Trofimov <sarg@sarg.org.ru>
> > Date: Tue, 7 Apr 2020 06:57:13 +0200
> > Subject: [PATCH] gnu: Add fdroidcl.
> >
> > * gnu/packages/android (fdroidcl): New variable.
> 
> [...]
> 
> > +    (native-inputs
> > +     `(;; used in tests
> > +       ;; ("go-github-com-rogpeppe-go-internal-testscript"
> > +       ;;  ,go-github-com-rogpeppe-go-internal-testscript)
> 
> Perhaps make the comment a TODO and push?
> 
> Thanks,
> Ludo’.

Works for me.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 40479@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 40479

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags

mumi command -t +confirmed -t +easy

Or, remove the moreinfo tag and set the help tag

mumi command -t -moreinfo -t +help

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date