(address . guix-patches@gnu.org)
9fde0f2d6cf97a9368ae132a717cf18a@disroot.org
gnu: gsm: Update to 1.0.19.
- Done
Details
- 3 participants
- Mathieu Othacehe
- maxim.cournoyer
- Raghav Gururajan
- Owner
- unassigned
- Submitted by
- Raghav Gururajan
- Severity
- normal
R
R
(address . control@debbugs.gnu.org)
a4e6bfc5c3d3db8eb8801ba7ffd7d6e3@disroot.org
block 40264 by 40445
M
(name . Raghav Gururajan)(address . raghavgururajan@disroot.org)(address . 40445@debbugs.gnu.org)
87d08ms22w.fsf@gmail.com
Hello Raghav,
Toggle quote (5 lines)
> + #:make-flags
> + (list
> + ;; Added -fPIC with other default options.
> + "CCFLAGS=-fPIC -c -O2 -DNeedFunctionPrototypes=1 -Wall -Wno-comment")
I wonder if we need all those options, the package seems to build fine
without them. Could you have a look?
Thanks,
Mathieu
R
(name . Mathieu Othacehe)(address . m.othacehe@gmail.com)(address . 40445@debbugs.gnu.org)
06e6a1cfe8a54f80493a4e9f2820399b@disroot.org
Hi Mathieu!
Toggle quote (8 lines)
>> + #:make-flags
>> + (list
>> + ;; Added -fPIC with other default options.
>> + "CCFLAGS=-fPIC -c -O2 -DNeedFunctionPrototypes=1 -Wall -Wno-comment")
>
> I wonder if we need all those options, the package seems to build fine
> without them. Could you have a look?
Yes, Maxim and I, updated these options, to use libgsm in mediastreamer, as a part of linphone packaging. :-)
Btw, currently the gsm package is in unusable state, after the commit "74c7f367daa554cedeb5f02a00d1cd02acf1584b".
Regards,
RG.
M
(name . Raghav Gururajan)(address . raghavgururajan@disroot.org)(address . 40445@debbugs.gnu.org)
87pncmcjuo.fsf@gmail.com
Toggle quote (2 lines)
> Yes, Maxim and I, updated these options, to use libgsm in mediastreamer, as a part of linphone packaging. :-)
Ok, I see. Maybe it would be preferable to find a way to add "-fPIC" to
CCFLAGS without having to repeat all the other options that are already
present in the Makefile:
Toggle snippet (3 lines)
CCFLAGS = -c -O2 -DNeedFunctionPrototypes=1 -Wall -Wno-comment
Adding a new 'add-fpic-ccflag' phase could be an option?
Thanks,
Mathieu
R
(name . Mathieu Othacehe)(address . m.othacehe@gmail.com)(address . 40445@debbugs.gnu.org)
b633146363e6944017f5aa752f577237@disroot.org
Hi Mathieu!
Toggle quote (10 lines)
> Ok, I see. Maybe it would be preferable to find a way to add "-fPIC" to
> CCFLAGS without having to repeat all the other options that are already
> present in the Makefile:
>
> --8<---------------cut here---------------start------------->8---
> CCFLAGS = -c -O2 -DNeedFunctionPrototypes=1 -Wall -Wno-comment
> --8<---------------cut here---------------end--------------->8---
>
> Adding a new 'add-fpic-ccflag' phase could be an option?
We can do that too. But this seems simple and less messy :-)
Regards,
RG.
R
(name . Mathieu Othacehe)(address . m.othacehe@gmail.com)(address . 40445@debbugs.gnu.org)
265df2102f5ed69aa35fc059dbb4d8e5@disroot.org
Hi Mathieu!
Toggle quote (12 lines)
>> Ok, I see. Maybe it would be preferable to find a way to add "-fPIC" to
>> CCFLAGS without having to repeat all the other options that are already
>> present in the Makefile:
>>
>> --8<---------------cut here---------------start------------->8---
>> CCFLAGS = -c -O2 -DNeedFunctionPrototypes=1 -Wall -Wno-comment
>> --8<---------------cut here---------------end--------------->8---
>>
>> Adding a new 'add-fpic-ccflag' phase could be an option?
>
> We can do that too. But this seems simple and less messy :-)
Also, I believe, the make-flag just overwrites that line in the source.
Regards,
RG.
M
(name . Raghav Gururajan)(address . raghavgururajan@disroot.org)(address . 40445@debbugs.gnu.org)
87wo6ub4sz.fsf@gmail.com
Toggle quote (4 lines)
>> We can do that too. But this seems simple and less messy :-)
>
> Also, I believe, the make-flag just overwrites that line in the source.
Yes that's what it does. But if in a future release this package updates
its CCFLAGS list in the Makefile, we will have to update our own package
definition accordingly. That's why adding 'CCFLAGS += -fPIC' somewhere
seems safer to me.
Mathieu
R
(name . Mathieu Othacehe)(address . m.othacehe@gmail.com)(address . 40445@debbugs.gnu.org)
f2f7717677aec8b046fe1b6b2da2fe9b@disroot.org
Toggle quote (5 lines)
> Yes that's what it does. But if in a future release this package updates
> its CCFLAGS list in the Makefile, we will have to update our own package
> definition accordingly. That's why adding 'CCFLAGS += -fPIC' somewhere
> seems safer to me.
Ah, gotcha! Hmm, I don't know how to do that through. I'll have to look into code base for examples.
Regards,
RG.
R
(name . Mathieu Othacehe)(address . m.othacehe@gmail.com)(address . 40445@debbugs.gnu.org)
14a100f71916e1de2ba69279984e320b@disroot.org
Toggle quote (8 lines)
>> Yes that's what it does. But if in a future release this package updates
>> its CCFLAGS list in the Makefile, we will have to update our own package
>> definition accordingly. That's why adding 'CCFLAGS += -fPIC' somewhere
>> seems safer to me.
>
> Ah, gotcha! Hmm, I don't know how to do that through. I'll have to look into code base for
> examples.
No I also think that its a double-edged sword. 'CCFLAGS += -fPIC' also has to be changed/removed, if new release adds "-fPIC"?
Regards,
RG.
R
(name . Mathieu Othacehe)(address . m.othacehe@gmail.com)(address . 40445@debbugs.gnu.org)
41a61a922bd5ec0c22388c6c8d60e235@disroot.org
Toggle quote (11 lines)
>>> Yes that's what it does. But if in a future release this package updates
>>> its CCFLAGS list in the Makefile, we will have to update our own package
>>> definition accordingly. That's why adding 'CCFLAGS += -fPIC' somewhere
>>> seems safer to me.
>>
>> Ah, gotcha! Hmm, I don't know how to do that through. I'll have to look into code base for
>> examples.
>
> No I also think that its a double-edged sword. 'CCFLAGS += -fPIC' also has to be changed/removed,
> if new release adds "-fPIC"?
* Now
M
(name . Raghav Gururajan)(address . raghavgururajan@disroot.org)
87blo53k9r.fsf@hurd.i-did-not-set--mail-host-address--so-tickle-me
Hello,
"Raghav Gururajan" <raghavgururajan@disroot.org> writes:
Toggle quote (17 lines)
> Hi Mathieu!
>
>>> + #:make-flags
>>> + (list
>>> + ;; Added -fPIC with other default options.
>>> + "CCFLAGS=-fPIC -c -O2 -DNeedFunctionPrototypes=1 -Wall -Wno-comment")
>>
>> I wonder if we need all those options, the package seems to build fine
>> without them. Could you have a look?
>
> Yes, Maxim and I, updated these options, to use libgsm in mediastreamer, as a part of linphone packaging. :-)
>
> Btw, currently the gsm package is in unusable state, after the commit "74c7f367daa554cedeb5f02a00d1cd02acf1584b".
>
> Regards,
> RG.
Ooops. Sorry about that. I meant:
- #:make-flags '("INSTALL_ROOT=%output"
- "CCFLAGS=-fPIC \
+ #:make-flags (list (string-append "INSTALL_ROOT=" %output)
+ "CCFLAGS=-fPIC \
But I'll take into accounts comments from Mathieu, which make sense.
Maxim
M
(address . maxim.cournoyer@gmail.com)
878sj93ibb.fsf@hurd.i-did-not-set--mail-host-address--so-tickle-me
Hi all,
maxim.cournoyer@gmail.com writes:
Toggle quote (32 lines)
> Hello,
>
> "Raghav Gururajan" <raghavgururajan@disroot.org> writes:
>
>> Hi Mathieu!
>>
>>>> + #:make-flags
>>>> + (list
>>>> + ;; Added -fPIC with other default options.
>>>> + "CCFLAGS=-fPIC -c -O2 -DNeedFunctionPrototypes=1 -Wall -Wno-comment")
>>>
>>> I wonder if we need all those options, the package seems to build fine
>>> without them. Could you have a look?
>>
>> Yes, Maxim and I, updated these options, to use libgsm in mediastreamer, as a part of linphone packaging. :-)
>>
>> Btw, currently the gsm package is in unusable state, after the commit "74c7f367daa554cedeb5f02a00d1cd02acf1584b".
>>
>> Regards,
>> RG.
>
> Ooops. Sorry about that. I meant:
>
> - #:make-flags '("INSTALL_ROOT=%output"
> - "CCFLAGS=-fPIC \
> + #:make-flags (list (string-append "INSTALL_ROOT=" %output)
> + "CCFLAGS=-fPIC \
>
> But I'll take into accounts comments from Mathieu, which make sense.
>
> Maxim
I've fixed the breakage I caused with commit
5b05f8e9654ea722270c45c0fd0eead369bc0daf, and committed the update to
gsm 1.0.19 from Raghav on top as
5e16e4401f854d39f5fbebaf247750e554bd4a09.
Closing.
Thanks for the ideas!
Maxim
Closed
?