[PATCH 2/3] gnu: Add mruby-zest.

  • Open
  • quality assurance status badge
Details
2 participants
  • Alexandros Theodotou
  • Christopher Baines
Owner
unassigned
Submitted by
Alexandros Theodotou
Severity
normal
A
A
Alexandros Theodotou wrote on 4 Apr 2020 23:10
(name . Guix patches)(address . guix-patches@gnu.org)
dfcc38290135d0438a9d322426e7d0d3628a7195.camel@zrythm.org
Hi,

This patch adds mruby-zest, a dependency of zynfusion. I had some help
from the developer for making it build without connecting to the
internet.

Thanks,
Alex
Attachment: 0002-gnu-Add-mruby-zest.patch
-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEESBMjhK0999huJUuDAi6uQjE9cPMFAl6I99wACgkQAi6uQjE9
cPO9RQf/fPtW6o6TAJ4KtPXOdOfin5TwsgRz5TZ426qLoxwilBYS6TgcLaVSu/Xs
ozKfdMJChzuyni2plhXy70Zla+x8+IHFAhE/t3+/sgtK/rQ0CKwCnmU0m+J03keA
OMH+SslrKYoEe4l9KMBWhED4O0lfh1BjMp3yNIO4R9jZp33FV7+R/9FyoXjhrQua
0hfHHZGu62/RqAjw3SNlYC2wEZLdhzUsASciqaBEHAGrsMrarA+gwy0Hylz1blUk
rP+quw44oLwQqKV1s1Lm3DkaT3HiIZZdY8voIT5Jb6R+TPLAy0MXMkgD74m7RR08
1EaNKH90immBBVjyqFK3aj+ZA+tn/w==
=cytb
-----END PGP SIGNATURE-----


C
C
Christopher Baines wrote on 14 Apr 2020 20:41
(name . Alexandros Theodotou)(address . alex@zrythm.org)(address . 40440@debbugs.gnu.org)
87blnt7vv4.fsf@cbaines.net
Alexandros Theodotou <alex@zrythm.org> writes:

Toggle quote (4 lines)
> This patch adds mruby-zest, a dependency of zynfusion. I had some help
> from the developer for making it build without connecting to the
> internet.

Hey Alex,

Thanks for taking the time to package mruby-zest.

Toggle quote (17 lines)
> +(define-public mruby-zest
> + (package
> + (name "mruby-zest")
> + (version "3.0.5-ba39aabd")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + ;; this is a meta repo that packs the mruby dependencies
> + ;; as submodules
> + (url "https://github.com/mruby-zest/mruby-zest-build.git")
> + ;; ghaction branch - suggested by the developer to avoid
> + ;; automatic downloading of some unneeded and
> + ;; hard-to-package dependencies used for debugging
> + (commit "ba39aabd8d4ddc5f14137083b6f9a96c536f5f12")
> + (recursive? #t)))

So I spotted the use of a "deps" directory, which is a bad sign, as
dependencies should be other packages, not things as part of this
package.

I then spotted that the source for this package isn't the upstream Git
repository, but a Git repository that pulls together the mruby-zest
source code, with code from ~16 other Git repositories.

Would it be possible to create Guix packages for these dependencies?

I know that would involve quite a bit of work, but unfortunately that
kind of work is necessary to ensure Guix as a collection of packages can
be maintained in the long term.

Toggle quote (4 lines)
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "1vqzdds30sr982dp7fclg4r19l44rv8pbz6h4a8vcginj494gvjn"))))
-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl6WA+9fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE
9XdvNQ//fG8rO90rsWY9X9AwC2q2uMkrCRrzdlJmRygn7rbdJ7K2YMzcNiczpKBC
fY49IJKyYQCcR2Whznqgzv1G26YNCQvCe17q9yJfFIP5TZOyG7DuTef8v53IlHGM
QsOz/AEJLcAQmziqhGUhPSeEwA8RfELXOc7asEe5MAJ3Yz5ffD3cXO9JAkOkumaD
5/dnGWN+VrjxWDaTPXVrAMn89FoZB34gL3xQaRCCXispFJlbRrmPEoTNozW4Za3I
4xtgoscEDD8LgmtsX2SpMBlZSzxnDtLB04yoYgzkOpW8d4/4splmVMEoQ3RSSGQP
AYaYCm+2mZetMo/Oms0kYOwgE1SnaYFGtYjT1h5esIRML8xb6K1SQCBe41P0pf7l
H5naeUM+Y9ptbkRkvyIeMNyEMH4JQQ/OiyUjKeFAcG0x0/LWLG2487hNf5bgNPOk
k6620vuSB/3Q8/+GH7FDIrhtOqJPhEaaVPlApn7gEVW5MAE6vCHWZUdhGUFw/L/M
E6ASXtxyRnTAzTwpf92v9nUra1yCxq2ArtRDCxTSe2WEBR0z1dZD0QDH+27S7aZ0
s+K6FHpP7I/WNHHBabAB6KZbCUFCGm2AwUDsfr+X14bpuxrIsyhPkS3sacXedncY
z3yllvxbfhJ+zIpVFNaznW1DsAQMeAjOk9Et66f5rOjYrGYY1q0=
=yMA1
-----END PGP SIGNATURE-----

A
A
Alexandros Theodotou wrote on 14 Apr 2020 20:48
(name . Christopher Baines)(address . mail@cbaines.net)(address . 40440@debbugs.gnu.org)
6b672f1744ad3a5ce835e7a1068864e2967f9d22.camel@zrythm.org
Hi Christopher,

Thanks for the review.

It would indeed be best to package each dependency first, but I don't
really have time to package all those dependencies, and I also don't
have much knowledge about ruby. If someone else is willing to do it,
please go ahead.

Thanks,
Alex

On Tue, 2020-04-14 at 19:41 +0100, Christopher Baines wrote:
Toggle quote (53 lines)
> Alexandros Theodotou <alex@zrythm.org> writes:
>
> > This patch adds mruby-zest, a dependency of zynfusion. I had some
> > help
> > from the developer for making it build without connecting to the
> > internet.
>
> Hey Alex,
>
> Thanks for taking the time to package mruby-zest.
>
> > +(define-public mruby-zest
> > + (package
> > + (name "mruby-zest")
> > + (version "3.0.5-ba39aabd")
> > + (source
> > + (origin
> > + (method git-fetch)
> > + (uri (git-reference
> > + ;; this is a meta repo that packs the mruby
> > dependencies
> > + ;; as submodules
> > + (url "
> > https://github.com/mruby-zest/mruby-zest-build.git")
> > + ;; ghaction branch - suggested by the developer to
> > avoid
> > + ;; automatic downloading of some unneeded and
> > + ;; hard-to-package dependencies used for debugging
> > + (commit "ba39aabd8d4ddc5f14137083b6f9a96c536f5f12"
> > )
> > + (recursive? #t)))
>
> So I spotted the use of a "deps" directory, which is a bad sign, as
> dependencies should be other packages, not things as part of this
> package.
>
> I then spotted that the source for this package isn't the upstream
> Git
> repository, but a Git repository that pulls together the mruby-zest
> source code, with code from ~16 other Git repositories.
>
> Would it be possible to create Guix packages for these dependencies?
>
> I know that would involve quite a bit of work, but unfortunately that
> kind of work is necessary to ensure Guix as a collection of packages
> can
> be maintained in the long term.
>
> > + (file-name (git-file-name name version))
> > + (sha256
> > + (base32
> > + "1vqzdds30sr982dp7fclg4r19l44rv8pbz6h4a8vcginj494gvjn"))
> > ))
-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEESBMjhK0999huJUuDAi6uQjE9cPMFAl6WBYsACgkQAi6uQjE9
cPP4swf7BDrjKyvRWxTlIOALcMKo4yqJtHOKhqwnDa8A9Zdc9IbWmASRuYNpP7Lz
aYTiygm1S958pARV4i2xp7R3vNZ3t/v1OuK8xntinSYX25/Q9u5vrQveNVJ0b6wY
NGexnqzZWBrMwN+mGve7zzv0m+0oMtqiidodp68hcA84fNR9YI9BBxtRkn+FpEke
2z6/6989YlzJFttI+jj28RMwQp2piCGgAAxvUbo7qdNnzJirRqP8mw/Ww78G+P92
z26UIVL9ZDn29XrKqBEhtcZFXNK0V/dbSc4QfQD21ryMK9diqVho2LGUdYjE4W49
UPHR833AbYdX0A8/iJUElSDOEzmDCg==
=K4VZ
-----END PGP SIGNATURE-----


?