[PATCH 0/6] Make some more inputs native.

DoneSubmitted by Vincent Legoll.
Details
2 participants
  • Mathieu Othacehe
  • Vincent Legoll
Owner
unassigned
Severity
normal
V
V
Vincent Legoll wrote on 2 Apr 2020 21:14
(address . guix-patches@gnu.org)
CAEwRq=oKJ1DCoPSysnYX2N_i==y460d-xry1s9v+beRpfRTF6A@mail.gmail.com
Another day, another batch.

I checked them with `guix gc --references`.

I checked potential rebuilds with
`guix refresh --list-dependent`

- ibus is just over 300
- gdb is ~1.4K

the remaining ones should be ok for master.

Hopefully it takes less work for the committer
this time...

--
Vincent Legoll
V
V
Vincent Legoll wrote on 2 Apr 2020 21:15
[PATCH 1/6] gnu: a2ps: Make some inputs native.
(address . 40391@debbugs.gnu.org)(name . Vincent Legoll)(address . vincent.legoll@gmail.com)
20200402191533.7517-1-vincent.legoll@gmail.com
* gnu/packages/pretty-print.scm (a2ps)[inputs]: Move groff from here...
[native-inputs]: ...to here.
---
gnu/packages/pretty-print.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (27 lines)
diff --git a/gnu/packages/pretty-print.scm b/gnu/packages/pretty-print.scm
index 18e557611e..f7655c3535 100644
--- a/gnu/packages/pretty-print.scm
+++ b/gnu/packages/pretty-print.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2017, 2018, 2019 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2019 Meiyo Peng <meiyo@riseup.net>
 ;;; Copyright © 2020 Paul Garlick <pgarlick@tourbillion-technology.com>
+;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -71,11 +72,11 @@
     (build-system gnu-build-system)
     (inputs
      `(("psutils" ,psutils)
-       ("groff" ,groff)
        ("gv" ,gv)
        ("imagemagick" ,imagemagick)))
     (native-inputs
      `(("gperf" ,gperf)
+       ("groff" ,groff)
        ("perl" ,perl)))
     (arguments
      '(#:phases
-- 
2.26.0
V
V
Vincent Legoll wrote on 2 Apr 2020 21:15
[PATCH 2/6] gnu: ibus: Make some inputs native.
(address . 40391@debbugs.gnu.org)(name . Vincent Legoll)(address . vincent.legoll@gmail.com)
20200402191533.7517-2-vincent.legoll@gmail.com
* gnu/packages/ibus.scm (ibus)[inputs]: Move gettext from here...
[native-inputs]: ...to here.
---
gnu/packages/ibus.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (30 lines)
diff --git a/gnu/packages/ibus.scm b/gnu/packages/ibus.scm
index 12a8d6758f..3782f390de 100644
--- a/gnu/packages/ibus.scm
+++ b/gnu/packages/ibus.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2018, 2019 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2018, 2019 Meiyo Peng <meiyo@disroot.org>
 ;;; Copyright © 2020 kanichos <kanichos@yandex.ru>
+;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -140,7 +141,6 @@
        ("gconf" ,gconf)
        ("gtk2" ,gtk+-2)
        ("gtk+" ,gtk+)
-       ("gettext" ,gnu-gettext)
        ("json-glib" ,json-glib)
        ("libnotify" ,libnotify)
        ("libx11" ,libx11)
@@ -152,6 +152,7 @@
        ("python" ,python)))
     (native-inputs
      `(("glib" ,glib "bin") ; for glib-genmarshal
+       ("gettext" ,gnu-gettext)
        ("gobject-introspection" ,gobject-introspection) ; for g-ir-compiler
        ("ucd" ,ucd)
        ("unicode-emoji" ,unicode-emoji)
-- 
2.26.0
V
V
Vincent Legoll wrote on 2 Apr 2020 21:15
[PATCH 3/6] gnu: gdb: Make some inputs native.
(address . 40391@debbugs.gnu.org)(name . Vincent Legoll)(address . vincent.legoll@gmail.com)
20200402191533.7517-3-vincent.legoll@gmail.com
* gnu/packages/gdb.scm (gdb)[inputs]: Move dejagnu from here...
[native-inputs]: ...to here.
---
gnu/packages/gdb.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (30 lines)
diff --git a/gnu/packages/gdb.scm b/gnu/packages/gdb.scm
index 01f93f6def..c3f071965a 100644
--- a/gnu/packages/gdb.scm
+++ b/gnu/packages/gdb.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2015, 2016, 2019 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2020 Marius Bakke <mbakke@fastmail.com>
+;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -94,7 +95,6 @@
        ("guile" ,guile-2.0)
        ("python" ,python)
        ("python-wrapper" ,python-wrapper)
-       ("dejagnu" ,dejagnu)
        ("source-highlight" ,source-highlight)
 
        ;; Allow use of XML-formatted syscall information.  This enables 'catch
@@ -102,6 +102,7 @@
        ("libxml2" ,libxml2)))
     (native-inputs
       `(("texinfo" ,texinfo)
+       ("dejagnu" ,dejagnu)
         ("pkg-config" ,pkg-config)))
     (home-page "https://www.gnu.org/software/gdb/")
     (synopsis "The GNU debugger")
-- 
2.26.0
V
V
Vincent Legoll wrote on 2 Apr 2020 21:15
[PATCH 4/6] gnu: c-reduce: Make some inputs native.
(address . 40391@debbugs.gnu.org)(name . Vincent Legoll)(address . vincent.legoll@gmail.com)
20200402191533.7517-4-vincent.legoll@gmail.com
* gnu/packages/debug.scm (c-reduce)[inputs]: Move flex from here...
[native-inputs]: ...to this new field.
---
gnu/packages/debug.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (27 lines)
diff --git a/gnu/packages/debug.scm b/gnu/packages/debug.scm
index 75dd94d868..4a264427c2 100644
--- a/gnu/packages/debug.scm
+++ b/gnu/packages/debug.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2018, 2019 Rutger Helling <rhelling@mykolab.com>
 ;;; Copyright © 2019 Pkill -9 <pkill9@runbox.com>
+;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -119,11 +120,11 @@ program to exhibit a bug.")
       (sha256
        (base32 "0qx0zq8jxzx2as2zf0740g7kvgq163ayn3041di4vwk77490y76v"))))
     (build-system gnu-build-system)
+    (native-inputs `(("flex" ,flex)))
     (inputs
      `(("astyle"          ,astyle)
        ("llvm"            ,llvm)
        ("clang"           ,clang)
-       ("flex"            ,flex)
        ("indent"          ,indent)
        ("perl"            ,perl)
        ("exporter-lite"   ,perl-exporter-lite)
-- 
2.26.0
V
V
Vincent Legoll wrote on 2 Apr 2020 21:15
[PATCH 5/6] gnu: ell: Make some inputs native.
(address . 40391@debbugs.gnu.org)(name . Vincent Legoll)(address . vincent.legoll@gmail.com)
20200402191533.7517-5-vincent.legoll@gmail.com
* gnu/packages/linux.scm (ell)[inputs]: Move libtool from here...
[native-inputs]: ...to here.
---
gnu/packages/linux.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (19 lines)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index ff069723c1..9604379eee 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -6571,10 +6571,10 @@ of Linux application development.")
                (("/usr/bin/dbus-daemon") (which "dbus-daemon")))
              #t)))))
     (inputs
-     `(("dbus" ,dbus)
-       ("libtool" ,libtool)))
+     `(("dbus" ,dbus)))
     (native-inputs
      `(("autoconf" ,autoconf)
+       ("libtool" ,libtool)
        ("pkgconfig" ,pkg-config)
        ("automake" ,automake)))
     (home-page "https://01.org/ell")
-- 
2.26.0
V
V
Vincent Legoll wrote on 2 Apr 2020 21:15
[PATCH 6/6] gnu: dico: Make some inputs native.
(address . 40391@debbugs.gnu.org)(name . Vincent Legoll)(address . vincent.legoll@gmail.com)
20200402191533.7517-6-vincent.legoll@gmail.com
* gnu/packages/dico.scm (dico)[inputs]: Move groff from here...
[native-inputs]: ...to this new field.
---
gnu/packages/dico.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (29 lines)
diff --git a/gnu/packages/dico.scm b/gnu/packages/dico.scm
index f6ab56887c..44a7a21b6b 100644
--- a/gnu/packages/dico.scm
+++ b/gnu/packages/dico.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2015, 2016, 2018 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2016, 2018 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me@tobias.gr>
+;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -63,13 +64,13 @@
                     (lambda _
                       ;; Test '71: append + dooffs + env' fails if $V is not 2.
                       (invoke "make" "check" "V=2"))))))
+    (native-inputs `(("groff" ,groff)))
     (inputs
      `(("m4" ,m4)                                 ;used at run time
        ("pcre" ,pcre)
        ("python" ,python-2)
        ("guile" ,guile-2.2)
        ("gsasl" ,gsasl)
-       ("groff" ,groff)
        ("readline" ,readline)
        ("zlib" ,zlib)
        ("wordnet" ,wordnet)
-- 
2.26.0
V
V
Vincent Legoll wrote on 3 Apr 2020 20:01
bad indent
(address . 40391@debbugs.gnu.org)
CAEwRq=o8wa4N5AMBtRhzV=d9XUR182zAQP3z4DDOZxwMRYq=7w@mail.gmail.com
The gdb patch's indentation is off-by-one
space character...

Here is an updated one...

--
Vincent Legoll
From b5f50ee8203ebdc11fd604429d509817da6648d1 Mon Sep 17 00:00:00 2001
From: Vincent Legoll <vincent.legoll@gmail.com>
Date: Thu, 2 Apr 2020 20:20:54 +0200
Subject: [PATCH 3/6] gnu: gdb: Make some inputs native.

* gnu/packages/gdb.scm (gdb)[inputs]: Move dejagnu from here...
[native-inputs]: ...to here.
---
gnu/packages/gdb.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (30 lines)
diff --git a/gnu/packages/gdb.scm b/gnu/packages/gdb.scm
index 01f93f6def..6331bd23f3 100644
--- a/gnu/packages/gdb.scm
+++ b/gnu/packages/gdb.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2015, 2016, 2019 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2020 Marius Bakke <mbakke@fastmail.com>
+;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -94,7 +95,6 @@
        ("guile" ,guile-2.0)
        ("python" ,python)
        ("python-wrapper" ,python-wrapper)
-       ("dejagnu" ,dejagnu)
        ("source-highlight" ,source-highlight)
 
        ;; Allow use of XML-formatted syscall information.  This enables 'catch
@@ -102,6 +102,7 @@
        ("libxml2" ,libxml2)))
     (native-inputs
       `(("texinfo" ,texinfo)
+        ("dejagnu" ,dejagnu)
         ("pkg-config" ,pkg-config)))
     (home-page "https://www.gnu.org/software/gdb/")
     (synopsis "The GNU debugger")
-- 
2.26.0
M
M
Mathieu Othacehe wrote on 4 Apr 2020 12:51
Re: [bug#40391] [PATCH 0/6] Make some more inputs native.
(name . Vincent Legoll)(address . vincent.legoll@gmail.com)(address . 40391@debbugs.gnu.org)
877dyvv80v.fsf@gmail.com
Hey,

Toggle quote (3 lines)
> - ibus is just over 300
> - gdb is ~1.4K

Pushed those two on staging and the other ones on master. Thanks for
this serie, feel to propose new ones, if you feel like it :)

Mathieu
M
M
Mathieu Othacehe wrote on 4 Apr 2020 12:51
control message for bug #40391
(address . control@debbugs.gnu.org)
875zefv7zx.fsf@gmail.com
close 40391
quit
V
V
Vincent Legoll wrote on 4 Apr 2020 18:01
Re: [bug#40391] [PATCH 0/6] Make some more inputs native.
(name . Mathieu Othacehe)(address . m.othacehe@gmail.com)(address . 40391@debbugs.gnu.org)
CAEwRq=oiCYHzHahso9+fpQzaSzuCQtNUMU2HHHbcLtZcqGFW3w@mail.gmail.com
On Sat, Apr 4, 2020 at 12:51 PM Mathieu Othacehe <m.othacehe@gmail.com> wrote:
Toggle quote (6 lines)
> > - ibus is just over 300
> > - gdb is ~1.4K
>
> Pushed those two on staging and the other ones on master. Thanks for
> this serie, feel to propose new ones, if you feel like it :)

Thanks
I'll see what I can do... ;-)

BTW, do we want to annotate (maybe with a simple comment) the ones
found to really be used ?

--
Vincent Legoll
V
V
Vincent Legoll wrote on 4 Apr 2020 19:51
(name . Mathieu Othacehe)(address . m.othacehe@gmail.com)(address . 40391@debbugs.gnu.org)
CAEwRq=p-RkObqwLGLdQHHufKvAfqfFeFPtWTwwhUetO=NAmTnw@mail.gmail.com
Here we go, next batch: #40435

--
Vincent Legoll
?
Your comment

This issue is archived.

To comment on this conversation send email to 40391@debbugs.gnu.org