[PATCH] gnu: Set JAVA_HOME for all Java development kits.

Open

Details

3 participants

Pierre Neidhardt
Christopher Baines
Roel Janssen

Owner: unassigned

Submitted by: Pierre Neidhardt

Severity: normal

Pierre Neidhardt wrote on 2 Apr 2020 10:10

Recipients:(address . guix-patches@gnu.org)

Message-ID:20200402081017.28866-1-mail@ambrevar.xyz

* gnu/packages/java.scm (icedtea-6, icedtea-7, openjdk9)[native-search-paths]:
  Set JAVA_HOME to "jre".
  This fixes issues for which the Java tooling could not find Jars,
  e.g. tools.jar.
---
 gnu/packages/java.scm | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Toggle diff (39 lines)diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 4d305aac49..ca6c64fc1e 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -1078,6 +1078,10 @@ machine.")))
            (sha256
             (base32
              "0835lkw8vib1xhp8lxnybhlvzdh699hbi4mclxanydjk63zbpxk0"))))))
+    (native-search-paths
+       (list (search-path-specification
+              (variable "JAVA_HOME")
+              (files '("jre")))))
     (home-page "http://icedtea.classpath.org")
     (synopsis "Java development kit")
     (description
@@ -1620,6 +1624,10 @@ bootstrapping purposes.")
          ("lcms" ,lcms)
          ("zlib" ,zlib)
          ("gtk" ,gtk+-2)))
+      (native-search-paths
+       (list (search-path-specification
+              (variable "JAVA_HOME")
+              (files '("jre")))))
       (home-page "http://icedtea.classpath.org")
       (synopsis "Java development kit")
       (description
@@ -1923,6 +1931,10 @@ new Date();"))
        ("unzip" ,unzip)
        ("which" ,which)
        ("zip" ,zip)))
+    (native-search-paths
+       (list (search-path-specification
+              (variable "JAVA_HOME")
+              (files '("jre")))))
     (home-page "https://openjdk.java.net/projects/jdk9/")
     (synopsis "Java development kit")
     (description
-- 
2.25.1

Pierre Neidhardt wrote on 2 Apr 2020 10:28

Re: bug#40387: Acknowledgement ([PATCH] gnu: Set JAVA_HOME for all Java development kits.)

Recipients:(address . 40387@debbugs.gnu.org)(name . Roel Janssen)(address . roel@gnu.org)

Message-ID:87zhbu9tqa.fsf@ambrevar.xyz

I cannot test this patch unfortunately, build icedtea-8 fails for me

with

Toggle snippet (12 lines)INFO: ZIP_DEBUGINFO_FILES=1
echo Generating precompiled header precompiled.hpp.gch
Generating precompiled header precompiled.hpp.gch
mkdir -p .
/gnu/store/x3jx25cd3q363mr7nbgzrhrv1vza6cf7-gcc-7.4.0/bin/g++ -DLINUX -D_GNU_SOURCE -DAMD64 -DPRODUCT -I. -I/tmp/guix-build-icedtea-3.7.0.drv-0/icedtea-2.6.13/openjdk/hotspot/src/share/vm/prims -I/tmp/guix-build-icedtea-3.7.0.drv-0/icedtea-2.6.13/openjdk/hotspot/src/share/vm -I/tmp/guix-build-icedtea-3.7.0.drv-0/icedtea-2.6.13/openjdk/hotspot/src/share/vm/precompiled -I/tmp/guix-build-icedtea-3.7.0.drv-0/icedtea-2.6.13/openjdk/hotspot/src/cpu/x86/vm -I/tmp/guix-build-icedtea-3.7.0.drv-0/icedtea-2.6.13/openjdk/hotspot/src/os_cpu/linux_x86/vm -I/tmp/guix-build-icedtea-3.7.0.drv-0/icedtea-2.6.13/openjdk/hotspot/src/os/linux/vm -I/tmp/guix-build-icedtea-3.7.0.drv-0/icedtea-2.6.13/openjdk/hotspot/src/os/posix/vm -I../generated -DHOTSPOT_RELEASE_VERSION="\"25.161-b12\"" -DHOTSPOT_BUILD_TARGET="\"product\"" -DHOTSPOT_BUILD_USER="\"nixbld\"" -DHOTSPOT_LIB_ARCH=\"amd64\" -DHOTSPOT_VM_DISTRO="\"OpenJDK\"" -DDERIVATIVE_ID="\"IcedTea 3.7.0\"" -DDISTRIBUTION_ID="\"Custom build\""  -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86_64 -DTARGET_OS_ARCH_linux_x86 -DTARGET_OS_ARCH_MODEL_linux_x86_64 -DTARGET_COMPILER_gcc -DCOMPILER2 -DCOMPILER1 -fPIC -fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -fvisibility=hidden -m64  -pipe -fno-strict-aliasing  -g -fno-omit-frame-pointer -O3  -DVM_LITTLE_ENDIAN -D_LP64=1  -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value   -g -O2 -fno-delete-null-pointer-checks -fno-lifetime-dse -std=gnu++98 -c -MMD -MP -MF ../generated/dependencies/precompiled.hpp.gch.d -fpch-deps -x c++-header /tmp/guix-build-icedtea-3.7.0.drv-0/icedtea-2.6.13/openjdk/hotspot/src/share/vm/precompiled/precompiled.hpp -o precompiled.hpp.gch 
In file included from /tmp/guix-build-icedtea-3.7.0.drv-0/icedtea-2.6.13/openjdk/hotspot/src/share/vm/precompiled/precompiled.hpp:315:0:
/tmp/guix-build-icedtea-3.7.0.drv-0/icedtea-2.6.13/openjdk/hotspot/src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp:250:2: fatal error: can't write PCH file: No space left on device
 };
  ^
compilation terminated.

Even though I do have enough space and memory left.
Unsure what's going on.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

Roel Janssen wrote on 2 Apr 2020 10:56

Recipients:

Message-ID:9e3d44f966ddc66c4c1cfcd8928381a351e96a06.camel@gnu.org

On Thu, 2020-04-02 at 10:28 +0200, Pierre Neidhardt wrote:

Toggle quote (50 lines)> I cannot test this patch unfortunately, build icedtea-8 fails for me
> with
> 
> 
> --8<---------------cut here---------------start------------->8---
> INFO: ZIP_DEBUGINFO_FILES=1
> echo Generating precompiled header precompiled.hpp.gch
> Generating precompiled header precompiled.hpp.gch
> mkdir -p .
> /gnu/store/x3jx25cd3q363mr7nbgzrhrv1vza6cf7-gcc-7.4.0/bin/g++ -DLINUX
> -D_GNU_SOURCE -DAMD64 -DPRODUCT -I. -I/tmp/guix-build-icedtea-3.7.0.drv-
> 0/icedtea-2.6.13/openjdk/hotspot/src/share/vm/prims -I/tmp/guix-build-icedtea-
> 3.7.0.drv-0/icedtea-2.6.13/openjdk/hotspot/src/share/vm -I/tmp/guix-build-
> icedtea-3.7.0.drv-0/icedtea-2.6.13/openjdk/hotspot/src/share/vm/precompiled
> -I/tmp/guix-build-icedtea-3.7.0.drv-0/icedtea-
> 2.6.13/openjdk/hotspot/src/cpu/x86/vm -I/tmp/guix-build-icedtea-3.7.0.drv-
> 0/icedtea-2.6.13/openjdk/hotspot/src/os_cpu/linux_x86/vm -I/tmp/guix-build-
> icedtea-3.7.0.drv-0/icedtea-2.6.13/openjdk/hotspot/src/os/linux/vm
> -I/tmp/guix-build-icedtea-3.7.0.drv-0/icedtea-
> 2.6.13/openjdk/hotspot/src/os/posix/vm -I../generated
> -DHOTSPOT_RELEASE_VERSION="\"25.161-b12\""
> -DHOTSPOT_BUILD_TARGET="\"product\"" -DHOTSPOT_BUILD_USER="\"nixbld\""
> -DHOTSPOT_LIB_ARCH=\"amd64\" -DHOTSPOT_VM_DISTRO="\"OpenJDK\""
> -DDERIVATIVE_ID="\"IcedTea 3.7.0\"" -DDISTRIBUTION_ID="\"Custom build\""  -
> DTARGET_OS_FAMILY_linux -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86_64
> -DTARGET_OS_ARCH_linux_x86 -DTARGET_OS_ARCH_MODEL_linux_x86_64
> -DTARGET_COMPILER_gcc -DCOMPILER2 -DCOMPILER1 -fPIC -fno-rtti -fno-exceptions
> -D_REENTRANT -fcheck-new -fvisibility=hidden -m64  -pipe -fno-strict-
> aliasing  -g -fno-omit-frame-pointer -O3  -DVM_LITTLE_ENDIAN -D_LP64=1  -
> Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value   -g
> -O2 -fno-delete-null-pointer-checks -fno-lifetime-dse -std=gnu++98 -c -MMD -MP
> -MF ../generated/dependencies/precompiled.hpp.gch.d -fpch-deps -x c++-header
> /tmp/guix-build-icedtea-3.7.0.drv-0/icedtea-
> 2.6.13/openjdk/hotspot/src/share/vm/precompiled/precompiled.hpp -o
> precompiled.hpp.gch 
> In file included from /tmp/guix-build-icedtea-3.7.0.drv-0/icedtea-
> 2.6.13/openjdk/hotspot/src/share/vm/precompiled/precompiled.hpp:315:0:
> /tmp/guix-build-icedtea-3.7.0.drv-0/icedtea-
> 2.6.13/openjdk/hotspot/src/share/vm/gc_implementation/parallelScavenge/paralle
> lScavengeHeap.hpp:250:2: fatal error: can't write PCH file: No space left on
> device
>  };
>   ^
> compilation terminated.
> --8<---------------cut here---------------end--------------->8---
> 
> Even though I do have enough space and memory left.
> Unsure what's going on.
> 

Is your /tmp a separate partition, and full at the time this build fails?

Kind regards,

Roel Janssen

Pierre Neidhardt wrote on 2 Apr 2020 11:03

Recipients:

Message-ID:87d08qi7ip.fsf@ambrevar.xyz

/tmp is a separate partition but it's a tmpfs, it uses my virtual
memory which is largely free (5GiB+).

-- 
Pierre Neidhardt
https://ambrevar.xyz/

Christopher Baines wrote on 18 Dec 2020 12:17

Re: [bug#40387] [PATCH] gnu: Set JAVA_HOME for all Java development kits.

Recipients:(name . Pierre Neidhardt)(address . mail@ambrevar.xyz)(address . 40387@debbugs.gnu.org)

Message-ID:874kkj2wj4.fsf@cbaines.net

Pierre Neidhardt <mail@ambrevar.xyz> writes:

Toggle quote (5 lines)

> * gnu/packages/java.scm (icedtea-6, icedtea-7, openjdk9)[native-search-paths]:

> Set JAVA_HOME to "jre".

> This fixes issues for which the Java tooling could not find Jars,

> e.g. tools.jar.

Which tools have you observed not to work? I tried running javac and I

got the help output at least.

Thanks,

Chris

Pierre Neidhardt wrote on 18 Dec 2020 13:31

Recipients:(name . Christopher Baines)(address . mail@cbaines.net)(address . 40387@debbugs.gnu.org)

Message-ID:87h7ojgusm.fsf@ambrevar.xyz

Sorry, I forgot, I've moved on since then.
Maybe it was for some Clojure thing.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 40387@debbugs.gnu.org

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date