(address . guix-patches@gnu.org)
206415b91c8972f54a8c9e04fd330a50@disroot.org
Hello Guix!
Please find the attached patch to remove deprecated package-definitions of bctoolbox and ortp.
Regards,
RG.
Remove deprecated packages
- Done
Details
- 4 participants
- Danny Milosavljevic
- Leo Famulari
- Maxim Cournoyer
- Raghav Gururajan
- Owner
- unassigned
- Submitted by
- Raghav Gururajan
- Severity
- normal
R
L
(name . Raghav Gururajan)(address . raghavgururajan@disroot.org)(address . 40326@debbugs.gnu.org)
20200330180138.GC6896@jasmine.lan
On Mon, Mar 30, 2020 at 05:03:42PM +0000, Raghav Gururajan wrote:
Toggle quote (4 lines)
> Hello Guix!
>
> Please find the attached patch to remove deprecated package-definitions of bctoolbox and ortp.
These packages haven't been deprecated, as I understand it. That would
mean they had been defined with the deprecated-package procedure for a
while.
M
(name . Leo Famulari)(address . leo@famulari.name)
87pnctz64j.fsf@gmail.com
Hello Leo and Raghav,
Leo Famulari <leo@famulari.name> writes:
Toggle quote (9 lines)
> On Mon, Mar 30, 2020 at 05:03:42PM +0000, Raghav Gururajan wrote:
>> Hello Guix!
>>
>> Please find the attached patch to remove deprecated package-definitions of bctoolbox and ortp.
>
> These packages haven't been deprecated, as I understand it. That would
> mean they had been defined with the deprecated-package procedure for a
> while.
I think it's hard to understand why this is done here without context.
Raghav has started working on packaging Linphone and has made new
definitions for bctoolbox and ortp in a new (gnu packages linphone)
module.
So these packages are going to be moved rather than be outright
removed.
Raghav, for backward compatibility, when me move or rename a package, we
bind the deprecated symbols using the define-deprecated macro (from
(guix deprecation)).
In this case, it'd look like, for example:
(define-deprecated btcoolbox linphone:bctoolbox)
For an actual example, you can "git show 8ab060b68b3".
Maxim
M
(name . Leo Famulari)(address . leo@famulari.name)
875zekxmti.fsf@gmail.com
Hello,
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
Toggle quote (34 lines)
> Hello Leo and Raghav,
>
> Leo Famulari <leo@famulari.name> writes:
>
>> On Mon, Mar 30, 2020 at 05:03:42PM +0000, Raghav Gururajan wrote:
>>> Hello Guix!
>>>
>>> Please find the attached patch to remove deprecated package-definitions of bctoolbox and ortp.
>>
>> These packages haven't been deprecated, as I understand it. That would
>> mean they had been defined with the deprecated-package procedure for a
>> while.
>
> I think it's hard to understand why this is done here without context.
>
> Raghav has started working on packaging Linphone and has made new
> definitions for bctoolbox and ortp in a new (gnu packages linphone)
> module.
>
> So these packages are going to be moved rather than be outright
> removed.
>
> Raghav, for backward compatibility, when me move or rename a package, we
> bind the deprecated symbols using the define-deprecated macro (from
> (guix deprecation)).
>
> In this case, it'd look like, for example:
>
> (define-deprecated btcoolbox linphone:bctoolbox)
>
> For an actual example, you can "git show 8ab060b68b3".
>
> Maxim
Sorry, it seems I was wrong about this. A simple move of a package
definition does not warrant defining deprecation symbols (thanks
Tobias).
The packages should only be removed after (or better yet -- at the same
time) their replacement are added, to prevent breaking someone's
manifest.
Maxim
D
(name . Raghav Gururajan)(address . raghavgururajan@disroot.org)(address . 40326-done@debbugs.gnu.org)
20200403164413.119cb618@scratchpost.org
Hi Raghav,
these were used by kopete and bluez-alsa.
I've updated those references too and pushed the result to guix master as
commit 9be3ab7bbe41234d861062e0037d3bd24cbba274.
Still wondering what to do with the "-fPIC" that is now gone from bctoolbox.
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6HS70ACgkQ5xo1VCww
uqVdkgf/WCHKzs6rsTPwmjixyi+xtaVg9vp3xkh9HG03F6lB2pdLO8sn187xDbK9
rIft3l8xwQbbNWflk6x0cQ5yCwI7c4NnIlQsXaJrn/SLrwj3ATOx4RKgOeKBDO5F
BN5hcOLTMju3vuLN3t7kNDwoM0NfUtPQ5Bla9vsCCTjoej4vYs1hY1V8SSSp9ryO
gaoj+RzPOw0CdQw14hO/+IhQA9+xhxEuANqQlIi3fyOCRREvz1Uq2F3c4i7OzqlV
XYWpdOm0aeHraf4GKPTib6otClkZgaLJmEDkTF3x/aYSu3bDHGmfQQYTlfc/XusG
6QjDEDVblGVTy74aD0hey4+eL9bZYQ==
=5oZw
-----END PGP SIGNATURE-----
Closed
R
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)(address . 40326-done@debbugs.gnu.org)
c3e77f97107255c32c4de86d49c36cb0@disroot.org
Hi Danny!
Toggle quote (5 lines)
> these were used by kopete and bluez-alsa.
>
> I've updated those references too and pushed the result to guix master as
> commit 9be3ab7bbe41234d861062e0037d3bd24cbba274.
Thank you so much.
Toggle quote (2 lines)
> Still wondering what to do with the "-fPIC" that is now gone from bctoolbox.
I think we can deal with when we get any errors related to that in the future. :-)
Regards,
RG.
Closed
?