Add Docusign python API module as a package

  • Open
  • quality assurance status badge
Details
2 participants
  • Josh Marshall
  • Leo Famulari
Owner
unassigned
Submitted by
Josh Marshall
Severity
normal
J
J
Josh Marshall wrote on 23 Mar 2020 15:26
(name . guix-patches@gnu.org)(address . guix-patches@gnu.org)
BL0PR06MB467337164FD5310F6BC47585E9F00@BL0PR06MB4673.namprd06.prod.outlook.com
Add Docusign python API module as a package
---

The information in this email, including attachments, may be confidential and is intended solely for the addressee(s). If you believe you received this email by mistake, please notify the sender by return email as soon as possible.
L
L
Leo Famulari wrote on 23 Mar 2020 20:39
(name . Josh Marshall)(address . Josh.Marshall@jax.org)(address . 40195@debbugs.gnu.org)
20200323193906.GA30452@jasmine.lan
On Mon, Mar 23, 2020 at 02:26:10PM +0000, Josh Marshall wrote:
Toggle quote (2 lines)
> Add Docusign python API module as a package

Thanks! I have a few changes...

The tarballs that GitHub automatically generates per-tag (named like
'v3.0.0.tar.gz') do sometimes change, which breaks our packaging. So we
should package this either from the Git tag or from PyPI:


I think we should take the PyPi name as canonical, so as a Python
library, this Guix package should be called 'python-docusign-esign'.

Why are the tests skipped? Can you add a code comment? Even just "No
test suite" if that is the case.

Make sure to lint the package. You may need to do it in a Guix
development environment; something like this should work:

`guix environment guix -- ./pre-inst-env guix lint python-docusign`.

Can you send a revised patch? Also, does this integrate with any Guix
packages?
J
J
Josh Marshall wrote on 24 Mar 2020 18:46
(name . Leo Famulari)(address . leo@famulari.name)(name . 40195@debbugs.gnu.org)(address . 40195@debbugs.gnu.org)
BL0PR06MB46733D434B8858B35F493798E9F10@BL0PR06MB4673.namprd06.prod.outlook.com
The tarballs that GitHub automatically generates per-tag (named like
'v3.0.0.tar.gz') do sometimes change, which breaks our packaging. So we
should package this either from the Git tag or from PyPI:
Toggle quote (2 lines)
> Done

I think we should take the PyPi name as canonical, so as a Python
library, this Guix package should be called 'python-docusign-esign'.
Toggle quote (2 lines)
> Done

Why are the tests skipped? Can you add a code comment? Even just "No
test suite" if that is the case.
Toggle quote (2 lines)
> Done

Make sure to lint the package. You may need to do it in a Guix
development environment; something like this should work:
Toggle quote (2 lines)
> I couldn't figure the command -- thanks. Also done

Can you send a revised patch?
Toggle quote (2 lines)
> See attached

Also, does this integrate with any Guix packages?
Toggle quote (1 lines)
> No?
---

The information in this email, including attachments, may be confidential and is intended solely for the addressee(s). If you believe you received this email by mistake, please notify the sender by return email as soon as possible.
L
L
Leo Famulari wrote on 24 Mar 2020 20:39
(name . Josh Marshall)(address . Josh.Marshall@jax.org)(name . 40195-done@debbugs.gnu.org)(address . 40195@debbugs.gnu.org)
20200324193942.GA5689@jasmine.lan
Thanks for the revisions! I pushed as
b14c234c0d32216f8c2f6e6d1935c469a6b947c9 with a few more changes:

I made it fetch from PyPi instead of Git since they didn't actually tag
a 3.1.0 release. We'd rather take the thing that upstream definitely
says is "the release" in cases like that.

I made the variable name and package name consistent.

And I simplified the synopsis to hopefully improve searchability.
J
J
Josh Marshall wrote on 24 Mar 2020 22:06
(name . Leo Famulari)(address . leo@famulari.name)(name . 40195-done@debbugs.gnu.org)(address . 40195@debbugs.gnu.org)
BL0PR06MB467388F3D4EE74576A564146E9F10@BL0PR06MB4673.namprd06.prod.outlook.com
Thanks! I'll try to do better on the next one I submit.

________________________________________
From: Leo Famulari <leo@famulari.name>
Sent: Tuesday, March 24, 2020 3:39 PM
To: Josh Marshall
Cc: 40195-done@debbugs.gnu.org
Subject: Re: [EXTERNAL]Re: [bug#40195] Add Docusign python API module as a package

Thanks for the revisions! I pushed as
b14c234c0d32216f8c2f6e6d1935c469a6b947c9 with a few more changes:

I made it fetch from PyPi instead of Git since they didn't actually tag
a 3.1.0 release. We'd rather take the thing that upstream definitely
says is "the release" in cases like that.

I made the variable name and package name consistent.

And I simplified the synopsis to hopefully improve searchability.
---

The information in this email, including attachments, may be confidential and is intended solely for the addressee(s). If you believe you received this email by mistake, please notify the sender by return email as soon as possible.
L
L
Leo Famulari wrote on 24 Mar 2020 22:20
(name . Josh Marshall)(address . Josh.Marshall@jax.org)(name . 40195-done@debbugs.gnu.org)(address . 40195@debbugs.gnu.org)
20200324212054.GA27847@jasmine.lan
On Tue, Mar 24, 2020 at 09:06:58PM +0000, Josh Marshall wrote:
Toggle quote (2 lines)
> Thanks! I'll try to do better on the next one I submit.

Okay! The important thing is to get the patch in the queue :)
?