Add Docusign python API module as a package

Add Docusign python API module as a package

---

The information in this email, including attachments, may be confidential and is intended solely for the addressee(s). If you believe you received this email by mistake, please notify the sender by return email as soon as possible.

On Mon, Mar 23, 2020 at 02:26:10PM +0000, Josh Marshall wrote:

Thanks! I have a few changes...

The tarballs that GitHub automatically generates per-tag (named like

'v3.0.0.tar.gz') do sometimes change, which breaks our packaging. So we

should package this either from the Git tag or from PyPI:

I think we should take the PyPi name as canonical, so as a Python

library, this Guix package should be called 'python-docusign-esign'.

Why are the tests skipped? Can you add a code comment? Even just "No

test suite" if that is the case.

Make sure to lint the package. You may need to do it in a Guix

development environment; something like this should work:

`guix environment guix -- ./pre-inst-env guix lint python-docusign`.

Can you send a revised patch? Also, does this integrate with any Guix

packages?

The tarballs that GitHub automatically generates per-tag (named like

'v3.0.0.tar.gz') do sometimes change, which breaks our packaging. So we

should package this either from the Git tag or from PyPI:

I think we should take the PyPi name as canonical, so as a Python

library, this Guix package should be called 'python-docusign-esign'.

Why are the tests skipped? Can you add a code comment? Even just "No

test suite" if that is the case.

Make sure to lint the package. You may need to do it in a Guix

development environment; something like this should work:

Can you send a revised patch?

Also, does this integrate with any Guix packages?

---

The information in this email, including attachments, may be confidential and is intended solely for the addressee(s). If you believe you received this email by mistake, please notify the sender by return email as soon as possible.

Thanks for the revisions! I pushed as

b14c234c0d32216f8c2f6e6d1935c469a6b947c9 with a few more changes:

I made it fetch from PyPi instead of Git since they didn't actually tag

a 3.1.0 release. We'd rather take the thing that upstream definitely

says is "the release" in cases like that.

I made the variable name and package name consistent.

And I simplified the synopsis to hopefully improve searchability.

Thanks! I'll try to do better on the next one I submit.

________________________________________

Sent: Tuesday, March 24, 2020 3:39 PM

To: Josh Marshall

Cc: 40195-done@debbugs.gnu.org

Thanks for the revisions! I pushed as

b14c234c0d32216f8c2f6e6d1935c469a6b947c9 with a few more changes:

I made it fetch from PyPi instead of Git since they didn't actually tag

a 3.1.0 release. We'd rather take the thing that upstream definitely

says is "the release" in cases like that.

I made the variable name and package name consistent.

And I simplified the synopsis to hopefully improve searchability.

---

The information in this email, including attachments, may be confidential and is intended solely for the addressee(s). If you believe you received this email by mistake, please notify the sender by return email as soon as possible.

On Tue, Mar 24, 2020 at 09:06:58PM +0000, Josh Marshall wrote:

Okay! The important thing is to get the patch in the queue :)