[PATCH] gnu: ocaml-menhir: Update to 20200211

  • Done
  • quality assurance status badge
Details
4 participants
  • Leo Famulari
  • Christopher Baines
  • Vincent Legoll
  • zimoun
Owner
unassigned
Submitted by
Vincent Legoll
Severity
normal
Blocked by

Debbugs page

Vincent Legoll wrote 5 years ago
(address . guix-patches@gnu.org)
CAEwRq=rLKfAU-rspytLXuHW6JuqT+cB2XDrZdQ0SrxRXqfW_tg@mail.gmail.com
The attached patch depends on the
previously submitted for inclusion dune 2.4.0
update (which may not go into master)

The package is switched from ocaml-build-system to dune-build-system.

This one is untested though

--
Vincent Legoll
From d5a34254f0fdcc53f1f4c2614e5f2393d12e6cc9 Mon Sep 17 00:00:00 2001
From: Vincent Legoll <vincent.legoll@gmail.com>
Date: Mon, 16 Mar 2020 16:32:25 +0100
Subject: [PATCH] gnu: ocaml-menhir: Update to 20200211.

* gnu/packages/ocaml.scm (ocaml-menhir): Update to 20200211.
[build-system]: Switch from gnu to dune.
[arguments]: Remove phases and make-flags.
[native-inputs]: remove field.
---
gnu/packages/ocaml.scm | 15 ++++-----------
1 file changed, 4 insertions(+), 11 deletions(-)

Toggle diff (38 lines)
diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index 047bcc2d7b..6414fc0316 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -706,7 +706,7 @@ Emacs.")
(define-public ocaml-menhir
(package
(name "ocaml-menhir")
- (version "20181113")
+ (version "20200211")
(source
(origin
(method git-fetch)
@@ -715,19 +715,12 @@ Emacs.")
(commit version)))
(file-name (git-file-name name version))
(sha256
- (base32 "1iqdf64ayq4s3d9jkwhs3s8wqc2s48b292hp0kcjsskfhcvwg0kr"))))
- (build-system ocaml-build-system)
+ (base32 "019izf51kdc7pzkw68zg8a2alc8lxw1gwdp7in970mr90n16b5zj"))))
+ (build-system dune-build-system)
(inputs
`(("ocaml" ,ocaml)))
- (native-inputs
- `(("ocamlbuild" ,ocamlbuild)))
(arguments
- `(#:make-flags `("USE_OCAMLFIND=true"
- ,(string-append "PREFIX=" (assoc-ref %outputs "out")))
- #:tests? #f ; No check target
- #:phases
- (modify-phases %standard-phases
- (delete 'configure))))
+ `(#:tests? #f)) ; No check target
(home-page "http://gallium.inria.fr/~fpottier/menhir/")
(synopsis "Parser generator")
(description "Menhir is a parser generator. It turns high-level grammar
--
2.25.1
Leo Famulari wrote 5 years ago
(name . Vincent Legoll)(address . vincent.legoll@gmail.com)(address . 40092@debbugs.gnu.org)
20200529003859.GD5443@jasmine.lan
On Mon, Mar 16, 2020 at 06:01:15PM +0100, Vincent Legoll wrote:
Toggle quote (8 lines)
> The attached patch depends on the
> previously submitted for inclusion dune 2.4.0
> update (which may not go into master)
>
> The package is switched from ocaml-build-system to dune-build-system.
>
> This one is untested though

It's been a while... is this patch still waiting for something else?
Vincent Legoll wrote 5 years ago
(name . Leo Famulari)(address . leo@famulari.name)(address . 40092@debbugs.gnu.org)
87a0a0bb-af44-147a-f4c4-ee7beaecb648@gmail.com
Hello,

On 29/05/2020 02:38, Leo Famulari wrote:
Toggle quote (11 lines)
> On Mon, Mar 16, 2020 at 06:01:15PM +0100, Vincent Legoll wrote:
>> The attached patch depends on the
>> previously submitted for inclusion dune 2.4.0
>> update (which may not go into master)
>>
>> The package is switched from ocaml-build-system to dune-build-system.
>>
>> This one is untested though
>
> It's been a while... is this patch still waiting for something else?

Yes, this depends on dune 2 (we still have 1.11.3) which is breaking
compatibility by removing support for jhbuild. See details in issue:
#40091.

I'm not into ocaml, (was just trying to update packages, to get
acquainted with guix packaging). I think I was too optimistic with
those.

I'll let the ones who know handle this.

I don't know if this means closing the issues or letting them open
though...

--
Vincent Legoll
Leo Famulari wrote 5 years ago
(no subject)
(address . control@debbugs.gnu.org)
20200529171152.GA1454@jasmine.lan
block 40092 by 40091
Leo Famulari wrote 5 years ago
Re: [bug#40092] [PATCH] gnu: ocaml-menhir: Update to 20200211
(name . Vincent Legoll)(address . vincent.legoll@gmail.com)(address . 40092@debbugs.gnu.org)
20200529171256.GB643@jasmine.lan
On Fri, May 29, 2020 at 10:25:34AM +0200, Vincent Legoll wrote:
Toggle quote (4 lines)
> Yes, this depends on dune 2 (we still have 1.11.3) which is breaking
> compatibility by removing support for jhbuild. See details in issue:
> #40091.

Alright, I've set this patch as "blocked by" #40091 in the bug tracker.
zimoun wrote 4 years ago
(name . Leo Famulari)(address . leo@famulari.name)
86blh31kr6.fsf@gmail.com
Dear,

On Fri, 29 May 2020 at 13:12, Leo Famulari <leo@famulari.name> wrote:
Toggle quote (7 lines)
> On Fri, May 29, 2020 at 10:25:34AM +0200, Vincent Legoll wrote:
>> Yes, this depends on dune 2 (we still have 1.11.3) which is breaking
>> compatibility by removing support for jhbuild. See details in issue:
>> #40091.
>
> Alright, I've set this patch as "blocked by" #40091 in the bug tracker.

The recent commit 339177956a updates dune to 2.7.1, therefore somehow
unblock 40091. Could you try to rebase your patch?


All the best,
simon

PS:
It could be nice to have this recent version of menhir in v1.2. :-)
Christopher Baines wrote 4 years ago
(name . zimoun)(address . zimon.toutoune@gmail.com)
871rg0hwzn.fsf@cbaines.net
zimoun <zimon.toutoune@gmail.com> writes:

Toggle quote (20 lines)
> Dear,
>
> On Fri, 29 May 2020 at 13:12, Leo Famulari <leo@famulari.name> wrote:
>> On Fri, May 29, 2020 at 10:25:34AM +0200, Vincent Legoll wrote:
>>> Yes, this depends on dune 2 (we still have 1.11.3) which is breaking
>>> compatibility by removing support for jhbuild. See details in issue:
>>> #40091.
>>
>> Alright, I've set this patch as "blocked by" #40091 in the bug tracker.
>
> The recent commit 339177956a updates dune to 2.7.1, therefore somehow
> unblock 40091. Could you try to rebase your patch?
>
>
> All the best,
> simon
>
> PS:
> It could be nice to have this recent version of menhir in v1.2. :-)

This patch looks good to me, so I've gone ahead and pushed to master as
20e5658c0471c76cc297cfd30ad49f0585310e27.

Thanks,

Chris
-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl/P37xfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9Xdu6Q/9HiIzsWHLwm7XbYkSvOb7ODFFfkPsf+qK
SvJvhomKw8deVHyY8Of9FmLVRPH01F2JzNidN6oHfShPQLW9QSaMWp8WhAfipxY7
PvezaqpgGpgX6iDOlBt0U0rE2BmZprYG5gOVreYKB+/hjSaAB/9y28bdGnaKCB2H
NeSQmHgWTr1sHioR1M58sj3XPCWN1ArIfA2yXHbDOORLwjCIdautYuw+PUycQUyp
yMM73L3wnGG0Lr+eqH2+aut+zreBzRjp0OeBIE0gU96oh599qy6763C+xOAnbGGI
amPfu7mE6tpew/CpHl0LAZ2DJCEJOscZjjfcCibO6cQAlNo14anH93JNdHBb5hXx
EfE8fb1eoH609Puvj5AbSQscguGlAdnM6DcDbs+xAGRrvJqk0/eRqmXiLDFYMp/y
Gmzp2Yw47WpNpeimkQcjGma7vZQ96ZQQlcef2cxV5iO59Y2IYF4F0X1n+Xs1Kaah
VfJipTGXQvHQFHMhvl00iKqsQsalUudUyMVu3KMRiZY3Fb5PnTQ4lKMWFd9WLOJb
NgLHgUygCGeBDq8AxvXyTLS3OPqE52MqgDTPFf28KGTHpZeOIpv1wuBEPcB+l1LP
O6NsYPKH5fjREQZ7Ee3OLFW/uvu87N+LAgxIR9TrsnAj/1NmxG+KMtR5JFfs8wLh
1ZQAymWzcpY=
=8UEf
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 40092@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 40092
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help