[PATCH] Add zlfo.

Done

Details

3 participants

Alexandros Theodotou
Jakub Kądziołka
Ricardo Wurmus

Owner: unassigned

Submitted by: Alexandros Theodotou

Severity: normal

Debbugs page

Alexandros Theodotou wrote 5 years ago

Recipients:(name . Guix patches)(address . guix-patches@gnu.org)

Message-ID:0f84534047c834937c210429116d686bc159e8a3.camel@zrythm.org

Hi,

This is a new LV2 plugin. It uses Ztoolkit for its UI so I packaged

that separately.

I made a separate package for ztoolkit-rsvg because adding librsvg

brings in the whole glib stack, while ztoolkit by itself is very

minimal. Feel free to let me know if you have any other suggestions.

Thanks,

Alex

From 0ba05eed84867e0e7bd17fbbf8916c53f6cf7abd Mon Sep 17 00:00:00 2001

* gnu/packages/music.scm (zlfo): New variable.

---

gnu/packages/music.scm | 27 +++++++++++++++++++++++++++

1 file changed, 27 insertions(+)

Toggle diff (37 lines)diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 16e69840df..8d07a23127 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5189,3 +5189,30 @@ featureful and easy to use.  It offers unlimited automation options, LV2
 plugin support, JACK support and chord assistance.")
    (home-page "https://www.zrythm.org")
    (license license:agpl3+)))
+
+(define-public zlfo
+  (package
+    (name "zlfo")
+    (version "0.1.3")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://git.zrythm.org/git/ZLFO")
+               (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+          (base32
+            "0bm466ci5xyvxvq7l9p6xyh789lvk6i31b4zja1igqh13akbjnjz"))))
+    (build-system meson-build-system)
+    (inputs
+     `(("ztoolkit-rsvg" ,ztoolkit-rsvg)))
+    (native-inputs
+     `(("git" ,git)
+       ("lv2" ,lv2)
+       ("pkg-config" ,pkg-config)))
+    (synopsis "LFO plugin")
+    (description "ZLFO is a fully featured LFO for CV-based automation
+that comes as a cross-platform LV2 plugin bundle with a custom UI.")
+    (home-page "https://git.zrythm.org/cgit/ZLFO/")
+    (license license:agpl3+)))
-- 
2.25.1

From c8b1c930846eb6cc0f8b2aed47e430e62466577a Mon Sep 17 00:00:00 2001

* gnu/packages/audio.scm (ztoolkit): New variable.

---

gnu/packages/audio.scm | 43 ++++++++++++++++++++++++++++++++++++++++++

1 file changed, 43 insertions(+)

Toggle diff (53 lines)diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 5b8c610882..dece9c03fe 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -4036,3 +4036,46 @@ libsamplerate for reading and resampling audio files, based on Robin Gareus'
 @code{audio_decoder} code.")
    (home-page "https://git.zrythm.org/cgit/libaudec")
    (license license:agpl3+)))
+
+(define-public ztoolkit
+  (package
+    (name "ztoolkit")
+    (version "0.1.1")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://git.zrythm.org/git/ztoolkit")
+               (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+          (base32
+            "07xl3cmdaf7k9mm58m93cn8i1jvgimmiifdw1w7v2jl88nx60pm1"))))
+    (build-system meson-build-system)
+    (propagated-inputs
+     `(("cairo" ,cairo)
+       ("libx11" ,libx11)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("git" ,git)))
+    (synopsis "GUI toolkit for LV2 plugins")
+    (description "ZToolkit (Ztk) is a cross-platform GUI toolkit heavily
+inspired by GTK.  It handles events and low level drawing on behalf of
+the user and provides a high-level API for managing the UI and custom
+widgets.  ZToolkit is written in C and was created to be used for building
+audio plugin UIs, where the dependencies often need to be kept to a
+minimum.")
+    (home-page "https://git.zrythm.org/cgit/ztoolkit/")
+    (license license:agpl3+)))
+
+(define-public ztoolkit-rsvg
+  (package
+    (inherit ztoolkit)
+    (name "ztoolkit-rsvg")
+    (arguments
+     `(#:configure-flags `("-Denable_rsvg=true")))
+    (propagated-inputs
+     `(("cairo" ,cairo)
+       ("librsvg" ,librsvg)
+       ("libx11" ,libx11)))
+    (synopsis "ZToolkit with SVG support")))
-- 
2.25.1

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEESBMjhK0999huJUuDAi6uQjE9cPMFAl5VN/4ACgkQAi6uQjE9

cPPdjQgAmyetoChwWP464Zeh2BMdvdAWb7Ofsf1UBhU0D4HA8phFPCBgqP9T6K1l

mGdOx9gz5J9SKt3YbhQhgds/WP8WImxN8x4cKar6adg5obfhfznXHwggLwtREwjd

2EM9UTKEz0pojHHlfjJL80qKvtDWLPr1xB1XoD0rF8RPR6htHHz+kOunQBfiy53P

rVdRh9S5aoeg656vFo7hHxMFSH7Qfp7HW2hwzaZqvCoG/bFSztRiHNgohl4JG0FW

EuhY22ZdS5vS6CY1H21Fe7jexVxmOqCLw3xwIjk1IZaIdryMkpkmg7h7ck1YoUej

JdwaeKoyEGZPmdJWce5lV0VOzRo/wA==

=56RQ

-----END PGP SIGNATURE-----

Jakub Kądziołka wrote 5 years ago

Recipients:(name . Alexandros Theodotou)(address . alex@zrythm.org)(name . Guix patches)(address . guix-patches@gnu.org)

Message-ID:20200226220320.qfog7rmaqsglx2dg@gravity

On Tue, Feb 25, 2020 at 03:06:38PM +0000, Alexandros Theodotou wrote:

Toggle quote (5 lines)

> Hi,

> This is a new LV2 plugin. It uses Ztoolkit for its UI so I packaged

> that separately.

Hi,

could you send your patches inline, instead of as an attachment? It

makes reviews easier. The workflow on your side is easier too, since you

only need to `git send-email` (available as git:send-email in guix).

It's fine if you prefer not to do this, though.

Toggle quote (4 lines)

> * gnu/packages/audio.scm (ztoolkit): New variable.

> ---

> gnu/packages/audio.scm | 43 ++++++++++++++++++++++++++++++++++++++++++

> 1 file changed, 43 insertions(+)

I'm not sure if audio.scm is the best place for a GUI toolkit. It might

be fine since audio plugins are the primary usecase, but I'm not sure.

Toggle quote (14 lines)> +(define-public ztoolkit
> +  (package
> +    (name "ztoolkit")
> +    (version "0.1.1")
> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri (git-reference
> +               (url "https://git.zrythm.org/git/ztoolkit")
> +               (commit (string-append "v" version))))
> +        (file-name (git-file-name name version))
> +        (sha256
> +          (base32
> +            "07xl3cmdaf7k9mm58m93cn8i1jvgimmiifdw1w7v2jl88nx60pm1"))))

Please run etc/indent-code.el on your packages.

Toggle quote (4 lines)

> + (build-system meson-build-system)

> + (propagated-inputs

> + `(("cairo" ,cairo)

> + ("libx11" ,libx11)))

Why are these propagated-inputs? I would've thought that these

dependencies get linked into the binary, so they don't need to propagate

to the user's profile.

Toggle quote (3 lines)

> + (native-inputs

> + `(("pkg-config" ,pkg-config)

> + ("git" ,git)))

Why the dependency on git? The package seems to build fine without it.

Toggle quote (29 lines)> +    (synopsis "GUI toolkit for LV2 plugins")
> +    (description "ZToolkit (Ztk) is a cross-platform GUI toolkit heavily
> +inspired by GTK.  It handles events and low level drawing on behalf of
> +the user and provides a high-level API for managing the UI and custom
> +widgets.  ZToolkit is written in C and was created to be used for building
> +audio plugin UIs, where the dependencies often need to be kept to a
> +minimum.")
> +    (home-page "https://git.zrythm.org/cgit/ztoolkit/")
> +    (license license:agpl3+)))

> +(define-public zlfo
> +  (package
> +    (name "zlfo")
> +    (version "0.1.3")
> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri (git-reference
> +               (url "https://git.zrythm.org/git/ZLFO")
> +               (commit (string-append "v" version))))
> +        (file-name (git-file-name name version))
> +        (sha256
> +          (base32
> +            "0bm466ci5xyvxvq7l9p6xyh789lvk6i31b4zja1igqh13akbjnjz"))))
> +    (build-system meson-build-system)
> +    (inputs
> +     `(("ztoolkit-rsvg" ,ztoolkit-rsvg)))
> +    (native-inputs
> +     `(("git" ,git)

Same question as above.

Toggle quote (3 lines)

> + ("lv2" ,lv2)

> + ("pkg-config" ,pkg-config)))

> + (synopsis "LFO plugin")

That's quite blunt, and impenetrable for non-domain-experts. Is there

really nothing more you could say about the package? Perhaps expand the

acronym?

Toggle quote (2 lines)

> + (description "ZLFO is a fully featured LFO for CV-based automation

> +that comes as a cross-platform LV2 plugin bundle with a custom UI.")

Consider using Texinfo's @acronym.

Toggle quote (2 lines)

> + (home-page "https://git.zrythm.org/cgit/ZLFO/")

> + (license license:agpl3+)))

Jakub Kądziołka wrote 5 years ago

Recipients:(name . Alexandros Theodotou)(address . alex@zrythm.org)(name . Guix patches)(address . guix-patches@gnu.org)

Message-ID:20200226220822.huzkjdkskfzan2ay@gravity

One more thing: zlfo has a reference to lv2 (see guix size). This
usually means that either it shouldn't be a native input, or the build
process stores the path in the output unnecessarily, increasing the
package closure size.

Ricardo Wurmus wrote 5 years ago

Re: [bug#39784] [PATCH] Add zlfo.

Recipients:(name . Jakub Kądziołka)(address . kuba@kadziolka.net)

Message-ID:87pne0ih5z.fsf@elephly.net

Jakub Kądziołka <kuba@kadziolka.net> writes:

Toggle quote (90 lines)> On Tue, Feb 25, 2020 at 03:06:38PM +0000, Alexandros Theodotou wrote:
>> Hi,
>>
>> This is a new LV2 plugin. It uses Ztoolkit for its UI so I packaged
>> that separately.
>
> Hi,
>
> could you send your patches inline, instead of as an attachment? It
> makes reviews easier. The workflow on your side is easier too, since you
> only need to `git send-email` (available as git:send-email in guix).
> It's fine if you prefer not to do this, though.
>
>> * gnu/packages/audio.scm (ztoolkit): New variable.
>> ---
>>  gnu/packages/audio.scm | 43 ++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 43 insertions(+)
> I'm not sure if audio.scm is the best place for a GUI toolkit. It might
> be fine since audio plugins are the primary usecase, but I'm not sure.
>
>> +(define-public ztoolkit
>> +  (package
>> +    (name "ztoolkit")
>> +    (version "0.1.1")
>> +    (source
>> +      (origin
>> +        (method git-fetch)
>> +        (uri (git-reference
>> +               (url "https://git.zrythm.org/git/ztoolkit")
>> +               (commit (string-append "v" version))))
>> +        (file-name (git-file-name name version))
>> +        (sha256
>> +          (base32
>> +            "07xl3cmdaf7k9mm58m93cn8i1jvgimmiifdw1w7v2jl88nx60pm1"))))
> Please run etc/indent-code.el on your packages.
>
>> +    (build-system meson-build-system)
>> +    (propagated-inputs
>> +     `(("cairo" ,cairo)
>> +       ("libx11" ,libx11)))
> Why are these propagated-inputs? I would've thought that these
> dependencies get linked into the binary, so they don't need to propagate
> to the user's profile.
>
>> +    (native-inputs
>> +     `(("pkg-config" ,pkg-config)
>> +       ("git" ,git)))
> Why the dependency on git? The package seems to build fine without it.
>
>> +    (synopsis "GUI toolkit for LV2 plugins")
>> +    (description "ZToolkit (Ztk) is a cross-platform GUI toolkit heavily
>> +inspired by GTK.  It handles events and low level drawing on behalf of
>> +the user and provides a high-level API for managing the UI and custom
>> +widgets.  ZToolkit is written in C and was created to be used for building
>> +audio plugin UIs, where the dependencies often need to be kept to a
>> +minimum.")
>> +    (home-page "https://git.zrythm.org/cgit/ztoolkit/")
>> +    (license license:agpl3+)))
>
>> +(define-public zlfo
>> +  (package
>> +    (name "zlfo")
>> +    (version "0.1.3")
>> +    (source
>> +      (origin
>> +        (method git-fetch)
>> +        (uri (git-reference
>> +               (url "https://git.zrythm.org/git/ZLFO")
>> +               (commit (string-append "v" version))))
>> +        (file-name (git-file-name name version))
>> +        (sha256
>> +          (base32
>> +            "0bm466ci5xyvxvq7l9p6xyh789lvk6i31b4zja1igqh13akbjnjz"))))
>> +    (build-system meson-build-system)
>> +    (inputs
>> +     `(("ztoolkit-rsvg" ,ztoolkit-rsvg)))
>> +    (native-inputs
>> +     `(("git" ,git)
> Same question as above.
>
>> +       ("lv2" ,lv2)
>> +       ("pkg-config" ,pkg-config)))
>> +    (synopsis "LFO plugin")
> That's quite blunt, and impenetrable for non-domain-experts. Is there
> really nothing more you could say about the package? Perhaps expand the
> acronym?
>
>> +    (description "ZLFO is a fully featured LFO for CV-based automation
>> +that comes as a cross-platform LV2 plugin bundle with a custom UI.")

CV is “control voltage” and LFO is “low frequency oscillator”.  While CV
is sometimes expanded, LFO rarely is, but it wouldn’t hurt to use
“@dfn{low frequency oscillator} (LFO)” here.

What it means is that the plugin outputs a slow waveform (much slower
than audio waveform signals) that can be used to modulate other
parameters in a synthesizer / LV2 plugin network automatically, much
like control voltages are used in (hardware) modular synthesizers to
control parameters of other modules.  A common use case is to modulate
the pitch of an audio oscillator with an LFO so as to produce vibrato
(i.e. the pitch rises and falls periodically, a couple of times per
second, centered around a certain pitch).

I would remove the “cross-platform” because as far as Guix is concerned
packages are available for all platforms that Guix supports.

--
Ricardo

Alexandros Theodotou wrote 5 years ago

Recipients:(address . 39784@debbugs.gnu.org)

Message-ID:7c9f720c38ca4b0286c3c543341936d546dd2820.camel@zrythm.org

Hi,

Thanks for the feedback.

Just updated the patches (see attachment).

Thanks,

Alex

From fc6c3eccadb6cccab9a8e2f0e3f6a74f02f56e6f Mon Sep 17 00:00:00 2001

* gnu/packages/music.scm (zlfo): New variable.

---

gnu/packages/music.scm | 28 ++++++++++++++++++++++++++++

1 file changed, 28 insertions(+)

Toggle diff (38 lines)diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 468be9937f..aba6dda87e 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5213,3 +5213,31 @@ featureful and easy to use.  It offers unlimited automation options, LV2
 plugin support, JACK support and chord assistance.")
    (home-page "https://www.zrythm.org")
    (license license:agpl3+)))
+
+(define-public zlfo
+  (package
+    (name "zlfo")
+    (version "0.1.3")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://git.zrythm.org/git/ZLFO")
+               (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+          (base32
+            "0bm466ci5xyvxvq7l9p6xyh789lvk6i31b4zja1igqh13akbjnjz"))))
+    (build-system meson-build-system)
+    (inputs
+     `(("librsvg" ,librsvg)
+       ("lv2" ,lv2)
+       ("ztoolkit-rsvg" ,ztoolkit-rsvg)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (synopsis "Low frequency oscillator plugin")
+    (description "ZLFO is a fully featured
+@dfn{low frequency oscillator} (LFO) for @dfn{control voltage} (CV)-based
+automation that comes as an LV2 plugin bundle with a custom UI.")
+    (home-page "https://git.zrythm.org/cgit/ZLFO/")
+    (license license:agpl3+)))
-- 
2.25.1

From fbaa53144f4ec96bb725d03aa305e039116e8ca1 Mon Sep 17 00:00:00 2001

* gnu/packages/audio.scm (ztoolkit-rsvg): New variable.

---

gnu/packages/audio.scm | 12 ++++++++++++

1 file changed, 12 insertions(+)

Toggle diff (22 lines)diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index fe951b5153..cb9d830a41 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -4111,3 +4111,15 @@ audio plugin UIs, where the dependencies often need to be kept to a
 minimum.")
     (home-page "https://git.zrythm.org/cgit/ztoolkit/")
     (license license:agpl3+)))
+
+(define-public ztoolkit-rsvg
+  (package
+    (inherit ztoolkit)
+    (name "ztoolkit-rsvg")
+    (arguments
+     `(#:configure-flags `("-Denable_rsvg=true")))
+    (inputs
+     `(("cairo" ,cairo)
+       ("librsvg" ,librsvg)
+       ("libx11" ,libx11)))
+    (synopsis "ZToolkit with SVG support")))
-- 
2.25.1

From f9398e031b8f88fb0cd7be7f9aa63cfd3bc1e825 Mon Sep 17 00:00:00 2001

* gnu/packages/audio.scm (ztoolkit): New variable.

---

gnu/packages/audio.scm | 30 ++++++++++++++++++++++++++++++

1 file changed, 30 insertions(+)

Toggle diff (40 lines)diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index f3edd21c69..fe951b5153 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -4081,3 +4081,33 @@ given plugin and its UI(s) match up with the provided metadata and adhere
 to well-known best practices.")
     (home-page "https://open-music-kontrollers.ch/lv2/lv2lint/")
     (license license:artistic2.0)))
+
+(define-public ztoolkit
+  (package
+    (name "ztoolkit")
+    (version "0.1.1")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://git.zrythm.org/git/ztoolkit")
+               (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+          (base32
+            "07xl3cmdaf7k9mm58m93cn8i1jvgimmiifdw1w7v2jl88nx60pm1"))))
+    (build-system meson-build-system)
+    (inputs
+     `(("cairo" ,cairo)
+       ("libx11" ,libx11)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (synopsis "GUI toolkit for LV2 plugins")
+    (description "ZToolkit (Ztk) is a cross-platform GUI toolkit heavily
+inspired by GTK.  It handles events and low level drawing on behalf of
+the user and provides a high-level API for managing the UI and custom
+widgets.  ZToolkit is written in C and was created to be used for building
+audio plugin UIs, where the dependencies often need to be kept to a
+minimum.")
+    (home-page "https://git.zrythm.org/cgit/ztoolkit/")
+    (license license:agpl3+)))
-- 
2.25.1

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEESBMjhK0999huJUuDAi6uQjE9cPMFAl52Ye4ACgkQAi6uQjE9

cPOnWggAl1k5Y2l8hUw4is38FwnhCx9Hg2dzRvxbTgPD5lvylTriZ+oXQgz64fOf

D6JMf0qDAEjleHOfqiXF2rAjXYiBmBt3ZSMkGwwc9G3ZSx+nGKCBvESPS/LsLlrD

PhuUR1Ucv6MgYgG6tjRifufH1czH3k7R+2QQdxO2oLiFL+Fi4DRGIftzCG8t8mjM

v/0MBLg44YTTuxWYbi6gsAVxjgG789VfeWICpTKtT5SI5MZWQ8ue3OJAcyebxdoa

vLDiSn/D5GkRTRwK6Wat3PO6ykOF1QRfrMthvNoFvlXM9DwGboJvBUGF1YKF9vYj

dSGo8USbYS2Kfuo+MYp0oL8unyWX+w==

=Coo1

-----END PGP SIGNATURE-----

Jakub Kądziołka wrote 5 years ago

Recipients:(name . Alexandros Theodotou)(address . alex@zrythm.org)

Message-ID:20200323144503.nosivm2euxfjhcpi@gravity

Thanks for your updated patches! You still haven't ran indent-code.el on
them, but I fixed that on my side. I also took the liberty to define the
inputs of ztoolkit-rsvg in terms of the ztoolkit package, like this:

@@ -4119,7 +4119,6 @@ minimum.")
     (arguments
      `(#:configure-flags `("-Denable_rsvg=true")))
     (inputs
-     `(("cairo" ,cairo)
-       ("librsvg" ,librsvg)
-       ("libx11" ,libx11)))
+     `(("librsvg" ,librsvg)
+       ,@(package-inputs ztoolkit)))
     (synopsis "ZToolkit with SVG support")))

Your patches have been applied on master, with the last commit being
d3e7282ec35d87842e8143f0230e27fd5ec5e74d

Cheers!

Jakub Kądziołka wrote 5 years ago

close #39784

Recipients:(address . control@debbugs.gnu.org)

Message-ID:20200324110756.euzlxj5gbtgyyng5@gravity

close 39784

thanks

Forgot to change the cc to -done :P

Your comment

This issue is archived.

To comment on this conversation send an email to 39784@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 39784

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags

mumi command -t +confirmed -t +easy

Or, remove the moreinfo tag and set the help tag

mumi command -t -moreinfo -t +help

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date