[PATCH] enable PostScript backend in Evince

  • Open
  • quality assurance status badge
Details
5 participants
  • Nicolò Balzarotti
  • calcium
  • Ludovic Courtès
  • Maxim Cournoyer
  • raingloom
Owner
unassigned
Submitted by
raingloom
Severity
normal
R
R
raingloom wrote on 19 Feb 2020 13:08
(address . guix-patches@gnu.org)
1582114083.2225.0@riseup.net
Some of my teacheres distribute notes in .ps files, so I kinda need
this, and I think others will find it helpful as well.

AFAIK other distros enable it too.

Much easier than converting PostScript files to PDF.
From c767aa2d6a3d779d90e8185e313892eb2212dd37 Mon Sep 17 00:00:00 2001
From: raingloom <raingloom@protonmail.com>
Date: Wed, 19 Feb 2020 12:47:42 +0100
Subject: [PATCH] gnu: evince: --enable-ps

---
gnu/packages/gnome.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Toggle diff (16 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 3c63ab283d..5fae5d11ad 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -1502,7 +1502,8 @@ forgotten when the session ends.")
"05q6v9lssd21623mnj2p49clj9v9csw9kay7n4nklki025grbh1w"))))
(build-system glib-or-gtk-build-system)
(arguments
- `(#:configure-flags '("--disable-nautilus" "--enable-introspection")
+ `(#:configure-flags '("--disable-nautilus" "--enable-introspection"
+ "--enable-ps")
#:phases
(modify-phases %standard-phases
(add-before 'install 'skip-gtk-update-icon-cache
--
2.25.0
N
N
Nicolò Balzarotti wrote on 19 Feb 2020 13:27
87o8tubw3l.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me
Thanks!

I was wondering why it could not open .eps files! I tested the patch,
applies, build and now I can open them. guix size reports +3%
(1009.6 -> 1038.0).

+1 for merging

raingloom <raingloom@riseup.net> writes:

Toggle quote (32 lines)
> Some of my teacheres distribute notes in .ps files, so I kinda need
> this, and I think others will find it helpful as well.
>
> AFAIK other distros enable it too.
>
> Much easier than converting PostScript files to PDF.
>
> From c767aa2d6a3d779d90e8185e313892eb2212dd37 Mon Sep 17 00:00:00 2001
> From: raingloom <raingloom@protonmail.com>
> Date: Wed, 19 Feb 2020 12:47:42 +0100
> Subject: [PATCH] gnu: evince: --enable-ps
>
> ---
> gnu/packages/gnome.scm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 3c63ab283d..5fae5d11ad 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -1502,7 +1502,8 @@ forgotten when the session ends.")
> "05q6v9lssd21623mnj2p49clj9v9csw9kay7n4nklki025grbh1w"))))
> (build-system glib-or-gtk-build-system)
> (arguments
> - `(#:configure-flags '("--disable-nautilus" "--enable-introspection")
> + `(#:configure-flags '("--disable-nautilus" "--enable-introspection"
> + "--enable-ps")
> #:phases
> (modify-phases %standard-phases
> (add-before 'install 'skip-gtk-update-icon-cache
> --
> 2.25.0
N
N
Nicolò Balzarotti wrote on 20 Feb 2020 08:05
8736b591rt.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me
Should we enable DVI too? What are other distributions doing?

Nicolò Balzarotti <anothersms@gmail.com> writes:

Toggle quote (42 lines)
> Thanks!
>
> I was wondering why it could not open .eps files! I tested the patch,
> applies, build and now I can open them. guix size reports +3%
> (1009.6 -> 1038.0).
>
> +1 for merging
>
> raingloom <raingloom@riseup.net> writes:
>
>> Some of my teacheres distribute notes in .ps files, so I kinda need
>> this, and I think others will find it helpful as well.
>>
>> AFAIK other distros enable it too.
>>
>> Much easier than converting PostScript files to PDF.
>>
>> From c767aa2d6a3d779d90e8185e313892eb2212dd37 Mon Sep 17 00:00:00 2001
>> From: raingloom <raingloom@protonmail.com>
>> Date: Wed, 19 Feb 2020 12:47:42 +0100
>> Subject: [PATCH] gnu: evince: --enable-ps
>>
>> ---
>> gnu/packages/gnome.scm | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
>> index 3c63ab283d..5fae5d11ad 100644
>> --- a/gnu/packages/gnome.scm
>> +++ b/gnu/packages/gnome.scm
>> @@ -1502,7 +1502,8 @@ forgotten when the session ends.")
>> "05q6v9lssd21623mnj2p49clj9v9csw9kay7n4nklki025grbh1w"))))
>> (build-system glib-or-gtk-build-system)
>> (arguments
>> - `(#:configure-flags '("--disable-nautilus" "--enable-introspection")
>> + `(#:configure-flags '("--disable-nautilus" "--enable-introspection"
>> + "--enable-ps")
>> #:phases
>> (modify-phases %standard-phases
>> (add-before 'install 'skip-gtk-update-icon-cache
>> --
>> 2.25.0
R
R
raingloom wrote on 23 Feb 2020 00:24
(address . 39674@debbugs.gnu.org)
1582413877.30358.1@riseup.net
Looks like it's an optional feature in Arch, provided by installing the
texlive optional dependency.
Isn't that enough on Guix as well? I have no DVI files on hand to test
it.


On Thu, Feb 20, 2020 at 08:05, Nicolò Balzarotti
<anothersms@gmail.com> wrote:
Toggle quote (51 lines)
> Should we enable DVI too? What are other distributions doing?
>
> Nicolò Balzarotti <anothersms@gmail.com> writes:
>
>> Thanks!
>>
>> I was wondering why it could not open .eps files! I tested the
>> patch,
>> applies, build and now I can open them. guix size reports +3%
>> (1009.6 -> 1038.0).
>>
>> +1 for merging
>>
>> raingloom <raingloom@riseup.net> writes:
>>
>>> Some of my teacheres distribute notes in .ps files, so I kinda need
>>> this, and I think others will find it helpful as well.
>>>
>>> AFAIK other distros enable it too.
>>>
>>> Much easier than converting PostScript files to PDF.
>>>
>>> From c767aa2d6a3d779d90e8185e313892eb2212dd37 Mon Sep 17 00:00:00
>>> 2001
>>> From: raingloom <raingloom@protonmail.com>
>>> Date: Wed, 19 Feb 2020 12:47:42 +0100
>>> Subject: [PATCH] gnu: evince: --enable-ps
>>>
>>> ---
>>> gnu/packages/gnome.scm | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
>>> index 3c63ab283d..5fae5d11ad 100644
>>> --- a/gnu/packages/gnome.scm
>>> +++ b/gnu/packages/gnome.scm
>>> @@ -1502,7 +1502,8 @@ forgotten when the session ends.")
>>>
>>> "05q6v9lssd21623mnj2p49clj9v9csw9kay7n4nklki025grbh1w"))))
>>> (build-system glib-or-gtk-build-system)
>>> (arguments
>>> - `(#:configure-flags '("--disable-nautilus"
>>> "--enable-introspection")
>>> + `(#:configure-flags '("--disable-nautilus"
>>> "--enable-introspection"
>>> + "--enable-ps")
>>> #:phases
>>> (modify-phases %standard-phases
>>> (add-before 'install 'skip-gtk-update-icon-cache
>>> --
>>> 2.25.0
L
L
Ludovic Courtès wrote on 18 Mar 2020 11:02
(name . Nicolò Balzarotti)(address . anothersms@gmail.com)
87imj29e15.fsf@gnu.org
Hi Nicolò & raingloom!

(+ Cc: guix-security)

Nicolò Balzarotti <anothersms@gmail.com> skribis:

Toggle quote (8 lines)
> Thanks!
>
> I was wondering why it could not open .eps files! I tested the patch,
> applies, build and now I can open them. guix size reports +3%
> (1009.6 -> 1038.0).
>
> +1 for merging

I think PostScript support is often disabled by default because of
security issues: PostScript is a very versatile language and Ghostscript
has had a series of problems due to its inability to “sandbox”
PostScript code.

A particularly important issue is thumbnail generation: you could find
yourself running PostScript code without explicitly opening a file.

FWIW, I resort to gv (or ps2pdf) when I need to open a PostScript that I
deem trustworthy.

Leo, Mark, WDYT?

Thanks,
Ludo’.
C
C
calcium wrote on 22 Apr 2022 15:04
[PATCH] enable PostScript backend in Evince
(address . 39674@debbugs.gnu.org)
a9c501cc-9ce0-341c-fced-21411461d4e9@disroot.org
+1 for merging, .ps files are common enough.
M
M
Maxim Cournoyer wrote on 22 Oct 16:17 +0200
(name . Ludovic Courtès)(address . ludo@gnu.org)
87o73c1asx.fsf@gmail.com
Hi,

Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (25 lines)
> Hi Nicolò & raingloom!
>
> (+ Cc: guix-security)
>
> Nicolò Balzarotti <anothersms@gmail.com> skribis:
>
>> Thanks!
>>
>> I was wondering why it could not open .eps files! I tested the patch,
>> applies, build and now I can open them. guix size reports +3%
>> (1009.6 -> 1038.0).
>>
>> +1 for merging
>
> I think PostScript support is often disabled by default because of
> security issues: PostScript is a very versatile language and Ghostscript
> has had a series of problems due to its inability to “sandbox”
> PostScript code.
>
> A particularly important issue is thumbnail generation: you could find
> yourself running PostScript code without explicitly opening a file.
>
> FWIW, I resort to gv (or ps2pdf) when I need to open a PostScript that I
> deem trustworthy.

My opinion is that we should enable it. It's advertised as a
supported format [0]; if there was a serious security issue upstream
would probably drop support for it, or at least hide it behind some
configuration warning, and not advertize it.

Debian, known for its security track record, also has it enabled [1].


--
Thanks,
Maxim
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 39674@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 39674
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch