mongo-tools test fail with Go 1.13

Hi Guix,

After the recent Go 1.13 update, the test for mongo-tools package

(currently at vervsion 3.4.0) fails with:

```

flag provided but not defined: -test.testlogfile

Usage of /tmp/guix-build-mongo-tools-3.4.24.drv-0/go-build972699285/b001/mongofiles.test:

-convey-json

When true, emits results in JSON blocks. Default: 'false'

-convey-silent

When true, all output from GoConvey is suppressed.

-convey-story

When true, emits story output, otherwise emits dot output. When not provided, this flag mirros the value of the '-test.v' flag

-test.types string

Comma-separated list of the types of tests to be run (default "unit")

FAIL github.com/mongodb/mongo-tools/mongofiles 0.002s

FAIL

command "go" "test" "-v" "github.com/mongodb/mongo-tools/mongofiles" failed with status 1

```

I believe that this is related to a change in Go's testing module with

1.13: https://golang.org/doc/go1.13#testing

For more information, also see the Go bug report:

Note that mongo-tools provides a number of tools in different Go packages,

and the mongofiles tool is the only one that has this error.

I have tried to adding a call to flag.Parse() in TestMain, which I added,

as described in the documentation [0], but that did not resolve the

problem. I'm not exactly sure why. The same fix worked for containerd [1].

[0] https://golang.org/pkg/testing/#hdr-Main

[1] http://git.savannah.gnu.org/cgit/guix.git/commit/?id=13c8e747e86e39c0a8c6ec7da8c812d9bbcb682b

I wonder if the difference is that mongofiles does not use the flag

package directly, but flag.Parse() is being called in the wrong place in

one of its dependencies.

A note on versions: the problem persists in the latest release of

mongo-tools in the 3.4 series, 3.4.24. I have not tried the other release

series, 3.6, 4.0, and 4.2 because those require dependencies not yet

packaged in Guix.

I have opened a bug report upstream:

Thoughts or suggestions?

Best,

Jack

On Sun, 16 Feb 2020, Jack Hill wrote:

Upstream reports, "MongoDB 3.4 is now EOL so it is no longer supported.

For MongoDB Tools specifically, we're only making critical fixes to

versions <4.2." Therefore, it seems like the thing to do is to work on

updating our mongo-tools package.

Best,

Jack

Jack Hill <jackhill@jackhill.us> writes:

mongo-tools is definitely failing to build, and it has been since the

11th of Feb (2020) I think.

It seems like you got further in understanding this than I did. Given

that this seems like a test failure, and I don't think there's anything

to suggest that the actual functionality doesn't work, the course of

action I see here is to disable either the failing tests, or running the

test suite entirely.

I originally packaged MongoDB and mongo-tools for Guix, but that was

before the licence of MongoDB changed, so I'm not sure about the long

term future of the packages. Keeping the packages we have actually

building though is still useful.

Thanks,

Chris

On Mon, Jun 22, 2020 at 06:06:44PM +0100, Christopher Baines wrote:

Not having looked into it closely, I think that, in general, test

failures do indicate that actual functionality is broken. Of course it's

a different story in many cases since the Guix build environment is so

unusual.

mongo-tools was removed from Guix in commit

097cf21d1d34f4f66a403c3fb6e15b6709c4dd8a so I'm closing this issue.

Best,

Jack