[PATCH] doc: Clarify documentation of guix environment --expose vs.

  • Done
  • quality assurance status badge
Details
2 participants
  • Damien Cassou
  • Jakub K?dzio?ka
Owner
unassigned
Submitted by
Damien Cassou
Severity
minor
D
D
Damien Cassou wrote on 9 Feb 2020 21:11
(address . guix-patches@gnu.org)
87k14v34hr.fsf@cassou.me
The documentation for --expose and --share parameters are so similar
that the reader has to read both descriptions in parallel to find the
difference.

* doc/guix.texi (Invoking guix environment): Merge the two descriptions
into one, making it much easier to see the difference.

--
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
From a790162f26a2349039955c70f264822dc00986b3 Mon Sep 17 00:00:00 2001
From: Damien Cassou <damien@cassou.me>
Date: Sun, 9 Feb 2020 21:07:04 +0100
Subject: [PATCH] doc: Clarify documentation of guix environment --expose vs.
--share

The documentation for --expose and --share parameters are so similar that the
reader has to read both descriptions in parallel to find the difference.

* doc/guix.texi (Invoking guix environment): Merge the two descriptions into
one, making it much easier to see the difference.
---
doc/guix.texi | 19 ++++---------------
1 file changed, 4 insertions(+), 15 deletions(-)

Toggle diff (39 lines)
diff --git a/doc/guix.texi b/doc/guix.texi
index 56cc333fe4..baa128f6f0 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -4958,8 +4958,10 @@ shared and will change to the user's home directory within the container
instead. See also @code{--user}.
@item --expose=@var{source}[=@var{target}]
-For containers, expose the file system @var{source} from the host system
-as the read-only file system @var{target} within the container. If
+@item --share=@var{source}[=@var{target}]
+For containers, @code{--expose} (resp. @code{--share}) exposes the file
+system @var{source} from the host system as the read-only
+(resp. writable) file system @var{target} within the container. If
@var{target} is not specified, @var{source} is used as the target mount
point in the container.
@@ -4971,19 +4973,6 @@ directory:
guix environment --container --expose=$HOME=/exchange --ad-hoc guile -- guile
@end example
-@item --share=@var{source}[=@var{target}]
-For containers, share the file system @var{source} from the host system
-as the writable file system @var{target} within the container. If
-@var{target} is not specified, @var{source} is used as the target mount
-point in the container.
-
-The example below spawns a Guile REPL in a container in which the user's
-home directory is accessible for both reading and writing via the
-@file{/exchange} directory:
-
-@example
-guix environment --container --share=$HOME=/exchange --ad-hoc guile -- guile
-@end example
@end table
@command{guix environment}
--
2.24.1
J
J
Jakub K?dzio?ka wrote on 14 Feb 2020 23:00
(name . Damien Cassou)(address . damien@cassou.me)(address . 39533-done@debbugs.gnu.org)
20200214220003.azinipkwzd5hrtnf@gravity
On Sun, Feb 09, 2020 at 09:11:44PM +0100, Damien Cassou wrote:
Toggle quote (7 lines)
> The documentation for --expose and --share parameters are so similar
> that the reader has to read both descriptions in parallel to find the
> difference.
>
> * doc/guix.texi (Invoking guix environment): Merge the two descriptions
> into one, making it much easier to see the difference.

Thanks for the patch! I agree that the options are so similar that they
are best described together. I've edited the commit message slightly and
pushed your patch as 459e0967705945bf6b5861598202aefef27451cd.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl5HGGMACgkQ4xWnWEYT
FWQkzA/9HGqmnBgL6khNUaMFbktyz4TqG/uXEg1E98RdmWFpqLRwONkIAjKv3dsE
tBNpkqG8G3I6nEnfqGSaCnilr3yd2n/koCmyzC+WzjAEPHTQAnHxR/rDlYr9WICA
t0zer9QrlQfJP3nfSulhMcpVtgt4YlYWbcDKCt1oAJEHXJSLD4j87d12bKf5Nlm3
Wb4JiI0+sM/pRN0e6TS1DxKgMANNAtW8IFV54J/KCzh2GFUMXYEzmwLf8h1q7tmv
cQlCJP2kM+lht+rsxzplyJ/DUPRP5x/McgRKeRYIBbuDe+TqY/JtbQD64uU6pnjB
SVQnJxYHLypBtAHzUT8ynfrlStW+XTJlSas4UjTR1HLMxWYXX9BP6uieglUSczRO
aN2CTNPzy3VAnCMPvMwcYkWK+ZPum6BWA1ziQtVf3jXHjuG9SHB5MWdC8Bf6+iN3
xaqkwSzL3nTRcEr0ptlcMFga9q+h0kB0Iw6C1QNV8cSbJfNfQeeTMDQ52ATilPHF
wyp76ELt1fI2VmKYm1Psb8KPK+G8R/Q9AnieEBsu7vRAKgWQXICpud4nIRswf7aV
TT2JIPOwcJLXFIvEEQw2UwgFTGvOzTmh2hXMyqppmO84eH9UXWMmF74ChM9MD3kC
kXf3+0cj5Zob0ECM5C9mRMv/P0UFQODG85MpTXUha8t3PiaDPZc=
=wEcN
-----END PGP SIGNATURE-----


Closed
?