[PATCH] gnu: vlc: add fluidsynth as input.

Open

Details

3 participants

Danny Milosavljevic
Jesse Gibbons
Christopher Baines

Owner: unassigned

Submitted by: Jesse Gibbons

Severity: normal

Jesse Gibbons wrote on 25 Jan 2020 02:19

Recipients:(address . guix-patches@gnu.org)

Message-ID:56f17e2eeb450626e36f546d80f0c63a26185c56.camel@gmail.com

* gnu/packages/video.scm (vlc) [inputs]: Add FluidSynth.

---

gnu/packages/video.scm | 1 +

1 file changed, 1 insertion(+)

Toggle diff (13 lines)diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index ee7108753f..53d9a794f8 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1118,6 +1118,7 @@ videoformats depend on the configuration flags of
ffmpeg.")
        ("dbus" ,dbus)
        ("eudev" ,eudev)
        ("flac" ,flac)
+       ("fluidsynth" ,fluidsynth)
        ("ffmpeg" ,ffmpeg)
        ("fontconfig" ,fontconfig)
        ("freetype" ,freetype)

Christopher Baines wrote on 25 Jan 2020 09:35

Recipients:(address . jgibbons2357@gmail.com)(address . 39275@debbugs.gnu.org)

Message-ID:871rro6iis.fsf@cbaines.net

Jesse Gibbons <jgibbons2357@gmail.com> writes:

Toggle quote (19 lines)> * gnu/packages/video.scm (vlc) [inputs]: Add FluidSynth.
> ---
>  gnu/packages/video.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index ee7108753f..53d9a794f8 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -1118,6 +1118,7 @@ videoformats depend on the configuration flags of
> ffmpeg.")
>         ("dbus" ,dbus)
>         ("eudev" ,eudev)
>         ("flac" ,flac)
> +       ("fluidsynth" ,fluidsynth)
>         ("ffmpeg" ,ffmpeg)
>         ("fontconfig" ,fontconfig)
>         ("freetype" ,freetype)

Hi Jesse,

It would be good to put something in the commit message about why this

is happening, as it's not obvious to me at least.

Thanks,

Chris

Danny Milosavljevic wrote on 25 Jan 2020 12:30

Recipients:(address . 39275@debbugs.gnu.org)

Message-ID:20200125123027.50a6ab1a@scratchpost.org

Hi,

I'd prefer to change the subject to "gnu: vlc: Add MIDI support.".

Toggle quote (3 lines)

> It would be good to put something in the commit message about why this

> is happening, as it's not obvious to me at least.

I disagree in general because I've seen before what that leads to:

Half the source code (the comments) end up in the commit messages instead.

Eventually (because of some merge or something) those get lost, or

(because of a new commit) those get hidden.

Now someone is going to overlook it.

So I'd put documentation into comments, except when it's ephemeral ("news").

Also, in the special case of Guix the reason why we add an input later is

"we forgot to add it earlier and it was optional to the package and thus the

package built" most of the time. So the commit message would always be

"we forgot earlier".

In this case, vlc got MIDI support with vlc 0.9.0 (long ago) and nobody

noticed.

We could have the subject say "Add MIDI support" because it communicates more

clearly what this commit does for users. And that's the news :)

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl4sJtMACgkQ5xo1VCww

uqW6kgf+N9sb5cn0u0bbHONcvsSF8EDZsCFubO2yiQFvQ6TnV2WxWZEOOlI8LuNH

Zuwhg3sFDarX9lp2ol3ZMb/rTrmKR7STm3NRFW4bZeVp8kQYxAt7VW5kl29oRR+n

U77/9rNpyeOd0OOcfG6+6suumMWC2VSlw3DbjtcGrwFxJX0n+Z9y8EPn8/WqXW3p

q82laSqg9X/z8e4FT17e8XQJJkBhPSzcEeT/R0ykxc02SDDVSal53EoRNoIuJZqJ

5/n/S7SXbtxU1DkEUHuDA/eajZZpif9pJIq/xy+sGHOSJ2vJqgpGQ26P7TEJCZ9p

IPXYWDMUpMMTG0VOd/OCqyV85SZngg==

=Nvop

-----END PGP SIGNATURE-----

Christopher Baines wrote on 26 Jan 2020 11:23

Recipients:(name . Danny Milosavljevic)(address . dannym@scratchpost.org)

Message-ID:87r1zmikj6.fsf@cbaines.net

Danny Milosavljevic <dannym@scratchpost.org> writes:

Toggle quote (13 lines)> Hi,
>
> I'd prefer to change the subject to "gnu: vlc: Add MIDI support.".
>
>> It would be good to put something in the commit message about why this
>> is happening, as it's not obvious to me at least.
>
> I disagree in general because I've seen before what that leads to:
> Half the source code (the comments) end up in the commit messages instead.
> Eventually (because of some merge or something) those get lost, or
> (because of a new commit) those get hidden.
> Now someone is going to overlook it.

I'm not suggesting documenting code in commit messages, just saying

something about the motivation/intention with the change is useful. The

message you suggest meets this criteria perfectly.

Toggle quote (7 lines)

> So I'd put documentation into comments, except when it's ephemeral ("news").

> Also, in the special case of Guix the reason why we add an input later is

> "we forgot to add it earlier and it was optional to the package and thus the

> package built" most of the time. So the commit message would always be

> "we forgot earlier".

So I would say that "we forgot earlier" isn't a motivation, or

descriptive of intent (although maybe it meets the "why this is

happening" I mentioned earlier, but that was maybe poorly explained)..

Toggle quote (6 lines)

> In this case, vlc got MIDI support with vlc 0.9.0 (long ago) and nobody

> noticed.

> We could have the subject say "Add MIDI support" because it communicates more

> clearly what this commit does for users. And that's the news :)

Yeah, I think that's good. At least in the context I was looking at
this, trying to review the change, knowing what the intent is allows me
to check if that's been satisfied (trying to play some MIDI content with
VLC before and after).

Chris

Jesse Gibbons wrote on 27 Jan 2020 01:56

Recipients:(address . 39275@debbugs.gnu.org)

Message-ID:999e82b162db35d396932eb2c1d5a20f68c00959.camel@gmail.com

On Sun, 2020-01-26 at 10:23 +0000, Christopher Baines wrote:

Toggle quote (56 lines)> 	Error verifying signature: Failed to execute gpg.
> Danny Milosavljevic <dannym@scratchpost.org> writes:
> 
> > Hi,
> > 
> > I'd prefer to change the subject to "gnu: vlc: Add MIDI support.".
> > 
> > > It would be good to put something in the commit message about why
> > > this
> > > is happening, as it's not obvious to me at least.
> > 
> > I disagree in general because I've seen before what that leads to:
> > Half the source code (the comments) end up in the commit messages
> > instead.
> > Eventually (because of some merge or something) those get lost, or
> > (because of a new commit) those get hidden.
> > Now someone is going to overlook it.
> 
> I'm not suggesting documenting code in commit messages, just saying
> something about the motivation/intention with the change is useful.
> The
> message you suggest meets this criteria perfectly.
> 
> > So I'd put documentation into comments, except when it's ephemeral
> > ("news").
> > 
> > Also, in the special case of Guix the reason why we add an input
> > later is
> > "we forgot to add it earlier and it was optional to the package and
> > thus the
> > package built" most of the time.  So the commit message would
> > always be
> > "we forgot earlier".
> 
> So I would say that "we forgot earlier" isn't a motivation, or
> descriptive of intent (although maybe it meets the "why this is
> happening" I mentioned earlier, but that was maybe poorly
> explained)..
> 
> > In this case, vlc got MIDI support with vlc 0.9.0 (long ago) and
> > nobody
> > noticed.
> > 
> > We could have the subject say "Add MIDI support" because it
> > communicates more
> > clearly what this commit does for users.  And that's the news :)
> 
> Yeah, I think that's good. At least in the context I was looking at
> this, trying to review the change, knowing what the intent is allows
> me
> to check if that's been satisfied (trying to play some MIDI content
> with
> VLC before and after).
> 
> Chris

Sorry for not explaining the intention. Do you want me to send a new
patch mentioning the added MIDI support? Should I put that in the
commit title, or in a comment?

Christopher Baines wrote on 27 Jan 2020 09:09

Recipients:(name . Jesse Gibbons)(address . jgibbons2357@gmail.com)

Message-ID:87o8upialv.fsf@cbaines.net

Jesse Gibbons <jgibbons2357@gmail.com> writes:

Toggle quote (61 lines)> On Sun, 2020-01-26 at 10:23 +0000, Christopher Baines wrote:
>> 	Error verifying signature: Failed to execute gpg.
>> Danny Milosavljevic <dannym@scratchpost.org> writes:
>>
>> > Hi,
>> >
>> > I'd prefer to change the subject to "gnu: vlc: Add MIDI support.".
>> >
>> > > It would be good to put something in the commit message about why
>> > > this
>> > > is happening, as it's not obvious to me at least.
>> >
>> > I disagree in general because I've seen before what that leads to:
>> > Half the source code (the comments) end up in the commit messages
>> > instead.
>> > Eventually (because of some merge or something) those get lost, or
>> > (because of a new commit) those get hidden.
>> > Now someone is going to overlook it.
>>
>> I'm not suggesting documenting code in commit messages, just saying
>> something about the motivation/intention with the change is useful.
>> The
>> message you suggest meets this criteria perfectly.
>>
>> > So I'd put documentation into comments, except when it's ephemeral
>> > ("news").
>> >
>> > Also, in the special case of Guix the reason why we add an input
>> > later is
>> > "we forgot to add it earlier and it was optional to the package and
>> > thus the
>> > package built" most of the time.  So the commit message would
>> > always be
>> > "we forgot earlier".
>>
>> So I would say that "we forgot earlier" isn't a motivation, or
>> descriptive of intent (although maybe it meets the "why this is
>> happening" I mentioned earlier, but that was maybe poorly
>> explained)..
>>
>> > In this case, vlc got MIDI support with vlc 0.9.0 (long ago) and
>> > nobody
>> > noticed.
>> >
>> > We could have the subject say "Add MIDI support" because it
>> > communicates more
>> > clearly what this commit does for users.  And that's the news :)
>>
>> Yeah, I think that's good. At least in the context I was looking at
>> this, trying to review the change, knowing what the intent is allows
>> me
>> to check if that's been satisfied (trying to play some MIDI content
>> with
>> VLC before and after).
>>
>> Chris
>
> Sorry for not explaining the intention. Do you want me to send a new
> patch mentioning the added MIDI support? Should I put that in the
> commit title, or in a comment?

Sending a new patch would be great. Adding something anywhere in the

commit message is fine by me.

Thanks,

Chris

Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 39275@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 39275

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date