pelzflorian (Florian Pelz) wrote 5 years ago
(address . guix-patches@gnu.org)
20200115124810.j3myokleoa7le3sq@pelzflorian.localdomain
This series updates USB_ModeSwitch and its data package to their
November release.
Update USB_ModeSwitch.
- Done
Details
- 3 participants
- Danny Milosavljevic
- Christopher Baines
- pelzflorian (Florian Pelz)
- Owner
- unassigned
- Submitted by
- pelzflorian (Florian Pelz)
- Severity
- normal
Florian Pelz wrote 5 years ago
[PATCH 1/2] gnu: USB_ModeSwitch: Update to 2.6.0.
(address . 39142@debbugs.gnu.org)
20200115125031.ky2czidsqep3of4m@pelzflorian.localdomain
Florian Pelz wrote 5 years ago
[PATCH 2/2] gnu: USB_ModeSwitch data: Update to 20191128.
(address . 39142@debbugs.gnu.org)
20200115125056.qfayoyyotuyttudp@pelzflorian.localdomain
* gnu/packages/usb-modeswitch.scm (usb-modeswitch-data): Update to 20191128.
[source] Use HTTPS.
[home-page] Use HTTPS.
---
gnu/packages/usb-modeswitch.scm | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Toggle diff (34 lines)
diff --git a/gnu/packages/usb-modeswitch.scm b/gnu/packages/usb-modeswitch.scm
index 8f3edc7f43..6de810d23d 100644
--- a/gnu/packages/usb-modeswitch.scm
+++ b/gnu/packages/usb-modeswitch.scm
@@ -32,15 +32,15 @@
(define-public usb-modeswitch-data
(package
(name "usb-modeswitch-data")
- (version "20170806")
+ (version "20191128")
(source (origin
(method url-fetch)
(uri (string-append
- "http://www.draisberghof.de/usb_modeswitch/"
+ "https://www.draisberghof.de/usb_modeswitch/"
"usb-modeswitch-data-" version ".tar.bz2"))
(sha256
(base32
- "0b1wari3aza6qjggqd0hk2zsh93k1q8scgmwh6f8wr0flpr3whff"))))
+ "1ygahl3r26r38ai8yyblq9nhf3v5i6n6r6672p5wf88wg5h9n0rz"))))
(build-system trivial-build-system)
(native-inputs `(("tar" ,tar)
("bzip2" ,bzip2)))
@@ -67,7 +67,7 @@
(install-file (string-append files "/40-usb_modeswitch.rules")
udev-dir)
(install-file (string-append files "/COPYING") license-dir)))))
- (home-page "http://www.draisberghof.de/usb_modeswitch/")
+ (home-page "https://www.draisberghof.de/usb_modeswitch/")
(synopsis "Data package for USB_ModeSwitch")
(description "This package contains data about devices and a UDEV rules
file for use with USB_ModeSwitch.")
--
2.24.1
Christopher Baines wrote 5 years ago
Re: [bug#39142] Update USB_ModeSwitch.
(address . pelzflorian@pelzflorian.de)(address . 39142@debbugs.gnu.org)
87sgkdovdm.fsf@cbaines.net
pelzflorian (Florian Pelz) <pelzflorian@pelzflorian.de> writes:
Toggle quote (3 lines)
> This series updates USB_ModeSwitch and its data package to their
> November release.
Both patches look good to me :)
There's a somewhat uninformative comparison of Guix without these
patches, and Guix with these patches here [1].
But what it does show is that there aren't any additional lint warnings,
and the derivations can be computed.
I also tried building the derivations on x86_64-linux, and they built :D
-----BEGIN PGP SIGNATURE-----
iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl4i7CVfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE
9XcKIw/+LqEmOWOksdjGPfRSIwvOIosnMr5peMDLrXdwZL0aSszlvG7tWYr9M3vI
1gED69rhc18yt5I8Apebgeqi0N4il9N1meqbEW+VPI3VUcts7JRwc+hmS2JNnOiH
V3txFzCnWec1WVJCta91am9oz9tftnQqRFYlymLA090lxRIOb7ni88J2VPMzp/bJ
BfxwYbrvRK/sZmsu/lB4WghUzMBY9+jNo5LkGA8q5sLcDT+eO9cIkvE4ZcRlu8/W
58Sk4N9/NfrNgl+fch2CvKFMnVUPx8v7hYKev5eN5mhXUk2vb2hMasDcoOFLOuks
nr8Qty7PjZztaZth2zXVSIu/P+Q9Cmy/ffFjpOUjPUSlh9g2GKbx08piodZztfH2
uTpdTLEDUUZ8ZiS1lshdZfNzJMhtunmsmVb75y6ohzx4t5UgiqJSCmSlhcInIAkH
vigH3GbithWDVybBB41+8tzpzV3ldNIywaOzJgekFbuYEAmSbI3+4GIl0eEgq2K0
wAyUkCsfDCJerVIizARgxCvdzaZZoN3Ba2VFraAojy2YpelIhwaJZqQiT+k7QAXZ
XfM7WtE+3swXhzqvnHEEksRLr3rAOe1nVTjPfsTsQQ7L/o8jCuDX3sqEfcAaHS8m
k62w2PyvlKiILCzmq0vLSJylnT03WXJASFUSK6Qn9K0ROP+EEak=
=XfhU
-----END PGP SIGNATURE-----
Danny Milosavljevic wrote 5 years ago
(name . Christopher Baines)(address . mail@cbaines.net)
20200118125238.3423c25d@scratchpost.org
Hi,
On Sat, 18 Jan 2020 11:29:41 +0000
Christopher Baines <mail@cbaines.net> wrote:
Toggle quote (2 lines)
Very nice!
In general, I suggest to also list license changes. Whether we like it or
not, in practice those happen and it's important to know (especially to know
when they stay the same).
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl4i8YYACgkQ5xo1VCww
uqXy7gf9G/n5TW5GIlKjHUF35tQ/UNdZ1/wEjVe94RLjS8MTXo0kv/MOLP0JQBdA
nr8PB7Ia9NK/UVfdqLWp5bh4bU/hlDxoNSzbaVSuB4E2zlMRdZ1bKpFYfTYgOxZV
qdfqxyPXF/jq96OxkHBEBT5rwd9B/YK0PliKdEP33eNBWNrlYd4oLs0OQ5j4o10S
HIteCnEhSm+Dg/ZGDgNI0dkDXfkPkA3TpiE5yVgZ63V+F5cgC6Mqm2qoekKs+lOG
wmCmaQr1xl6f0QcgG8pVt2TgJWCBuU0GCTbBH0urkTzz3iU3/lSRzm72bqyk391I
5yGZB+apBZ+PE6Z7fGF46INj7gsZCA==
=iWEG
-----END PGP SIGNATURE-----
Christopher Baines wrote 5 years ago
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)
87r1zxotuh.fsf@cbaines.net
Danny Milosavljevic <dannym@scratchpost.org> writes:
Toggle quote (9 lines)
> Hi,
>
> On Sat, 18 Jan 2020 11:29:41 +0000
> Christopher Baines <mail@cbaines.net> wrote:
>
>> 1: https://guix-patches-data.cbaines.net/compare?base_commit=9edae6c05cd879393d59702f033f4c3ccce30dba&target_commit=0115c829cc1021b01b1686c5d28a7f6004390c83
>
> Very nice!
Thanks :)
Toggle quote (4 lines)
> In general, I suggest to also list license changes. Whether we like it or
> not, in practice those happen and it's important to know (especially to know
> when they stay the same).
So, the Guix Data Service does know what licenses are associated with a
package. I guess it could list packages where that's changed on the main
comparison page, is that what you're referring to?
In my mind at least, the primary issue when reviewing packages is making
sure the license list for the package corresponds with the actual
licenses that apply to the contents. That's a little harder, as you'd
have to download the source tarball, and run licensecheck or something
similar, but hopefully that can be automated at some point!
Chris
-----BEGIN PGP SIGNATURE-----
iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl4i8+ZfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE
9XeYEw/+PoB4qYWm/bpW7Or6oRKyj5M1rXWZx58f1RMxRhdPJlO+WDSUl6Bqz7rr
+Q7VE9+OCC0L9YTRNUPalPMrR6GmxG8STW+Ff+H8sLK6cMuFwOMxOfTdaet8JwFW
ha9huyheL+KPnAI7xKf1R0Iu7HD+2aZA4qQFZYsWtKiwUqve7FdbonEssQddFI9W
33eopZpUornreFRjGvTeBSg4+WDLLwlCtbEVsuJbFGguHwNOHAmz2M75jp5HVCsk
AdXdw+soan0rn34nkhWc+5fASeWErxtr3JIeBpy336DpSWn/ttzQs+Ukke2dyEK8
xFG8yLGdy0QP1b1Wtc83lz8dDiE0VrmTqBHQFdNf1p5tYSMQ/t4JdvmGOpAPwrmq
X+I6gc0hqyRpB0vIf93WuF9F+eCv/D8n1HQ6n+BubFNDfMioWLYw4xLvEBfrxwjj
4gyIGxP8tvKn3Gja+wKYkfbbZ8T4RlzuW0/IVJsW16AGiBrgGH1JA1m1ortHaxLq
F/Tlg2walCkRl1ZUinA5h0yZFrRmhmjsi8bYWsqFIjfvUaCWNQJnJl3DztfK62B+
Jy5ZJwlXCQomp6iLGqS+oOPMYW+AGXJaix9trbOZKIM+9dPPrXXNc3c1nVd7i1W9
MgRsZbAeDWF2TjTfjd0/A7i94jv+FjPn10HD/xHqQTTb0LYWysk=
=QRnO
-----END PGP SIGNATURE-----
Danny Milosavljevic wrote 5 years ago
(name . Christopher Baines)(address . mail@cbaines.net)
20200119111129.48f3eaa3@scratchpost.org
Hi,
On Sat, 18 Jan 2020 12:02:46 +0000
Christopher Baines <mail@cbaines.net> wrote:
Toggle quote (8 lines)
> > In general, I suggest to also list license changes. Whether we like it or
> > not, in practice those happen and it's important to know (especially to know
> > when they stay the same).
>
> So, the Guix Data Service does know what licenses are associated with a
> package. I guess it could list packages where that's changed on the main
> comparison page, is that what you're referring to?
Yes, on that ".../compare" page, just like "Version changes" there could be
an always-visible section "License changes".
Toggle quote (6 lines)
> In my mind at least, the primary issue when reviewing packages is making
> sure the license list for the package corresponds with the actual
> licenses that apply to the contents. That's a little harder, as you'd
> have to download the source tarball, and run licensecheck or something
> similar, but hopefully that can be automated at some point!
I'm not sure that that could ever be reliably automated (after all, the source
code can say whatever license text in the comments--we can't have an
exhaustive list).
In general it would already be much help to automate basically
grep -ri 'gnu general' $(grep -ril license .)
just in order to reduce the workload. But I think we already package third
party license checkers for that, no need to do that for Guix Data Service.
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl4kK1EACgkQ5xo1VCww
uqVRYwgAiok6svZdsi1bfimftZTMZtLBuuWgWbw6VOI+ucEwBx/SUhbZcNo2Eo4d
eI7h0ekuIeDAXm9RFEPjwMTshRNUko5HlH16uIm/1ZjSSUWi1Pf4bQdNOi5m1hIK
HTUxgCH9wNXewxtWqx+ySBzS3b9OOs+FWg0yxuCcRjF4BdmKcCcO7aMgeAd58ZLE
Ax8q1zApqpcPUyA4l0qC4heh0Xa1MyhNu8dW74AeIwctcJAoPJyrX8zs7M+9pJC7
wbcrtD/sKfsHxpA7cGJbSbstmeTkgGw72HpapWOnHbw/I2IJcPzjNH3Btohcbsh2
3z2mDBaQp324yhIpX/nJMsPY/dYQgg==
=zPj2
-----END PGP SIGNATURE-----
pelzflorian (Florian Pelz) wrote 5 years ago
(name . Christopher Baines)(address . mail@cbaines.net)(address . 39142-done@debbugs.gnu.org)
20200120090338.5otoyrppuhsp4p23@pelzflorian.localdomain
On Sat, Jan 18, 2020 at 11:29:41AM +0000, Christopher Baines wrote:
Toggle quote (9 lines)
>
> pelzflorian (Florian Pelz) <pelzflorian@pelzflorian.de> writes:
>
> > This series updates USB_ModeSwitch and its data package to their
> > November release.
>
> Both patches look good to me :)
>
Thank you for the review! Pushed as
d0759f613480c13b8c81716eb46dc3606b3a34b0 and
17fe068ed7372dbae09043885b8f091105bef143.
Closing this bug.
Toggle quote (9 lines)
> There's a somewhat uninformative comparison of Guix without these
> patches, and Guix with these patches here [1].
>
> 1: https://guix-patches-data.cbaines.net/compare?base_commit=9edae6c05cd879393d59702f033f4c3ccce30dba&target_commit=0115c829cc1021b01b1686c5d28a7f6004390c83
>
> But what it does show is that there aren't any additional lint warnings,
> and the derivations can be computed.
>
I do not see the first patch there, but it should be OK. I have built
it on armhf and x86_64 and successfully modeswitched.
Regards,
Florian
Closed
?