[PATCH] Clarify description of the Pagekite service.

  • Done
  • quality assurance status badge
Details
2 participants
  • Alex Griffin
  • Florian Pelz
Owner
unassigned
Submitted by
Florian Pelz
Severity
normal

Debbugs page

Florian Pelz wrote 5 years ago
(address . guix-patches@gnu.org)
20200109073128.wi5gsntnypxw4dmn@pelzflorian.localdomain
* doc/guix.texi (Networking Services): Make clear Pagekite is not necessary
with port forwarding.
---
doc/guix.texi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (17 lines)
diff --git a/doc/guix.texi b/doc/guix.texi
index df1ba428a5..2a860db4c8 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -14154,8 +14154,8 @@ Package object of the Open vSwitch.
@defvr {Scheme Variable} pagekite-service-type
This is the service type for the @uref{https://pagekite.net, PageKite} service,
a tunneling solution for making localhost servers publicly visible, even from
-behind NAT or restrictive firewalls. The value for this service type is a
-@code{pagekite-configuration} record.
+behind restrictive firewalls or NAT without forwarded ports. The value for
+this service type is a @code{pagekite-configuration} record.
Here's an example exposing the local HTTP and SSH daemons:
--
2.24.1
pelzflorian (Florian Pelz) wrote 5 years ago
(name . Alex Griffin)(address . a@ajgrf.com)(address . 39048@debbugs.gnu.org)
20200109074212.elii3ebtr5j3pz2u@pelzflorian.localdomain
Hello Alex Griffin,

I see that you added the Pagekite service to Guix and am thankful for
that and for showing me that Pagekite exists. However I believe users
not familiar with setting up servers could think they need Pagekite in
cases where configuring their NAT to do port forwarding would be
enough.

On Thu, Jan 09, 2020 at 08:31:28AM +0100, Florian Pelz wrote:
Toggle quote (28 lines)
> * doc/guix.texi (Networking Services): Make clear Pagekite is not necessary
> with port forwarding.
> ---
> doc/guix.texi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index df1ba428a5..2a860db4c8 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -14154,8 +14154,8 @@ Package object of the Open vSwitch.
> @defvr {Scheme Variable} pagekite-service-type
> This is the service type for the @uref{https://pagekite.net, PageKite} service,
> a tunneling solution for making localhost servers publicly visible, even from
> -behind NAT or restrictive firewalls. The value for this service type is a
> -@code{pagekite-configuration} record.
> +behind restrictive firewalls or NAT without forwarded ports. The value for
> +this service type is a @code{pagekite-configuration} record.
>
> Here's an example exposing the local HTTP and SSH daemons:
>
> --
> 2.24.1
>
>
>
>

I propose this change; do you approve?

Regards,
Florian
Alex Griffin wrote 5 years ago
(name . pelzflorian (Florian Pelz))(address . pelzflorian@pelzflorian.de)(address . 39048@debbugs.gnu.org)
5e5b2946-96ca-4f1a-8335-2c39208fa46f@www.fastmail.com
Hello Florian Pelz,

Looks good to me, go ahead and make the change if you wish!

--
Alex Griffin
pelzflorian (Florian Pelz) wrote 5 years ago
(name . Alex Griffin)(address . a@ajgrf.com)(address . 39048-done@debbugs.gnu.org)
20200111000518.l7vshpfg6de3zjcj@pelzflorian.localdomain
On Fri, Jan 10, 2020 at 10:40:13PM +0000, Alex Griffin wrote:
Toggle quote (7 lines)
> Hello Florian Pelz,
>
> Looks good to me, go ahead and make the change if you wish!
>
> --
> Alex Griffin

Thank you! I added a doc: prefix to the commit message and pushed as
f22b35711323a1e101ed666ec5ce776bf1908a74

Regards,
Florian
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 39048@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 39048
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help