Recent changes to emacs build system

DoneSubmitted by brettg.
Details
2 participants
  • brettg
  • Maxim Cournoyer
Owner
unassigned
Severity
normal
B
B
brettg wrote on 18 Nov 2019 20:01
(name . Bug guix)(address . Bug-guix@gnu.org)
e200324c2d4535bc2044956fcdebc2ff@posteo.net
Hey all, the recent changes to the emacs build system result in a few broken packages like emacs-pdf-tools, or basically anything that uses a phase for emacs-set-emacs-load-path.
For example, I borrowed the technique used by emacs-pdf-tools to package emacs-telega, resulting in both packages failing to build:
Here is the code for emacs-telega:
https://git.sr.ht/~brettgilio/cfg/tree/master/channel/non-gnu/packages/emacs-xyz.scm#L99
The issue is in this phase for both emacs-pdf-tools and my channel package:
(add-after 'compress-documentation 'emacs-set-emacs-load-path (assoc-ref emacs:%standard-phases 'set-emacs-load-path))
Resulting in:
starting phase `emacs-set-emacs-load-path'Backtrace: 5 (primitive-load "/gnu/store/5b1p1gsvfyi4fbx4s42rhab2dns…")In ice-9/eval.scm: 191:35 4 (_ _)In ice-9/boot-9.scm: 829:9 3 (catch _ _ #<procedure 7ffff3bbb518 at /gnu/store/zmkg…> …)In srfi/srfi-1.scm: 863:16 2 (every1 #<procedure 7ffff30ae160 at /gnu/store/zmkgrvv…> …)In /gnu/store/zmkgrvvhmrix2b1z7id6zrg9bb7qxzdl-module-import/guix/build/gnu-build-system.scm: 839:30 1 (_ _)In unknown file: 0 (_ #:source "/gnu/store/qw8xbmk6ryl9a2jrp0gip3yffmsdix…" …)
ERROR: Wrong type to apply: #f
If we suspect that changes are going to be non-backwards compatible could we use the news system to pass along that message? Much appreciated. Thanks.
Brett Gilio
B
B
brettg wrote on 18 Nov 2019 21:28
(name . Bug guix)(address . Bug-guix@gnu.org)(name . bug-Guix)(address . bug-guix-bounces+brettg=posteo.net@gnu.org)
848bb376e0d6e171347afe53ce79bd96@posteo.net
On 18.11.2019 20:01, brettg@posteo.net wrote:
Toggle quote (45 lines)> Hey all, the recent changes to the emacs build system result in a few> broken packages like emacs-pdf-tools, or basically anything that uses> a phase for emacs-set-emacs-load-path.> > For example, I borrowed the technique used by emacs-pdf-tools to> package emacs-telega, resulting in both packages failing to build:> > Here is the code for emacs-telega:> > https://git.sr.ht/~brettgilio/cfg/tree/master/channel/non-gnu/packages/emacs-xyz.scm#L99> > The issue is in this phase for both emacs-pdf-tools and my channel > package:> > (add-after 'compress-documentation 'emacs-set-emacs-load-path> (assoc-ref emacs:%standard-phases 'set-emacs-load-path))> > Resulting in:> > starting phase `emacs-set-emacs-load-path'> Backtrace:> 5 (primitive-load "/gnu/store/5b1p1gsvfyi4fbx4s42rhab2dns…")> In ice-9/eval.scm:> 191:35 4 (_ _)> In ice-9/boot-9.scm:> 829:9 3 (catch _ _ #<procedure 7ffff3bbb518 at /gnu/store/zmkg…> > …)> In srfi/srfi-1.scm:> 863:16 2 (every1 #<procedure 7ffff30ae160 at /gnu/store/zmkgrvv…> > …)> In> /gnu/store/zmkgrvvhmrix2b1z7id6zrg9bb7qxzdl-module-import/guix/build/gnu-build-system.scm:> 839:30 1 (_ _)> In unknown file:> 0 (_ #:source "/gnu/store/qw8xbmk6ryl9a2jrp0gip3yffmsdix…" > …)> > ERROR: Wrong type to apply: #f> > If we suspect that changes are going to be non-backwards compatible> could we use the news system to pass along that message? Much> appreciated. Thanks.> > Brett Gilio
I applied a hotfix to the package by replacing 'set-emacs-load-path with 'add-source-to-load-path. I believe this fix would work for all other affected packages.
B
B
brettg wrote on 18 Nov 2019 21:33
(name . Bug guix)(address . Bug-guix@gnu.org)(name . bug-Guix)(address . bug-guix-bounces+brettg=posteo.net@gnu.org)
421db4d1a206488fa1883e40666846c5@posteo.net
On 18.11.2019 21:28, brettg@posteo.net wrote:
Toggle quote (51 lines)> On 18.11.2019 20:01, brettg@posteo.net wrote:>> Hey all, the recent changes to the emacs build system result in a few>> broken packages like emacs-pdf-tools, or basically anything that uses>> a phase for emacs-set-emacs-load-path.>> >> For example, I borrowed the technique used by emacs-pdf-tools to>> package emacs-telega, resulting in both packages failing to build:>> >> Here is the code for emacs-telega:>> >> https://git.sr.ht/~brettgilio/cfg/tree/master/channel/non-gnu/packages/emacs-xyz.scm#L99>> >> The issue is in this phase for both emacs-pdf-tools and my channel >> package:>> >> (add-after 'compress-documentation 'emacs-set-emacs-load-path>> (assoc-ref emacs:%standard-phases 'set-emacs-load-path))>> >> Resulting in:>> >> starting phase `emacs-set-emacs-load-path'>> Backtrace:>> 5 (primitive-load >> "/gnu/store/5b1p1gsvfyi4fbx4s42rhab2dns…")>> In ice-9/eval.scm:>> 191:35 4 (_ _)>> In ice-9/boot-9.scm:>> 829:9 3 (catch _ _ #<procedure 7ffff3bbb518 at /gnu/store/zmkg…> >> …)>> In srfi/srfi-1.scm:>> 863:16 2 (every1 #<procedure 7ffff30ae160 at /gnu/store/zmkgrvv…> >> …)>> In>> /gnu/store/zmkgrvvhmrix2b1z7id6zrg9bb7qxzdl-module-import/guix/build/gnu-build-system.scm:>> 839:30 1 (_ _)>> In unknown file:>> 0 (_ #:source "/gnu/store/qw8xbmk6ryl9a2jrp0gip3yffmsdix…" >> …)>> >> ERROR: Wrong type to apply: #f>> >> If we suspect that changes are going to be non-backwards compatible>> could we use the news system to pass along that message? Much>> appreciated. Thanks.>> >> Brett Gilio> > I applied a hotfix to the package by replacing 'set-emacs-load-path> with 'add-source-to-load-path. I believe this fix would work for all> other affected packages.
B
B
brettg wrote on 18 Nov 2019 22:34
(name . bug-Guix)(address . bug-guix-bounces+brettg=posteo.net@gnu.org)
805ec3dde9328f427bc34126c36735d3@posteo.net
On 18.11.2019 21:33, brettg@posteo.net wrote:
Toggle quote (54 lines)> On 18.11.2019 21:28, brettg@posteo.net wrote:>> On 18.11.2019 20:01, brettg@posteo.net wrote:>>> Hey all, the recent changes to the emacs build system result in a few>>> broken packages like emacs-pdf-tools, or basically anything that uses>>> a phase for emacs-set-emacs-load-path.>>> >>> For example, I borrowed the technique used by emacs-pdf-tools to>>> package emacs-telega, resulting in both packages failing to build:>>> >>> Here is the code for emacs-telega:>>> >>> https://git.sr.ht/~brettgilio/cfg/tree/master/channel/non-gnu/packages/emacs-xyz.scm#L99>>> >>> The issue is in this phase for both emacs-pdf-tools and my channel >>> package:>>> >>> (add-after 'compress-documentation 'emacs-set-emacs-load-path>>> (assoc-ref emacs:%standard-phases 'set-emacs-load-path))>>> >>> Resulting in:>>> >>> starting phase `emacs-set-emacs-load-path'>>> Backtrace:>>> 5 (primitive-load >>> "/gnu/store/5b1p1gsvfyi4fbx4s42rhab2dns…")>>> In ice-9/eval.scm:>>> 191:35 4 (_ _)>>> In ice-9/boot-9.scm:>>> 829:9 3 (catch _ _ #<procedure 7ffff3bbb518 at /gnu/store/zmkg…> >>> …)>>> In srfi/srfi-1.scm:>>> 863:16 2 (every1 #<procedure 7ffff30ae160 at /gnu/store/zmkgrvv…> >>> …)>>> In>>> /gnu/store/zmkgrvvhmrix2b1z7id6zrg9bb7qxzdl-module-import/guix/build/gnu-build-system.scm:>>> 839:30 1 (_ _)>>> In unknown file:>>> 0 (_ #:source "/gnu/store/qw8xbmk6ryl9a2jrp0gip3yffmsdix…" >>> …)>>> >>> ERROR: Wrong type to apply: #f>>> >>> If we suspect that changes are going to be non-backwards compatible>>> could we use the news system to pass along that message? Much>>> appreciated. Thanks.>>> >>> Brett Gilio>> >> I applied a hotfix to the package by replacing 'set-emacs-load-path>> with 'add-source-to-load-path. I believe this fix would work for all>> other affected packages.> > https://git.sr.ht/~brettgilio/cfg/commit/c24a6db9d25151c487e9db675bd74e4bb3912173
Ricardo, just wanted to make you aware that this emacs-build-system change does break your guile-studio. I discovered this because I adopted some of your ideas of autoloading in the generated emacs lisp from guile-studio when creating my own emacs configuration dependent on guix, which resulted in
progn: Wrong number of arguments: (lambda nil "Autoload Emacs packages found in EMACSLOADPATH.
'Autoload' means to load the 'autoloads' files matching`guix-emacs-autoloads-regexp'." (interactive) (let* ((emacs-load-path (getenv "EMACSLOADPATH")) (emacs-non-core-load-path-directories (seq-filter (function (lambda (dir) (string-match-p "/share/emacs/site-lisp" dir))) (split-string emacs-load-path ":"))) (autoloads (mapcan (function guix-emacs-find-autoloads) emacs-non-core-load-path-directories))) (mapc (function (lambda (f) (load f (quote noerror)))) autoloads))), 78
I'll let you know if I can find any fix for this when I get some time. But just wanted to pass the message along.
Brett
B
B
brettg wrote on 19 Nov 2019 01:27
(name . bug-Guix)(address . bug-guix-bounces+brettg=posteo.net@gnu.org)
70112f45226b44a1234a4d41aa7ac610@posteo.net
On 18.11.2019 22:34, brettg@posteo.net wrote:
Toggle quote (80 lines)> On 18.11.2019 21:33, brettg@posteo.net wrote:>> On 18.11.2019 21:28, brettg@posteo.net wrote:>>> On 18.11.2019 20:01, brettg@posteo.net wrote:>>>> Hey all, the recent changes to the emacs build system result in a >>>> few>>>> broken packages like emacs-pdf-tools, or basically anything that >>>> uses>>>> a phase for emacs-set-emacs-load-path.>>>> >>>> For example, I borrowed the technique used by emacs-pdf-tools to>>>> package emacs-telega, resulting in both packages failing to build:>>>> >>>> Here is the code for emacs-telega:>>>> >>>> https://git.sr.ht/~brettgilio/cfg/tree/master/channel/non-gnu/packages/emacs-xyz.scm#L99>>>> >>>> The issue is in this phase for both emacs-pdf-tools and my channel >>>> package:>>>> >>>> (add-after 'compress-documentation 'emacs-set-emacs-load-path>>>> (assoc-ref emacs:%standard-phases 'set-emacs-load-path))>>>> >>>> Resulting in:>>>> >>>> starting phase `emacs-set-emacs-load-path'>>>> Backtrace:>>>> 5 (primitive-load >>>> "/gnu/store/5b1p1gsvfyi4fbx4s42rhab2dns…")>>>> In ice-9/eval.scm:>>>> 191:35 4 (_ _)>>>> In ice-9/boot-9.scm:>>>> 829:9 3 (catch _ _ #<procedure 7ffff3bbb518 at >>>> /gnu/store/zmkg…> …)>>>> In srfi/srfi-1.scm:>>>> 863:16 2 (every1 #<procedure 7ffff30ae160 at >>>> /gnu/store/zmkgrvv…> …)>>>> In>>>> /gnu/store/zmkgrvvhmrix2b1z7id6zrg9bb7qxzdl-module-import/guix/build/gnu-build-system.scm:>>>> 839:30 1 (_ _)>>>> In unknown file:>>>> 0 (_ #:source >>>> "/gnu/store/qw8xbmk6ryl9a2jrp0gip3yffmsdix…" …)>>>> >>>> ERROR: Wrong type to apply: #f>>>> >>>> If we suspect that changes are going to be non-backwards compatible>>>> could we use the news system to pass along that message? Much>>>> appreciated. Thanks.>>>> >>>> Brett Gilio>>> >>> I applied a hotfix to the package by replacing 'set-emacs-load-path>>> with 'add-source-to-load-path. I believe this fix would work for all>>> other affected packages.>> >> https://git.sr.ht/~brettgilio/cfg/commit/c24a6db9d25151c487e9db675bd74e4bb3912173> > Ricardo, just wanted to make you aware that this emacs-build-system> change does break your guile-studio. I discovered this because I> adopted some of your ideas of autoloading in the generated emacs lisp> from guile-studio when creating my own emacs configuration dependent> on guix, which resulted in> > progn: Wrong number of arguments: (lambda nil "Autoload Emacs packages> found in EMACSLOADPATH.> > 'Autoload' means to load the 'autoloads' files matching> `guix-emacs-autoloads-regexp'." (interactive) (let* ((emacs-load-path> (getenv "EMACSLOADPATH")) (emacs-non-core-load-path-directories> (seq-filter (function (lambda (dir) (string-match-p> "/share/emacs/site-lisp" dir))) (split-string emacs-load-path ":")))> (autoloads (mapcan (function guix-emacs-find-autoloads)> emacs-non-core-load-path-directories))) (mapc (function (lambda (f)> (load f (quote noerror)))) autoloads))), 78> > I'll let you know if I can find any fix for this when I get some time.> But just wanted to pass the message along.> > Brett
I tried removing the arguments passed to `guix-emacs-autoload-packages' as the updated version (http://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/aux-files/emacs/guix-emacs.el?id=47b3b4c2aa49e21f4cc32c97ff7bbbd069bb849c)does not carry arguments anymore, instead depending on a variable EMACSLOADPATH. However, whenever that is done it returns
split-string: Wrong type argument: stringp, nil
possibly because my system is not finding EMACSLOADPATH.
I will keep investigating.
B
B
brettg wrote on 19 Nov 2019 01:32
(name . bug-Guix)(address . bug-guix-bounces+brettg=posteo.net@gnu.org)
26711cb3bba8555dea8ac4e9f8220726@posteo.net
On 19.11.2019 01:27, brettg@posteo.net wrote:
Toggle quote (93 lines)> On 18.11.2019 22:34, brettg@posteo.net wrote:>> On 18.11.2019 21:33, brettg@posteo.net wrote:>>> On 18.11.2019 21:28, brettg@posteo.net wrote:>>>> On 18.11.2019 20:01, brettg@posteo.net wrote:>>>>> Hey all, the recent changes to the emacs build system result in a >>>>> few>>>>> broken packages like emacs-pdf-tools, or basically anything that >>>>> uses>>>>> a phase for emacs-set-emacs-load-path.>>>>> >>>>> For example, I borrowed the technique used by emacs-pdf-tools to>>>>> package emacs-telega, resulting in both packages failing to build:>>>>> >>>>> Here is the code for emacs-telega:>>>>> >>>>> https://git.sr.ht/~brettgilio/cfg/tree/master/channel/non-gnu/packages/emacs-xyz.scm#L99>>>>> >>>>> The issue is in this phase for both emacs-pdf-tools and my channel >>>>> package:>>>>> >>>>> (add-after 'compress-documentation 'emacs-set-emacs-load-path>>>>> (assoc-ref emacs:%standard-phases 'set-emacs-load-path))>>>>> >>>>> Resulting in:>>>>> >>>>> starting phase `emacs-set-emacs-load-path'>>>>> Backtrace:>>>>> 5 (primitive-load >>>>> "/gnu/store/5b1p1gsvfyi4fbx4s42rhab2dns…")>>>>> In ice-9/eval.scm:>>>>> 191:35 4 (_ _)>>>>> In ice-9/boot-9.scm:>>>>> 829:9 3 (catch _ _ #<procedure 7ffff3bbb518 at >>>>> /gnu/store/zmkg…> …)>>>>> In srfi/srfi-1.scm:>>>>> 863:16 2 (every1 #<procedure 7ffff30ae160 at >>>>> /gnu/store/zmkgrvv…> …)>>>>> In>>>>> /gnu/store/zmkgrvvhmrix2b1z7id6zrg9bb7qxzdl-module-import/guix/build/gnu-build-system.scm:>>>>> 839:30 1 (_ _)>>>>> In unknown file:>>>>> 0 (_ #:source >>>>> "/gnu/store/qw8xbmk6ryl9a2jrp0gip3yffmsdix…" …)>>>>> >>>>> ERROR: Wrong type to apply: #f>>>>> >>>>> If we suspect that changes are going to be non-backwards compatible>>>>> could we use the news system to pass along that message? Much>>>>> appreciated. Thanks.>>>>> >>>>> Brett Gilio>>>> >>>> I applied a hotfix to the package by replacing 'set-emacs-load-path>>>> with 'add-source-to-load-path. I believe this fix would work for all>>>> other affected packages.>>> >>> https://git.sr.ht/~brettgilio/cfg/commit/c24a6db9d25151c487e9db675bd74e4bb3912173>> >> Ricardo, just wanted to make you aware that this emacs-build-system>> change does break your guile-studio. I discovered this because I>> adopted some of your ideas of autoloading in the generated emacs lisp>> from guile-studio when creating my own emacs configuration dependent>> on guix, which resulted in>> >> progn: Wrong number of arguments: (lambda nil "Autoload Emacs packages>> found in EMACSLOADPATH.>> >> 'Autoload' means to load the 'autoloads' files matching>> `guix-emacs-autoloads-regexp'." (interactive) (let* ((emacs-load-path>> (getenv "EMACSLOADPATH")) (emacs-non-core-load-path-directories>> (seq-filter (function (lambda (dir) (string-match-p>> "/share/emacs/site-lisp" dir))) (split-string emacs-load-path ":")))>> (autoloads (mapcan (function guix-emacs-find-autoloads)>> emacs-non-core-load-path-directories))) (mapc (function (lambda (f)>> (load f (quote noerror)))) autoloads))), 78>> >> I'll let you know if I can find any fix for this when I get some time.>> But just wanted to pass the message along.>> >> Brett> > I tried removing the arguments passed to> `guix-emacs-autoload-packages' as the updated version> (http://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/aux-files/emacs/guix-emacs.el?id=47b3b4c2aa49e21f4cc32c97ff7bbbd069bb849c)> does not carry arguments anymore, instead depending on a variable> EMACSLOADPATH. However, whenever that is done it returns> > split-string: Wrong type argument: stringp, nil> > possibly because my system is not finding EMACSLOADPATH.> > I will keep investigating.
I can confirm, when running something analogous to `guix environment --ad-hoc emacs-dashboard` no changes are being made to the $GUIX_ENVIRONMENT/etc/profile to resemble EMACSLOADPATH.
B
B
brettg wrote on 19 Nov 2019 02:58
(name . bug-Guix)(address . bug-guix-bounces+brettg=posteo.net@gnu.org)
57dee66c6531e9c8afbc5a22518d9917@posteo.net
On 19.11.2019 01:32, brettg@posteo.net wrote:
Toggle quote (102 lines)> On 19.11.2019 01:27, brettg@posteo.net wrote:>> On 18.11.2019 22:34, brettg@posteo.net wrote:>>> On 18.11.2019 21:33, brettg@posteo.net wrote:>>>> On 18.11.2019 21:28, brettg@posteo.net wrote:>>>>> On 18.11.2019 20:01, brettg@posteo.net wrote:>>>>>> Hey all, the recent changes to the emacs build system result in a >>>>>> few>>>>>> broken packages like emacs-pdf-tools, or basically anything that >>>>>> uses>>>>>> a phase for emacs-set-emacs-load-path.>>>>>> >>>>>> For example, I borrowed the technique used by emacs-pdf-tools to>>>>>> package emacs-telega, resulting in both packages failing to build:>>>>>> >>>>>> Here is the code for emacs-telega:>>>>>> >>>>>> https://git.sr.ht/~brettgilio/cfg/tree/master/channel/non-gnu/packages/emacs-xyz.scm#L99>>>>>> >>>>>> The issue is in this phase for both emacs-pdf-tools and my channel >>>>>> package:>>>>>> >>>>>> (add-after 'compress-documentation 'emacs-set-emacs-load-path>>>>>> (assoc-ref emacs:%standard-phases 'set-emacs-load-path))>>>>>> >>>>>> Resulting in:>>>>>> >>>>>> starting phase `emacs-set-emacs-load-path'>>>>>> Backtrace:>>>>>> 5 (primitive-load >>>>>> "/gnu/store/5b1p1gsvfyi4fbx4s42rhab2dns…")>>>>>> In ice-9/eval.scm:>>>>>> 191:35 4 (_ _)>>>>>> In ice-9/boot-9.scm:>>>>>> 829:9 3 (catch _ _ #<procedure 7ffff3bbb518 at >>>>>> /gnu/store/zmkg…> …)>>>>>> In srfi/srfi-1.scm:>>>>>> 863:16 2 (every1 #<procedure 7ffff30ae160 at >>>>>> /gnu/store/zmkgrvv…> …)>>>>>> In>>>>>> /gnu/store/zmkgrvvhmrix2b1z7id6zrg9bb7qxzdl-module-import/guix/build/gnu-build-system.scm:>>>>>> 839:30 1 (_ _)>>>>>> In unknown file:>>>>>> 0 (_ #:source >>>>>> "/gnu/store/qw8xbmk6ryl9a2jrp0gip3yffmsdix…" …)>>>>>> >>>>>> ERROR: Wrong type to apply: #f>>>>>> >>>>>> If we suspect that changes are going to be non-backwards >>>>>> compatible>>>>>> could we use the news system to pass along that message? Much>>>>>> appreciated. Thanks.>>>>>> >>>>>> Brett Gilio>>>>> >>>>> I applied a hotfix to the package by replacing 'set-emacs-load-path>>>>> with 'add-source-to-load-path. I believe this fix would work for >>>>> all>>>>> other affected packages.>>>> >>>> https://git.sr.ht/~brettgilio/cfg/commit/c24a6db9d25151c487e9db675bd74e4bb3912173>>> >>> Ricardo, just wanted to make you aware that this emacs-build-system>>> change does break your guile-studio. I discovered this because I>>> adopted some of your ideas of autoloading in the generated emacs lisp>>> from guile-studio when creating my own emacs configuration dependent>>> on guix, which resulted in>>> >>> progn: Wrong number of arguments: (lambda nil "Autoload Emacs >>> packages>>> found in EMACSLOADPATH.>>> >>> 'Autoload' means to load the 'autoloads' files matching>>> `guix-emacs-autoloads-regexp'." (interactive) (let* ((emacs-load-path>>> (getenv "EMACSLOADPATH")) (emacs-non-core-load-path-directories>>> (seq-filter (function (lambda (dir) (string-match-p>>> "/share/emacs/site-lisp" dir))) (split-string emacs-load-path ":")))>>> (autoloads (mapcan (function guix-emacs-find-autoloads)>>> emacs-non-core-load-path-directories))) (mapc (function (lambda (f)>>> (load f (quote noerror)))) autoloads))), 78>>> >>> I'll let you know if I can find any fix for this when I get some >>> time.>>> But just wanted to pass the message along.>>> >>> Brett>> >> I tried removing the arguments passed to>> `guix-emacs-autoload-packages' as the updated version>> (http://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/aux-files/emacs/guix-emacs.el?id=47b3b4c2aa49e21f4cc32c97ff7bbbd069bb849c)>> does not carry arguments anymore, instead depending on a variable>> EMACSLOADPATH. However, whenever that is done it returns>> >> split-string: Wrong type argument: stringp, nil>> >> possibly because my system is not finding EMACSLOADPATH.>> >> I will keep investigating.> > I can confirm, when running something analogous to `guix environment> --ad-hoc emacs-dashboard` no changes are being made to the> $GUIX_ENVIRONMENT/etc/profile to resemble EMACSLOADPATH.
So I have investigated the issue with EMACSLOADPATH: Similar to Ricardo's guile-studio,my package enlign was using the autoload function from guix-emacs.el to propagate a listof packages called from inputs to be loaded with the start of emacs.
I have since revised this to just call the autoload function directly, no longer passing any arguments, and had to modify my enlign package to respect the EMACSLOADPATH variable. This is only possible if all of the packages are passed as propagated-inputs though, which is less than desirable in my opinion (though I am willing to be convinced.)
This additionally leads to having to require emacs as a propagated input as well, as leading it native or regular input leads to an error with emacs not recognizing simple.el or mule-util.
Overall, I am not sure if I like the recent change to guix-emacs.el. I understand where the incentive is to do this, but ultimately it seems to lead to more headache when creating packages around emacs.
https://git.sr.ht/~brettgilio/cfg/commit/47bc9ae544ba10c0cacef1435625dcb0114e8cf5
Anyways,
If there is no other comment, this issue really just needs to fix emacs-pdf-tools and other affected packages from the recent string of changes.
Best,Brett Gilio
M
M
Maxim Cournoyer wrote on 19 Nov 2019 22:14
(address . brettg@posteo.net)
87ftijwou1.fsf@gmail.com
Hello Brett,
Thank you for the heads-up concerning the latest changes to the wayEmacs find its libraries and the adjustments done to theemacs-build-system.
brettg@posteo.net writes:
Toggle quote (48 lines)> On 19.11.2019 01:32, brettg@posteo.net wrote:>> On 19.11.2019 01:27, brettg@posteo.net wrote:>>> On 18.11.2019 22:34, brettg@posteo.net wrote:>>>> On 18.11.2019 21:33, brettg@posteo.net wrote:>>>>> On 18.11.2019 21:28, brettg@posteo.net wrote:>>>>>> On 18.11.2019 20:01, brettg@posteo.net wrote:>>>>>>> Hey all, the recent changes to the emacs build system result in>>>>>>> a few>>>>>>> broken packages like emacs-pdf-tools, or basically anything>>>>>>> that uses>>>>>>> a phase for emacs-set-emacs-load-path.>>>>>>>>>>>>>> For example, I borrowed the technique used by emacs-pdf-tools to>>>>>>> package emacs-telega, resulting in both packages failing to build:>>>>>>>>>>>>>> Here is the code for emacs-telega:>>>>>>>>>>>>>> https://git.sr.ht/~brettgilio/cfg/tree/master/channel/non-gnu/packages/emacs-xyz.scm#L99>>>>>>>>>>>>>> The issue is in this phase for both emacs-pdf-tools and my>>>>>>> channel package:>>>>>>>>>>>>>> (add-after 'compress-documentation 'emacs-set-emacs-load-path>>>>>>> (assoc-ref emacs:%standard-phases 'set-emacs-load-path))>>>>>>>>>>>>>> Resulting in:>>>>>>>>>>>>>> starting phase `emacs-set-emacs-load-path'>>>>>>> Backtrace:>>>>>>> 5 (primitive-load>>>>>>> "/gnu/store/5b1p1gsvfyi4fbx4s42rhab2dns…")>>>>>>> In ice-9/eval.scm:>>>>>>> 191:35 4 (_ _)>>>>>>> In ice-9/boot-9.scm:>>>>>>> 829:9 3 (catch _ _ #<procedure 7ffff3bbb518 at>>>>>>> /gnu/store/zmkg…> …)>>>>>>> In srfi/srfi-1.scm:>>>>>>> 863:16 2 (every1 #<procedure 7ffff30ae160 at>>>>>>> /gnu/store/zmkgrvv…> …)>>>>>>> In>>>>>>> /gnu/store/zmkgrvvhmrix2b1z7id6zrg9bb7qxzdl-module-import/guix/build/gnu-build-system.scm:>>>>>>> 839:30 1 (_ _)>>>>>>> In unknown file:>>>>>>> 0 (_ #:source>>>>>>> "/gnu/store/qw8xbmk6ryl9a2jrp0gip3yffmsdix…" …)>>>>>>>>>>>>>> ERROR: Wrong type to apply: #f
Sorry for failing to foresee this problem. I've fixed the couplepackages that were impacted on master now. You can have a look at thefixes (they are fairly simple).
Toggle quote (14 lines)>>>>>>> If we suspect that changes are going to be non-backwards>>>>>>> compatible>>>>>>> could we use the news system to pass along that message? Much>>>>>>> appreciated. Thanks.>>>>>>>>>>>>>> Brett Gilio>>>>>>>>>>>> I applied a hotfix to the package by replacing 'set-emacs-load-path>>>>>> with 'add-source-to-load-path. I believe this fix would work for>>>>>> all>>>>>> other affected packages.>>>>>>>>>> https://git.sr.ht/~brettgilio/cfg/commit/c24a6db9d25151c487e9db675bd74e4bb3912173
Indeed!
Toggle quote (35 lines)>>>> Ricardo, just wanted to make you aware that this emacs-build-system>>>> change does break your guile-studio. I discovered this because I>>>> adopted some of your ideas of autoloading in the generated emacs lisp>>>> from guile-studio when creating my own emacs configuration dependent>>>> on guix, which resulted in>>>>>>>> progn: Wrong number of arguments: (lambda nil "Autoload Emacs>>>> packages>>>> found in EMACSLOADPATH.>>>>>>>> 'Autoload' means to load the 'autoloads' files matching>>>> `guix-emacs-autoloads-regexp'." (interactive) (let* ((emacs-load-path>>>> (getenv "EMACSLOADPATH")) (emacs-non-core-load-path-directories>>>> (seq-filter (function (lambda (dir) (string-match-p>>>> "/share/emacs/site-lisp" dir))) (split-string emacs-load-path ":")))>>>> (autoloads (mapcan (function guix-emacs-find-autoloads)>>>> emacs-non-core-load-path-directories))) (mapc (function (lambda (f)>>>> (load f (quote noerror)))) autoloads))), 78>>>>>>>> I'll let you know if I can find any fix for this when I get some>>>> time.>>>> But just wanted to pass the message along.>>>>>>>> Brett>>>>>> I tried removing the arguments passed to>>> `guix-emacs-autoload-packages' as the updated version>>> (http://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/aux-files/emacs/guix-emacs.el?id=47b3b4c2aa49e21f4cc32c97ff7bbbd069bb849c)>>> does not carry arguments anymore, instead depending on a variable>>> EMACSLOADPATH. However, whenever that is done it returns>>>>>> split-string: Wrong type argument: stringp, nil>>>>>> possibly because my system is not finding EMACSLOADPATH.
Yes, that's the reason. Perhaps it could be worthwhile to give a bettermessage in this condition, but it's unclear to me why this conditionwould arise at all. Would you mind giving some more background to howyou got into that situation? I'll try building guile-studio and see ifI could get a hint or two.
Toggle quote (18 lines)>>> I will keep investigating.>>>> I can confirm, when running something analogous to `guix environment>> --ad-hoc emacs-dashboard` no changes are being made to the>> $GUIX_ENVIRONMENT/etc/profile to resemble EMACSLOADPATH.>> So I have investigated the issue with EMACSLOADPATH: Similar to> Ricardo's guile-studio,> my package enlign was using the autoload function from guix-emacs.el> to propagate a list> of packages called from inputs to be loaded with the start of emacs.>> I have since revised this to just call the autoload function directly,> no longer passing any arguments, and had to modify my enlign package> to respect the EMACSLOADPATH variable. This is only possible if all of> the packages are passed as propagated-inputs though, which is less> than desirable in my opinion (though I am willing to be convinced.)
Is your package an Emacs library/package? If so, just defining the otherElisp dependencies of this package as propagated inputs would be thecorrect solution.
For other cases (I can't think of how that would work exactly), perhapswrapping the package's script with the computed EMACSLOADPATHenvironment variable could do?
Toggle quote (4 lines)> This additionally leads to having to require emacs as a propagated> input as well, as leading it native or regular input leads to an error> with emacs not recognizing simple.el or mule-util.
Do you mean, that your package somehow uses Emacs without having Emacsinstalled in the profile (not being propagated)? If this is the case,wrapping your program with EMACSLOADPATH (and patching its reference toEmacs) should work, without having to propagate anything.
Toggle quote (12 lines)> Overall, I am not sure if I like the recent change to guix-emacs.el. I> understand where the incentive is to do this, but ultimately it seems> to lead to more headache when creating packages around emacs.>> https://git.sr.ht/~brettgilio/cfg/commit/47bc9ae544ba10c0cacef1435625dcb0114e8cf5>> Anyways,>> If there is no other comment, this issue really just needs to fix> emacs-pdf-tools and other affected packages from the recent string of> changes.
I'm sorry you've had some problems with this recent change! Thanks forbringing them out. Please do continue, I'm interested to know about anyremaining issues you might find.
Maxim
B
B
brettg wrote on 19 Nov 2019 22:16
(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)
cd4ac72f73ac64e626369db300ca2024@posteo.net
On 19.11.2019 22:14, Maxim Cournoyer wrote:
Toggle quote (179 lines)> Hello Brett,> > Thank you for the heads-up concerning the latest changes to the way> Emacs find its libraries and the adjustments done to the> emacs-build-system.> > brettg@posteo.net writes:> >> On 19.11.2019 01:32, brettg@posteo.net wrote:>>> On 19.11.2019 01:27, brettg@posteo.net wrote:>>>> On 18.11.2019 22:34, brettg@posteo.net wrote:>>>>> On 18.11.2019 21:33, brettg@posteo.net wrote:>>>>>> On 18.11.2019 21:28, brettg@posteo.net wrote:>>>>>>> On 18.11.2019 20:01, brettg@posteo.net wrote:>>>>>>>> Hey all, the recent changes to the emacs build system result in>>>>>>>> a few>>>>>>>> broken packages like emacs-pdf-tools, or basically anything>>>>>>>> that uses>>>>>>>> a phase for emacs-set-emacs-load-path.>>>>>>>> >>>>>>>> For example, I borrowed the technique used by emacs-pdf-tools to>>>>>>>> package emacs-telega, resulting in both packages failing to >>>>>>>> build:>>>>>>>> >>>>>>>> Here is the code for emacs-telega:>>>>>>>> >>>>>>>> https://git.sr.ht/~brettgilio/cfg/tree/master/channel/non-gnu/packages/emacs-xyz.scm#L99>>>>>>>> >>>>>>>> The issue is in this phase for both emacs-pdf-tools and my>>>>>>>> channel package:>>>>>>>> >>>>>>>> (add-after 'compress-documentation 'emacs-set-emacs-load-path>>>>>>>> (assoc-ref emacs:%standard-phases 'set-emacs-load-path))>>>>>>>> >>>>>>>> Resulting in:>>>>>>>> >>>>>>>> starting phase `emacs-set-emacs-load-path'>>>>>>>> Backtrace:>>>>>>>> 5 (primitive-load>>>>>>>> "/gnu/store/5b1p1gsvfyi4fbx4s42rhab2dns…")>>>>>>>> In ice-9/eval.scm:>>>>>>>> 191:35 4 (_ _)>>>>>>>> In ice-9/boot-9.scm:>>>>>>>> 829:9 3 (catch _ _ #<procedure 7ffff3bbb518 at>>>>>>>> /gnu/store/zmkg…> …)>>>>>>>> In srfi/srfi-1.scm:>>>>>>>> 863:16 2 (every1 #<procedure 7ffff30ae160 at>>>>>>>> /gnu/store/zmkgrvv…> …)>>>>>>>> In>>>>>>>> /gnu/store/zmkgrvvhmrix2b1z7id6zrg9bb7qxzdl-module-import/guix/build/gnu-build-system.scm:>>>>>>>> 839:30 1 (_ _)>>>>>>>> In unknown file:>>>>>>>> 0 (_ #:source>>>>>>>> "/gnu/store/qw8xbmk6ryl9a2jrp0gip3yffmsdix…" …)>>>>>>>> >>>>>>>> ERROR: Wrong type to apply: #f> > Sorry for failing to foresee this problem. I've fixed the couple> packages that were impacted on master now. You can have a look at the> fixes (they are fairly simple).> >>>>>>>> If we suspect that changes are going to be non-backwards>>>>>>>> compatible>>>>>>>> could we use the news system to pass along that message? Much>>>>>>>> appreciated. Thanks.>>>>>>>> >>>>>>>> Brett Gilio>>>>>>> >>>>>>> I applied a hotfix to the package by replacing >>>>>>> 'set-emacs-load-path>>>>>>> with 'add-source-to-load-path. I believe this fix would work for>>>>>>> all>>>>>>> other affected packages.>>>>>> >>>>>> https://git.sr.ht/~brettgilio/cfg/commit/c24a6db9d25151c487e9db675bd74e4bb3912173> > Indeed!> >>>>> Ricardo, just wanted to make you aware that this emacs-build-system>>>>> change does break your guile-studio. I discovered this because I>>>>> adopted some of your ideas of autoloading in the generated emacs >>>>> lisp>>>>> from guile-studio when creating my own emacs configuration >>>>> dependent>>>>> on guix, which resulted in>>>>> >>>>> progn: Wrong number of arguments: (lambda nil "Autoload Emacs>>>>> packages>>>>> found in EMACSLOADPATH.>>>>> >>>>> 'Autoload' means to load the 'autoloads' files matching>>>>> `guix-emacs-autoloads-regexp'." (interactive) (let* >>>>> ((emacs-load-path>>>>> (getenv "EMACSLOADPATH")) (emacs-non-core-load-path-directories>>>>> (seq-filter (function (lambda (dir) (string-match-p>>>>> "/share/emacs/site-lisp" dir))) (split-string emacs-load-path >>>>> ":")))>>>>> (autoloads (mapcan (function guix-emacs-find-autoloads)>>>>> emacs-non-core-load-path-directories))) (mapc (function (lambda (f)>>>>> (load f (quote noerror)))) autoloads))), 78>>>>> >>>>> I'll let you know if I can find any fix for this when I get some>>>>> time.>>>>> But just wanted to pass the message along.>>>>> >>>>> Brett>>>> >>>> I tried removing the arguments passed to>>>> `guix-emacs-autoload-packages' as the updated version>>>> (http://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/aux-files/emacs/guix-emacs.el?id=47b3b4c2aa49e21f4cc32c97ff7bbbd069bb849c)>>>> does not carry arguments anymore, instead depending on a variable>>>> EMACSLOADPATH. However, whenever that is done it returns>>>> >>>> split-string: Wrong type argument: stringp, nil>>>> >>>> possibly because my system is not finding EMACSLOADPATH.> > Yes, that's the reason. Perhaps it could be worthwhile to give a > better> message in this condition, but it's unclear to me why this condition> would arise at all. Would you mind giving some more background to how> you got into that situation? I'll try building guile-studio and see if> I could get a hint or two.> >>>> I will keep investigating.>>> >>> I can confirm, when running something analogous to `guix environment>>> --ad-hoc emacs-dashboard` no changes are being made to the>>> $GUIX_ENVIRONMENT/etc/profile to resemble EMACSLOADPATH.>> >> So I have investigated the issue with EMACSLOADPATH: Similar to>> Ricardo's guile-studio,>> my package enlign was using the autoload function from guix-emacs.el>> to propagate a list>> of packages called from inputs to be loaded with the start of emacs.>> >> I have since revised this to just call the autoload function directly,>> no longer passing any arguments, and had to modify my enlign package>> to respect the EMACSLOADPATH variable. This is only possible if all of>> the packages are passed as propagated-inputs though, which is less>> than desirable in my opinion (though I am willing to be convinced.)> > Is your package an Emacs library/package? If so, just defining the > other> Elisp dependencies of this package as propagated inputs would be the> correct solution.> > For other cases (I can't think of how that would work exactly), perhaps> wrapping the package's script with the computed EMACSLOADPATH> environment variable could do?> >> This additionally leads to having to require emacs as a propagated>> input as well, as leading it native or regular input leads to an error>> with emacs not recognizing simple.el or mule-util.> > Do you mean, that your package somehow uses Emacs without having Emacs> installed in the profile (not being propagated)? If this is the case,> wrapping your program with EMACSLOADPATH (and patching its reference to> Emacs) should work, without having to propagate anything.> >> Overall, I am not sure if I like the recent change to guix-emacs.el. I>> understand where the incentive is to do this, but ultimately it seems>> to lead to more headache when creating packages around emacs.>> >> https://git.sr.ht/~brettgilio/cfg/commit/47bc9ae544ba10c0cacef1435625dcb0114e8cf5>> >> Anyways,>> >> If there is no other comment, this issue really just needs to fix>> emacs-pdf-tools and other affected packages from the recent string of>> changes.> > I'm sorry you've had some problems with this recent change! Thanks for> bringing them out. Please do continue, I'm interested to know about > any> remaining issues you might find.> > Maxim
Thank you for your work Maxim, I think most of them are resolved now. I do wonder about what prompted the change, though. Perhaps you might share?
Brett
M
M
Maxim Cournoyer wrote on 19 Nov 2019 22:29
(address . brettg@posteo.net)
874kyzwo66.fsf@gmail.com
brettg@posteo.net writes:
[...]
Toggle quote (6 lines)> Thank you for your work Maxim, I think most of them are resolved> now. I do wonder about what prompted the change, though. Perhaps you> might share?>> Brett
The main motivation was to gain the ability to install Emacs in a givenprofile and have it use the Elisp libraries installed in said profile(and only from that profile). Using a search path specification is thenative Guix mechanism to find libraries for systems that mostly rely onthe FHS and means it work consistently across profiles, environments, orother features supported by Guix.
There was a discussion here about this change and some feedback in thetwo weeks it was published preceding its merge:https://lists.gnu.org/archive/html/help-guix/2019-11/msg00000.html.
HTH!
Maxim
B
B
brettg wrote on 19 Nov 2019 22:32
(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)
3bb8ddae57a7890e08438eda424bad34@posteo.net
On 19.11.2019 22:29, Maxim Cournoyer wrote:
Toggle quote (26 lines)> brettg@posteo.net writes:> > [...]> >> Thank you for your work Maxim, I think most of them are resolved>> now. I do wonder about what prompted the change, though. Perhaps you>> might share?>> >> Brett> > The main motivation was to gain the ability to install Emacs in a given> profile and have it use the Elisp libraries installed in said profile> (and only from that profile). Using a search path specification is the> native Guix mechanism to find libraries for systems that mostly rely on> the FHS and means it work consistently across profiles, environments, > or> other features supported by Guix.> > There was a discussion here about this change and some feedback in the> two weeks it was published preceding its merge:> https://lists.gnu.org/archive/html/help-guix/2019-11/msg00000.html.> > HTH!> > Maxim
Maxim, indeed it does! I guess I was out of the loop on that conversation and it just took me by surprise! Thanks for your efforts.
Best,Brett
M
M
Maxim Cournoyer wrote on 28 Nov 2019 06:21
control message for bug #38261
(address . control@debbugs.gnu.org)
877e3ktw2i.fsf@gmail.com
tags 38261 fixedclose 38261 quit
?
Your comment

This issue is archived.

To comment on this conversation send email to 38261@debbugs.gnu.org