Volatile? argument seems to be ignored for system disk images

DoneSubmitted by Maxim Cournoyer.
Details
One participant
  • Maxim Cournoyer
Owner
unassigned
Severity
normal
M
M
Maxim Cournoyer wrote on 18 Nov 2019 06:08
(name . Jelle Licht)(address . jlicht@fsfe.org)
87v9rhu5z7.fsf@gmail.com
Jelle Licht <jlicht@fsfe.org> writes:
Toggle quote (20 lines)> I am trying to dive into some of the code that goes into generating> system disk images for guix, and I ran into the following:>> It seems that commit 932e1f92404d917a91af28737d6631ec45b56875 did more> than what the commit log said:>>> vm: Make sure disk image initrds load 'usb-storage.ko'.>>>> Reported by David Thompson <dthompson2@worcester.edu>.>>>> * gnu/system/vm.scm (system-disk-image): Add usb-storage.ko to the>> initrd.>> This commit effectively made the `#:volatile?' kwarg to> `system-disk-image' redundant. Should we remove `#:volatile?', or should> it be passed along instead of #t?>> Or am I misunderstanding something subtle here, and is everything as it> should be?
No, my understanding is the same as yours: it looks like a bug.
Fixed with commit 67ed544212.
Thank you!
Maxim
M
M
Maxim Cournoyer wrote on 28 Nov 2019 06:20
control message for bug #38253
(address . control@debbugs.gnu.org)
878so0tw3y.fsf@gmail.com
tags 38253 fixedclose 38253 quit
?
Your comment

This issue is archived.

To comment on this conversation send email to 38253@debbugs.gnu.org