[PATCH] gnu: emacs-evil: Remove undo-tree dependency.

DoneSubmitted by Clément Lassieur.
Details
2 participants
  • Clément Lassieur
  • Mathieu Othacehe
Owner
unassigned
Severity
normal
C
C
Clément Lassieur wrote on 28 Oct 2019 16:34
(address . guix-patches@gnu.org)
20191028153435.5076-1-clement@lassieur.org
Because it is buggy and unnecessary. Seehttps://github.com/emacs-evil/evil/issues/1074.
* gnu/packages/emacs-xyz.scm (emacs-evil)[propagated-inputs]: Removeemacs-undo-tree and emacs-goto-chg.--- gnu/packages/emacs-xyz.scm | 3 --- 1 file changed, 3 deletions(-)
Toggle diff (16 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scmindex 688206452e..ba8ece1e22 100644--- a/gnu/packages/emacs-xyz.scm+++ b/gnu/packages/emacs-xyz.scm@@ -7418,9 +7418,6 @@ news items, openrc and runscripts.") (base32 "1833w397xhac5g3pp25szr2gyvclxy91aw27azvbmsx94pyk2a3q")))) (build-system emacs-build-system)- (propagated-inputs- `(("emacs-undo-tree" ,emacs-undo-tree)- ("emacs-goto-chg" ,emacs-goto-chg))) (home-page "https://github.com/emacs-evil/evil") (synopsis "Extensible Vi layer for Emacs") (description-- 2.23.0
C
C
Clément Lassieur wrote on 28 Oct 2019 16:43
(address . 37962@debbugs.gnu.org)
87zhhkj2ox.fsf@lassieur.org
The idea is that if people need it, they can install it and it'll justwork, but I personnaly don't want 'u' to be bound to undo-tree becauseit has unfixed bugs that can lead to data loss[1].
'r' won't work anymore, but C-/ can be used instead[2].
Cheers,Clément
[1]: https://github.com/emacs-evil/evil/issues/1074#issuecomment-430012097[2]: https://github.com/emacs-evil/evil/issues/1074#issuecomment-470690948
C
C
Clément Lassieur wrote on 28 Oct 2019 16:50
(address . 37962@debbugs.gnu.org)
87sgnczx7b.fsf@lassieur.org
clement@lassieur.org (Clément Lassieur) writes:
Toggle quote (6 lines)> The idea is that if people need it, they can install it and it'll just> work, but I personnaly don't want 'u' to be bound to undo-tree because> it has unfixed bugs that can lead to data loss[1].>> 'r' won't work anymore, but C-/ can be used instead[2].
I meant C-r (undo-tree-redo).
Toggle quote (6 lines)>> Cheers,> Clément>> [1]: https://github.com/emacs-evil/evil/issues/1074#issuecomment-430012097> [2]: https://github.com/emacs-evil/evil/issues/1074#issuecomment-470690948
M
M
Mathieu Othacehe wrote on 29 Oct 2019 08:43
(address . guix-patches@gnu.org)(address . 37962@debbugs.gnu.org)
87mudkj8tc.fsf@gmail.com
Hello Clément,
This LGTM!
Thanks,
Mathieu
Clément Lassieur writes:
Toggle quote (23 lines)> Because it is buggy and unnecessary. See> <https://github.com/emacs-evil/evil/issues/1074>.>> * gnu/packages/emacs-xyz.scm (emacs-evil)[propagated-inputs]: Remove> emacs-undo-tree and emacs-goto-chg.> ---> gnu/packages/emacs-xyz.scm | 3 ---> 1 file changed, 3 deletions(-)>> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm> index 688206452e..ba8ece1e22 100644> --- a/gnu/packages/emacs-xyz.scm> +++ b/gnu/packages/emacs-xyz.scm> @@ -7418,9 +7418,6 @@ news items, openrc and runscripts.")> (base32> "1833w397xhac5g3pp25szr2gyvclxy91aw27azvbmsx94pyk2a3q"))))> (build-system emacs-build-system)> - (propagated-inputs> - `(("emacs-undo-tree" ,emacs-undo-tree)> - ("emacs-goto-chg" ,emacs-goto-chg)))> (home-page "https://github.com/emacs-evil/evil")> (synopsis "Extensible Vi layer for Emacs")> (description
C
C
Clément Lassieur wrote on 29 Oct 2019 11:07
(name . Mathieu Othacehe)(address . m.othacehe@gmail.com)(address . 37962@debbugs.gnu.org)
87y2x3dfv0.fsf@lassieur.org
thanks! Pushed.
C
C
Clément Lassieur wrote on 29 Oct 2019 18:53
whatever
(address . control@debbugs.gnu.org)
87pnifv3nt.fsf@lassieur.org
close 37962
C
C
Clément Lassieur wrote on 29 Oct 2019 22:00
control message for bug #37962
(address . control@debbugs.gnu.org)
87o8xzl11j.fsf@lassieur.org
tags 37962 fixedclose 37962 quit
C
C
Clément Lassieur wrote on 29 Oct 2019 22:07
(address . control@debbugs.gnu.org)
87wocns1jn.fsf@lassieur.org
reopen 37962tags 37962 - fixed patchquit
C
C
Clément Lassieur wrote on 29 Oct 2019 22:19
(address . control@debbugs.gnu.org)
87o8xzdzc7.fsf@lassieur.org
tags 37962 fixedclose 37962 quit
?
Your comment

This issue is archived.

To comment on this conversation send email to 37962@debbugs.gnu.org