[PATCH] reconfigure: Fix GC root installation.

  • Done
  • quality assurance status badge
Details
2 participants
  • Danny Milosavljevic
  • Jakob L. Kreuze
Owner
unassigned
Submitted by
Jakob L. Kreuze
Severity
normal
J
J
Jakob L. Kreuze wrote on 6 Aug 2019 19:37
(address . guix-patches@gnu.org)
87h86uxkir.fsf@sdf.lonestar.org
Reported by ison <ison@airmail.cc>.

guix/scripts/system/reconfigure.scm (install-bootloader-program): Switch
new symlink to the canonical bootloader configuration file.
---
guix/scripts/system/reconfigure.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/guix/scripts/system/reconfigure.scm b/guix/scripts/system/reconfigure.scm
index dee0c24bd2..72d97b6c48 100644
--- a/guix/scripts/system/reconfigure.scm
+++ b/guix/scripts/system/reconfigure.scm
@@ -196,7 +196,7 @@ BOOTLOADER-PACKAGE."
(srfi srfi-35))
(let* ((gc-root (string-append #$target %gc-roots-directory "/bootcfg"))
(temp-gc-root (string-append gc-root ".new")))
- (switch-symlinks temp-gc-root gc-root)
+ (switch-symlinks temp-gc-root #$bootcfg)
(install-boot-config #$bootcfg #$bootcfg-file #$target)
;; Preserve the previous activation's garbage collector root
;; until the bootloader installer has run, so that a failure in
--
2.22.0
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEa1VJLOiXAjQ2BGSm9Qb9Fp2P2VoFAl1JutwACgkQ9Qb9Fp2P
2VpTVw/+NEcNXoMUqp4lsomyok52AZGMBAo55jVZn0ArozMJ/C2HjUGG96ZReIdq
GkaKi5weAvtqx3MlcAC7GJGmMmX7f6/FeOLvSvilYbsTq/1aMwltXrSX8fo6ftNH
cZoj1sE3/xKJd6jy1SD2nisqnsQfylF+qAXQipaxIXzL0HfAyf0lw/Rtoon0ysrn
Vqda417zyoYT7Kf8MLEsg9LIa2irlR84HRU7cLdJFoHQVq3fO72h7+XYu+FxSBqH
zmTKq0t0XHM/jS73WtxQ20KCHVoaD/ipa/SiOZuSyX1cADyefuYKI3OGEb35gBEv
yLY8imJ5D7pZhon3Safz2iZftm2jxWlBQ7JKYHdUdle7NjGpCr+Dny/ZnUgTWbX/
eVcCbo8zcNMYfu98iW3FeiFm3RjKjFbMuUP1SRv/iQXl1TaqDqgUTNVUnAAv1Zo+
Du3Z3HKu78AYKfr1ZoZmJR5aE/84OETkgb1QFqnzd/ijyys9AHcpMrSTim8aBjAR
2m0NYSmMJRxlGoSH8/bphC3Q3j81DlQpJqNzFp21mRGfw4YQiAWEmnr0EsDjmJ8x
J1Zrs2gO0fAwXwrep+ibCbc+NuQ4Y2EUhTyZSszBBGhFOvcEZ4FtDn89Cr2or77d
3efqzJKRGm/IUxOlP/2zSAG8w86R0fJJvUlWe2Sg5CFGs/eQD6U=
=8bNK
-----END PGP SIGNATURE-----

D
D
Danny Milosavljevic wrote on 6 Aug 2019 22:27
(name . Jakob L. Kreuze)(address . zerodaysfordays@sdf.lonestar.org)
20190806222729.09d644ff@scratchpost.org
Hi Jakob,

thanks for that patch!

Pushed to guix master with a huge comment, as commit
5f04e9f9620aeb45940855e4f655f22db55ba6eb.

Feel free to Cc me with important installation-saving patches like that one.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl1J4rEACgkQ5xo1VCww
uqXXdwf5AZKJy6EU4q8r+vRu/xvBBtsR2REvbZZd06MuB7ouwSKSNV//PxbDI/vh
WS2QNON6vZ0PqvNUq0KpLChuNFdz942N3RcAKrFshP1GhF6ciTahezS13lGNRLHB
Z+j83DNoXvqqwk6DZTVZSXq3Z6u+ge9aPXh07NMYhDjzQ3f4OHHEHjUDcjuz/faV
nsVAJNNvbD2Y0tn6wi05T5sXvrHsZAXZxxSU+FIVDVuwsT5xAKvf6rsOxIqk/61J
c/EJFpqGt02oakvZdtOSX6w5g5mZOVRnptCgQ7GPZBTr8XL5hEDAprQVdgim1iQx
71NmdyQOTDJCORiffi8WuaGV/R7pxA==
=CLif
-----END PGP SIGNATURE-----


Closed
J
J
Jakob L. Kreuze wrote on 6 Aug 2019 22:47
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)
87tvauvx6g.fsf@sdf.lonestar.org
Hi Danny,

Danny Milosavljevic <dannym@scratchpost.org> writes:

Toggle quote (4 lines)
> Hi Jakob,
>
> thanks for that patch!

My pleasure :)

Toggle quote (5 lines)
> Pushed to guix master with a huge comment, as commit
> 5f04e9f9620aeb45940855e4f655f22db55ba6eb.
>
> Feel free to Cc me with important installation-saving patches like that one.

Heh, I'll keep that in mind

Regards,
Jakob
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEa1VJLOiXAjQ2BGSm9Qb9Fp2P2VoFAl1J50cACgkQ9Qb9Fp2P
2Vp7Vw/9G0ns/GSpc4FruVCzNe6qRcxbBBexgvZspsbzrAiE56m+8RBrxIrTDDI7
8C1rELq1g9qRYECukK7LuCIBPpIhSTz8Vwu59PWAi85TR4tH0C3qFUfI+f7bSkCI
icJjgdcY43ORG7y3pJ9aCMpVPYGaNQA+Xr+UZCk3hMbXuqcXLp5OP0pCzBbWb/7S
EohEtGRLXgb9I4BvCPp5RDAGiiz6alVcRPIp0ynQmfHb+ne6pJVH3EYbasqwNReq
sCatFmy5TsLkAUT8iH5b0HKXgKItmPU4lMss5BFvg7MhOelC1CM/LXkHwQh6ql7T
b1vyAElyGj4T2fCiPogqX43Q9UtML7yCc5CBapUF6T2DDlcq3L9AYOHou3uUzUZn
XHgS6qKqxswRHtH73vA3CIG+IkovsRcMGgloecioZ9lpFbXInxxVhLmYRZoF0pR8
SdeICGvc1oL3H1oE/56KeSPJn6D5bal3jX5fPOE5Rbut3AvR4sKo+djuYG5hDXEk
ui+BeLKvPLNhWJLjboVtZsN/rj+92yChf1j3GgUGjwAt9ve7Q8zUkt6GoP/Z7TSE
URVwzIsIhqNcDqw0PUxCfKeuQNnH43xgMNOnkO64vpqmyObvql4Hpi4jcsW67ald
Y1GDsB4+UwD8YJORrFder0GjWckbRjAbrppV7nBYMW8h0hXXs14=
=aA5N
-----END PGP SIGNATURE-----

Closed
?