[PATCH] installer: Speak of keyboard layout language.

  • Open
  • quality assurance status badge
Details
2 participants
  • Ludovic Courtès
  • Tobias Geerinckx-Rice
Owner
unassigned
Submitted by
Tobias Geerinckx-Rice
Severity
normal

Debbugs page

Tobias Geerinckx-Rice wrote 6 years ago
(address . guix-patches@gnu.org)
20190514175540.24394-1-me@tobias.gr
* gnu/installer/newt/keymap.scm (run-layout-page): Tweak #:info-text.
---

Guix,

I'm finally trying out this fancy installer.

In the list of keyboard layouts, I scrolled down to ‘US’ but it didn't exist, because (for better or worse) the list we use is language-oriented. I now better understand how people have been confused in the past.

OK to apply this tweak?

T G-R

gnu/installer/newt/keymap.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/installer/newt/keymap.scm b/gnu/installer/newt/keymap.scm
index 2908ba7f0e..6386ac4e45 100644
--- a/gnu/installer/newt/keymap.scm
+++ b/gnu/installer/newt/keymap.scm
@@ -37,7 +37,7 @@
(let ((title (G_ "Layout")))
(run-listbox-selection-page
#:title title
- #:info-text (G_ "Please choose your keyboard layout.")
+ #:info-text (G_ "Please choose your keyboard layout language.")
#:listbox-items layouts
#:listbox-item->text layout->text
#:sort-listbox-items? #f
--
2.21.0
Ludovic Courtès wrote 6 years ago
(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)(address . 35733@debbugs.gnu.org)
87tvdvvqi6.fsf@gnu.org
Hi Tobias,

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

Toggle quote (2 lines)
> OK to apply this tweak?

Not for 1.0.1 IMO as this would invalidate translations.

Other than that, I don’t know if adding “language” helps, but maybe it
does?

Thanks,
Ludo’.
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 35733@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 35733
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help