[PATCH] gnu: qjackctl: Re-enable xunique.

  • Done
  • quality assurance status badge
Details
2 participants
  • Pierre Langlois
  • Ricardo Wurmus
Owner
unassigned
Submitted by
Pierre Langlois
Severity
normal

Debbugs page

Pierre Langlois wrote 6 years ago
(name . Guix-patches)(address . guix-patches@gnu.org)(name . Pierre Langlois)(address . pierre.langlois@gmx.com)
87bm1xdz73.fsf@gmx.com
Hello,

I realised version 0.5.6 of qjackctl appears to have fixed the xunique
bug that was causing X hanging when using tiling window managers!


Thanks,
Pierre
From 9c61af1a5ae548594016dcc50f1c5d125048eb5d Mon Sep 17 00:00:00 2001
From: Pierre Langlois <pierre.langlois@gmx.com>
Date: Tue, 26 Mar 2019 22:48:11 +0000
Subject: [PATCH] gnu: qjackctl: Re-enable xunique.

It looks like version 0.5.6 fixed the problem with tiling window manager.

* gnu/packages/audio.scm (qjackctl)[arguments]: Remove "--disable-xunique"
from configure-flags.
---
gnu/packages/audio.scm | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

Toggle diff (17 lines)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index a38e77c996..aa99382f79 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -2130,11 +2130,7 @@ different audio devices such as ALSA or PulseAudio.")
"0wlmbb9m7cf3wr7c2h2hji18592x2b119m7mx85wksjs6rjaq2mj"))))
(build-system gnu-build-system)
(arguments
- '(#:tests? #f ; no check target
- ;; Disable xunique to prevent X hanging when starting qjackctl in
- ;; tiling window managers such as StumpWM or i3
- ;; (see https://github.com/rncbc/qjackctl/issues/13).
- #:configure-flags '("--disable-xunique")))
+ '(#:tests? #f)) ; no check target
(inputs
`(("jack" ,jack-1)
("alsa-lib" ,alsa-lib)
--
2.21.0
Ricardo Wurmus wrote 6 years ago
(name . Pierre Langlois)(address . pierre.langlois@gmx.com)(address . 35015-done@debbugs.gnu.org)
877ecl44ga.fsf@elephly.net
Pierre Langlois <pierre.langlois@gmx.com> writes:

Toggle quote (7 lines)
> Hello,
>
> I realised version 0.5.6 of qjackctl appears to have fixed the xunique
> bug that was causing X hanging when using tiling window managers!
>
> https://github.com/rncbc/qjackctl/blob/d54a1da43fa197da04d676a110f36a1d4c062252/ChangeLog#L9

Thanks. I pushed this to the master branch with commit 4dcf221c85.

--
Ricardo
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 35015@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 35015
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help