Curl is not configured to use its dependency libssh2

  • Done
  • quality assurance status badge
Details
2 participants
  • Leo Famulari
  • Marius Bakke
Owner
unassigned
Submitted by
Leo Famulari
Severity
normal
L
L
Leo Famulari wrote on 20 Mar 2019 21:40
(address . bug-guix@gnu.org)
20190320204052.GA21181@jasmine.lan
While working on a libssh2 update [0] I noticed that curl was not
keeping a reference to libssh2, even though libssh2 is an input of the
curl build.

Our curl package is missing the required configuration option:

------
SSH support: no (--with-libssh2)
------

I assume that our curl package did build with SSH support in the past,
but I'm not sure.

It's unfortunate that we have to use a graft to update libssh2 even
though only a few dozen packages refer to it, because of this curl
issue.

What should we do about curl? Should we remove libssh2 from its inputs,
or enable the build-time --with-libssh2 configuration option?

[0]
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlySpVEACgkQJkb6MLrK
fwjarQ//QnJ1UB+hMU9z84PeNbBT6N9dsmof+5BENnMzn/FDbscZsvW2cEoxe6Cs
QWFg0lKOT+lZ7FBNrPscEY4e60a/KyBI9yOjCdaqmft71QKnzsnTPiO7b+HNVPdr
SfMP5C2dIJQzJ5XlHr8/C/QFTpfls1XEdkzpyaTXuyyTNVXdCfXdGnnPOQ+bgVcr
0kiX7yzblR0XqF4B2qVX1o9JhPuSEapJvtrKSi9pApwUccKKD+Yaf7UvGTxvh3vd
M/8kHnbBWr+q9AIn5EWoC7DwrhmgwGcrXJ0rnQFi+Y7uWJPdGw5VVA9fIib7W5Ge
ZZHuXnIgD0CshuaZgTqDY1GpVryIrX1fUaUVcvznF9WVludhf0eeaSJ0fLQlAieC
mCJdHxjSYe6BBiFlj8lkksYzOZ3LxKYmNbgHS2n7yfo9DrNCvyKsKNij6vlqyy5s
qpMCnwQZQUSVFFYfdY1MP2Q5cnsNs+7ZQ9AG5yXY6sLJs67sdHP5SosFBpF9In3I
Az3DkSDaOHfC6eosgp+c/KdSS6qvXZ8a8py54wQRd+mtVsh+2kXNDy7gAOzuPVKu
3aAp/yLONRuadNVNMVcyCl4V4qVhL1GTJKUG6biyk+JK7TLgGAZ2J80WbZcc94Gn
odm0ZBHmpIFKdcN3BEgoQufqUTFSWTt+aAduRecFIqiuzE9SkzM=
=KiUZ
-----END PGP SIGNATURE-----


M
M
Marius Bakke wrote on 21 Mar 2019 00:54
87lg1985lx.fsf@fastmail.com
Leo Famulari <leo@famulari.name> writes:

Toggle quote (20 lines)
> While working on a libssh2 update [0] I noticed that curl was not
> keeping a reference to libssh2, even though libssh2 is an input of the
> curl build.
>
> Our curl package is missing the required configuration option:
>
> ------
> SSH support: no (--with-libssh2)
> ------
>
> I assume that our curl package did build with SSH support in the past,
> but I'm not sure.
>
> It's unfortunate that we have to use a graft to update libssh2 even
> though only a few dozen packages refer to it, because of this curl
> issue.
>
> What should we do about curl? Should we remove libssh2 from its inputs,
> or enable the build-time --with-libssh2 configuration option?

Since no one apparently uses it, let's just remove it. I'm something of
a curl power user and did not know it even had SSH support!

In the mean time, if curl is the only "heavy" user of libssh2, we
can give it a non-public or hidden libssh2 package that stays on version
1.8.0 to avoid the graft. WDYT?
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlyS0poACgkQoqBt8qM6
VPrp3gf+IuLN3BfIFCkpuJGO+Wno+XEV7NxxujkNMDSxt4/sKmWJ5uRg/xGH3JhK
W2IVh9N1K38SKzzUlhmi/Ggw+BLelg6i0OcIwNW/hYyt/JLaBoKYtYI9Z9P5icsb
yUsofojL2ezM1l0xvORpmAGRG3HuMaoeOSlUWK+o0MOPYNZ5dv9Xbp/PZl3M+0u2
AEMzWvV69owOjPs3hlAgtPMIv3dqkZhaBt1pOzSGIb4Ne1q8ABQInB1N81Gf2mg2
+WWgw7uj/39k3itj/gftRk2h+U12PIZpHCLQiqh28n9OYdAi+6kXuB26ABLQq+hy
b9e8N799jWYSqL4sB331uriiaSKEUQ==
=4/mn
-----END PGP SIGNATURE-----

L
L
Leo Famulari wrote on 21 Mar 2019 18:38
(name . Marius Bakke)(address . mbakke@fastmail.com)(address . 34927@debbugs.gnu.org)
20190321173812.GA13933@jasmine.lan
On Thu, Mar 21, 2019 at 12:54:02AM +0100, Marius Bakke wrote:
Toggle quote (7 lines)
> Since no one apparently uses it, let's just remove it. I'm something of
> a curl power user and did not know it even had SSH support!
>
> In the mean time, if curl is the only "heavy" user of libssh2, we
> can give it a non-public or hidden libssh2 package that stays on version
> 1.8.0 to avoid the graft. WDYT?

Good idea! Done in af8f7eb4f2a664c2d0fb3faabaf2e80c72993ef6

I'll leave this bug open until curl either uses libssh2 or we remove the
dependency.
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlyTzAQACgkQJkb6MLrK
fwgU9hAAvRHtwQIE6PU6avVZv1VQcI4982ClrguXeGXSLczw0Vu0VbRbrwc7kwC9
/mzRavw6t9ISGQqca06mxU6llwj4ZUqUKaU0YMjY1T0mefiNgjuO0b95ZJF/wmaQ
PbtHfy/9vTT3hkxcT3wvB8xnhPTOp3hdbzjSwI+JiHwlOTBpZn2Y6d1G+M1TIFD/
CE36bVXnmYLjEbgBxPNLqFWUK+EEKObokPRsLF8H90h35s3QRKItbx2FW6x0B21u
T+kRcY+9lvcMUPZL6FuSYefspeeA/fInAnJj2ZujSsZcSEiUt3ylwtwSfXyGE+DX
f/REYKa6ydZ4uXNj5FESJRvSwqqsjDMa03GzvKnPm6cA2LPc0vPJdv9uw+L0X3Nk
rwr8QLb8M6k4pWgJ4gMEPqU/bEl8S9V8Ojf1GRMARY3rJmij8XYlcD11lm7dYVxi
b0Z/8dwB9Llk+r+Wqk4Ef+eZ+kAp4OaGmpdRnHp2zPH6YXPQZ1A7aePSxO/DrRkC
Dc2GH0F//SO8B8xyqPOA+xAVLKJVy3nbh9jE1txOlNHp5NyjZVMLBtVrU+LWJNdI
wD3kbbbszzD5iz1rgcY44zW9b5IxA35PBu+e2+4dxsWChsCiI6BOkALEV+WlpinV
N2QIhgMLvBuAjrzVZ+zVFGWllD+ZtKEdCsA7ckAGbTDEOlqMu1g=
=IioN
-----END PGP SIGNATURE-----


M
M
Marius Bakke wrote on 21 Mar 2019 20:06
(name . Leo Famulari)(address . leo@famulari.name)
877ecs82tr.fsf@fastmail.com
Leo Famulari <leo@famulari.name> writes:

Toggle quote (10 lines)
> On Thu, Mar 21, 2019 at 12:54:02AM +0100, Marius Bakke wrote:
>> Since no one apparently uses it, let's just remove it. I'm something of
>> a curl power user and did not know it even had SSH support!
>>
>> In the mean time, if curl is the only "heavy" user of libssh2, we
>> can give it a non-public or hidden libssh2 package that stays on version
>> 1.8.0 to avoid the graft. WDYT?
>
> Good idea! Done in af8f7eb4f2a664c2d0fb3faabaf2e80c72993ef6

This commit changed the cURL derivation, so I pushed a followup in
c1f4e6491cecc5d121ef371a8fb2aa0a07030d36.

I think using the "hidden?" property will leave the derivation
unchanged (as opposed to (hidden-package ...)).

@guix-sysadmin: Can you cancel evaluation 4309 on Berlin?
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlyT4LAACgkQoqBt8qM6
VPrKkAgAnbQIWGxod0yfesX9L7IoUw4FskIuBIhPSOve3OgaR7hAB10+RgHYcxXo
OEMGHPhJ4LNDM/8kKF2Mqc9QmU8unE6YS7HlylVjnJh2xmDl2RoSQFyKPLiRwDyG
auGEK1BDLvXLRHGpaUBHQCqwIKTQ5s77voo6XWL29OveUvO9mmTtQuyD3e9W277C
lbj+78Qt6D7ithd2puVcH3MKmOmsWUvvSxCRDSvYD9AT0+6H1a+Cuu1bCY0xpzuG
XuUM3ENoqW6Pg/7bm9WwkjfBvujOGxS4D16sZfODi7vH0TzuuLxPesxwoGVkX4It
VIty1wbxjtyFvlsQYqDgQycrLU6zvw==
=WRKU
-----END PGP SIGNATURE-----

L
L
Leo Famulari wrote on 21 Mar 2019 21:37
(name . Marius Bakke)(address . mbakke@fastmail.com)
20190321203700.GA16774@jasmine.lan
On Thu, Mar 21, 2019 at 08:06:24PM +0100, Marius Bakke wrote:
Toggle quote (3 lines)
> This commit changed the cURL derivation, so I pushed a followup in
> c1f4e6491cecc5d121ef371a8fb2aa0a07030d36.

Oops... I did check that the libssh2 derivation had not changed, but I
didn't expect the order of the inputs in the curl package definition to
affect the derivation. Thanks for you quick fix!

Toggle quote (3 lines)
> I think using the "hidden?" property will leave the derivation
> unchanged (as opposed to (hidden-package ...)).

(hidden-package) does work to preserve the derivation — the issue was
the inputs ordering in the curl package definition. I pushed another
followup to use it.
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlyT9ewACgkQJkb6MLrK
fwgOlhAAvEWPFyrrE/h3qBARk9K9Zvz3XAaSQyqiEXEADT90dlQqtNtd/GBeoBnK
93oC6igOMg9Wp/mBD2THZCU/+6YEc8n9bZnrmYYitY3cMqbncohbDvQ6+7Ktt7xP
Cqvp1CJN1sDjdq4Unv+/15M4Q5ac9Z57UUFiKMr8U7/yF6Iq0H9KjzsooCnryEMR
6jhrN6wbHHG4FkCdEnGlNiYLJrYK3a0jr66uTi+IhFcMwZysC0zW2YZkcOzYH+K6
OpcI/+fIxzTAwr6aThOGEcl2HbdOnWkKOCXbCXR0Jq3fhoqwIav2pjyD5RddoDAn
7D/N9zHXHSFYLvA6U3h/y+ZRv0VhiZWyIbjY47AXI8I5XW/mmH2CSO4emXonfdIY
H4aa3XaIaFxqH/iNJfkmLbTNAkGdD6EwBQlsre3zZo/GrW+5aYU3z8FY2BCBvw0C
Sj1QS+iVpVMRr+I3KY6T/8wNjjgS2DHOcj62Yi2SmCuxoTkpytwviJWK48GgAF+2
3OsjUSROadbdMAzamSyRPjn3QYhGqlwcd63V7gyMbzlBCExwZAe2oiiT5o/TWQBk
uO3OBpDVK2hDo+cTW2dvhfsNAvzUdG7chS0Mp9tV5/jk9Ai2G8wBoERH3o7oR90U
1U365G3vxob7TUrzmyEg6k3h29tlJ7LokRX3EEqhhE9mehv0Xao=
=Jza5
-----END PGP SIGNATURE-----


Closed
M
M
Marius Bakke wrote on 21 Mar 2019 22:02
(name . Leo Famulari)(address . leo@famulari.name)(address . 34927-done@debbugs.gnu.org)
877ecs0wmu.fsf@fastmail.com
Leo Famulari <leo@famulari.name> writes:

Toggle quote (15 lines)
> On Thu, Mar 21, 2019 at 08:06:24PM +0100, Marius Bakke wrote:
>> This commit changed the cURL derivation, so I pushed a followup in
>> c1f4e6491cecc5d121ef371a8fb2aa0a07030d36.
>
> Oops... I did check that the libssh2 derivation had not changed, but I
> didn't expect the order of the inputs in the curl package definition to
> affect the derivation. Thanks for you quick fix!
>
>> I think using the "hidden?" property will leave the derivation
>> unchanged (as opposed to (hidden-package ...)).
>
> (hidden-package) does work to preserve the derivation — the issue was
> the inputs ordering in the curl package definition. I pushed another
> followup to use it.

Oops, indeed it does.. I must have mixed it up with something else,
thanks for correcting my flawed assumption :-)
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlyT+8kACgkQoqBt8qM6
VPqgqgf/f48oPaxEW17us+nxoLjZbGVVLh52kerjH4gn2Xz77uQKmTJc4xYOXkTo
9WsIr9rDPtCP3x+DFqd2rQal5Fb7DaCrTBNNJDbvNrctelTmhGlH5fEkqkL796OO
btgcucAx9tpDfDlJYgw1kcrsRH4LXAh07E8HayL+YdIRKoT9CkiuB2tmvv4KhUcL
36jR/ZdpqRzGoXRZuaCO1PBxCG0ovS3ZtADDCeT7uEU+oLNbcRRhYIc1bVaCZ7Q9
TvXSBSYrEC4/g16UY80gD+89SRCqSccnuQFSSLnKGUqI342HOgpWadb6lM4JU5dn
iD7q4kKzXdIm47ukwz44AiVCVq8OdA==
=CBL7
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 34927@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 34927
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch