psmisc description vague

  • Done
  • quality assurance status badge
Details
4 participants
  • Ludovic Courtès
  • Tobias Geerinckx-Rice
  • mikadoZero
  • mirai
Owner
unassigned
Submitted by
mikadoZero
Severity
normal
M
M
mikadoZero wrote on 12 Mar 2019 19:15
(address . bug-guix@gnu.org)
ftrst0wm.fsf@yandex.com
The description for the psmisc package would be more helpful if it
listed the utilities that it included. As it is I do not know what I
will get after installing.

An example of a description that is more helpful is procps.
L
L
Ludovic Courtès wrote on 13 Mar 2019 15:48
(name . mikadoZero)(address . mikadozero@yandex.com)(address . 34828@debbugs.gnu.org)
874l867rus.fsf@gnu.org
Hi,

mikadoZero <mikadozero@yandex.com> skribis:

Toggle quote (6 lines)
> The description for the psmisc package would be more helpful if it
> listed the utilities that it included. As it is I do not know what I
> will get after installing.
>
> An example of a description that is more helpful is procps.

I would recommend against turning descriptions into lists of commands
just for the sake of package search (we should instead have another
mechanism to determine which package provides a given command), but
listing key commands is useful for a package like this one.

Would you like to propose a patch?

Ludo’.
M
M
mikadoZero wrote on 24 Mar 2019 00:54
[PATCH] bug#34828 gnu: psmisc: Make package description more informative
(name . Guix-patches)(address . guix-patches@gnu.org)
cucimw95epm.fsf@yandex.com
This patch is for bug#34828. It makes the description for psmisc
more informative.

This is one of my first patches submitted to Guix. Feedback is
appreciated.

Passed:
`guix lint psmisc`
`guix build --rounds=4 psmisc`

------------


From 95f47eadb05de56a542d1be8f630e5ec4aa81485 Mon Sep 17 00:00:00 2001
From: mikadoZero <mikadozero@yandex.com>
Date: Sat, 23 Mar 2019 19:23:33 -0400
Subject: [PATCH] gnu: psmisc: Make package description more informative.

* gnu/packages/linux.scm (psmisc):
The content for the description is taken from the psmisc readme.
---
gnu/packages/linux.scm | 19 ++++++++++++++++---
1 file changed, 16 insertions(+), 3 deletions(-)

Toggle diff (39 lines)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 311bc6fa5..5365aa97d 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -33,6 +33,7 @@
;;; Copyright © 2018 Pierre Langlois <pierre.langlois@gmx.com>
;;; Copyright © 2018 Vasile Dumitrascu <va511e@yahoo.com>
;;; Copyright © 2019 Tim Gesthuizen <tim.gesthuizen@yahoo.de>
+;;; Copyright © 2019 mikadoZero <mikadozero@yandex.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -602,9 +603,21 @@ at login. Local and dynamic reconfiguration are its key features.")
(synopsis
"Small utilities that use the proc file system")
(description
- "This PSmisc package is a set of some small useful utilities that
-use the proc file system. We're not about changing the world, but
-providing the system administrator with some help in common tasks.")
+ "A package of small utilities that use the proc file-system.
+@itemize @bullet
+@item
+fuser - Identifies processes using files or sockets
+@item
+killall - kills processes by name, e.g. killall -HUP named
+@item
+prtstat - prints statistics of a process
+@item
+pslog - prints log path(s) of a process
+@item
+pstree - shows the currently running processes as a tree
+@item
+peekfd - shows the data travelling over a file descriptor
+@end itemize")
(license license:gpl2+)))
(define-public util-linux
--
2.21.0
M
M
mirai wrote on 5 Jan 2023 13:09
(no subject)
(name . control)(address . control@debbugs.gnu.org)
718b024b-13df-d894-eb64-faa56664e04d@makinata.eu
tags 34828 + patch
tags 34829 + patch
quit

--

bump for visibility
T
T
Tobias Geerinckx-Rice wrote on 16 Sep 2023 15:43
Re: [PATCH] Update psmisc to 23.6.
718fbf66254c89368203edfb7efebb7a@tobias.gr
Hi mikadoZero & Bruno,

I pushed #62348 patches 1 & 2 to master as
32b4f59433df620ab8f4b9a6c523f8ef9500d75d et al. I fixed a minor typo
(‘file-system’) and added a full stop.

The update patch (3/3) went to core-updates as
725b2528a65edf7425762b99330ab1c9bd33bc86.

Thanks!

T G-R

Sent from a Web browser. Excuse or enjoy my brevity.
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 34828@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 34828
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch