[PATCH] gnu: qjackctl: Disable xunique.

  • Done
  • quality assurance status badge
Details
3 participants
  • Ludovic Courtès
  • Pierre Langlois
  • Ricardo Wurmus
Owner
unassigned
Submitted by
Pierre Langlois
Severity
normal

Debbugs page

Pierre Langlois wrote 6 years ago
(address . guix-patches@gnu.org)(name . Pierre Langlois)(address . pierre.langlois@gmx.com)
cubfttyj37e.fsf@gmx.com
Hello Guix!

For the past few months I've been unable to use qjackctl, it would
freeze X all together on startup. It seems to happen only in tiling
window manager though. But, it looks like people upstream have found the
problem and disabling xunique fixes it!

The bug mentions qsynth too, I'll check if it has the same problem.

Thanks!
Pierre
From c1ab105660e8572d6711d408a8441d4b51327f25 Mon Sep 17 00:00:00 2001
From: Pierre Langlois <pierre.langlois@gmx.com>
Date: Fri, 11 Jan 2019 20:55:42 +0000
Subject: [PATCH] gnu: qjackctl: Disable xunique.

* gnu/packages/audio.scm (qjackctl)[arguments]: Pass "--disable-xunique" to
configure-flags.
---
gnu/packages/audio.scm | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

Toggle diff (27 lines)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index d47dd90f56..c3761db6c3 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -18,6 +18,7 @@
;;; Copyright © 2018 Thorsten Wilms <t_w_@freenet.de>
;;; Copyright © 2018 Eric Bavier <bavier@member.fsf.org>
;;; Copyright © 2018 Brendan Tildesley <brendan.tildesley@openmailbox.org>
+;;; Copyright © 2019 Pierre Langlois <pierre.langlois@gmx.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -2154,7 +2155,11 @@ and ALSA.")
"1rzzqa39a6llr52vjkjr0a86nc776kmr5xs52qqga8ms9697psz5"))))
(build-system gnu-build-system)
(arguments
- '(#:tests? #f)) ; no check target
+ '(#:tests? #f ;; no check target
+ ;; Disable xunique to prevent X hanging when starting qjackctl in
+ ;; tiling window managers such as StumpWM or i3
+ ;; (see https://github.com/rncbc/qjackctl/issues/13).
+ #:configure-flags '("--disable-xunique")))
(inputs
`(("jack" ,jack-1)
("alsa-lib" ,alsa-lib)
--
2.20.1
Ludovic Courtès wrote 6 years ago
(name . Pierre Langlois)(address . pierre.langlois@gmx.com)
87bm4kyzgv.fsf@gnu.org
Hi Pierre,

Pierre Langlois <pierre.langlois@gmx.com> skribis:

Toggle quote (8 lines)
> For the past few months I've been unable to use qjackctl, it would
> freeze X all together on startup. It seems to happen only in tiling
> window manager though. But, it looks like people upstream have found the
> problem and disabling xunique fixes it!
> See https://github.com/rncbc/qjackctl/issues/13.
>
> The bug mentions qsynth too, I'll check if it has the same problem.

It LGTM, but let’s see if Ricardo approves. :-)

Thanks,
Ludo’.
Ricardo Wurmus wrote 6 years ago
(name . Ludovic Courtès)(address . ludo@gnu.org)
8736pwnpp0.fsf@elephly.net
Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (14 lines)
> Hi Pierre,
>
> Pierre Langlois <pierre.langlois@gmx.com> skribis:
>
>> For the past few months I've been unable to use qjackctl, it would
>> freeze X all together on startup. It seems to happen only in tiling
>> window manager though. But, it looks like people upstream have found the
>> problem and disabling xunique fixes it!
>> See https://github.com/rncbc/qjackctl/issues/13.
>>
>> The bug mentions qsynth too, I'll check if it has the same problem.
>
> It LGTM, but let’s see if Ricardo approves. :-)

This seems okay to me. This is only about letting qjackctl capture
attempts to start it another time, which isn’t an essential feature. It
starts jackd in the background and *that* can’t be started more than
once on the same audio device anyway.

--
Ricardo
Ludovic Courtès wrote 6 years ago
(name . Ricardo Wurmus)(address . rekado@elephly.net)
87ef97p673.fsf@gnu.org
Hello,

Ricardo Wurmus <rekado@elephly.net> skribis:

Toggle quote (21 lines)
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hi Pierre,
>>
>> Pierre Langlois <pierre.langlois@gmx.com> skribis:
>>
>>> For the past few months I've been unable to use qjackctl, it would
>>> freeze X all together on startup. It seems to happen only in tiling
>>> window manager though. But, it looks like people upstream have found the
>>> problem and disabling xunique fixes it!
>>> See https://github.com/rncbc/qjackctl/issues/13.
>>>
>>> The bug mentions qsynth too, I'll check if it has the same problem.
>>
>> It LGTM, but let’s see if Ricardo approves. :-)
>
> This seems okay to me. This is only about letting qjackctl capture
> attempts to start it another time, which isn’t an essential feature. It
> starts jackd in the background and *that* can’t be started more than
> once on the same audio device anyway.

Alright, I’ve applied it now. Thanks!

Ludo’.
Closed
Pierre Langlois wrote 6 years ago
(name . Ludovic Courtès)(address . ludo@gnu.org)
cubef965nik.fsf@gmx.com
Ludovic Courtès writes:

Toggle quote (18 lines)
> Hello,
>
> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>>
>>> Hi Pierre,
>>>
>>> Pierre Langlois <pierre.langlois@gmx.com> skribis:
>>>
>>>> For the past few months I've been unable to use qjackctl, it would
>>>> freeze X all together on startup. It seems to happen only in tiling
>>>> window manager though. But, it looks like people upstream have found the
>>>> problem and disabling xunique fixes it!
>>>> See https://github.com/rncbc/qjackctl/issues/13.
>>>>
>>>> The bug mentions qsynth too, I'll check if it has the same problem.

By the way, I've installed qsynth and it doesn't hang the system.

Toggle quote (10 lines)
>>>
>>> It LGTM, but let’s see if Ricardo approves. :-)
>>
>> This seems okay to me. This is only about letting qjackctl capture
>> attempts to start it another time, which isn’t an essential feature. It
>> starts jackd in the background and *that* can’t be started more than
>> once on the same audio device anyway.
>
> Alright, I’ve applied it now. Thanks!

Brilliant, thanks!!

Pierre
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 34046@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 34046
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help