fortune-mod build (test) failure

Done

Details

5 participants

Danny Milosavljevic
Sarah Morgensen
Leo Famulari
Pierre Neidhardt
Maxim Cournoyer

Owner: unassigned

Submitted by: Danny Milosavljevic

Severity: normal

Debbugs page

Danny Milosavljevic wrote 6 years ago

Recipients:(address . bug-guix@gnu.org)

Message-ID:20181204111033.0aa0d4c6@scratchpost.org

Running [prove /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/check-cookies.t /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/test-fortune-m.t /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/test-fortune-o-rot.t /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/trailing-space-and-CRs.t /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t]
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/check-cookies.t ........... ok
(computers)
%
(cookie)
%
(politics)
%
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/test-fortune-m.t .......... ok
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/test-fortune-o-rot.t ...... ok
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/trailing-space-and-CRs.t .. ok
No fortunes found

#   Failed test 'fortune valgrind test'
#   at /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t line 15.
No fortunes found

#   Failed test 'fortune -f valgrind test'
#   at /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t line 25.
No fortunes found

#   Failed test 'fortune -m valgrind test'
#   at /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t line 35.
No fortunes found

#   Failed test 'fortune -i -m valgrind test'
#   at /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t line 45.
# Looks like you failed 4 tests of 4.
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t              (Wstat: 1024 Tests: 4 Failed: 4)
  Failed tests:  1-4
  Non-zero exit status: 4
Files=5, Tests=10, 22 wallclock secs ( 0.40 usr  0.05 sys + 14.69 cusr  6.35 csys = 21.49 CPU)
Result: FAIL
Running [prove /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/check-cookies.t /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/test-fortune-m.t /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/test-fortune-o-rot.t /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/trailing-space-and-CRs.t /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t] failed! at /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/run-tests.pl line 32.
make[3]: *** [CMakeFiles/check.dir/build.make:60: CMakeFiles/check] Error 1
make[3]: Leaving directory '/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/build'

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlwGUpkACgkQ5xo1VCww

uqXv8Qf/WCTENHgLqMiAD4Wy4b361wCft8X9r1SLv+EKqEQPEScbfCqn+SSKLNly

5GHMBk5TuQfvNxhBr9NyPFHi2Tb4ry0bCXR7OfOJp9JBWX5ZxOsmC7rHdLrKlvBt

wHPNKzwFRTMQUUROjcHVOYVLkGF8ydfJM3W/WvXMSlc6UO3pAwHGaDKYNYEP16n1

AzIFbFenVdA0vOwLQNEsy8e4G23jNCA6IfvpmCY+czEeFVFQ47hCjxjbPB/4gzq2

e4hOh4P3LnTH+NHednIa9Me7DBlL2j+KUwZFCVztRr3gYV2k24fPbEqq+47LUCkD

uMcN8ynkbPqktqm9BWV2HyBhAsEuuA==

=qL5t

-----END PGP SIGNATURE-----

Leo Famulari wrote 6 years ago

Recipients:(name . Danny Milosavljevic)(address . dannym@scratchpost.org)(address . 33609@debbugs.gnu.org)

Message-ID:20181204213425.GA8601@jasmine.lan

On Tue, Dec 04, 2018 at 11:10:33AM +0100, Danny Milosavljevic wrote:

Toggle quote (7 lines)

> # Looks like you failed 4 tests of 4.

> /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t (Wstat: 1024 Tests: 4 Failed: 4)

> Failed tests: 1-4

> Non-zero exit status: 4

> Files=5, Tests=10, 22 wallclock secs ( 0.40 usr 0.05 sys + 14.69 cusr 6.35 csys = 21.49 CPU)

> Result: FAIL

I wonder, does this program really need a test suite that includes

Valgrind?

Pierre Neidhardt wrote 6 years ago

bug#33609: fortune-mod build (test) failure

Recipients:(address . 33609@debbugs.gnu.org)

Message-ID:87womxk6h5.fsf@ambrevar.xyz

I've pushed 6185732390003ca36a730231bb6280b68c37ee8e which skips the

valgrind test. This is not ideal but better than having a broken

package.

Upstream has https://github.com/shlomif/fortune-mod/issues/21which

could be related.

Pierre Neidhardt

https://ambrevar.xyz/

Sarah Morgensen wrote 3 years ago

Recipients:(name . Pierre Neidhardt)(address . mail@ambrevar.xyz)(address . 33609@debbugs.gnu.org)

Message-ID:86k0jjiwvd.fsf@mgsn.dev

Hi,

Pierre Neidhardt <mail@ambrevar.xyz> writes:

Toggle quote (7 lines)

> I've pushed 6185732390003ca36a730231bb6280b68c37ee8e which skips the

> valgrind test. This is not ideal but better than having a broken

> package.

> Upstream has https://github.com/shlomif/fortune-mod/issues/21 which

> could be related.

This seems to be fixed now. I've attached a patch below to reenable it.

It could probably do with an update, too. It now vendors 'rinutils'

(which we already have as an input) so that would need to be removed.

Sarah

From 5aa332afa3f624ecab54ffd411026700b0d0dfb8 Mon Sep 17 00:00:00 2001

Message-Id: <5aa332afa3f624ecab54ffd411026700b0d0dfb8.1631594857.git.iskarian@mgsn.dev>

Re-enable the valgrind test, fixed in a previous version update.

* gnu/packages/games.scm (fortune-mod)[arguments]<#:phases>

{fix-build-env}: Re-enable test.

---

gnu/packages/games.scm | 6 +-----

1 file changed, 1 insertion(+), 5 deletions(-)

Toggle diff (21 lines)diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index a2f756e3a7..4236560143 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -7633,11 +7633,7 @@ original.")
                (copy-file cmake-rules
                           (string-append "fortune-mod/cmake/"
                                          (strip-store-file-name cmake-rules)))
-               (chdir "fortune-mod")
-               ;; TODO: Valgrind tests fail for some reason.
-               ;; Similar issue: https://github.com/shlomif/fortune-mod/issues/21 (?)
-               (delete-file "tests/t/valgrind.t")
-               #t)))
+               (chdir "fortune-mod"))))
          (add-after 'install 'fix-install-directory
            (lambda* (#:key outputs #:allow-other-keys)
              ;; Move binary from "games/" to "bin/" and remove the latter.  This

base-commit: 72297993a174586ee0a23b95b6b9ee2f3db34cf1
-- 
2.33.0

Maxim Cournoyer wrote 3 years ago

Recipients:(name . Sarah Morgensen)(address . iskarian@mgsn.dev)

Message-ID:87o7xtyrvj.fsf@gmail.com

Hi,

Sarah Morgensen <iskarian@mgsn.dev> writes:

Toggle quote (16 lines)> Hi,
>
> Pierre Neidhardt <mail@ambrevar.xyz> writes:
>
>> I've pushed 6185732390003ca36a730231bb6280b68c37ee8e which skips the
>> valgrind test.  This is not ideal but better than having a broken
>> package.
>>
>> Upstream has https://github.com/shlomif/fortune-mod/issues/21 which
>> could be related.
>
> This seems to be fixed now.  I've attached a patch below to reenable it.
>
> It could probably do with an update, too.  It now vendors 'rinutils'
> (which we already have as an input) so that would need to be removed.

Our fortune-mod package is now at version 3.14.0. I haven't reviewed

bundling status, but if there are problem, we can open a new issue.

Closing for now,

Thanks!

Maxim

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 33609@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 33609

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags

mumi command -t +confirmed -t +easy

Or, remove the moreinfo tag and set the help tag

mumi command -t -moreinfo -t +help

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date