[Wishlist] recursive guix lint

Open

Details

2 participants

Efraim Flashner
Ludovic Courtès

Owner: unassigned

Submitted by: Efraim Flashner

Severity: wishlist

Efraim Flashner wrote on 24 Oct 2018 14:39

Recipients:(address . bug-guix@gnu.org)

Message-ID:20181024123915.GB1297@macbook41

We have the linter check for CVEs and updates to packages in a list, but
what about those packages they depend on? It would be great to be able
to 'guix lint --recursive foo' and get foo and also all the packages in
the different types of inputs.

-- 
Efraim Flashner   <efraim@flashner.co.il>   ????? ?????
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Ludovic Courtès wrote on 25 Oct 2018 15:31

Recipients:(name . Efraim Flashner)(address . efraim@flashner.co.il)(address . 33137@debbugs.gnu.org)

Message-ID:875zxqup8r.fsf@gnu.org

Hello,

Efraim Flashner <efraim@flashner.co.il> skribis:

Toggle quote (5 lines)

> We have the linter check for CVEs and updates to packages in a list, but

> what about those packages they depend on? It would be great to be able

> to 'guix lint --recursive foo' and get foo and also all the packages in

> the different types of inputs.

On the question of CVEs, see also

https://issues.guix.info/issue/31442.

Do you think --recursive would be useful for other types of linters?

Thanks,

Ludo’.

Efraim Flashner wrote on 27 Oct 2018 22:30

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 33137@debbugs.gnu.org)

Message-ID:20181027203013.GF1297@macbook41

On Thu, Oct 25, 2018 at 03:31:32PM +0200, Ludovic Courtès wrote:

Toggle quote (17 lines)> Hello,
> 
> Efraim Flashner <efraim@flashner.co.il> skribis:
> 
> > We have the linter check for CVEs and updates to packages in a list, but
> > what about those packages they depend on? It would be great to be able
> > to 'guix lint --recursive foo' and get foo and also all the packages in
> > the different types of inputs.
> 
> On the question of CVEs, see also
> <https://issues.guix.info/issue/31442>.
> 
> Do you think --recursive would be useful for other types of linters?
> 
> Thanks,
> Ludo’.

Checking for new versions would definately be good. It seems to me that checking
everything would make for better code overall, but the behavior I would
expect is that it would check all the linters specified in the command.

-- 
Efraim Flashner   <efraim@flashner.co.il>   ????? ?????
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Ludovic Courtès wrote on 28 Oct 2018 23:29

Recipients:(name . Efraim Flashner)(address . efraim@flashner.co.il)(address . 33137@debbugs.gnu.org)

Message-ID:878t2h66yf.fsf@gnu.org

Efraim Flashner <efraim@flashner.co.il> skribis:

Toggle quote (20 lines)> On Thu, Oct 25, 2018 at 03:31:32PM +0200, Ludovic Courtès wrote:
>> Hello,
>> 
>> Efraim Flashner <efraim@flashner.co.il> skribis:
>> 
>> > We have the linter check for CVEs and updates to packages in a list, but
>> > what about those packages they depend on? It would be great to be able
>> > to 'guix lint --recursive foo' and get foo and also all the packages in
>> > the different types of inputs.
>> 
>> On the question of CVEs, see also
>> <https://issues.guix.info/issue/31442>.
>> 
>> Do you think --recursive would be useful for other types of linters?
>> 
>> Thanks,
>> Ludo’.
>
> Checking for new versions would definately be good.

But that’s what ‘guix refresh’ does, right?

Toggle quote (4 lines)

> It seems to me that checking everything would make for better code

> overall, but the behavior I would expect is that it would check all

> the linters specified in the command.

If you run ‘guix lint’ without any arguments, all the packages are

checked. Is this what you meant?

Thanks,

Ludo’.

Efraim Flashner wrote on 30 Oct 2018 08:35

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 33137@debbugs.gnu.org)

Message-ID:20181030073529.GI1297@macbook41

On Sun, Oct 28, 2018 at 11:29:28PM +0100, Ludovic Courtès wrote:

Toggle quote (25 lines)> Efraim Flashner <efraim@flashner.co.il> skribis:
> 
> > On Thu, Oct 25, 2018 at 03:31:32PM +0200, Ludovic Courtès wrote:
> >> Hello,
> >> 
> >> Efraim Flashner <efraim@flashner.co.il> skribis:
> >> 
> >> > We have the linter check for CVEs and updates to packages in a list, but
> >> > what about those packages they depend on? It would be great to be able
> >> > to 'guix lint --recursive foo' and get foo and also all the packages in
> >> > the different types of inputs.
> >> 
> >> On the question of CVEs, see also
> >> <https://issues.guix.info/issue/31442>.
> >> 
> >> Do you think --recursive would be useful for other types of linters?
> >> 
> >> Thanks,
> >> Ludo’.
> >
> > Checking for new versions would definately be good.
> 
> But that’s what ‘guix refresh’ does, right?
> 

I assume you mean 'guix lint -c refresh'. 'guix lint -c refresh foo' is

nice, but we don't have anything that could take the place of 'guix lint

-c refresh --recursive foo'

I just saw again 'guix refresh', 'guix refresh --recursive -m

my-manifest.scm' would be great.

Toggle quote (7 lines)

> > It seems to me that checking everything would make for better code

> > overall, but the behavior I would expect is that it would check all

> > the linters specified in the command.

> If you run ‘guix lint’ without any arguments, all the packages are

> checked. Is this what you meant?

I meant more like "hey, khard can be upgraded to 0.12.2, after I've

checked the upgrade with 'guix lint khard', now I'd like to check the rest

of the dependency tree with 'guix lint --recursive khard' to see if

anything else can be upgraded or has any linter errors."

Toggle quote (4 lines)

> Thanks,

> Ludo’.

-- 
Efraim Flashner   <efraim@flashner.co.il>   ????? ?????
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Ludovic Courtès wrote on 30 Oct 2018 19:13

Recipients:(name . Efraim Flashner)(address . efraim@flashner.co.il)(address . 33137@debbugs.gnu.org)

Message-ID:87sh0nz4ir.fsf@gnu.org

Hello,

Efraim Flashner <efraim@flashner.co.il> skribis:

Toggle quote (5 lines)

> I meant more like "hey, khard can be upgraded to 0.12.2, after I've

> checked the upgrade with 'guix lint khard', now I'd like to check the rest

> of the dependency tree with 'guix lint --recursive khard' to see if

> anything else can be upgraded or has any linter errors."

Oh I see.  So to me this would be a ‘guix refresh’ feature rather than
‘guix lint’, but I agree it would be nice (and not too hard to
implement.)

Thanks,
Ludo.’

Efraim Flashner wrote on 31 Oct 2018 10:57

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 33137@debbugs.gnu.org)

Message-ID:20181031095738.GJ1297@macbook41

On Tue, Oct 30, 2018 at 07:13:48PM +0100, Ludovic Courtès wrote:

Toggle quote (13 lines)> Hello,
> 
> Efraim Flashner <efraim@flashner.co.il> skribis:
> 
> > I meant more like "hey, khard can be upgraded to 0.12.2, after I've
> > checked the upgrade with 'guix lint khard', now I'd like to check the rest
> > of the dependency tree with 'guix lint --recursive khard' to see if
> > anything else can be upgraded or has any linter errors."
> 
> Oh I see.  So to me this would be a ‘guix refresh’ feature rather than
> ‘guix lint’, but I agree it would be nice (and not too hard to
> implement.)
> 

I think ultimately implementing it in both would be good, but even just
having it for refresh would go a long way to shedding light on some of
our libraries that aren't updates as often as they might be. Especially
with the scripting langaguages.

-- 
Efraim Flashner   <efraim@flashner.co.il>   ????? ?????
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 33137@debbugs.gnu.org

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date