Le 2018-10-05 17:50, Danny Milosavljevic a écrit :
I think the message should be simply
* gnu/packages/batik.scm: New file.
Toggle quote (33 lines)
> gnu/packages/batik.scm | 85 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 85 insertions(+)
> create mode 100644 gnu/packages/batik.scm
> diff --git a/gnu/packages/batik.scm b/gnu/packages/batik.scm
> index 000000000..2ca15b763
> +++ b/gnu/packages/batik.scm
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2018 Danny Milosavljevic <dannym@scratchpost.org>
> +;;; This file is part of GNU Guix.
> +;;; GNU Guix is free software; you can redistribute it and/or modify
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or
> +;;; your option) any later version.
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +;;; GNU General Public License for more details.
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
> +(define-module (wip batik)
Testing leftover? It should be (gnu packages batik)
The filename should end with ".tar.gz"
That's already the default value
,@(package-arguments base-package)))
Nice! I guess every package will have the same synopsis and description,
which makes it hard to understand what they do. Could you do something
about it? For instance, using:
(description (string-append (package-description java-batik) " "
additional-description))) in java-batik-package?
I also have my own version of this package that uses build.xml. So my
question is, why did you split this package? Here are two package
(define-public java-batik
"mirror://apache/xmlgraphics/batik/source/"
"batik-src-" version ".tar.gz"))
"05nipxvm940m2dgzmrvflr2r72a5mmqbl25pvqr0xn73a5lygi6z"))))
(build-system ant-build-system)
`(#:test-target "regard"; FIXME: no test is actually run
(modify-phases %standard-phases
(add-before 'check 'remove-failing
;; This file looks for w3c.dom.Window, but it has been
;; org.apache.batik.w3c.dom.Window.
"samples/tests/resources/java/sources/com/untrusted/script/UntrustedScriptHandler.java")
(lambda* (#:key outputs #:allow-other-keys)
(let ((dir (string-append (assoc-ref outputs "out")
(copy-file (string-append "batik-" ,version
"/lib/batik-all-" ,version ".jar")
(string-append dir "batik-all.jar"))))))))
`(("java-xmlgraphics-commons" ,java-xmlgraphics-commons)))
`(("java-junit" ,java-junit)))
(license license:asl2.0)))
(define-public java-xmlgraphics-commons
(name "java-xmlgraphics-commons")
"mirror://apache/xmlgraphics/commons/source/"
"xmlgraphics-commons-" version
"0a432a4ca3vgnbada5cy9mlmfzmq6hi4i176drfxrp17q2d43w23"))))
(build-system ant-build-system)
`(#:jar-name "xmlgraphics-commons.jar"
#:source-dir "src/main/java"
#:tests? #f; FIXME: need commons-xml-resolver
(modify-phases %standard-phases
(add-before 'build 'copy-resources
(copy-recursively "src/main/resources" "build/classes")
`(("java-commons-io" ,java-commons-io)
("java-commons-logging-minimal" ,java-commons-logging-minimal)))
`(("java-junit" ,java-junit)
("java-mockito-1" ,java-mockito-1)))
(home-page "https://xmlgraphics.apache.org")
(license license:asl2.0)))