Update: Erlang and Elixir

Done

Details

3 participants

Ludovic Courtès
Nils Gillmann
Pjotr Prins

Owner: unassigned

Submitted by: Nils Gillmann

Severity: normal

Debbugs page

Nils Gillmann wrote 7 years ago

Recipients:(address . guix-patches@gnu.org)

Message-ID:20180716100730.ixv5mqqlbl3tdleb@abyayala

These 3 patches update Erlang and Elixir to the latest versions.

From 6b142a63d4b48ee887e0f27cd2e2fc4733b7b236 Mon Sep 17 00:00:00 2001

Signed-off-by: Nils Gillmann <gillmann@infotropique.org>

---

.mailmap | 1 +

1 file changed, 1 insertion(+)

Toggle diff (14 lines)diff --git a/.mailmap b/.mailmap
index 4f672f327..74434a39e 100644
--- a/.mailmap
+++ b/.mailmap
@@ -43,6 +43,7 @@ Mathieu Lirzin <mthl@gnu.org> <mathieu.lirzin@openmailbox.org>
 Mathieu Othacehe <m.othacehe@gmail.com>
 Nikita Karetnikov <nikita@karetnikov.org> <nikita.karetnikov@gmail.com>
 Nils Gillmann <ng0@n0.is> ng0 <ng0@n0.is>
+Nils Gillmann <ng0@n0.is> Nils Gillmann <gillmann@infotropique.org>
 Nils Gillmann <ng0@n0.is> ng0 <ng0@crash.cx>
 Nils Gillmann <ng0@n0.is> ng0 <ng0@crash.cx>
 Nils Gillmann <ng0@n0.is> <ng0@infotropique.org>
-- 
2.18.0

From b7b3a3dc544e63ab21ff5c7e7746e54654f78752 Mon Sep 17 00:00:00 2001

* gnu/packages/erlang.scm (erlang): Update to 21.0.

Signed-off-by: Nils Gillmann <gillmann@infotropique.org>

---

gnu/packages/erlang.scm | 7 ++++---

1 file changed, 4 insertions(+), 3 deletions(-)

Toggle diff (41 lines)diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm
index 1c18efe9d..f0b2f350c 100644
--- a/gnu/packages/erlang.scm
+++ b/gnu/packages/erlang.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2016, 2017 Leo Famulari <leo@famulari.name>
 ;;; Copyright © 2016, 2017 Pjotr Prins <pjotr.guix@thebird.nl>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me@tobias.gr>
+;;; Copyright (C) 2018 Nils Gillmann <ng0@n0.is>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -37,7 +38,7 @@
 (define-public erlang
   (package
     (name "erlang")
-    (version "20.2.3")
+    (version "21.0")
     (source (origin
               (method url-fetch)
               ;; The tarball from http://erlang.org/download contains many
@@ -48,7 +49,7 @@
               (file-name (string-append name "-" version ".tar.gz"))
               (sha256
                (base32
-                "0s9g4ijdbqq21k4cqggz074d3fiimah942qisv2kgizhlivpw2nm"))
+                "0gv43lra4870xns8b0yjzbq78afzvz9gk6y3q3fa4y4sqcrqwbas"))
               (patches (search-patches "erlang-man-path.patch"))))
     (build-system gnu-build-system)
     (native-inputs
@@ -64,7 +65,7 @@
                                (version-major+minor version) ".tar.gz"))
            (sha256
             (base32
-             "1pyb8wbk7znsyni8d1k4dj1m01lr191dcrrzisli1z27ks7hh3lm"))))))
+             "0cgv23q0215f6lvmhj4w9skx5m29khjs9mb890635s3yp520xgqh"))))))
     (inputs
      `(("ncurses" ,ncurses)
        ("openssl" ,openssl)
-- 
2.18.0

From 872a4c6b71f702cd86d2374f9bb2e03ad09dd09b Mon Sep 17 00:00:00 2001

* gnu/packages/elixir.scm (elixir): Update to 1.6.6.

Signed-off-by: Nils Gillmann <gillmann@infotropique.org>

---

gnu/packages/elixir.scm | 5 +++--

1 file changed, 3 insertions(+), 2 deletions(-)

Toggle diff (32 lines)diff --git a/gnu/packages/elixir.scm b/gnu/packages/elixir.scm
index ed6bd0023..3368449b4 100644
--- a/gnu/packages/elixir.scm
+++ b/gnu/packages/elixir.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2016 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2017 nee <nee.git@cock.li>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me@tobias.gr>
+;;; Copyright (C) 2018 Nils Gillmann <ng0@n0.is>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -32,7 +33,7 @@
 (define-public elixir
   (package
     (name "elixir")
-    (version "1.5.3")
+    (version "1.6.6")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://github.com/elixir-lang/elixir"
@@ -40,7 +41,7 @@
               (file-name (string-append name "-" version ".tar.gz"))
               (sha256
                (base32
-                "0acnxfwvkx1m1d0h5z051mz95n35zm468hcvc3wpmn17c15h5ihg"))))
+                "0c9qz5hasa59a9x1iwpcqpqj6wdbzpijfxqfmzimwj5z8q37nl3l"))))
     (build-system gnu-build-system)
     (arguments
      `(#:test-target "test"
-- 
2.18.0

Ludovic Courtès wrote 7 years ago

Recipients:(name . Nils Gillmann)(address . ng0@n0.is)(address . 32171@debbugs.gnu.org)

Message-ID:87wotvtdma.fsf@gnu.org

Hello Nils,

Nils Gillmann <ng0@n0.is> skribis:

Toggle quote (2 lines)

> These 3 patches update Erlang and Elixir to the latest versions.

Thanks for the patches. Erlang builds fine but Elixir’s tests fail

for me:

Toggle snippet (45 lines)

starting phase `check'

==> elixir (compile)

==> elixir (eunit)

All 199 tests passed.

==> elixir (exunit)

Excluding tags: [windows: true]

.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

1) test case with empty clause (Code.Formatter.IntegrationTest)

test/elixir/code_formatter/integration_test.exs:312

** (RuntimeError) IO device registered at :standard_error is already captured

code: ExUnit.CaptureIO.capture_io(:stderr, fn ->

stacktrace:

(ex_unit) lib/ex_unit/capture_io.ex:144: ExUnit.CaptureIO.do_capture_io/3

test/elixir/code_formatter/integration_test.exs:313: (test)

test/elixir/kernel/docs_test.exs:182

..........................................

Finished in 27.5 seconds (11.2s on load, 16.3s on tests)

1367 doctests, 2893 tests, 1 failure, 7 skipped

Randomized with seed 36445

make: *** [Makefile:216: test_stdlib] Error 1

Test suite failed, dumping logs.

Backtrace:

4 (primitive-load "/gnu/store/h4yzwydlq6jny17vmmyqqh319yn?")

In ice-9/eval.scm:

191:35 3 (_ _)

In srfi/srfi-1.scm:

640:9 2 (for-each #<procedure adde60 at /gnu/store/f95ghy8mx00?> ?)

In /gnu/store/f95ghy8mx00fc22nrvswvnpqlfdkf2nk-module-import/guix/build/gnu-build-system.scm:

799:31 1 (_ _)

369:6 0 (check #:target _ #:make-flags _ #:tests? _ # _ # _ # _)

/gnu/store/f95ghy8mx00fc22nrvswvnpqlfdkf2nk-module-import/guix/build/gnu-build-system.scm:369:6: In procedure check:

Throw to key `srfi-34' with args `(#<condition &invoke-error [program: "make" arguments: ("test" "-j" "24" "PREFIX=/gnu/store/7jshqipclwq4x3nxb735pfhpmnrjyy38-elixir-1.6.6") exit-status: 2 term-signal: #f stop-signal: #f] ae4b40>)'.

builder for `/gnu/store/4yfcqji3szbbgrihgrax5wzidzigacjm-elixir-1.6.6.drv' failed with exit code 1

Any ideas?

Thanks,

Ludo’.

Nils Gillmann wrote 7 years ago

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 32171@debbugs.gnu.org)(name . Nils Gillmann)(address . ng0@n0.is)

Message-ID:20180716153634.gpwa2zw3v6fxm5ln@abyayala

Attachment: file

Nils Gillmann wrote 7 years ago

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 32171@debbugs.gnu.org)(name . Nils Gillmann)(address . ng0@n0.is)

Message-ID:20180716155316.62rrscxji5gtvj6n@abyayala

Attachment: file

Nils Gillmann wrote 7 years ago

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 32171@debbugs.gnu.org)(name . Nils Gillmann)(address . ng0@n0.is)

Message-ID:20180716160610.pyeca44pwfugm7la@abyayala

Attachment: file

Ludovic Courtès wrote 7 years ago

Recipients:(name . Nils Gillmann)(address . ng0@n0.is)(address . 32171@debbugs.gnu.org)

Message-ID:87a7qrrn2e.fsf@gnu.org

Nils Gillmann <ng0@n0.is> skribis:

Toggle quote (3 lines)

> Okay, before I leave I've --check build the package again, at most

> built with make -j4... Can you try and build it with less cores?

If you suspect a parallelism issue, could you check whether other

distros have patches along these lines, or whether

#:parallel-builds? #f gives us something that works reproducibly?

Toggle quote (2 lines)

> guix build: error: build failed: derivation `/gnu/store/57394p4p5l928711hzj4xg7mkcg1zmz0-elixir-1.6.6.drv' may not be deterministic: output `/gnu/store/7jshqipclwq4x3nxb735pfhpmnrjyy38-elixir-1.6.6' differs

Once we’ve fixed the issue above, we should look into this. :-)

Ludo’.

Nils Gillmann wrote 7 years ago

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(name . Pjotr Prins)(address . pjotr.public12@thebird.nl)(address . 32171@debbugs.gnu.org)(name . Nils Gillmann)(address . ng0@n0.is)

Message-ID:20180716202248.rdhlggsy7zfw2k6w@abyayala

Attachment: file

Pjotr Prins wrote 7 years ago

Recipients:(name . Nils Gillmann)(address . ng0@n0.is)(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 32171@debbugs.gnu.org)(name . Pjotr Prins)(address . pjotr.public12@thebird.nl)

Message-ID:20180717094839.yixlfony4o3nwsfd@thebird.nl

On Mon, Jul 16, 2018 at 08:22:48PM +0000, Nils Gillmann wrote:

Toggle quote (2 lines)

> Apparently we had this (Erlang, Elixir reproducible) fixed at some point.

That was due to beam's time stamp getting removed.

Toggle quote (4 lines)

> compressing documentation in '/gnu/store/a3938xrgzdlwh25qfpbhrgaf9gm6231b-erlang-21.0/share/man' with "gzip" and flags ("--best" "--no-name")

> phase `compress-documentation' succeeded after 0.3 seconds

> guix build: error: build failed: derivation `/gnu/store/1vaz67iwn518m8d35j98zjpy3fjw92ca-erlang-21.0.drv' may not be deterministic: output `/gnu/store/a3938xrgzdlwh25qfpbhrgaf9gm6231b-erlang-21.0' differs

I may look into this at some point. Best is to see what individual

files were changed during different builds. Erlang cares about

reproducibility, so they'll be responsive.

Pj.

Ludovic Courtès wrote 7 years ago

Recipients:(name . Nils Gillmann)(address . ng0@n0.is)(name . Pjotr Prins)(address . pjotr.public12@thebird.nl)(address . 32171-done@debbugs.gnu.org)

Message-ID:87601e9h0e.fsf@gnu.org

Nils Gillmann <ng0@n0.is> skribis:

Toggle quote (12 lines)> Ludovic Courtès transcribed 660 bytes:
>> Nils Gillmann <ng0@n0.is> skribis:
>> 
>> > Okay, before I leave I've --check build the package again, at most
>> > built with make -j4... Can you try and build it with less cores?
>> 
>> If you suspect a parallelism issue, could you check whether other
>> distros have patches along these lines, or whether
>> #:parallel-builds? #f gives us something that works reproducibly?
>
> parallel-build set to #f does gives us a reproducible elixir package.

Indeed, #:parallel-tests? #f is enough actually. So I added that and

committed the update.

It would be nice if you could take a closer look at the

bit-reproducibility issue, but we’ll do that separately.

Thank you!

Ludo’.

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 32171@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 32171

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags

mumi command -t +confirmed -t +easy

Or, remove the moreinfo tag and set the help tag

mumi command -t -moreinfo -t +help

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date