shaderc fails its test suite on all hydra-supported systems

  • Open
  • quality assurance status badge
Details
2 participants
  • Mark H Weaver
  • Rutger Helling
Owner
unassigned
Submitted by
Mark H Weaver
Severity
normal
M
M
Mark H Weaver wrote on 26 Jun 2018 19:44
(address . bug-guix@gnu.org)
877emlcujd.fsf@netris.org
shaderc fails its test suite on all systems supported by Hydra, but the
builds succeed because the #f returned by meson-build-system's check
phase is ignored, due to https://bugs.gnu.org/31974.


See below for the relevant excerpt of the log.

I have a preliminary patch to fix 'meson-build-system' to return #t from
all phases, and will push after some testing.

Mark

Toggle snippet (33 lines)
phase `build' succeeded after 119.5 seconds
starting phase `check'
[0/1] Running tests...
Test project /tmp/guix-build-shaderc-0.0.0-2.be8e087.drv-0/source
Start 1: spirv-tools-symbol-exports-SPIRV-Tools
1/4 Test #1: spirv-tools-symbol-exports-SPIRV-Tools ..........***Failed 0.60 sec
Start 2: spirv-tools-symbol-exports-SPIRV-Tools-shared
2/4 Test #2: spirv-tools-symbol-exports-SPIRV-Tools-shared ...***Failed 0.13 sec
Start 3: spirv-tools-symbol-exports-SPIRV-Tools-opt
3/4 Test #3: spirv-tools-symbol-exports-SPIRV-Tools-opt ......***Failed 0.14 sec
Start 4: spirv-tools-symbol-exports-SPIRV-Tools-link
4/4 Test #4: spirv-tools-symbol-exports-SPIRV-Tools-link .....***Failed 0.12 sec

0% tests passed, 4 tests failed out of 4

Total Test time (real) = 1.02 sec

The following tests FAILED:
1 - spirv-tools-symbol-exports-SPIRV-Tools (Failed)
2 - spirv-tools-symbol-exports-SPIRV-Tools-shared (Failed)
3 - spirv-tools-symbol-exports-SPIRV-Tools-opt (Failed)
4 - spirv-tools-symbol-exports-SPIRV-Tools-link (Failed)
Errors while running CTest
FAILED: CMakeFiles/test.util
cd /tmp/guix-build-shaderc-0.0.0-2.be8e087.drv-0/source && /gnu/store/g85ikfjxs2d7aydvg5w06jn2h9xrjmpc-cmake-3.11.0/bin/ctest --force-new-ctest-process
ninja: build stopped: subcommand failed.
phase `check' failed after 1.7 seconds
## WARNING: phase `check' returned `#f'. Return values other than #t
## are deprecated. Please migrate this package so that its phase
## procedures report errors by raising an exception, and otherwise
## always return #t.
starting phase `install'
M
M
Mark H Weaver wrote on 26 Jun 2018 20:41
(name . Rutger Helling)(address . rhelling@mykolab.com)(address . 31982@debbugs.gnu.org)
87zhzhbdag.fsf@netris.org
Hi Rutger,

In commit 7f540654873a2761746bdc43be4727cad99b92c0, you updated
'sharerc' to upstream commit be8e087 and enabled tests.

It turns out that it fails its test suite on all systems supported by
Hydra, but the failure is effectively being ignored, because of

I'd like to fix 'meson-build-system' to always return #t from phases and
to report errors using exceptions, which would effectively work around
the aforementioned bug, but then that would cause 'shaderc' to start
failing in earnest.

See https://bugs.gnu.org/31982 for more details.

Would you be willing to take a look and fix 'sharerc' so that it won't
start failing when I fix 'meson-build-system'?

Regards,
Mark
R
R
Rutger Helling wrote on 27 Jun 2018 11:07
(name . Mark H Weaver)(address . mhw@netris.org)(address . 31982@debbugs.gnu.org)
20180627110738.33ff76d7@mykolab.com
Hi Mark,

unfortunately I don't really have the time to look at it in-depth now.
I've disabled the tests for now so I'm not blocking you. I'll take
another look at the tests after you've fixed 'meson-build-system.

On Tue, 26 Jun 2018 14:41:59 -0400
Mark H Weaver <mhw@netris.org> wrote:

Toggle quote (23 lines)
> Hi Rutger,
>
> In commit 7f540654873a2761746bdc43be4727cad99b92c0, you updated
> 'sharerc' to upstream commit be8e087 and enabled tests.
>
> It turns out that it fails its test suite on all systems supported by
> Hydra, but the failure is effectively being ignored, because of
> <https://bugs.gnu.org/31974>.
>
> I'd like to fix 'meson-build-system' to always return #t from phases
> and to report errors using exceptions, which would effectively work
> around the aforementioned bug, but then that would cause 'shaderc' to
> start failing in earnest.
>
> See <https://bugs.gnu.org/31982> for more details.
>
> Would you be willing to take a look and fix 'sharerc' so that it won't
> start failing when I fix 'meson-build-system'?
>
> Regards,
> Mark
>
>
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEAVThuRzJ2e93ZI3n86cn20T8yjYFAlszU9oACgkQ86cn20T8
yjYVuwgAqFcTKOS8FhbSzxsuqZwnbRiXaqVAuwgZtC+tkqaeyjelkZJrCPgkMniv
SVKfhZFoYSvQK83CkBJpiWCY0PvLcCeDtoFgpNYk1BXLICHqtlA/4kvvKSEQjDbJ
eikFiFdBEMZQeobcTGxEAMNy6gGS3MTO0eF3dtZqQ+suAUxbI1JXEZo3pXGoF1aM
vxzdA1GR7QBOtCSydZD0PIT4wpH88loU/JsoMaEUSNMJHZO0rTh4ra8cZl4yGulX
RRsBrY3Ojd6j87bPFcLRZsGoq0ZlcH5/CP6oG/pnR5rr7roVIXaxIRI7a6lxo7RF
yNNKo2rl+31qqIusj6orWCwJBG7S/w==
=Uf78
-----END PGP SIGNATURE-----


?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 31982@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 31982
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch