libreoffice not reproducible

  • Done
  • quality assurance status badge
Details
3 participants
  • Danny Milosavljevic
  • Ludovic Courtès
  • Tobias Geerinckx-Rice
Owner
unassigned
Submitted by
Danny Milosavljevic
Severity
normal

Debbugs page

Danny Milosavljevic wrote 7 years ago
(address . bug-guix@gnu.org)
20180526093117.6653c908@scratchpost.org
libreoffice 5.4.7.2 is not reproducible:

│ │ ├── presets
│ │ │ ├── autotext
│ │ │ │ ├── mytexts.bau

and similar bau files

│ │ │ ├── autocorr
│ │ │ │ ├── acor_af-ZA.dat

and similar dat files

│ │ │ ├── config
│ │ │ │ ├── images_breeze.zip

and similar zip files
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlsJDUUACgkQ5xo1VCww
uqWHFAf/b18L8tY98tH/xEhhnxtHLD+Iiqi1I2t/LJz+h9YjM9tSd3XK//xecNnq
YSYswJwbZZuKy9BC2GR3Nj26HVNg0jlRv72PiLGEtRjAwjyrewtHYcHJyt5Jyz0C
qSKXvz1hBU2E+Q0r5BYfTg5C6EVlwuIV+/PxblDpyegSysevikT5Czw/0PAWGg9h
2YhL0m1M6S9b1qCfvxcCblJ9F28+d+kXWtByfbKju/wO5yXsEZSPZunuXNKCheYc
9n92ls3VRU1JZdKskS+GKSNQZ6kAA/sDuE6HM4nQ7Ew9NimgDKnqqWL1PUhLOhS7
qa/1gaNR7As50z9wL9Q+j2h4vJxgwA==
=YEmb
-----END PGP SIGNATURE-----


Danny Milosavljevic wrote 7 years ago
(address . 31602@debbugs.gnu.org)
20180527233813.3c924c19@scratchpost.org
These are actually all zip files. The reason for the non-reproducibility is
that something copies the contents from the source to a mktemp'ed directory
without preserving timestamps. Then this directory is zipped up.

So the zip file now contains non-constant timestamps.

I think it's somewhere in postprocess, but I can't find it so far.

I found packimages.pl but I'm not sure whether this does the copying, too.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlsLJUUACgkQ5xo1VCww
uqV+GQgAoc9TV3e/Ra2HJanpQe2MKGrALQy9oIzeHvGgJ70c4shiz9vkr5mrLoLV
sSGvAJ1TRzxpLbxG5db5S8ovT6j3WhISEQhmoU5CRB0eYhH27szGJ+3JX6jZ8X32
3MZOwO3EJ/S0MhI8VyDG1qlWuzT7ngZA1odQ1tc53If6CK6t0Z8cNhbzPBO0CqzE
JDpYPI9vH7/cPygY0q9lJH4ejZBvvFRdC7UC4ls9xXps29W1A1ppt2iMYGdKYJOH
y6co/ij57KOjkP7xmru/tXm0R6/9qSLzPR6Hug+HjmbeehSDnuEWoUrLPJqUhEj8
5+5fnYsDCD43QtWb63EI5NA3p80i/g==
=dNrt
-----END PGP SIGNATURE-----


Ludovic Courtès wrote 7 years ago
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)(address . 31602@debbugs.gnu.org)
87bmcywf6j.fsf@gnu.org
Danny Milosavljevic <dannym@scratchpost.org> skribis:

Toggle quote (4 lines)
> These are actually all zip files. The reason for the non-reproducibility is
> that something copies the contents from the source to a mktemp'ed directory
> without preserving timestamps. Then this directory is zipped up.

Without *clearing* timestamps?

Toggle quote (4 lines)
> So the zip file now contains non-constant timestamps.
>
> I think it's somewhere in postprocess, but I can't find it so far.

Perhaps we could add a phase that unpacks-resets-repacks these? Or,
alternately, something like the Debian/R-B tool (I forgot the name) that
does that automatically.

Thanks,
Ludo’.
Danny Milosavljevic wrote 7 years ago
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 31602@debbugs.gnu.org)
20180530094715.089a7761@scratchpost.org
Hi Ludo,

On Tue, 29 May 2018 19:21:40 +0200
ludo@gnu.org (Ludovic Courtès) wrote:

Toggle quote (8 lines)
> Danny Milosavljevic <dannym@scratchpost.org> skribis:
>
> > These are actually all zip files. The reason for the non-reproducibility is
> > that something copies the contents from the source to a mktemp'ed directory
> > without preserving timestamps. Then this directory is zipped up.
>
> Without *clearing* timestamps?

I think it's something like this:

src/foo.png exists with the source timestamp (which is constant for this version).

Something does mktemp, then copies the src/foo.png there without preserving timestamps.

Then this temp directory is zipped up. Now it has the wrong (different, more current)
timestamps in it.

Toggle quote (4 lines)
> Perhaps we could add a phase that unpacks-resets-repacks these? Or,
> alternately, something like the Debian/R-B tool (I forgot the name) that
> does that automatically.

As a fallback - sure.

For now I've been trying to find the place in libreoffice where
it does the copying and patch that and upstream it.

I tried Zip.mk but seems that's not actually used (?).
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlsOVwMACgkQ5xo1VCww
uqXnwAf/UrgxUSEMXFb58i7Jl7MPM4sLml0ndvuGMd/EGPiTCb34xiIrCcYPrPIj
CviREIbe13/iGELBiOpAjopd7eNGXdfF9BqjHFgNKFg5vo++YeP72H2owuJnyXrl
Xf6AsjtJmEc0gkuXfiNymuvFPlWD2imTKxR0CbhQnHz/dsdSlspgS9OrZqbEnUC6
9meAJvm1yDqkix/SgCAJ1V/VU8diFXyFloKuM86sNrh30cM7BGQt3zWJqBqsjxfe
KUKH8L0AqxjJ8C/ab42RvikeVV7CbjaVNnrDZkQgZctIaDnfcmWBiDCcghWq08jO
eD6z8ZZnixnE+bhInTY2+1P9OnXTIg==
=927e
-----END PGP SIGNATURE-----


Ludovic Courtès wrote 5 years ago
(address . 31602@debbugs.gnu.org)
87d04xlp8z.fsf@gnu.org
Danny Milosavljevic <dannym@scratchpost.org> skribis:

Toggle quote (2 lines)
> libreoffice 5.4.7.2 is not reproducible:

It’s still the case, here’s a complete list of files:

Toggle snippet (104 lines)
$ guix challenge libreoffice --substitute-urls='https://ci.guix.gnu.org https://bayfront.guix.gnu.org'
/gnu/store/fv69m52aawvn7n5jk27bnrz1f2d7jvkp-libreoffice-6.4.4.2 contents differ:
no local build for '/gnu/store/fv69m52aawvn7n5jk27bnrz1f2d7jvkp-libreoffice-6.4.4.2'
https://ci.guix.gnu.org/nar/lzip/fv69m52aawvn7n5jk27bnrz1f2d7jvkp-libreoffice-6.4.4.2: 0fa8az4i1msscynapb9a8rn07w1q7j2bq441xwd4a38xvs3qrmz6
https://bayfront.guix.gnu.org/nar/lzip/fv69m52aawvn7n5jk27bnrz1f2d7jvkp-libreoffice-6.4.4.2: 0mbh0ibhy548gln9a4b9q62w8y3pndils24g04wbpx92ysc7jidr
differing files:
/lib/libreoffice/share/template/common/styles/Modern.ott
/lib/libreoffice/share/template/common/styles/Default.ott
/lib/libreoffice/share/template/common/presnt/Vivid.otp
/lib/libreoffice/share/template/common/presnt/Vintage.otp
/lib/libreoffice/share/template/common/presnt/Sunset.otp
/lib/libreoffice/share/template/common/presnt/Progress.otp
/lib/libreoffice/share/template/common/presnt/Portfolio.otp
/lib/libreoffice/share/template/common/presnt/Piano.otp
/lib/libreoffice/share/template/common/presnt/Pencil.otp
/lib/libreoffice/share/template/common/presnt/Nature_Illustration.otp
/lib/libreoffice/share/template/common/presnt/Midnightblue.otp
/lib/libreoffice/share/template/common/presnt/Metropolis.otp
/lib/libreoffice/share/template/common/presnt/LushGreen.otp
/lib/libreoffice/share/template/common/presnt/Lights.otp
/lib/libreoffice/share/template/common/presnt/Inspiration.otp
/lib/libreoffice/share/template/common/presnt/Impress.otp
/lib/libreoffice/share/template/common/presnt/Forestbird.otp
/lib/libreoffice/share/template/common/presnt/Focus.otp
/lib/libreoffice/share/template/common/presnt/DNA.otp
/lib/libreoffice/share/template/common/presnt/Classy_Red.otp
/lib/libreoffice/share/template/common/presnt/BrightBlue.otp
/lib/libreoffice/share/template/common/presnt/Blueprint_Plans.otp
/lib/libreoffice/share/template/common/presnt/Blue_Curve.otp
/lib/libreoffice/share/template/common/presnt/Beehive.otp
/lib/libreoffice/share/template/common/presnt/Alizarin.otp
/lib/libreoffice/share/template/common/personal/Resume1page.ott
/lib/libreoffice/share/template/common/personal/CV.ott
/lib/libreoffice/share/template/common/offimisc/Businesscard-with-logo.ott
/lib/libreoffice/share/template/common/officorr/Modern_business_letter_serif.ott
/lib/libreoffice/share/template/common/officorr/Modern_business_letter_sans_serif.ott
/lib/libreoffice/share/config/images_tango.zip
/lib/libreoffice/share/config/images_sifr_svg.zip
/lib/libreoffice/share/config/images_sifr_dark_svg.zip
/lib/libreoffice/share/config/images_sifr_dark.zip
/lib/libreoffice/share/config/images_sifr.zip
/lib/libreoffice/share/config/images_karasa_jaga_svg.zip
/lib/libreoffice/share/config/images_karasa_jaga.zip
/lib/libreoffice/share/config/images_elementary_svg.zip
/lib/libreoffice/share/config/images_elementary.zip
/lib/libreoffice/share/config/images_colibre_svg.zip
/lib/libreoffice/share/config/images_colibre.zip
/lib/libreoffice/share/config/images_breeze_svg.zip
/lib/libreoffice/share/config/images_breeze_dark_svg.zip
/lib/libreoffice/share/config/images_breeze_dark.zip
/lib/libreoffice/share/config/images_breeze.zip
/lib/libreoffice/share/autotext/en-US/template.bau
/lib/libreoffice/share/autotext/en-US/standard.bau
/lib/libreoffice/share/autotext/en-US/crdbus50.bau
/lib/libreoffice/share/autocorr/acor_zh-TW.dat
/lib/libreoffice/share/autocorr/acor_zh-CN.dat
/lib/libreoffice/share/autocorr/acor_vi-VN.dat
/lib/libreoffice/share/autocorr/acor_tr-TR.dat
/lib/libreoffice/share/autocorr/acor_sv-SE.dat
/lib/libreoffice/share/autocorr/acor_sr-RS.dat
/lib/libreoffice/share/autocorr/acor_sr-ME.dat
/lib/libreoffice/share/autocorr/acor_sr-Latn-RS.dat
/lib/libreoffice/share/autocorr/acor_sr-Latn-ME.dat
/lib/libreoffice/share/autocorr/acor_sr-Latn-CS.dat
/lib/libreoffice/share/autocorr/acor_sr-CS.dat
/lib/libreoffice/share/autocorr/acor_sl-SI.dat
/lib/libreoffice/share/autocorr/acor_sk-SK.dat
/lib/libreoffice/share/autocorr/acor_ru-RU.dat
/lib/libreoffice/share/autocorr/acor_ro-RO.dat
/lib/libreoffice/share/autocorr/acor_pt-PT.dat
/lib/libreoffice/share/autocorr/acor_pt-BR.dat
/lib/libreoffice/share/autocorr/acor_pl-PL.dat
/lib/libreoffice/share/autocorr/acor_nl-NL.dat
/lib/libreoffice/share/autocorr/acor_nl-BE.dat
/lib/libreoffice/share/autocorr/acor_mn-MN.dat
/lib/libreoffice/share/autocorr/acor_lt-LT.dat
/lib/libreoffice/share/autocorr/acor_lb-LU.dat
/lib/libreoffice/share/autocorr/acor_ko-KR.dat
/lib/libreoffice/share/autocorr/acor_ja-JP.dat
/lib/libreoffice/share/autocorr/acor_it.dat
/lib/libreoffice/share/autocorr/acor_is-IS.dat
/lib/libreoffice/share/autocorr/acor_hu-HU.dat
/lib/libreoffice/share/autocorr/acor_hsb.dat
/lib/libreoffice/share/autocorr/acor_hr-HR.dat
/lib/libreoffice/share/autocorr/acor_ga-IE.dat
/lib/libreoffice/share/autocorr/acor_fr.dat
/lib/libreoffice/share/autocorr/acor_fi-FI.dat
/lib/libreoffice/share/autocorr/acor_fa-IR.dat
/lib/libreoffice/share/autocorr/acor_es.dat
/lib/libreoffice/share/autocorr/acor_en-ZA.dat
/lib/libreoffice/share/autocorr/acor_en-US.dat
/lib/libreoffice/share/autocorr/acor_en-GB.dat
/lib/libreoffice/share/autocorr/acor_en-AU.dat
/lib/libreoffice/share/autocorr/acor_el-GR.dat
/lib/libreoffice/share/autocorr/acor_dsb.dat
/lib/libreoffice/share/autocorr/acor_de.dat
/lib/libreoffice/share/autocorr/acor_da-DK.dat
/lib/libreoffice/share/autocorr/acor_cs-CZ.dat
/lib/libreoffice/share/autocorr/acor_ca-ES.dat
/lib/libreoffice/share/autocorr/acor_bg-BG.dat
/lib/libreoffice/share/autocorr/acor_af-ZA.dat
/lib/libreoffice/presets/autotext/mytexts.bau

And indeed, all the template files as well as *.dat files are actually
zip files with embedded timestamps.

Ludo’.
Tobias Geerinckx-Rice wrote 4 years ago
libreoffice not reproducible
(address . 31602-done@debbugs.gnu.org)
878saiy3kc.fsf@nckx
Finally fixed in commit 0d5578c12beec105f5ec113cc50deab703270a82:

~$ guix environment --pure guix -- ./pre-inst-env guix build \
--{check,no-grafts} libreoffice
successfully built /gnu/store/...-libreoffice-6.4.6.2.drv
successfully built /gnu/store/...-libreoffice-6.4.6.2.drv
/gnu/store/25q6nl2l2k3nks0rrh2ah5qsxr3mqy3a-libreoffice-6.4.6.2

Closing, though it remains to be seen whether it works across file
systems.

Kind regards,

T G-R
-----BEGIN PGP SIGNATURE-----

iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCX8Vacw0cbWVAdG9iaWFz
LmdyAAoJEA2w/4hPVW15R9YBAJPvKs2ezvfPWi8A8fW+C5FoKQjZZH+TMDDj/ke2
yQgkAQCUs8Apr+SbkKpC3I1uOWx4K2VSSvwcT4OEda5aMHHbBA==
=4BN+
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 31602@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 31602
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help