[PATCH 0/5] 'guix health': a tool to report vulnerable packages

OpenSubmitted by Ludovic Courtès.
Details
2 participants
  • Ludovic Courtès
  • zimoun
Owner
unassigned
Severity
normal
Merged with
L
L
Ludovic Courtès wrote on 13 May 2018 22:25
(address . guix-patches@gnu.org)(name . Ludovic Courtès)(address . ludo@gnu.org)
20180513202525.4010-1-ludo@gnu.org
Hello Guix!
On IRC davidl shared a shell script that checks the output of ‘guix lint-c cve’ and uses that to determine vulnerable packages in a profile.That reminds me of the plan for ‘guix health’ (a tool to do just that),so I went ahead and tried to make it a reality at last.
This ‘guix health’ reports information about “leaf” packages in aprofile, but not about their dependencies:
Toggle snippet (17 lines)$ ./pre-inst-env guix health -p /run/current-system/profile/guix health: warning: util-linux@2.31.1 may be vulnerable to CVE-2018-7738guix health: warning: util-linux@2.31.1 is available but does not fix any of thesehint: Run `guix pull' and then re-run `guix health' to see if fixes are available. Ifnone are available, please consider submitting a patch for the package definition of'util-linux'.

guix health: warning: shadow@4.5 may be vulnerable to CVE-2018-7169guix health: warning: shadow@4.6 is available and fixes CVE-2018-7169, consider ugpradingguix health: warning: tar@1.29 may be vulnerable to CVE-2016-6321guix health: warning: tar@1.29 is available but does not fix any of thesehint: Run `guix pull' and then re-run `guix health' to see if fixes are available. Ifnone are available, please consider submitting a patch for the package definition of'tar'.
The difficulty here is that we need to know a package’s CPE name beforewe can check the CVE database, and we also need to know whether thepackage already includes fixes for known CVEs. This patch set attachesthis information to manifest entries, so that ‘guix health’ can thenrely on it.
Fundamentally, that means we cannot reliably tell much aboutdependencies: in cases where the CPE name differs from the Guix name, wewon’t have any match, and more generally, we cannot know what CVE arepatched in the package; we could infer part of this by looking at thesame-named package in the current Guix, but that’s hacky.
I think that longer-term we probably need to attach this kind ofmeta-data to packages themselves, by adding a bunch of files in eachpackage, say under PREFIX/guix. We could do that for search paths aswell.
Should we satisfy ourselves with the current approach in the meantime?Thoughts?
Besides, support for properties in manifest entries seems useful to me,so we may want to keep it regardless of whether we take ‘guix health’as-is.
Ludo’.
Ludovic Courtès (5): profiles: Add '%current-profile', 'user-friendly-profile', & co. packages: Add 'package-patched-vulnerabilities'. profiles: Add 'properties' field to manifest entries. profiles: Record fixed vulnerabilities as properties of entries. DRAFT Add 'guix health'.
Makefile.am | 1 + guix/packages.scm | 28 +++++++ guix/profiles.scm | 91 ++++++++++++++++++++-- guix/scripts/health.scm | 158 +++++++++++++++++++++++++++++++++++++++ guix/scripts/lint.scm | 23 +----- guix/scripts/package.scm | 40 ---------- po/guix/POTFILES.in | 1 + tests/packages.scm | 15 ++++ tests/profiles.scm | 22 ++++++ 9 files changed, 312 insertions(+), 67 deletions(-) create mode 100644 guix/scripts/health.scm
-- 2.17.0
L
L
Ludovic Courtès wrote on 14 May 2018 10:25
[PATCH 3/5] profiles: Add 'properties' field to manifest entries.
(address . 31442@debbugs.gnu.org)(name . Ludovic Courtès)(address . ludo@gnu.org)
20180514082550.1131-3-ludo@gnu.org
* guix/profiles.scm (<manifest-entry>)[properties]: New field.(manifest->gexp)[entry->gexp]: Serialize it.(sexp->manifest)[sexp->manifest-entry]: Deserialize it.--- guix/profiles.scm | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-)
Toggle diff (61 lines)diff --git a/guix/profiles.scm b/guix/profiles.scmindex 3cdc3d2f1..02828e465 100644--- a/guix/profiles.scm+++ b/guix/profiles.scm@@ -78,6 +78,7 @@ manifest-entry-dependencies manifest-entry-search-paths manifest-entry-parent+ manifest-entry-properties manifest-pattern manifest-pattern?@@ -181,7 +182,9 @@ (search-paths manifest-entry-search-paths ; search-path-specification* (default '())) (parent manifest-entry-parent ; promise (#f | <manifest-entry>)- (default (delay #f))))+ (default (delay #f)))+ (properties manifest-entry-properties ; list of symbol/value pairs+ (default '()))) (define-record-type* <manifest-pattern> manifest-pattern make-manifest-pattern@@ -320,18 +323,20 @@ denoting a specific output of a package." (define (entry->gexp entry) (match entry (($ <manifest-entry> name version output (? string? path)- (deps ...) (search-paths ...))+ (deps ...) (search-paths ...) _ (properties ...)) #~(#$name #$version #$output #$path (propagated-inputs #$(map entry->gexp deps)) (search-paths #$(map search-path-specification->sexp- search-paths))))+ search-paths))+ (properties . #$properties))) (($ <manifest-entry> name version output package- (deps ...) (search-paths ...))+ (deps ...) (search-paths ...) _ (properties ...)) #~(#$name #$version #$output (ungexp package (or output "out")) (propagated-inputs #$(map entry->gexp deps)) (search-paths #$(map search-path-specification->sexp- search-paths))))))+ search-paths))+ (properties . #$properties))))) (match manifest (($ <manifest> (entries ...))@@ -394,7 +399,9 @@ procedure is here for backward-compatibility and will eventually vanish." (dependencies deps*) (search-paths (map sexp->search-path-specification search-paths))- (parent parent))))+ (parent parent)+ (properties (or (assoc-ref extra-stuff 'properties)+ '()))))) entry)))) (match sexp-- 2.17.0
L
L
Ludovic Courtès wrote on 14 May 2018 10:25
[PATCH 1/5] profiles: Add '%current-profile', 'user-friendly-profile', & co.
(address . 31442@debbugs.gnu.org)(name . Ludovic Courtès)(address . ludo@gnu.org)
20180514082550.1131-1-ludo@gnu.org
* guix/scripts/package.scm (%user-profile-directory)(%profile-directory, %current-profile, canonicalize-profile)(user-friendly-profile): Move to...* guix/profiles.scm: ... here.--- guix/profiles.scm | 49 +++++++++++++++++++++++++++++++++++++++- guix/scripts/package.scm | 40 -------------------------------- 2 files changed, 48 insertions(+), 41 deletions(-)
Toggle diff (125 lines)diff --git a/guix/profiles.scm b/guix/profiles.scmindex dca247976..3cdc3d2f1 100644--- a/guix/profiles.scm+++ b/guix/profiles.scm@@ -25,6 +25,7 @@ ;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>. (define-module (guix profiles)+ #:use-module ((guix config) #:select (%state-directory)) #:use-module ((guix utils) #:hide (package-name->name+version)) #:use-module ((guix build utils) #:select (package-name->name+version))@@ -118,7 +119,13 @@ generation-file-name switch-to-generation roll-back- delete-generation))+ delete-generation++ %user-profile-directory+ %profile-directory+ %current-profile+ canonicalize-profile+ user-friendly-profile)) ;;; Commentary: ;;;@@ -1465,4 +1472,44 @@ because the NUMBER is zero.)" (else (delete-and-return))))) +(define %user-profile-directory+ (and=> (getenv "HOME")+ (cut string-append <> "/.guix-profile")))++(define %profile-directory+ (string-append %state-directory "/profiles/"+ (or (and=> (or (getenv "USER")+ (getenv "LOGNAME"))+ (cut string-append "per-user/" <>))+ "default")))++(define %current-profile+ ;; Call it `guix-profile', not `profile', to allow Guix profiles to+ ;; coexist with Nix profiles.+ (string-append %profile-directory "/guix-profile"))++(define (canonicalize-profile profile)+ "If PROFILE is %USER-PROFILE-DIRECTORY, return %CURRENT-PROFILE. Otherwise+return PROFILE unchanged. The goal is to treat '-p ~/.guix-profile' as if+'-p' was omitted." ; see <http://bugs.gnu.org/17939>++ ;; Trim trailing slashes so that the basename comparison below works as+ ;; intended.+ (let ((profile (string-trim-right profile #\/)))+ (if (and %user-profile-directory+ (string=? (canonicalize-path (dirname profile))+ (dirname %user-profile-directory))+ (string=? (basename profile) (basename %user-profile-directory)))+ %current-profile+ profile)))++(define (user-friendly-profile profile)+ "Return either ~/.guix-profile if that's what PROFILE refers to, directly or+indirectly, or PROFILE."+ (if (and %user-profile-directory+ (false-if-exception+ (string=? (readlink %user-profile-directory) profile)))+ %user-profile-directory+ profile))+ ;;; profiles.scm ends herediff --git a/guix/scripts/package.scm b/guix/scripts/package.scmindex 4f519e6f3..29829f52c 100644--- a/guix/scripts/package.scm+++ b/guix/scripts/package.scm@@ -64,46 +64,6 @@ ;;; Profiles. ;;; -(define %user-profile-directory- (and=> (getenv "HOME")- (cut string-append <> "/.guix-profile")))--(define %profile-directory- (string-append %state-directory "/profiles/"- (or (and=> (or (getenv "USER")- (getenv "LOGNAME"))- (cut string-append "per-user/" <>))- "default")))--(define %current-profile- ;; Call it `guix-profile', not `profile', to allow Guix profiles to- ;; coexist with Nix profiles.- (string-append %profile-directory "/guix-profile"))--(define (canonicalize-profile profile)- "If PROFILE is %USER-PROFILE-DIRECTORY, return %CURRENT-PROFILE. Otherwise-return PROFILE unchanged. The goal is to treat '-p ~/.guix-profile' as if-'-p' was omitted." ; see <http://bugs.gnu.org/17939>-- ;; Trim trailing slashes so that the basename comparison below works as- ;; intended.- (let ((profile (string-trim-right profile #\/)))- (if (and %user-profile-directory- (string=? (canonicalize-path (dirname profile))- (dirname %user-profile-directory))- (string=? (basename profile) (basename %user-profile-directory)))- %current-profile- profile)))--(define (user-friendly-profile profile)- "Return either ~/.guix-profile if that's what PROFILE refers to, directly or-indirectly, or PROFILE."- (if (and %user-profile-directory- (false-if-exception- (string=? (readlink %user-profile-directory) profile)))- %user-profile-directory- profile))- (define (ensure-default-profile) "Ensure the default profile symlink and directory exist and are writable." -- 2.17.0
L
L
Ludovic Courtès wrote on 14 May 2018 10:25
[PATCH 4/5] profiles: Record fixed vulnerabilities as properties of entries.
(address . 31442@debbugs.gnu.org)(name . Ludovic Courtès)(address . ludo@gnu.org)
20180514082550.1131-4-ludo@gnu.org
* guix/profiles.scm (package->manifest-entry)[fixed, cpe-name][cpe-version]: New variables.Populate the 'properties' field based on these.* tests/profiles.scm ("manifest-entry-properties"): New test.--- guix/profiles.scm | 23 ++++++++++++++++++++++- tests/profiles.scm | 22 ++++++++++++++++++++++ 2 files changed, 44 insertions(+), 1 deletion(-)
Toggle diff (76 lines)diff --git a/guix/profiles.scm b/guix/profiles.scmindex 02828e465..6656cf356 100644--- a/guix/profiles.scm+++ b/guix/profiles.scm@@ -286,6 +286,17 @@ file name." (define* (package->manifest-entry package #:optional (output "out") #:key (parent (delay #f))) "Return a manifest entry for the OUTPUT of package PACKAGE."+ (define fixed+ (append (package-patched-vulnerabilities package)+ (or (assq-ref (package-properties package) 'lint-hidden-cve)+ '())))++ (define cpe-name+ (assoc-ref (package-properties package) 'cpe-name))++ (define cpe-version+ (assoc-ref (package-properties package) 'cpe-version))+ ;; For each dependency, keep a promise pointing to its "parent" entry. (letrec* ((deps (map (match-lambda ((label package)@@ -303,7 +314,17 @@ file name." (dependencies (delete-duplicates deps)) (search-paths (package-transitive-native-search-paths package))- (parent parent))))+ (parent parent)+ (properties `(,@(if cpe-name+ `((cpe-name . ,cpe-name))+ '())+ ,@(if cpe-version+ `((cpe-version . ,cpe-version))+ '())+ ,@(if (null? fixed)+ '()+ `((fixed-vulnerabilities+ . ,fixed)))))))) entry)) (define (packages->manifest packages)diff --git a/tests/profiles.scm b/tests/profiles.scmindex c668c2b83..8152e4b68 100644--- a/tests/profiles.scm+++ b/tests/profiles.scm@@ -439,6 +439,28 @@ #:locales? #f))) (return #f))))) +(test-equal "manifest-entry-properties"+ '(((fixed-vulnerabilities "CVE-2015-1234"))+ ((fixed-vulnerabilities "CVE-2016-1234" "CVE-2018-4567"))+ ((cpe-name . "Pi")+ (fixed-vulnerabilities "CVE-2002-0001"))+ ())+ (let ((p1 (dummy-package "pi"+ (source (dummy-origin+ (patches (list "/a/b/pi-CVE-2015-1234.patch"))))))+ (p2 (dummy-package "pi"+ (source (dummy-origin+ (patches+ (list+ "/a/b/pi-CVE-2016-1234-CVE-2018-4567.patch"))))))+ (p3 (dummy-package "pi" (source (dummy-origin))+ (properties+ '((cpe-name . "Pi")+ (lint-hidden-cve "CVE-2002-0001")))))+ (p4 (dummy-package "pi" (source (dummy-origin)))))+ (map (compose manifest-entry-properties package->manifest-entry)+ (list p1 p2 p3 p4))))+ (test-assertm "no collision" ;; Here we have an entry that is "lowered" (its 'item' field is a store file ;; name) and another entry (its 'item' field is a package) that is-- 2.17.0
L
L
Ludovic Courtès wrote on 14 May 2018 10:25
[PATCH 5/5] DRAFT Add 'guix health'.
(address . 31442@debbugs.gnu.org)(name . Ludovic Courtès)(address . ludo@gnu.org)
20180514082550.1131-5-ludo@gnu.org
DRAFT: Needs doc and tests, plus the FIXME noted inside.
* guix/scripts/health.scm: New file.* Makefile.am (MODULES): Add it.* po/guix/POTFILES.in: Add it.--- Makefile.am | 1 + guix/scripts/health.scm | 158 ++++++++++++++++++++++++++++++++++++++++ po/guix/POTFILES.in | 1 + 3 files changed, 160 insertions(+) create mode 100644 guix/scripts/health.scm
Toggle diff (190 lines)diff --git a/Makefile.am b/Makefile.amindex 38bd54cf4..870ff6a89 100644--- a/Makefile.am+++ b/Makefile.am@@ -194,6 +194,7 @@ MODULES = \ guix/scripts/package.scm \ guix/scripts/gc.scm \ guix/scripts/hash.scm \+ guix/scripts/health.scm \ guix/scripts/pack.scm \ guix/scripts/pull.scm \ guix/scripts/substitute.scm \diff --git a/guix/scripts/health.scm b/guix/scripts/health.scmnew file mode 100644index 000000000..a991fcbe3--- /dev/null+++ b/guix/scripts/health.scm@@ -0,0 +1,158 @@+;;; GNU Guix --- Functional package management for GNU+;;; Copyright © 2018 Ludovic Courtès <ludo@gnu.org>+;;;+;;; This file is part of GNU Guix.+;;;+;;; GNU Guix is free software; you can redistribute it and/or modify it+;;; under the terms of the GNU General Public License as published by+;;; the Free Software Foundation; either version 3 of the License, or (at+;;; your option) any later version.+;;;+;;; GNU Guix is distributed in the hope that it will be useful, but+;;; WITHOUT ANY WARRANTY; without even the implied warranty of+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the+;;; GNU General Public License for more details.+;;;+;;; You should have received a copy of the GNU General Public License+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.++(define-module (guix scripts health)+ #:use-module (guix ui)+ #:use-module (guix scripts)+ #:use-module (guix profiles)+ #:use-module (guix packages)+ #:use-module (guix cve)+ #:use-module (guix utils)+ #:use-module (gnu packages)+ #:use-module (srfi srfi-1)+ #:use-module (srfi srfi-37)+ #:use-module (ice-9 match)+ #:export (guix-health))++ +;;;+;;; Reporting CVEs.+;;;++(define (same-package-entries? entry1 entry2)+ "Return true if ENTRY1 and ENTRY2 refer to the same package and version."+ (and (string=? (manifest-entry-name entry1)+ (manifest-entry-name entry2))+ (string=? (manifest-entry-version entry1)+ (manifest-entry-version entry2))))++(define (manifest-entry-vulnerabilities entry lookup-vulnerabilities)+ "Return the list of vulnerabilities for ENTRY. Call LOOKUP-VULNERABILITIES+to determine the list of vulnerabilities for a package/version."+ (let* ((name (manifest-entry-name entry))+ (cpe-name (or (assoc-ref (manifest-entry-properties entry)+ 'cpe-name)+ name))+ (version (manifest-entry-version entry))+ (cpe-version (or (assoc-ref (manifest-entry-properties entry)+ 'cpe-version)+ version))+ (fixed (or (assoc-ref (manifest-entry-properties entry)+ 'fixed-vulnerabilities)+ '())))+ (remove (lambda (vuln)+ (member (vulnerability-id vuln) fixed))+ (lookup-vulnerabilities cpe-name cpe-version))))++(define (check-profile-cve profile)+ "Check and report the CVEs of packages in PROFILE."+ (define lookup-vulnerabilities+ (vulnerabilities->lookup-proc (current-vulnerabilities)))++ (define (report-entry-vulnerabilities entry)+ (let ((name (manifest-entry-name entry))+ (version (manifest-entry-version entry)))+ (match (manifest-entry-vulnerabilities entry lookup-vulnerabilities)+ (()+ #t)+ ((vulns ...)+ (warning (G_ "~a@~a may be vulnerable to~{ ~a~}~%")+ name version (map vulnerability-id vulns))+ (match (find-best-packages-by-name name #f)+ ((package . _)+ (let ((vulns* (lookup-vulnerabilities name+ (package-version package))))+ (match (lset-difference string=?+ (map vulnerability-id vulns)+ (map vulnerability-id vulns*))+ (()+ (warning (G_ "~a@~a is available but does not \+fix any of these~%")+ name (package-version package))+ (display-hint (format #f (G_ "Run @command{guix pull} and+then re-run @command{guix health} to see if fixes are available. If none are+available, please consider submitting a patch for the package definition of+'~a'.") name)))+ (fixed+ (warning (G_ "~a@~a is available and fixes~{ ~a~}, \+consider ugprading~%")+ name (package-version package) fixed)))))+ (()+ (warning (G_ "'~a' is unavailable and thus \+cannot be upgraded~%")+ name)))))))++ (let* ((manifest (profile-manifest profile))+ (entries (manifest-transitive-entries manifest)))+ ;; FIXME: We don't report vulnerabilities in dependencies of the entries.+ ;; We could check the references and infer the package name/version for+ ;; each of them, but then we wouldn't know their CPE name nor whether they+ ;; already contain patches fixing known vulnerabilities.+ (for-each report-entry-vulnerabilities+ (delete-duplicates entries same-package-entries?))))++ +;;;+;;; Command-line options.+;;;++(define (show-help)+ (display (G_ "Usage: guix health [OPTIONS]+Report on the vulnerabilities of packages in a profile.\n"))+ (display (G_ "+ -p, --profile=PROFILE use PROFILE instead of the user's default profile"))+ (newline)+ (display (G_ "+ -h, --help display this help and exit"))+ (display (G_ "+ -V, --version display version information and exit"))+ (newline)+ (show-bug-report-information))++(define %options+ (list (option '(#\h "help") #f #f+ (lambda args+ (show-help)+ (exit 0)))+ (option '(#\V "version") #f #f+ (lambda args+ (show-version-and-exit "guix package")))++ (option '(#\p "profile") #t #f+ (lambda (opt name arg result)+ (values (alist-cons 'profile (canonicalize-profile arg)+ result)+ #f)))))++(define %default-options+ ;; Alist of default option values.+ '())++ +;;;+;;; Entry point.+;;;++(define (guix-health . args)+ (with-error-handling+ (let* ((opts (parse-command-line args %options (list %default-options)+ #:build-options? #f))+ (profile (or (and=> (assoc-ref opts 'profile)+ user-friendly-profile)+ %user-profile-directory)))+ (check-profile-cve profile))))diff --git a/po/guix/POTFILES.in b/po/guix/POTFILES.inindex d11f408d4..76fdbe13b 100644--- a/po/guix/POTFILES.in+++ b/po/guix/POTFILES.in@@ -31,6 +31,7 @@ guix/scripts/challenge.scm guix/scripts/copy.scm guix/scripts/pack.scm guix/scripts/weather.scm+guix/scripts/health.scm guix/gnu-maintenance.scm guix/scripts/container.scm guix/scripts/container/exec.scm-- 2.17.0
L
L
Ludovic Courtès wrote on 14 May 2018 10:25
[PATCH 2/5] packages: Add 'package-patched-vulnerabilities'.
(address . 31442@debbugs.gnu.org)(name . Ludovic Courtès)(address . ludo@gnu.org)
20180514082550.1131-2-ludo@gnu.org
* guix/packages.scm (patch-file-name): New procedure.(%vulnerability-regexp): New variable.(package-patched-vulnerabilities): New procedure.* guix/scripts/lint.scm (patch-file-name): Remove.(check-vulnerabilities): Adjust to use'package-patched-vulnerabilities'.* tests/packages.scm ("package-patched-vulnerabilities"): New test.--- guix/packages.scm | 28 ++++++++++++++++++++++++++++ guix/scripts/lint.scm | 23 ++++------------------- tests/packages.scm | 15 +++++++++++++++ 3 files changed, 47 insertions(+), 19 deletions(-)
Toggle diff (134 lines)diff --git a/guix/packages.scm b/guix/packages.scmindex e0ab72086..f536597ae 100644--- a/guix/packages.scm+++ b/guix/packages.scm@@ -35,6 +35,7 @@ #:use-module (guix sets) #:use-module (ice-9 match) #:use-module (ice-9 vlist)+ #:use-module (ice-9 regex) #:use-module (srfi srfi-1) #:use-module (srfi srfi-9 gnu) #:use-module (srfi srfi-11)@@ -106,6 +107,7 @@ package-cross-derivation package-output package-grafts+ package-patched-vulnerabilities package/inherit transitive-input-references@@ -394,6 +396,32 @@ DELIMITER (a string), you can customize what will appear between the name and the version. By default, DELIMITER is \"@\"." (string-append (package-name package) delimiter (package-version package))) +(define (patch-file-name patch)+ "Return the basename of PATCH's file name, or #f if the file name could not+be determined."+ (match patch+ ((? string?)+ (basename patch))+ ((? origin?)+ (and=> (origin-actual-file-name patch) basename))))++(define %vulnerability-regexp+ ;; Regexp matching a CVE identifier in patch file names.+ (make-regexp "CVE-[0-9]{4}-[0-9]+"))++(define (package-patched-vulnerabilities package)+ "Return the list of patched vulnerabilities of PACKAGE as a list of CVE+identifiers. The result is inferred from the file names of patches."+ (define (patch-vulnerabilities patch)+ (map (cut match:substring <> 0)+ (list-matches %vulnerability-regexp patch)))++ (let ((patches (filter-map patch-file-name+ (or (and=> (package-source package)+ origin-patches)+ '()))))+ (append-map patch-vulnerabilities patches)))+ (define (%standard-patch-inputs) (let* ((canonical (module-ref (resolve-interface '(gnu packages base)) 'canonical-package))diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scmindex cd802985d..e477bf0dd 100644--- a/guix/scripts/lint.scm+++ b/guix/scripts/lint.scm@@ -1,7 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2014 Cyril Roelandt <tipecaml@gmail.com> ;;; Copyright © 2014, 2015 Eric Bavier <bavier@member.fsf.org>-;;; Copyright © 2013, 2014, 2015, 2016, 2017 Ludovic Courtès <ludo@gnu.org>+;;; Copyright © 2013, 2014, 2015, 2016, 2017, 2018 Ludovic Courtès <ludo@gnu.org> ;;; Copyright © 2015, 2016 Mathieu Lirzin <mthl@gnu.org> ;;; Copyright © 2016 Danny Milosavljevic <dannym+a@scratchpost.org> ;;; Copyright © 2016 Hartmut Goebel <h.goebel@crazy-compilers.com>@@ -809,15 +809,6 @@ descriptions maintained upstream." (emit-warning package (G_ "invalid license field") 'license)))) -(define (patch-file-name patch)- "Return the basename of PATCH's file name, or #f if the file name could not-be determined."- (match patch- ((? string?)- (basename patch))- ((? origin?)- (and=> (origin-actual-file-name patch) basename))))- (define (call-with-networking-fail-safe message error-value proc) "Call PROC catching any network-related errors. Upon a networking error, display a message including MESSAGE and return ERROR-VALUE."@@ -878,20 +869,14 @@ the NIST server non-fatal." (() #t) ((vulnerabilities ...)- (let* ((patches (filter-map patch-file-name- (or (and=> (package-source package)- origin-patches)- '())))+ (let* ((patched (package-patched-vulnerabilities package)) (known-safe (or (assq-ref (package-properties package) 'lint-hidden-cve) '())) (unpatched (remove (lambda (vuln) (let ((id (vulnerability-id vuln)))- (or- (find (cute string-contains- <> id)- patches)- (member id known-safe))))+ (or (member id patched)+ (member id known-safe)))) vulnerabilities))) (unless (null? unpatched) (emit-warning packagediff --git a/tests/packages.scm b/tests/packages.scmindex 9e19c3992..642a3efa5 100644--- a/tests/packages.scm+++ b/tests/packages.scm@@ -941,6 +941,21 @@ ((("x" dep)) (eq? dep findutils))))))))) +(test-equal "package-patched-vulnerabilities"+ '(("CVE-2015-1234")+ ("CVE-2016-1234" "CVE-2018-4567")+ ())+ (let ((p1 (dummy-package "pi"+ (source (dummy-origin+ (patches (list "/a/b/pi-CVE-2015-1234.patch"))))))+ (p2 (dummy-package "pi"+ (source (dummy-origin+ (patches (list+ "/a/b/pi-CVE-2016-1234-CVE-2018-4567.patch"))))))+ (p3 (dummy-package "pi" (source (dummy-origin)))))+ (map package-patched-vulnerabilities+ (list p1 p2 p3))))+ (test-eq "fold-packages" hello (fold-packages (lambda (p r) (if (string=? (package-name p) "hello")-- 2.17.0
L
L
Ludovic Courtès wrote on 14 May 2018 10:26
control message for bug #31442
(address . control@debbugs.gnu.org)
87wow6bq38.fsf@gnu.org
merge 31442 31443
L
L
Ludovic Courtès wrote on 14 May 2018 10:26
(address . control@debbugs.gnu.org)
87vabqbq2z.fsf@gnu.org
merge 31442 31444
L
L
Ludovic Courtès wrote on 9 Jun 2018 12:18
Re: [bug#31442] [PATCH 0/5] 'guix health': a tool to report vulnerable packages
(address . 31442@debbugs.gnu.org)
87po10gt5t.fsf@gnu.org
Hello,
Ludovic Courtès <ludo@gnu.org> skribis:
Toggle quote (6 lines)> profiles: Add '%current-profile', 'user-friendly-profile', & co.> packages: Add 'package-patched-vulnerabilities'.> profiles: Add 'properties' field to manifest entries.> profiles: Record fixed vulnerabilities as properties of entries.> DRAFT Add 'guix health'.
I’ve just pushed the first three patches and the new ‘guix pull’ usesproperties already.
Ludo’.
Z
Z
zimoun wrote 3 days ago
Re: [bug#31444] 'guix health': a tool to report vulnerable packages
(name . Ludovic Courtès)(address . ludo@gnu.org)
864knuk8nk.fsf@gmail.com
Hi,
Digging in old bugs with patches, hit this one. :-)

On Mon, 14 May 2018 at 00:15, ludo@gnu.org (Ludovic Courtès) wrote:
Toggle quote (8 lines)> On IRC davidl shared a shell script that checks the output of ‘guix lint> -c cve’ and uses that to determine vulnerable packages in a profile.> That reminds me of the plan for ‘guix health’ (a tool to do just that),> so I went ahead and tried to make it a reality at last.>> This ‘guix health’ reports information about “leaf” packages in a> profile, but not about their dependencies:
Well, I do not know what was the idea at the time. :-)(The search http://logs.guix.gnu.org/guix/search?query=nick%3Adavidldoes not list logs before 2019 for the nickname. Do I miss something?)
And I do not know if the idea is to report only “leaf” packages.
Well, instead to create another new command, I think it would be betterto include the “leaf” packages to “guix graph” and then pipe to “guixlint”. Other said, “guix graph” should help to manipulate the graph ofpackages.
I am not sure it fits the idea behind “guix health” but the patch #43477allows to only output the nodes, for example.
http://issues.guix.gnu.org/issue/43477

Here an example, to verify the SWH health of one profile. (Note Ichoose the archival checker because it display stuff. :-))
Toggle snippet (34 lines)$ guix package -p ~/.config/guix/profiles/apps/apps -I | cut -f1youtube-dlmb2mdisyncxournalghostscriptimagemagickmupdf
$for pkg in \> $(guix package -p ~/.config/guix/profiles/apps/apps -I | cut -f1 | xargs ./pre-inst-env guix graph -b plain); \> do guix lint -c archival $pkg ; donegnu/packages/video.scm:2169:12: youtube-dl@2020.09.14: source not archived on Software Heritagegnu/packages/video.scm:1412:12: ffmpeg@4.3.1: source not archived on Software Heritagegnu/packages/autotools.scm:286:12: automake@1.16.2: source not archived on Software Heritageguix lint: error: autoconf-wrapper: package not found for version 2.69gnu/packages/perl.scm:89:12: perl@5.30.2: source not archived on Software Heritagegnu/packages/guile.scm:141:11: guile@2.0.14: source not archived on Software Heritagegnu/packages/ed.scm:32:12: ed@1.16: source not archived on Software Heritage
[...]
gnu/packages/xorg.scm:5280:6: libxcb@1.14: source not archived on Software Heritageguix lint: error: tzdata: package not found for version 2019cgnu/packages/python.scm:514:2: python-minimal@3.8.2: source not archived on Software Heritagegnu/packages/xorg.scm:2140:6: xcb-proto@1.14: source not archived on Software Heritage
[...]
gnu/packages/shells.scm:376:12: tcsh@6.22.02: source not archived on Software Heritagegnu/packages/icu4c.scm:43:11: icu4c@66.1: Software Heritage rate limit reached; try again laterC-c
Obviously, the for-loop should be avoided. But raising an error by“guix lint” breaks the stream. Well, that’s another story. :-)

To summary, instead of “guix health”, I suggest to add “features“ to‘guix graph’ (support manifest files, more facilities to manipulate/showthe DAG).

Toggle quote (6 lines)> The difficulty here is that we need to know a package’s CPE name before> we can check the CVE database, and we also need to know whether the> package already includes fixes for known CVEs. This patch set attaches> this information to manifest entries, so that ‘guix health’ can then> rely on it.
Well, I am not sure to understand. Is it not somehow an issue of ‘guixlint -c cve’?

Toggle quote (11 lines)> Fundamentally, that means we cannot reliably tell much about> dependencies: in cases where the CPE name differs from the Guix name, we> won’t have any match, and more generally, we cannot know what CVE are> patched in the package; we could infer part of this by looking at the> same-named package in the current Guix, but that’s hacky.>> I think that longer-term we probably need to attach this kind of> meta-data to packages themselves, by adding a bunch of files in each> package, say under PREFIX/guix. We could do that for search paths as> well.
What is the status of this idea?

Toggle quote (7 lines)> Should we satisfy ourselves with the current approach in the meantime?> Thoughts?>> Besides, support for properties in manifest entries seems useful to me,> so we may want to keep it regardless of whether we take ‘guix health’> as-is.
I am not sure that my email is relevant, but at least it will ping for‘guix health’. :-)

Cheers,simon
?