Missing icons in virt-manager user-interface

Done

Details

4 participants

Leo Famulari
Mike Gerwitz
Ricardo Wurmus
Vagrant Cascadian

Owner: unassigned

Submitted by: Vagrant Cascadian

Severity: normal

Debbugs page

Vagrant Cascadian wrote 7 years ago

Recipients:(address . bug-guix@gnu.org)

Message-ID:87fu37otbj.fsf@aikidev.net

Many of the icons appear to be missing from the user interface, such as

the button for "Power on", "Pause the virtual machine", "Shut down the

virtual machine" and "Show virtual hardware details".

Also, selecting the "Show virtual hardware details" nearly all the icons

are missing (e.g. "Overview", "Performance",

"CPUs", "Memory", etc.).

live well,

vagrant

Vagrant Cascadian wrote 7 years ago

Recipients:(address . 31366@debbugs.gnu.org)

Message-ID:8736uzo19m.fsf@aikidev.net

On 2018-05-04, Vagrant Cascadian wrote:

Toggle quote (8 lines)

> Many of the icons appear to be missing from the user interface, such as

> the button for "Power on", "Pause the virtual machine", "Shut down the

> virtual machine" and "Show virtual hardware details".

> Also, selecting the "Show virtual hardware details" nearly all the icons

> are missing (e.g. "Overview", "Performance",

> "CPUs", "Memory", etc.).

Attached patch that fixes the issue by adding adwaita-icon-theme and

hicolor-icon-theme to propagated-inputs.

live well,

vagrant

From 82f11703d0c1c45428fd4667b02e23eb714492de Mon Sep 17 00:00:00 2001

Fixes https://bugs.gnu.org/31366.

* gnu/packages/virtualization.scm (virt-manager) [propagated-inputs]: Add

adwaita-icon-theme and hicolor-icon-theme.

---

gnu/packages/virtualization.scm | 4 +++-

1 file changed, 3 insertions(+), 1 deletion(-)

Toggle diff (17 lines)diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index 7427465f5..e6948b872 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -634,7 +634,9 @@ virtualization library.")
        ("spice-gtk" ,spice-gtk)))
     ;; virt-manager searches for qemu-img or kvm-img in the PATH.
     (propagated-inputs
-     `(("qemu" ,qemu)))
+     `(("adwaita-icon-theme" ,adwaita-icon-theme)
+       ("hicolor-icon-theme" ,hicolor-icon-theme)
+       ("qemu" ,qemu)))
     (native-inputs
      `(("glib" ,glib "bin")             ; glib-compile-schemas.
        ("gtk+" ,gtk+ "bin")             ; gtk-update-icon-cache
-- 
2.18.0

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCW4SElQAKCRDcUY/If5cW

qsJNAQCRQ9mCXU5QxU7tzStHgwVLEBwy4PwRIRNpiQhCgf+5KAD/S+Ks83r9q1/X

IqObpR5POzrLqy5hKtY52jafSySeLQQ=

=1Hi7

-----END PGP SIGNATURE-----

Vagrant Cascadian wrote 7 years ago

Recipients:(address . control@debbugs.gnu.org)

Message-ID:87in3tlzr3.fsf@aikidev.net

tags 31366 patch

thanks

Vagrant Cascadian wrote 7 years ago

Recipients:(address . 31366@debbugs.gnu.org)

Message-ID:87ftywnas6.fsf@aikidev.net

On 2018-08-27, Vagrant Cascadian wrote:

Toggle quote (12 lines)> On 2018-05-04, Vagrant Cascadian wrote:
>> Many of the icons appear to be missing from the user interface, such as
>> the button for "Power on", "Pause the virtual machine", "Shut down the
>> virtual machine" and "Show virtual hardware details".
>>
>> Also, selecting the "Show virtual hardware details" nearly all the icons
>> are missing (e.g. "Overview", "Performance",
>> "CPUs", "Memory", etc.).
>
> Attached patch that fixes the issue by adding adwaita-icon-theme and
> hicolor-icon-theme to propagated-inputs.

Apparently, merely installing adwaita-icon-theme and hicolor-icon-theme

into the user's profile also works... not sure if this means it should

be added to propagated-inputs or users are just expected to install

relevent icon-theme packages themselves... ?

live well,

vagrant

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCW4cKqQAKCRDcUY/If5cW

qidrAP9MncqziqzpNlN75ST6fZnUPlQqHB8SOqDvdl6nw6aA4QEA7wtW47hHDigz

ujWmR9GqOtGabCIfkZHXT7vL0lmyGgM=

=lelc

-----END PGP SIGNATURE-----

Leo Famulari wrote 7 years ago

Re: bug#31366: Missing icons in virt-manager user-interface

Recipients:(name . Vagrant Cascadian)(address . vagrant@debian.org)(address . 31366@debbugs.gnu.org)

Message-ID:20180829222437.GA8741@jasmine.lan

On Wed, Aug 29, 2018 at 02:05:45PM -0700, Vagrant Cascadian wrote:

Toggle quote (5 lines)

> Apparently, merely installing adwaita-icon-theme and hicolor-icon-theme

> into the user's profile also works... not sure if this means it should

> be added to propagated-inputs or users are just expected to install

> relevent icon-theme packages themselves... ?

Yeah, so far it's preferred that users install the icons themselves. I
*thought* this was in the manual but it's not :)

One advantage of asking users to install the icon themes is that it
makes it easier to update the icon themes without having to rebuild many
packages.

Mike Gerwitz wrote 7 years ago

Recipients:(name . Leo Famulari)(address . leo@famulari.name)

Message-ID:871sagoeg4.fsf@gnu.org

On Wed, Aug 29, 2018 at 18:24:37 -0400, Leo Famulari wrote:

Toggle quote (13 lines)> On Wed, Aug 29, 2018 at 02:05:45PM -0700, Vagrant Cascadian wrote:
>> Apparently, merely installing adwaita-icon-theme and hicolor-icon-theme
>> into the user's profile also works... not sure if this means it should
>> be added to propagated-inputs or users are just expected to install
>> relevent icon-theme packages themselves... ?
>
> Yeah, so far it's preferred that users install the icons themselves. I
> *thought* this was in the manual but it's not :)
>
> One advantage of asking users to install the icon themes is that it
> makes it easier to update the icon themes without having to rebuild many
> packages.

That explains why I had this issue in the past and it has since resolved

itself.

I'm sorry if this type of thing has been discussed before (I don't read

every message on the Guix lists), but what about some way of indicating

recommended packages as part of the package definition (a sort of soft

dependency). Guix could then output to the user after installation that

certain package(s) ought to be installed for things to work optimally.

Guix could then be helpful to the user without expecting the user to

have read all relevant sections of the manual (I have only read portions

so far). `guix package` maybe could also have a flag to automatically

install recommended packages into the user's profile.

There are strong design considerations here; this is an

oversimplification of the problem.

Mike Gerwitz

Ricardo Wurmus wrote 7 years ago

Recipients:(name . Mike Gerwitz)(address . mtg@gnu.org)

Message-ID:87ftyu1y0a.fsf@elephly.net

Mike Gerwitz <mtg@gnu.org> writes:

Toggle quote (11 lines)> I'm sorry if this type of thing has been discussed before (I don't read
> every message on the Guix lists), but what about some way of indicating
> recommended packages as part of the package definition (a sort of soft
> dependency).  Guix could then output to the user after installation that
> certain package(s) ought to be installed for things to work optimally.
>
> Guix could then be helpful to the user without expecting the user to
> have read all relevant sections of the manual (I have only read portions
> so far).  `guix package` maybe could also have a flag to automatically
> install recommended packages into the user's profile.

One way of achieving this is to record recommended packages in the
package’s properties list.  (We use the properties list very rarely
because it easily becomes a grab bag of miscellaneous things that don’t
fit anywhere else.)

Much like we pin search path recommendations to certain “root” packages
we could do something similar for recommended packages.  “glibc”, for
example, could recommend “glibc-locales”; having a package installed
that links with glibc (i.e. all of them) would result in a
recommendation to also install the “glibc-locales” package.  For “gtk+”
the recommendation could be to also install one of the icon themes.
Installing any package depending on “gtk+” would then lead to a
recommendation to install one of these packages.

Unfortunately, some of these recommendations will only be correct when
using Guix on top of a foreign distribution, because we handle common
scenarios on the Guix-based GNU system directly.

--
Ricardo

Mike Gerwitz wrote 7 years ago

Recipients:(name . Ricardo Wurmus)(address . rekado@elephly.net)

Message-ID:87zhx29g2c.fsf@gnu.org

On Fri, Aug 31, 2018 at 15:11:49 +0200, Ricardo Wurmus wrote:

Toggle quote (9 lines)

> Much like we pin search path recommendations to certain “root” packages

> we could do something similar for recommended packages. “glibc”, for

> example, could recommend “glibc-locales”; having a package installed

> that links with glibc (i.e. all of them) would result in a

> recommendation to also install the “glibc-locales” package. For “gtk+”

> the recommendation could be to also install one of the icon themes.

> Installing any package depending on “gtk+” would then lead to a

> recommendation to install one of these packages.

That seems like desirable behavior to me.

Toggle quote (4 lines)

> Unfortunately, some of these recommendations will only be correct when

> using Guix on top of a foreign distribution, because we handle common

> scenarios on the Guix-based GNU system directly.

I can't comment on that, but in this virt-manager case, I did experience

the issue on GuixSD.

Mike Gerwitz

Leo Famulari wrote 6 years ago

(no subject)

Recipients:(address . control@debbugs.gnu.org)

Message-ID:20190226031946.GA7124@jasmine.lan

close 31366

Your comment

This issue is archived.

To comment on this conversation send an email to 31366@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 31366

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags

mumi command -t +confirmed -t +easy

Or, remove the moreinfo tag and set the help tag

mumi command -t -moreinfo -t +help

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date