"LibreOffice digital signature support?"

OpenSubmitted by Thomas Sigurdsen.
Details
5 participants
  • Clément Lassieur
  • Leo Famulari
  • Ludovic Courtès
  • Nils Gillmann
  • Thomas Sigurdsen
Owner
unassigned
Severity
normal
T
T
Thomas Sigurdsen wrote on 20 Mar 2018 18:28
Libreoffice
(address . guix-patches@gnu.org)
20180320182829.2b5abb89@merlin.browniehive.net
Here is two patches for libreoffice, both are changes of the configure flags
in the definition.

First is a change according to a comment. I started looking at these because
I wanted to check digital signatures and NSS was needed. Not sure NPAPI is
needed for NSS, but it is now enabled as per the old comment.

Second is enabling gtk2. This fixes bug#30642 for me. I think this is
because I'm not using gnome and therefore libreoffice can't find what it
needs. But Idk.

Filechooser dialog and digital signatures work with these 2 changes here.
From 4623ee9b626efe331dacfc97383d15bd80a9e4f3 Mon Sep 17 00:00:00 2001
From: Tonton <tonton@riseup.net>
Date: Tue, 20 Mar 2018 17:23:52 +0100
Subject: [PATCH 1/2] The corresponding inputs looks to be packaged (builds
succesfully)

Signed-off-by: Tonton <tonton@riseup.net>
---
gnu/packages/libreoffice.scm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Toggle diff (16 lines)
diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
index 316602adb..77c83b014 100644
--- a/gnu/packages/libreoffice.scm
+++ b/gnu/packages/libreoffice.scm
@@ -1027,8 +1027,7 @@ and to return information on pronunciations, meanings and synonyms.")
           "--without-fonts"
           ;; With java, the build fails since sac.jar is missing.
           "--without-java"
-          ;; FIXME: Enable once the corresponding inputs are packaged.
-          "--without-system-npapi-headers"
+          "--with-system-npapi-headers"
           "--disable-coinmp"
           "--disable-firebird-sdbc" ; embedded firebird
           "--disable-gltf"
-- 
2.16.2
From ac709f4766668030de58b76e5a3a847796c379e5 Mon Sep 17 00:00:00 2001
From: Tonton <tonton@riseup.net>
Date: Tue, 20 Mar 2018 17:24:49 +0100
Subject: [PATCH 2/2] Enable gtk2

Racionale: on systems without gtk2 the openfile dialog makes openoffice
crash. This (enabling gtk2) fixes this.

Signed-off-by: Tonton <tonton@riseup.net>
---
gnu/packages/libreoffice.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
index 77c83b014..92ff0f3b0 100644
--- a/gnu/packages/libreoffice.scm
+++ b/gnu/packages/libreoffice.scm
@@ -1035,7 +1035,7 @@ and to return information on pronunciations, meanings and synonyms.")
           ;; patching the build scripts to work with GCC5.  Try enabling this
           ;; when our default compiler is >=GCC 6.
           "--disable-pdfium"
-          "--disable-gtk" ; disable use of GTK+ 2
+          "--enable-gtk"
           "--without-doxygen")))
     (home-page "https://www.libreoffice.org/")
     (synopsis "Office suite")
-- 
2.16.2
L
L
Ludovic Courtès wrote on 4 Apr 2018 14:30
(name . Thomas Sigurdsen)(address . thomas.sigurdsen@gmail.com)(address . 30886@debbugs.gnu.org)
87efjvcfwg.fsf@gnu.org
Hello Thomas,

Sorry for the late reply.

Thomas Sigurdsen <thomas.sigurdsen@gmail.com> skribis:

Toggle quote (4 lines)
> First is a change according to a comment. I started looking at these because
> I wanted to check digital signatures and NSS was needed. Not sure NPAPI is
> needed for NSS, but it is now enabled as per the old comment.

OK.

Toggle quote (29 lines)
> Second is enabling gtk2. This fixes bug#30642 for me. I think this is
> because I'm not using gnome and therefore libreoffice can't find what it
> needs. But Idk.
>
> Filechooser dialog and digital signatures work with these 2 changes here.
>
>>From 4623ee9b626efe331dacfc97383d15bd80a9e4f3 Mon Sep 17 00:00:00 2001
> From: Tonton <tonton@riseup.net>
> Date: Tue, 20 Mar 2018 17:23:52 +0100
> Subject: [PATCH 1/2] The corresponding inputs looks to be packaged (builds
> succesfully)
>
> Signed-off-by: Tonton <tonton@riseup.net>
> ---
> gnu/packages/libreoffice.scm | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
> index 316602adb..77c83b014 100644
> --- a/gnu/packages/libreoffice.scm
> +++ b/gnu/packages/libreoffice.scm
> @@ -1027,8 +1027,7 @@ and to return information on pronunciations, meanings and synonyms.")
> "--without-fonts"
> ;; With java, the build fails since sac.jar is missing.
> "--without-java"
> - ;; FIXME: Enable once the corresponding inputs are packaged.
> - "--without-system-npapi-headers"
> + "--with-system-npapi-headers"

I suspect this doesn’t have any effect because ‘configure’ complains:

Toggle snippet (3 lines)
configure: WARNING: unrecognized options: --enable-fast-install, --enable-verbose, --with-system-npapi-headers

Are you sure digital signatures don’t work without this patch?

Toggle quote (10 lines)
>>From ac709f4766668030de58b76e5a3a847796c379e5 Mon Sep 17 00:00:00 2001
> From: Tonton <tonton@riseup.net>
> Date: Tue, 20 Mar 2018 17:24:49 +0100
> Subject: [PATCH 2/2] Enable gtk2
>
> Racionale: on systems without gtk2 the openfile dialog makes openoffice
> crash. This (enabling gtk2) fixes this.
>
> Signed-off-by: Tonton <tonton@riseup.net>

This is not OK because we’d rather keep using GTK+3.

Could you try the patch below and see if it fixes the FileChooser issue?

Thanks,
Ludo’.
Toggle diff (21 lines)
diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
index ef40e018b..5b8991299 100644
--- a/gnu/packages/libreoffice.scm
+++ b/gnu/packages/libreoffice.scm
@@ -27,6 +27,7 @@
 
 (define-module (gnu packages libreoffice)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system trivial)
   #:use-module (guix download)
   #:use-module ((guix licenses)
@@ -855,7 +856,7 @@ and to return information on pronunciations, meanings and synonyms.")
       (sha256
        (base32
         "0icd8h221gp2dsbn6d35flwhqhcfpx66cjc5dg8yifhhvrfam74i"))))
-    (build-system gnu-build-system)
+    (build-system glib-or-gtk-build-system)
     (native-inputs
      `(("bison" ,bison)
        ("cppunit" ,cppunit-1.14)
T
T
Thomas Sigurdsen wrote on 13 Apr 2018 22:58
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 30886@debbugs.gnu.org)
20180413225812.303a39d3@merlin.browniehive.net
Hi,

Seems this issue is a slow back and forth thing :)

I applied the patch and built it. The build fails before finishing with a
scheme backtrace. At first I thought it didn't finish anything, but it seems
to have finished building libreoffice because I get:

-------
Installation finished, you can now execute:
/gnu/store/hf2a8f4rca9dvw1s6ffcsrbcsp39aj83-libreoffice-5.4.6.2/lib/libreoffice/program/soffice
------

And then the most important part of the error after (I think):

------
phase `install' succeeded after 27.2 seconds
starting phase `bin-and-desktop-install'
Backtrace:
------

The backtrace points to trying to copy a file that might exist... the
following path exists in /tmp/guix-build-...libreoffice..../ - but ofcourse,
the whole path is not in the backtrace:
0 (copy-file "sysui/desktop/appstream-appdata/libreoffic…" …)


But, I can run the generated binary from the store. And the filechooser
dialog still causes libreoffice to crash:
"(soffice:9332): GLib-GIO-ERROR **: Settings schema
'org.gtk.Settings.FileChooser' is not installed "

On Wed, 04 Apr 2018 14:30:55 +0200
ludo@gnu.org (Ludovic Courtès) wrote:

Toggle quote (67 lines)
> Hello Thomas,
>
> Sorry for the late reply.
>
> Thomas Sigurdsen <thomas.sigurdsen@gmail.com> skribis:
>
> > First is a change according to a comment. I started looking at these
> > because I wanted to check digital signatures and NSS was needed. Not sure
> > NPAPI is needed for NSS, but it is now enabled as per the old comment.
>
> OK.
>
> > Second is enabling gtk2. This fixes bug#30642 for me. I think this is
> > because I'm not using gnome and therefore libreoffice can't find what it
> > needs. But Idk.
> >
> > Filechooser dialog and digital signatures work with these 2 changes here.
> >
> >>From 4623ee9b626efe331dacfc97383d15bd80a9e4f3 Mon Sep 17 00:00:00 2001
> > From: Tonton <tonton@riseup.net>
> > Date: Tue, 20 Mar 2018 17:23:52 +0100
> > Subject: [PATCH 1/2] The corresponding inputs looks to be packaged (builds
> > succesfully)
> >
> > Signed-off-by: Tonton <tonton@riseup.net>
> > ---
> > gnu/packages/libreoffice.scm | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
> > index 316602adb..77c83b014 100644
> > --- a/gnu/packages/libreoffice.scm
> > +++ b/gnu/packages/libreoffice.scm
> > @@ -1027,8 +1027,7 @@ and to return information on pronunciations,
> > meanings and synonyms.") "--without-fonts"
> > ;; With java, the build fails since sac.jar is missing.
> > "--without-java"
> > - ;; FIXME: Enable once the corresponding inputs are packaged.
> > - "--without-system-npapi-headers"
> > + "--with-system-npapi-headers"
>
> I suspect this doesn’t have any effect because ‘configure’ complains:
>
> --8<---------------cut here---------------start------------->8---
> configure: WARNING: unrecognized options: --enable-fast-install,
> --enable-verbose, --with-system-npapi-headers --8<---------------cut
> here---------------end--------------->8---
>
> Are you sure digital signatures don’t work without this patch?
>
> >>From ac709f4766668030de58b76e5a3a847796c379e5 Mon Sep 17 00:00:00 2001
> > From: Tonton <tonton@riseup.net>
> > Date: Tue, 20 Mar 2018 17:24:49 +0100
> > Subject: [PATCH 2/2] Enable gtk2
> >
> > Racionale: on systems without gtk2 the openfile dialog makes openoffice
> > crash. This (enabling gtk2) fixes this.
> >
> > Signed-off-by: Tonton <tonton@riseup.net>
>
> This is not OK because we’d rather keep using GTK+3.
>
> Could you try the patch below and see if it fixes the FileChooser issue?
>
> Thanks,
> Ludo’.
>
N
N
Nils Gillmann wrote on 14 Apr 2018 12:04
(name . Ludovic Courtès)(address . ludo@gnu.org)
20180414100437.yarnkprfp4b5gxs4@abyayala
Ludovic Courtès transcribed 3.3K bytes:
Toggle quote (57 lines)
> Hello Thomas,
>
> Sorry for the late reply.
>
> Thomas Sigurdsen <thomas.sigurdsen@gmail.com> skribis:
>
> > First is a change according to a comment. I started looking at these because
> > I wanted to check digital signatures and NSS was needed. Not sure NPAPI is
> > needed for NSS, but it is now enabled as per the old comment.
>
> OK.
>
> > Second is enabling gtk2. This fixes bug#30642 for me. I think this is
> > because I'm not using gnome and therefore libreoffice can't find what it
> > needs. But Idk.
> >
> > Filechooser dialog and digital signatures work with these 2 changes here.
> >
> >>From 4623ee9b626efe331dacfc97383d15bd80a9e4f3 Mon Sep 17 00:00:00 2001
> > From: Tonton <tonton@riseup.net>
> > Date: Tue, 20 Mar 2018 17:23:52 +0100
> > Subject: [PATCH 1/2] The corresponding inputs looks to be packaged (builds
> > succesfully)
> >
> > Signed-off-by: Tonton <tonton@riseup.net>
> > ---
> > gnu/packages/libreoffice.scm | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
> > index 316602adb..77c83b014 100644
> > --- a/gnu/packages/libreoffice.scm
> > +++ b/gnu/packages/libreoffice.scm
> > @@ -1027,8 +1027,7 @@ and to return information on pronunciations, meanings and synonyms.")
> > "--without-fonts"
> > ;; With java, the build fails since sac.jar is missing.
> > "--without-java"
> > - ;; FIXME: Enable once the corresponding inputs are packaged.
> > - "--without-system-npapi-headers"
> > + "--with-system-npapi-headers"
>
> I suspect this doesn’t have any effect because ‘configure’ complains:
>
> --8<---------------cut here---------------start------------->8---
> configure: WARNING: unrecognized options: --enable-fast-install, --enable-verbose, --with-system-npapi-headers
> --8<---------------cut here---------------end--------------->8---
>
> Are you sure digital signatures don’t work without this patch?
>
> >>From ac709f4766668030de58b76e5a3a847796c379e5 Mon Sep 17 00:00:00 2001
> > From: Tonton <tonton@riseup.net>
> > Date: Tue, 20 Mar 2018 17:24:49 +0100
> > Subject: [PATCH 2/2] Enable gtk2
> >
> > Racionale: on systems without gtk2 the openfile dialog makes openoffice
> > crash. This (enabling gtk2) fixes this.

A quick workaround which I found some time ago:

Workaround: Libreoffice options > "Libreoffice" > "general" > "Use Libreoffice dialogs".

Toggle quote (31 lines)
> > Signed-off-by: Tonton <tonton@riseup.net>
>
> This is not OK because we’d rather keep using GTK+3.
>
> Could you try the patch below and see if it fixes the FileChooser issue?
>
> Thanks,
> Ludo’.
>

> diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
> index ef40e018b..5b8991299 100644
> --- a/gnu/packages/libreoffice.scm
> +++ b/gnu/packages/libreoffice.scm
> @@ -27,6 +27,7 @@
>
> (define-module (gnu packages libreoffice)
> #:use-module (guix build-system gnu)
> + #:use-module (guix build-system glib-or-gtk)
> #:use-module (guix build-system trivial)
> #:use-module (guix download)
> #:use-module ((guix licenses)
> @@ -855,7 +856,7 @@ and to return information on pronunciations, meanings and synonyms.")
> (sha256
> (base32
> "0icd8h221gp2dsbn6d35flwhqhcfpx66cjc5dg8yifhhvrfam74i"))))
> - (build-system gnu-build-system)
> + (build-system glib-or-gtk-build-system)
> (native-inputs
> `(("bison" ,bison)
> ("cppunit" ,cppunit-1.14)
C
C
Clément Lassieur wrote on 14 Apr 2018 13:05
(name . Thomas Sigurdsen)(address . thomas.sigurdsen@gmail.com)
87604ucakm.fsf@lassieur.org
There was a similar issue some time ago on Icecat, see

Hope this helps.
Clément
L
L
Leo Famulari wrote on 12 Feb 2019 23:56
(name . Thomas Sigurdsen)(address . thomas.sigurdsen@gmail.com)(address . 30886@debbugs.gnu.org)
20190212225610.GA30699@jasmine.lan
On Tue, Mar 20, 2018 at 06:28:29PM +0100, Thomas Sigurdsen wrote:
Toggle quote (4 lines)
> First is a change according to a comment. I started looking at these because
> I wanted to check digital signatures and NSS was needed. Not sure NPAPI is
> needed for NSS, but it is now enabled as per the old comment.

What is the status of this patch? Do you still want it to be applied? It
seems the conversation just fizzled out.

Toggle quote (4 lines)
> Second is enabling gtk2. This fixes bug#30642 for me. I think this is
> because I'm not using gnome and therefore libreoffice can't find what it
> needs. But Idk.

The file chooser dialog issue is fixed since commit
994bccd9443032141accede0e403cbfb62f6c63e.
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlxjTwoACgkQJkb6MLrK
fwg4fw//UcJ3SalugOEN7ulxYZyHb+mSsHkDSO18f6uBjcwVYHuMDzD3//3uJooh
yv6fZhKJge0sDo5YM38pOfyOItDyhUXEACqzLxEYi13lBtSD3ZAYpapxt6QJIino
r0TVbGUga2sOZSHq7nrF1CeBrO+F/g1+EUx6MNYytsac/Zpizg78lqw8DdoyUS4x
DEqEtFDzhXDx+aWVHP0/6L/mxGco0da5/zwGW9HC522aFvtFdmhlvQgjj3yGkXmX
vnNwlNh6K/L5cgVlXWLRTwHSiCZJIjtwAXX7MhQozfl7DkFf9hq6oFiKag9vDGqa
T3iH0vLE3SW+8ZRL+JIIwqa9z259vJVvSKLOscvKJ/izzoSLKWfCvK0NmNYMmImI
vIMcAUCbgkFW7sBT4vHVejNEj1OVwatrbb8Ljy2xpwHWCugq+FvY4PR6frcdvSrG
g2vcnuR+xJnE61aZd7fzS9pp2dSXAVdq25dBzFxTq/3LOfXjAE861R7kZc+lNNP9
xFghn31IwOrme24olAkeGESlqJXZO3cuhYOV4nNRYGhAfR0Q43dJxOpprzTwqm8X
nrqjDJDGdIjw32kfRgsPpvBuwGm3PjBoZ+xypOmXhy3OEp/TgPjedoyHiSp1EnnH
vZdRBp2zPwPF5Hqsfi2JIqE2krQQHsFn9SnJtHDorAPGL7fwaDI=
=E66e
-----END PGP SIGNATURE-----


L
L
Leo Famulari wrote on 12 Feb 2019 23:59
(no subject)
(address . control@debbugs.gnu.org)
20190212225925.GA30796@jasmine.lan
retitle 30886 "LibreOffice digital signature support?"
tag 30886 moreinfo
?