[PATCH 0/2] Add Emacs packages for HCL and Terraform.

Done

Details

2 participants

Alex Kost
Christopher Baines

Owner: unassigned

Submitted by: Christopher Baines

Severity: normal

Debbugs page

Christopher Baines wrote 7 years ago

Recipients:(address . guix-patches@gnu.org)

Message-ID:877eqrrdom.fsf@cbaines.net

Christopher Baines (2):
  gnu: Add emacs-hcl-mode.
  gnu: Add emacs-terraform-mode.

 gnu/packages/emacs.scm | 47 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

Christopher Baines wrote 7 years ago

[PATCH 2/2] gnu: Add emacs-terraform-mode.

Recipients:(address . 30698@debbugs.gnu.org)

Message-ID:20180304165051.14024-2-mail@cbaines.net

---

gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++

1 file changed, 24 insertions(+)

Toggle diff (34 lines)diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 0e46c71f1..da31f7a13 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -7336,3 +7336,27 @@ the pipeline, featuring the support for running @code{emacsclient}.")
 @acronym{HCL, Hashicorp Configuration Language}.  It provides syntax
 highlighting and indentation support. ")
     (license license:gpl3+)))
+
+(define-public emacs-terraform-mode
+  (package
+    (name "emacs-terraform-mode")
+    (version "0.06")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/syohex/emacs-terraform-mode/archive/"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0h9267ifdjmcin4sj8slxydbacx4bqicbvg8pa1qq2l72h9m5381"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-hcl-mode" ,emacs-hcl-mode)))
+    (home-page "https://github.com/syohex/emacs-terraform-mode")
+    (synopsis "Major mode for Terraform")
+    (description
+     "@code{emacs-terraform-mode} provides a major mode for working with
+Terraform.  Most of the functionality is inherited from @code{hcl-mode}.")
+    (license license:gpl3+)))
-- 
2.16.1

Christopher Baines wrote 7 years ago

[PATCH 1/2] gnu: Add emacs-hcl-mode.

Recipients:(address . 30698@debbugs.gnu.org)

Message-ID:20180304165051.14024-1-mail@cbaines.net

* gnu/packages/emacs.scm (emacs-hcl-mode): New variable.

---

gnu/packages/emacs.scm | 23 +++++++++++++++++++++++

1 file changed, 23 insertions(+)

Toggle diff (33 lines)diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 69950cc6d..0e46c71f1 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -7313,3 +7313,26 @@ Features:
     (description "@code{epipe} provides an utility to use your editor in
 the pipeline, featuring the support for running @code{emacsclient}.")
     (license license:gpl3+)))
+
+(define-public emacs-hcl-mode
+  (package
+    (name "emacs-hcl-mode")
+    (version "0.03")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/syohex/emacs-hcl-mode/archive/"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0pvw74qpwh0znqzp6syp4wxjqs7dp1hbn5h7xfk97mff9l5d8k6x"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/syohex/emacs-hcl-mode")
+    (synopsis "Major mode for the Hashicorp Configuration Language")
+    (description
+     "@code{emacs-hcl-mode} provides an Emacs major mode for working with
+@acronym{HCL, Hashicorp Configuration Language}.  It provides syntax
+highlighting and indentation support. ")
+    (license license:gpl3+)))
-- 
2.16.1

Alex Kost wrote 7 years ago

Re: [bug#30698] [PATCH 2/2] gnu: Add emacs-terraform-mode.

Recipients:(name . Christopher Baines)(address . mail@cbaines.net)(address . 30698@debbugs.gnu.org)

Message-ID:87bmg3egnb.fsf@gmail.com

Christopher Baines (2018-03-04 16:50 +0000) wrote:

Toggle quote (36 lines)> ---
>  gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 0e46c71f1..da31f7a13 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -7336,3 +7336,27 @@ the pipeline, featuring the support for running @code{emacsclient}.")
>  @acronym{HCL, Hashicorp Configuration Language}.  It provides syntax
>  highlighting and indentation support. ")
>      (license license:gpl3+)))
> +
> +(define-public emacs-terraform-mode
> +  (package
> +    (name "emacs-terraform-mode")
> +    (version "0.06")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/syohex/emacs-terraform-mode/archive/"
> +             version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0h9267ifdjmcin4sj8slxydbacx4bqicbvg8pa1qq2l72h9m5381"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-hcl-mode" ,emacs-hcl-mode)))
> +    (home-page "https://github.com/syohex/emacs-terraform-mode")
> +    (synopsis "Major mode for Terraform")
> +    (description
> +     "@code{emacs-terraform-mode} provides a major mode for working with
> +Terraform.  Most of the functionality is inherited from @code{hcl-mode}.")

Maybe it would be good to clarify what Terraform is in the description,

for example:

"... working with @uref{https://www.terraform.io/,Terraform}

configuration files."

Toggle quote (2 lines)

> + (license license:gpl3+)))

Alex

Alex Kost wrote 7 years ago

Re: [bug#30698] [PATCH 1/2] gnu: Add emacs-hcl-mode.

Recipients:(name . Christopher Baines)(address . mail@cbaines.net)(address . 30698@debbugs.gnu.org)

Message-ID:877eqreglf.fsf@gmail.com

Christopher Baines (2018-03-04 16:50 +0000) wrote:

Toggle quote (35 lines)> * gnu/packages/emacs.scm (emacs-hcl-mode): New variable.
> ---
>  gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 69950cc6d..0e46c71f1 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -7313,3 +7313,26 @@ Features:
>      (description "@code{epipe} provides an utility to use your editor in
>  the pipeline, featuring the support for running @code{emacsclient}.")
>      (license license:gpl3+)))
> +
> +(define-public emacs-hcl-mode
> +  (package
> +    (name "emacs-hcl-mode")
> +    (version "0.03")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/syohex/emacs-hcl-mode/archive/"
> +             version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0pvw74qpwh0znqzp6syp4wxjqs7dp1hbn5h7xfk97mff9l5d8k6x"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/syohex/emacs-hcl-mode")
> +    (synopsis "Major mode for the Hashicorp Configuration Language")
> +    (description
> +     "@code{emacs-hcl-mode} provides an Emacs major mode for working with
> +@acronym{HCL, Hashicorp Configuration Language}.  It provides syntax
> +highlighting and indentation support. ")

^ extra space

otherwise, looks good to me, thank you!

Toggle quote (2 lines)

> + (license license:gpl3+)))

Alex

Christopher Baines wrote 7 years ago

Re: [bug#30698] [PATCH 2/2] gnu: Add emacs-terraform-mode.

Recipients:(name . Alex Kost)(address . alezost@gmail.com)(address . 30698@debbugs.gnu.org)

Message-ID:87o9k3otk0.fsf@cbaines.net

Alex Kost <alezost@gmail.com> writes:

Toggle quote (44 lines)> Christopher Baines (2018-03-04 16:50 +0000) wrote:
>
>> ---
>>  gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
>>  1 file changed, 24 insertions(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 0e46c71f1..da31f7a13 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -7336,3 +7336,27 @@ the pipeline, featuring the support for running @code{emacsclient}.")
>>  @acronym{HCL, Hashicorp Configuration Language}.  It provides syntax
>>  highlighting and indentation support. ")
>>      (license license:gpl3+)))
>> +
>> +(define-public emacs-terraform-mode
>> +  (package
>> +    (name "emacs-terraform-mode")
>> +    (version "0.06")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "https://github.com/syohex/emacs-terraform-mode/archive/"
>> +             version ".tar.gz"))
>> +       (file-name (string-append name "-" version ".tar.gz"))
>> +       (sha256
>> +        (base32
>> +         "0h9267ifdjmcin4sj8slxydbacx4bqicbvg8pa1qq2l72h9m5381"))))
>> +    (build-system emacs-build-system)
>> +    (propagated-inputs
>> +     `(("emacs-hcl-mode" ,emacs-hcl-mode)))
>> +    (home-page "https://github.com/syohex/emacs-terraform-mode")
>> +    (synopsis "Major mode for Terraform")
>> +    (description
>> +     "@code{emacs-terraform-mode} provides a major mode for working with
>> +Terraform.  Most of the functionality is inherited from @code{hcl-mode}.")
>
> Maybe it would be good to clarify what Terraform is in the description,
> for example:
>
> "... working with @uref{https://www.terraform.io/, Terraform}
> configuration files."

Sure, that sounds good, thanks for taking a look :)

Christopher Baines wrote 7 years ago

Re: [bug#30698] [PATCH 1/2] gnu: Add emacs-hcl-mode.

Recipients:(name . Alex Kost)(address . alezost@gmail.com)(address . 30698-done@debbugs.gnu.org)

Message-ID:87muznota8.fsf@cbaines.net

Alex Kost <alezost@gmail.com> writes:

Toggle quote (40 lines)> Christopher Baines (2018-03-04 16:50 +0000) wrote:
>
>> * gnu/packages/emacs.scm (emacs-hcl-mode): New variable.
>> ---
>>  gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 69950cc6d..0e46c71f1 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -7313,3 +7313,26 @@ Features:
>>      (description "@code{epipe} provides an utility to use your editor in
>>  the pipeline, featuring the support for running @code{emacsclient}.")
>>      (license license:gpl3+)))
>> +
>> +(define-public emacs-hcl-mode
>> +  (package
>> +    (name "emacs-hcl-mode")
>> +    (version "0.03")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "https://github.com/syohex/emacs-hcl-mode/archive/"
>> +             version ".tar.gz"))
>> +       (file-name (string-append name "-" version ".tar.gz"))
>> +       (sha256
>> +        (base32
>> +         "0pvw74qpwh0znqzp6syp4wxjqs7dp1hbn5h7xfk97mff9l5d8k6x"))))
>> +    (build-system emacs-build-system)
>> +    (home-page "https://github.com/syohex/emacs-hcl-mode")
>> +    (synopsis "Major mode for the Hashicorp Configuration Language")
>> +    (description
>> +     "@code{emacs-hcl-mode} provides an Emacs major mode for working with
>> +@acronym{HCL, Hashicorp Configuration Language}.  It provides syntax
>> +highlighting and indentation support. ")
>                                         ^ extra space
> otherwise, looks good to me, thank you!

Great, I've removed the space, and pushed both of these patches. Thanks

for your review :)

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 30698@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 30698

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags

mumi command -t +confirmed -t +easy

Or, remove the moreinfo tag and set the help tag

mumi command -t -moreinfo -t +help

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date